Re: [PATCH i-g-t v4] tests/intel/kms_dirtyfb: Skip FBC testing on BMG platform

["Sharma, Swati2" <swati2.sharma@intel.com>]

LGTM

Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 20-01-2025 12:49 pm, Mohammed Thasleem wrote:
> FBC test isn't supported on bmg, skip the test on this platform.
>
> v2: Add workaround id: Wa_16023588340. (Swati)
> v3: Add workaround id in code.
> v4: Update subject. (Kamil)
>
> Signed-off-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
> ---
>   tests/intel/kms_dirtyfb.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
> index 4cbd1a2f9..f2bdd4546 100644
> --- a/tests/intel/kms_dirtyfb.c
> +++ b/tests/intel/kms_dirtyfb.c
> @@ -54,7 +54,7 @@ IGT_TEST_DESCRIPTION("Test the DIRTYFB ioctl is working properly with "
>   #endif
>   
>   typedef struct {
> -	int drm_fd;
> +	int drm_fd, devid;
>   	int debugfs_fd;
>   	igt_display_t display;
>   	drmModeModeInfo *mode;
> @@ -364,6 +364,7 @@ igt_main
>   		igt_display_require(&data.display, data.drm_fd);
>   		igt_display_require_output(&data.display);
>   		igt_require(data.display.is_atomic);
> +		data.devid = intel_get_drm_devid(data.drm_fd);
>   
>   		data.bops = buf_ops_create(data.drm_fd);
>   		data.rendercopy = igt_get_render_copyfunc(intel_get_drm_devid(data.drm_fd));
> @@ -381,6 +382,10 @@ igt_main
>   							      data.output) {
>   					data.mode = igt_output_get_mode(data.output);
>   
> +					/* FBC disabled: Wa_16023588340 */
> +					igt_skip_on_f((IS_BATTLEMAGE(data.devid) && data.feature == FEATURE_FBC),
> +						       "FBC isn't supported on BMG\n");
> +
>   					if (!check_support(&data))
>   						continue;
>