Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Mohammed Thasleem <mohammed.thasleem@intel.com>,
	<igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] tests/intel/kms_dirtyfb: Add skip condition for bmg platform
Date: Thu, 14 Nov 2024 11:36:55 +0530	[thread overview]
Message-ID: <ec09d4b9-990e-43ec-a3a8-7600dcbc3f30@intel.com> (raw)
In-Reply-To: <20241113174118.158849-1-mohammed.thasleem@intel.com>

Hi Thasleem,

Add bspec id. in commit message.

On 13-11-2024 11:11 pm, Mohammed Thasleem wrote:
> FBC test isn't supported on bmg, skip the test on this platform.
>
> Signed-off-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
> ---
>   tests/intel/kms_dirtyfb.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
> index 35df9be3b..e20fde777 100644
> --- a/tests/intel/kms_dirtyfb.c
> +++ b/tests/intel/kms_dirtyfb.c
> @@ -54,7 +54,7 @@ IGT_TEST_DESCRIPTION("Test the DIRTYFB ioctl is working properly with "
>   #endif
>   
>   typedef struct {
> -	int drm_fd;
> +	int drm_fd, devid;
>   	int debugfs_fd;
>   	igt_display_t display;
>   	drmModeModeInfo *mode;
> @@ -345,6 +345,9 @@ igt_main
>   		igt_display_require(&data.display, data.drm_fd);
>   		igt_display_require_output(&data.display);
>   		igt_require(data.display.is_atomic);
> +		data.devid = intel_get_drm_devid(data.drm_fd);
> +		igt_require_f(!IS_BATTLEMAGE(data.devid),
> +			     "FBC isn't supported on BMG\n");
>   
>   		data.bops = buf_ops_create(data.drm_fd);
>   		data.rendercopy = igt_get_render_copyfunc(intel_get_drm_devid(data.drm_fd));

  parent reply	other threads:[~2024-11-14  6:07 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-13 17:41 [PATCH i-g-t] tests/intel/kms_dirtyfb: Add skip condition for bmg platform Mohammed Thasleem
2023-03-28  2:17 ` [PATCH i-g-t v2] " Mohammed Thasleem
2025-01-03 10:43   ` [PATCH i-g-t v3] " Mohammed Thasleem
2025-01-20  7:19     ` [PATCH i-g-t v4] tests/intel/kms_dirtyfb: Skip FBC testing on BMG platform Mohammed Thasleem
2025-01-30  7:06       ` Sharma, Swati2
2024-11-13 18:31 ` ✓ Fi.CI.BAT: success for tests/intel/kms_dirtyfb: Add skip condition for bmg platform Patchwork
2024-11-13 18:32 ` ✓ CI.xeBAT: " Patchwork
2024-11-13 21:13 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-11-14  3:26 ` ✗ CI.xeFULL: " Patchwork
2024-11-14  6:06 ` Sharma, Swati2 [this message]
2024-12-11 15:44 ` ✗ GitLab.Pipeline: warning for tests/intel/kms_dirtyfb: Add skip condition for bmg platform (rev2) Patchwork
2024-12-11 16:35 ` ✗ i915.CI.BAT: failure " Patchwork
2024-12-11 17:02 ` ✓ Xe.CI.BAT: success " Patchwork
2024-12-11 18:56 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-13  9:12 ` ✓ i915.CI.BAT: success for tests/intel/kms_dirtyfb: Add skip condition for bmg platform (rev3) Patchwork
2024-12-13  9:28 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-13 11:56 ` ✗ i915.CI.Full: failure " Patchwork
2024-12-13 15:12 ` ✗ Xe.CI.Full: " Patchwork
2025-01-03 13:19 ` ✗ i915.CI.BAT: failure for tests/intel/kms_dirtyfb: Add skip condition for bmg platform (rev4) Patchwork
2025-01-03 13:43 ` ✓ Xe.CI.BAT: success " Patchwork
2025-01-03 18:24 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-20 10:59 ` ✓ i915.CI.BAT: success for tests/intel/kms_dirtyfb: Add skip condition for bmg platform (rev5) Patchwork
2025-01-20 13:42 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-20 15:36 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-20 18:17   ` Thasleem, Mohammed
2025-01-22  4:45     ` Ravali, JupallyX
2025-01-21  6:07 ` ✗ i915.CI.Full: " Patchwork
2025-01-21 12:59 ` ✓ i915.CI.Full: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec09d4b9-990e-43ec-a3a8-7600dcbc3f30@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=mohammed.thasleem@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox