public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t 1/2] lib/psr: Skip PSR tests if sink not reliable
@ 2019-10-23 21:50 José Roberto de Souza
  2019-10-23 21:50 ` [igt-dev] [PATCH i-g-t 2/2] lib/psr: Remove unused function José Roberto de Souza
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: José Roberto de Souza @ 2019-10-23 21:50 UTC (permalink / raw)
  To: igt-dev; +Cc: Ap Kamal, Dhinakaran Pandiyan, Rodrigo Vivi

Right now if sink reported any PSR error or if it fails to
acknowledge the PSR wakeup it sets a flag and do not attempt to
enable PSR anymore. That is the safest approach to avoid repetitive
glitches and allowed us to have PSR enabled by default.

But from time to time even good PSR panels have a PSR error, causing
tests to fail. And for now we are not yet to the point were we could
try to recover from PSR errors, so lets check for this information in
debugfs and skip PSR tests because of sink errors and eliminate this
noise from CI runs.

Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Ap Kamal <kamal.ap@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 lib/igt_psr.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/igt_psr.c b/lib/igt_psr.c
index b92ea73f..0e79dcd9 100644
--- a/lib/igt_psr.c
+++ b/lib/igt_psr.c
@@ -33,6 +33,8 @@ static bool psr_active_check(int debugfs_fd, enum psr_mode mode)
 	igt_debugfs_simple_read(debugfs_fd, "i915_edp_psr_status", buf,
 				sizeof(buf));
 
+	igt_skip_on(strstr(buf, "PSR sink not reliable: yes"));
+
 	return strstr(buf, state);
 }
 
-- 
2.23.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-24 23:15 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-23 21:50 [igt-dev] [PATCH i-g-t 1/2] lib/psr: Skip PSR tests if sink not reliable José Roberto de Souza
2019-10-23 21:50 ` [igt-dev] [PATCH i-g-t 2/2] lib/psr: Remove unused function José Roberto de Souza
2019-10-23 22:33 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/psr: Skip PSR tests if sink not reliable Patchwork
2019-10-24 15:00 ` [igt-dev] [PATCH i-g-t 1/2] " Matt Roper
2019-10-24 23:15   ` Souza, Jose
2019-10-24 18:05 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox