Re: [igt-dev] [PATCH i-g-t 1/2] lib/intel_reg: Add copy commands in the lib

[Karolina Stolarek <karolina.stolarek@intel.com>]

Hi Sai,

On 18.08.2023 07:19, sai.gowtham.ch@intel.com wrote:
> From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
> 
> Add memory copy and set commands to the lib.
> 
> Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
> ---
>   lib/intel_mocs.h | 2 ++
>   lib/intel_reg.h  | 4 ++++
>   2 files changed, 6 insertions(+)
> 
> diff --git a/lib/intel_mocs.h b/lib/intel_mocs.h
> index 255eac0ff..4f4cf53e0 100644
> --- a/lib/intel_mocs.h
> +++ b/lib/intel_mocs.h
> @@ -6,6 +6,8 @@
>   #ifndef _INTEL_MOCS_H
>   #define _INTEL_MOCS_H
>   
> +#define MEM_COPY_MOCS_SHIFT                     25
> +

 From what I can see, this flag is only used in the xe_copy_basic test. 
Would it be possible to keep it local for the time being?

Many thanks,
Karolina

>   uint8_t intel_get_wb_mocs(int fd);
>   uint8_t intel_get_uc_mocs(int fd);
>   
> diff --git a/lib/intel_reg.h b/lib/intel_reg.h
> index 3bf3676dc..322aec9fd 100644
> --- a/lib/intel_reg.h
> +++ b/lib/intel_reg.h
> @@ -2564,6 +2564,10 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
>   
>   #define XY_FAST_COLOR_BLT		((0x2<<29)|(0x44<<22)|0xe)
>   
> +/* RAW memory commands */
> +#define MEM_COPY_CMD                    ((0x2 << 29)|(0x5a << 22)|0x8)
> +#define MEM_SET_CMD                     ((0x2 << 29)|(0x5b << 22)|0x5)
> +
>   #define XY_FAST_COPY_BLT				((2<<29)|(0x42<<22)|0x8)
>   /* dword 0 */
>   #define   XY_FAST_COPY_SRC_TILING_LINEAR		(0 << 20)