* [igt-dev] [PATCH i-g-t v2] tests/i915/kms_dsc: add limited flag
@ 2023-05-29 16:40 Swati Sharma
2023-05-30 15:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Swati Sharma @ 2023-05-29 16:40 UTC (permalink / raw)
To: igt-dev
Add limited flag to restrict test execution to one valid pipe-output
combination. By default all tests will run on all valid pipe-output
combinations.
v2: -rename extended to limited (Kamil)
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
tests/i915/kms_dsc.c | 26 ++++++++++++++++++++++++--
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
index 3ce28f84..9ddb441d 100644
--- a/tests/i915/kms_dsc.c
+++ b/tests/i915/kms_dsc.c
@@ -51,6 +51,7 @@ typedef struct {
int input_bpc;
int disp_ver;
enum pipe pipe;
+ bool limited;
} data_t;
static int output_format_list[] = {DSC_FORMAT_YCBCR420, DSC_FORMAT_YCBCR444};
@@ -250,13 +251,34 @@ static void test_dsc(data_t *data, enum dsc_test_type test_type, int bpc,
igt_dynamic_f("pipe-%s-%s%s", kmstest_pipe_name(data->pipe), data->output->name, name)
update_display(data, test_type);
+
+ if (data->limited)
+ break;
}
}
-igt_main
+static int opt_handler(int opt, int opt_index, void *_data)
{
- data_t data = {};
+ data_t *data = _data;
+
+ switch (opt) {
+ case 'l':
+ data->limited = true;
+ break;
+ default:
+ return IGT_OPT_HANDLER_ERROR;
+ }
+
+ return IGT_OPT_HANDLER_SUCCESS;
+}
+
+static const char help_str[] =
+ " --limited\t\tLimit execution to 1 valid pipe-output combo\n";
+static data_t data = {};
+
+igt_main_args("l", NULL, help_str, opt_handler, &data)
+{
igt_fixture {
data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
data.devid = intel_get_drm_devid(data.drm_fd);
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/kms_dsc: add limited flag
2023-05-29 16:40 [igt-dev] [PATCH i-g-t v2] tests/i915/kms_dsc: add limited flag Swati Sharma
@ 2023-05-30 15:05 ` Patchwork
2023-05-30 17:35 ` [igt-dev] [PATCH i-g-t v2] " Zbigniew Kempczyński
2023-05-31 8:24 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-05-30 15:05 UTC (permalink / raw)
To: Swati Sharma; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 6657 bytes --]
== Series Details ==
Series: tests/i915/kms_dsc: add limited flag
URL : https://patchwork.freedesktop.org/series/118519/
State : success
== Summary ==
CI Bug Log - changes from IGT_7310 -> IGTPW_9064
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/index.html
Participating hosts (38 -> 37)
------------------------------
Missing (1): fi-kbl-soraka
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_9064:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_suspend@basic-s3-without-i915:
- {bat-mtlp-8}: [SKIP][1] ([i915#6645]) -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/bat-mtlp-8/igt@i915_suspend@basic-s3-without-i915.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/bat-mtlp-8/igt@i915_suspend@basic-s3-without-i915.html
Known issues
------------
Here are the changes found in IGTPW_9064 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind:
- fi-kbl-8809g: NOTRUN -> [ABORT][3] ([i915#8298] / [i915#8299] / [i915#8397])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/fi-kbl-8809g/igt@core_hotunplug@unbind-rebind.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-8809g: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/fi-kbl-8809g/igt@gem_huc_copy@huc-copy.html
* igt@i915_selftest@live@requests:
- bat-rpls-2: [PASS][5] -> [ABORT][6] ([i915#7913])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/bat-rpls-2/igt@i915_selftest@live@requests.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/bat-rpls-2/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@slpc:
- bat-rpls-1: [PASS][7] -> [DMESG-WARN][8] ([i915#6367])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/bat-rpls-1/igt@i915_selftest@live@slpc.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@kms_addfb_basic@too-high:
- fi-kbl-8809g: NOTRUN -> [FAIL][9] ([i915#8296]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/fi-kbl-8809g/igt@kms_addfb_basic@too-high.html
* igt@kms_force_connector_basic@force-connector-state:
- fi-kbl-8809g: NOTRUN -> [DMESG-FAIL][10] ([i915#8299])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/fi-kbl-8809g/igt@kms_force_connector_basic@force-connector-state.html
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-8809g: NOTRUN -> [CRASH][11] ([i915#8299])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/fi-kbl-8809g/igt@kms_force_connector_basic@force-edid.html
* igt@kms_pipe_crc_basic@read-crc:
- bat-adlp-9: NOTRUN -> [SKIP][12] ([i915#3546]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/bat-adlp-9/igt@kms_pipe_crc_basic@read-crc.html
* igt@kms_psr@cursor_plane_move:
- fi-kbl-8809g: NOTRUN -> [SKIP][13] ([fdo#109271]) +59 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/fi-kbl-8809g/igt@kms_psr@cursor_plane_move.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-kbl-8809g: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#4579])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/fi-kbl-8809g/igt@kms_setmode@basic-clone-single-crtc.html
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- {bat-mtlp-6}: [ABORT][15] ([i915#8180]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/bat-mtlp-6/igt@core_hotunplug@unbind-rebind.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/bat-mtlp-6/igt@core_hotunplug@unbind-rebind.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-hsw-4770: [SKIP][17] ([fdo#109271]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/fi-hsw-4770/igt@i915_pm_rpm@basic-pci-d3-state.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/fi-hsw-4770/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_pm_rpm@basic-rte:
- fi-hsw-4770: [FAIL][19] ([i915#7364]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/fi-hsw-4770/igt@i915_pm_rpm@basic-rte.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/fi-hsw-4770/igt@i915_pm_rpm@basic-rte.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7364]: https://gitlab.freedesktop.org/drm/intel/issues/7364
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#8180]: https://gitlab.freedesktop.org/drm/intel/issues/8180
[i915#8296]: https://gitlab.freedesktop.org/drm/intel/issues/8296
[i915#8298]: https://gitlab.freedesktop.org/drm/intel/issues/8298
[i915#8299]: https://gitlab.freedesktop.org/drm/intel/issues/8299
[i915#8397]: https://gitlab.freedesktop.org/drm/intel/issues/8397
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7310 -> IGTPW_9064
CI-20190529: 20190529
CI_DRM_13200: 0ae4ee2c735979030a0219218081eee661606921 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9064: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/index.html
IGT_7310: 2f9acfea5e3a93303f71cbda6e80ba64b8d75a4d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/index.html
[-- Attachment #2: Type: text/html, Size: 7530 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/i915/kms_dsc: add limited flag
2023-05-29 16:40 [igt-dev] [PATCH i-g-t v2] tests/i915/kms_dsc: add limited flag Swati Sharma
2023-05-30 15:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2023-05-30 17:35 ` Zbigniew Kempczyński
2023-05-31 9:16 ` Sharma, Swati2
2023-05-31 8:24 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Zbigniew Kempczyński @ 2023-05-30 17:35 UTC (permalink / raw)
To: Swati Sharma; +Cc: igt-dev
On Mon, May 29, 2023 at 10:10:22PM +0530, Swati Sharma wrote:
> Add limited flag to restrict test execution to one valid pipe-output
> combination. By default all tests will run on all valid pipe-output
> combinations.
>
> v2: -rename extended to limited (Kamil)
>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
> tests/i915/kms_dsc.c | 26 ++++++++++++++++++++++++--
> 1 file changed, 24 insertions(+), 2 deletions(-)
>
> diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
> index 3ce28f84..9ddb441d 100644
> --- a/tests/i915/kms_dsc.c
> +++ b/tests/i915/kms_dsc.c
> @@ -51,6 +51,7 @@ typedef struct {
> int input_bpc;
> int disp_ver;
> enum pipe pipe;
> + bool limited;
> } data_t;
>
> static int output_format_list[] = {DSC_FORMAT_YCBCR420, DSC_FORMAT_YCBCR444};
> @@ -250,13 +251,34 @@ static void test_dsc(data_t *data, enum dsc_test_type test_type, int bpc,
>
> igt_dynamic_f("pipe-%s-%s%s", kmstest_pipe_name(data->pipe), data->output->name, name)
> update_display(data, test_type);
> +
> + if (data->limited)
> + break;
> }
> }
>
> -igt_main
> +static int opt_handler(int opt, int opt_index, void *_data)
> {
> - data_t data = {};
You don't need to introduce static data below, handler has pointer
to it, and functions are called with &data so keeping this on stack
is better for me (protects from global access in any place).
> + data_t *data = _data;
> +
> + switch (opt) {
> + case 'l':
> + data->limited = true;
> + break;
> + default:
> + return IGT_OPT_HANDLER_ERROR;
> + }
> +
> + return IGT_OPT_HANDLER_SUCCESS;
> +}
> +
> +static const char help_str[] =
> + " --limited\t\tLimit execution to 1 valid pipe-output combo\n";
I see you're using short option '-l', just add this to line above like:
" --limited\t-l\tLimit ..."
>
> +static data_t data = {};
Keep this on stack. With this nit fixed:
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
--
Zbigniew
> +
> +igt_main_args("l", NULL, help_str, opt_handler, &data)
> +{
> igt_fixture {
> data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
> data.devid = intel_get_drm_devid(data.drm_fd);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/i915/kms_dsc: add limited flag
2023-05-29 16:40 [igt-dev] [PATCH i-g-t v2] tests/i915/kms_dsc: add limited flag Swati Sharma
2023-05-30 15:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-05-30 17:35 ` [igt-dev] [PATCH i-g-t v2] " Zbigniew Kempczyński
@ 2023-05-31 8:24 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-05-31 8:24 UTC (permalink / raw)
To: Sharma, Swati2; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 17412 bytes --]
== Series Details ==
Series: tests/i915/kms_dsc: add limited flag
URL : https://patchwork.freedesktop.org/series/118519/
State : success
== Summary ==
CI Bug Log - changes from IGT_7310_full -> IGTPW_9064_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/index.html
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
New tests
---------
New tests have been introduced between IGT_7310_full and IGTPW_9064_full:
### New IGT tests (4) ###
* igt@kms_flip@flip-vs-panning-vs-hang@b-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@plane-scaler-with-rotation-unity-scaling@pipe-a-hdmi-a-2:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@plane-upscale-with-modifiers-20x20@pipe-a-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-a-hdmi-a-2:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_9064_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][1] -> [FAIL][2] ([i915#2846])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-glk8/igt@gem_exec_fair@basic-deadline.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-glk9/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#2842])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][5] -> [ABORT][6] ([i915#5566])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-glk9/igt@gen9_exec_parse@allowed-single.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-glk3/igt@gen9_exec_parse@allowed-single.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [PASS][7] -> [FAIL][8] ([IGT#6] / [i915#2346])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-absolute-wf_vblank@a-hdmi-a1:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#2122])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-glk7/igt@kms_flip@flip-vs-absolute-wf_vblank@a-hdmi-a1.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-glk9/igt@kms_flip@flip-vs-absolute-wf_vblank@a-hdmi-a1.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4579]) +11 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-snb1/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-vga-1:
- shard-snb: NOTRUN -> [SKIP][12] ([fdo#109271]) +16 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-snb2/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-vga-1.html
* igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-a-hdmi-a-2 (NEW):
- {shard-rkl}: NOTRUN -> [SKIP][13] ([i915#5176]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-rkl-4/igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-a-hdmi-a-2.html
#### Possible fixes ####
* igt@gem_barrier_race@remote-request@rcs0:
- {shard-tglu}: [ABORT][14] ([i915#8211] / [i915#8234]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-tglu-10/igt@gem_barrier_race@remote-request@rcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-tglu-5/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][16] ([i915#6268]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-tglu-9/igt@gem_ctx_exec@basic-nohangcheck.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-tglu-10/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_ctx_freq@sysfs:
- {shard-dg1}: [FAIL][18] ([i915#6786]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-dg1-14/igt@gem_ctx_freq@sysfs.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-dg1-16/igt@gem_ctx_freq@sysfs.html
* igt@gem_exec_fair@basic-none@bcs0:
- {shard-rkl}: [FAIL][20] ([i915#2842]) -> [PASS][21] +3 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-rkl-6/igt@gem_exec_fair@basic-none@bcs0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-rkl-1/igt@gem_exec_fair@basic-none@bcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [FAIL][22] ([i915#2842]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-glk7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-glk6/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [SKIP][24] ([fdo#109271]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-apl6/igt@i915_pm_dc@dc9-dpms.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-apl7/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- {shard-dg1}: [FAIL][26] ([i915#3591]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-dg1-14/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-dg1-16/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
* igt@i915_pm_rpm@dpms-non-lpsp:
- {shard-rkl}: [SKIP][28] ([i915#1397]) -> [PASS][29] +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-rkl-7/igt@i915_pm_rpm@dpms-non-lpsp.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-rkl-3/igt@i915_pm_rpm@dpms-non-lpsp.html
* igt@i915_selftest@live@workarounds:
- {shard-dg1}: [ABORT][30] ([i915#4983]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-dg1-16/igt@i915_selftest@live@workarounds.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-dg1-16/igt@i915_selftest@live@workarounds.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- {shard-rkl}: [FAIL][32] ([i915#3743]) -> [PASS][33] +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-rkl-7/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-rkl-3/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@kms_hdmi_inject@inject-audio:
- {shard-rkl}: [SKIP][34] ([i915#433]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-rkl-3/igt@kms_hdmi_inject@inject-audio.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-rkl-3/igt@kms_hdmi_inject@inject-audio.html
* igt@perf_pmu@busy-double-start@vecs0:
- {shard-dg1}: [FAIL][36] ([i915#4349]) -> [PASS][37] +2 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-dg1-14/igt@perf_pmu@busy-double-start@vecs0.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-dg1-14/igt@perf_pmu@busy-double-start@vecs0.html
#### Warnings ####
* igt@kms_big_fb@4-tiled-32bpp-rotate-0:
- shard-apl: [SKIP][38] ([fdo#109271]) -> [SKIP][39] ([IGT#6] / [fdo#109271]) +3 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-apl1/igt@kms_big_fb@4-tiled-32bpp-rotate-0.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-apl4/igt@kms_big_fb@4-tiled-32bpp-rotate-0.html
* igt@kms_big_fb@4-tiled-64bpp-rotate-180:
- shard-glk: [SKIP][40] ([fdo#109271]) -> [SKIP][41] ([IGT#6] / [fdo#109271]) +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-glk8/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/shard-glk2/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8516]: https://gitlab.freedesktop.org/drm/intel/issues/8516
[i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7310 -> IGTPW_9064
CI-20190529: 20190529
CI_DRM_13200: 0ae4ee2c735979030a0219218081eee661606921 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9064: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/index.html
IGT_7310: 2f9acfea5e3a93303f71cbda6e80ba64b8d75a4d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9064/index.html
[-- Attachment #2: Type: text/html, Size: 12913 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/i915/kms_dsc: add limited flag
2023-05-30 17:35 ` [igt-dev] [PATCH i-g-t v2] " Zbigniew Kempczyński
@ 2023-05-31 9:16 ` Sharma, Swati2
0 siblings, 0 replies; 5+ messages in thread
From: Sharma, Swati2 @ 2023-05-31 9:16 UTC (permalink / raw)
To: Zbigniew Kempczyński; +Cc: igt-dev
On 30-May-23 11:05 PM, Zbigniew Kempczyński wrote:
> On Mon, May 29, 2023 at 10:10:22PM +0530, Swati Sharma wrote:
>> Add limited flag to restrict test execution to one valid pipe-output
>> combination. By default all tests will run on all valid pipe-output
>> combinations.
>>
>> v2: -rename extended to limited (Kamil)
>>
>> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>> ---
>> tests/i915/kms_dsc.c | 26 ++++++++++++++++++++++++--
>> 1 file changed, 24 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
>> index 3ce28f84..9ddb441d 100644
>> --- a/tests/i915/kms_dsc.c
>> +++ b/tests/i915/kms_dsc.c
>> @@ -51,6 +51,7 @@ typedef struct {
>> int input_bpc;
>> int disp_ver;
>> enum pipe pipe;
>> + bool limited;
>> } data_t;
>>
>> static int output_format_list[] = {DSC_FORMAT_YCBCR420, DSC_FORMAT_YCBCR444};
>> @@ -250,13 +251,34 @@ static void test_dsc(data_t *data, enum dsc_test_type test_type, int bpc,
>>
>> igt_dynamic_f("pipe-%s-%s%s", kmstest_pipe_name(data->pipe), data->output->name, name)
>> update_display(data, test_type);
>> +
>> + if (data->limited)
>> + break;
>> }
>> }
>>
>> -igt_main
>> +static int opt_handler(int opt, int opt_index, void *_data)
>> {
>> - data_t data = {};
>
> You don't need to introduce static data below, handler has pointer
> to it, and functions are called with &data so keeping this on stack
> is better for me (protects from global access in any place).
>
>> + data_t *data = _data;
>> +
>> + switch (opt) {
>> + case 'l':
>> + data->limited = true;
>> + break;
>> + default:
>> + return IGT_OPT_HANDLER_ERROR;
>> + }
>> +
>> + return IGT_OPT_HANDLER_SUCCESS;
>> +}
>> +
>> +static const char help_str[] =
>> + " --limited\t\tLimit execution to 1 valid pipe-output combo\n";
>
> I see you're using short option '-l', just add this to line above like:
>
> " --limited\t-l\tLimit ..."
>
>>
>> +static data_t data = {};
>
> Keep this on stack. With this nit fixed:
>
> Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Thanks Zbigniew for the review. With above changes floated v3.
>
> --
> Zbigniew
>
>> +
>> +igt_main_args("l", NULL, help_str, opt_handler, &data)
>> +{
>> igt_fixture {
>> data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
>> data.devid = intel_get_drm_devid(data.drm_fd);
>> --
>> 2.25.1
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-31 9:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-29 16:40 [igt-dev] [PATCH i-g-t v2] tests/i915/kms_dsc: add limited flag Swati Sharma
2023-05-30 15:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-05-30 17:35 ` [igt-dev] [PATCH i-g-t v2] " Zbigniew Kempczyński
2023-05-31 9:16 ` Sharma, Swati2
2023-05-31 8:24 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox