From: Swati Sharma <swati2.sharma@intel.com>
To: "Hogander, Jouni" <jouni.hogander@intel.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t v4 3/8] lib/dsc: Add helpers for VDSC YCbCr420 debugfs entry
Date: Wed, 18 Jan 2023 22:06:13 +0530 [thread overview]
Message-ID: <cd098a3b-adeb-8a77-17e9-8bc82543c750@intel.com> (raw)
In-Reply-To: <e905e151fc0bb6c67f034752a7c428040c66ff47.camel@intel.com>
On 13-Jan-23 1:47 PM, Hogander, Jouni wrote:
>> + * Returns: 1 on success or negative error code, in case of failure.
> 0 is usually success, < 0 is error. This is also in coding style
> document. I see igt_force_dsc_enable is also using 1. Maybe you should
> fix that as well in a separate patch.
>
This ret value is returned from igt_sysfs_write() which returns the
number of bytes written, or -errno on error.
I guess we can't change this.
--
~Swati Sharma
next prev parent reply other threads:[~2023-01-18 16:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 7:35 [igt-dev] [PATCH i-g-t v4 0/8] VDSC YCbCr420 + Fractional BPP Swati Sharma
2023-01-12 7:35 ` [igt-dev] [PATCH i-g-t v4 1/8] lib/dsc: Move VDSC functions to separate lib file Swati Sharma
2023-01-12 7:35 ` [igt-dev] [PATCH i-g-t v4 2/8] Move wrapper functions from kms_dsc to kms_dsc_helper Swati Sharma
2023-01-13 7:55 ` Hogander, Jouni
2023-01-12 7:35 ` [igt-dev] [PATCH i-g-t v4 3/8] lib/dsc: Add helpers for VDSC YCbCr420 debugfs entry Swati Sharma
2023-01-13 8:17 ` Hogander, Jouni
2023-01-18 16:36 ` Swati Sharma [this message]
2023-01-20 11:02 ` Hogander, Jouni
2023-01-21 5:28 ` Swati Sharma
2023-01-12 7:35 ` [igt-dev] [PATCH i-g-t v4 4/8] tests/i915/kms_dsc: Prep work for extending val support for VDSC YCbCr420 Swati Sharma
2023-01-12 7:35 ` [igt-dev] [PATCH i-g-t v4 5/8] tests/i915/kms_dsc: Enable validation " Swati Sharma
2023-01-13 8:29 ` Hogander, Jouni
2023-01-12 7:35 ` [igt-dev] [PATCH i-g-t v4 6/8] lib/dsc: Add helpers for VDSC Fractional BPP debugfs entry Swati Sharma
2023-01-13 8:31 ` Hogander, Jouni
2023-01-12 7:35 ` [igt-dev] [PATCH i-g-t v4 7/8] tests/i915/kms_dsc: Enable validation for VDSC Fractional BPP Swati Sharma
2023-01-12 7:35 ` [igt-dev] [PATCH i-g-t v4 8/8] tests/i915/kms_dsc: Add test summary Swati Sharma
2023-01-12 8:51 ` [igt-dev] ✗ GitLab.Pipeline: warning for VDSC YCbCr420 + Fractional BPP (rev3) Patchwork
2023-01-12 14:56 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-01-12 17:56 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd098a3b-adeb-8a77-17e9-8bc82543c750@intel.com \
--to=swati2.sharma@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox