Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Riana Tauro <riana.tauro@intel.com>
To: Karthik Poosa <karthik.poosa@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <anshuman.gupta@intel.com>
Subject: Re: [PATCH i-g-t] tests/intel/xe_pm_residency: Add an assertion on MI_STORE execution time
Date: Tue, 24 Sep 2024 10:57:11 +0530	[thread overview]
Message-ID: <cd1d46a7-25d6-4dad-81e9-352cc041de8e@intel.com> (raw)
In-Reply-To: <20240923164703.1923050-1-karthik.poosa@intel.com>

Hi Karthik

On 9/23/2024 10:17 PM, Karthik Poosa wrote:
> MI_STORE_DWORD generally completes within couple of ms.
> Assert if it takes more than 1.2 seconds, as it will cause
> IGT test to timeout due to sleep of 120 seconds which is
> the current per task timeout.
s/task/test
> 
> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> ---
>   tests/intel/xe_pm_residency.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/tests/intel/xe_pm_residency.c b/tests/intel/xe_pm_residency.c
> index 0e687558b..29c35f617 100644
> --- a/tests/intel/xe_pm_residency.c
> +++ b/tests/intel/xe_pm_residency.c
> @@ -144,6 +144,15 @@ static void exec_load(int fd, struct drm_xe_engine_class_instance *hwe, unsigned
>   			  1e-3 * submit,
>   			  1e-3 * (elapsed - submit));
>   
> +		/*
> +		 * MI_STORE_DWORD generally completes within couple of ms.
> +		 * Assert if it takes more than 1.2 seconds, as it will cause
> +		 * IGT test to timeout due to sleep of 120 seconds which is
> +		 * the current per task timeout. Current there is no way to
s/task/test
s/Current/Currently

With that
Reviewed-by: Riana Tauro <riana.tauro@intel.com>
> +		 * read this timeout from IGT test.
> +		 */
> +		igt_assert((uint64_t)elapsed < (uint64_t)(1.2 * NSEC_PER_SEC));
> +
>   		syncobj_reset(fd, &syncobj, 1);
>   
>   		/*

      reply	other threads:[~2024-09-24  5:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-23 16:47 [PATCH i-g-t] tests/intel/xe_pm_residency: Add an assertion on MI_STORE execution time Karthik Poosa
2024-09-24  5:27 ` Riana Tauro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd1d46a7-25d6-4dad-81e9-352cc041de8e@intel.com \
    --to=riana.tauro@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=karthik.poosa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox