* [PATCH i-g-t] tests/intel/xe_pm_residency: Add an assertion on MI_STORE execution time
@ 2024-09-23 16:47 Karthik Poosa
2024-09-24 5:27 ` Riana Tauro
0 siblings, 1 reply; 2+ messages in thread
From: Karthik Poosa @ 2024-09-23 16:47 UTC (permalink / raw)
To: igt-dev; +Cc: anshuman.gupta, riana.tauro, Karthik Poosa
MI_STORE_DWORD generally completes within couple of ms.
Assert if it takes more than 1.2 seconds, as it will cause
IGT test to timeout due to sleep of 120 seconds which is
the current per task timeout.
Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
---
tests/intel/xe_pm_residency.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tests/intel/xe_pm_residency.c b/tests/intel/xe_pm_residency.c
index 0e687558b..29c35f617 100644
--- a/tests/intel/xe_pm_residency.c
+++ b/tests/intel/xe_pm_residency.c
@@ -144,6 +144,15 @@ static void exec_load(int fd, struct drm_xe_engine_class_instance *hwe, unsigned
1e-3 * submit,
1e-3 * (elapsed - submit));
+ /*
+ * MI_STORE_DWORD generally completes within couple of ms.
+ * Assert if it takes more than 1.2 seconds, as it will cause
+ * IGT test to timeout due to sleep of 120 seconds which is
+ * the current per task timeout. Current there is no way to
+ * read this timeout from IGT test.
+ */
+ igt_assert((uint64_t)elapsed < (uint64_t)(1.2 * NSEC_PER_SEC));
+
syncobj_reset(fd, &syncobj, 1);
/*
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH i-g-t] tests/intel/xe_pm_residency: Add an assertion on MI_STORE execution time
2024-09-23 16:47 [PATCH i-g-t] tests/intel/xe_pm_residency: Add an assertion on MI_STORE execution time Karthik Poosa
@ 2024-09-24 5:27 ` Riana Tauro
0 siblings, 0 replies; 2+ messages in thread
From: Riana Tauro @ 2024-09-24 5:27 UTC (permalink / raw)
To: Karthik Poosa, igt-dev; +Cc: anshuman.gupta
Hi Karthik
On 9/23/2024 10:17 PM, Karthik Poosa wrote:
> MI_STORE_DWORD generally completes within couple of ms.
> Assert if it takes more than 1.2 seconds, as it will cause
> IGT test to timeout due to sleep of 120 seconds which is
> the current per task timeout.
s/task/test
>
> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> ---
> tests/intel/xe_pm_residency.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/tests/intel/xe_pm_residency.c b/tests/intel/xe_pm_residency.c
> index 0e687558b..29c35f617 100644
> --- a/tests/intel/xe_pm_residency.c
> +++ b/tests/intel/xe_pm_residency.c
> @@ -144,6 +144,15 @@ static void exec_load(int fd, struct drm_xe_engine_class_instance *hwe, unsigned
> 1e-3 * submit,
> 1e-3 * (elapsed - submit));
>
> + /*
> + * MI_STORE_DWORD generally completes within couple of ms.
> + * Assert if it takes more than 1.2 seconds, as it will cause
> + * IGT test to timeout due to sleep of 120 seconds which is
> + * the current per task timeout. Current there is no way to
s/task/test
s/Current/Currently
With that
Reviewed-by: Riana Tauro <riana.tauro@intel.com>
> + * read this timeout from IGT test.
> + */
> + igt_assert((uint64_t)elapsed < (uint64_t)(1.2 * NSEC_PER_SEC));
> +
> syncobj_reset(fd, &syncobj, 1);
>
> /*
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-24 5:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-23 16:47 [PATCH i-g-t] tests/intel/xe_pm_residency: Add an assertion on MI_STORE execution time Karthik Poosa
2024-09-24 5:27 ` Riana Tauro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox