From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_persistent_relocs: Manage the domain for the GGTT access
Date: Thu, 17 Oct 2019 14:38:24 +0100 [thread overview]
Message-ID: <cdfe6069-d178-a448-72f2-a87a786f8cc8@linux.intel.com> (raw)
In-Reply-To: <20191016185642.16181-1-chris@chris-wilson.co.uk>
On 16/10/2019 19:56, Chris Wilson wrote:
> Since the GGTT fault will overlap with the pwrite access, there is no
> implicit moment at which the kernel will automagically flush the backing
> store. Userspace has to be explicit in its domain control, or do itself.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112037
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_persistent_relocs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/i915/gem_persistent_relocs.c b/tests/i915/gem_persistent_relocs.c
> index 2ab7091ad..20ee03027 100644
> --- a/tests/i915/gem_persistent_relocs.c
> +++ b/tests/i915/gem_persistent_relocs.c
> @@ -224,8 +224,11 @@ static void do_test(int fd, bool faulting_reloc)
>
> relocs_bo_handle[i] = gem_create(fd, 4096);
> gem_write(fd, relocs_bo_handle[i], 0, reloc, sizeof(reloc));
> +
> gtt_relocs_ptr[i] = gem_mmap__gtt(fd, relocs_bo_handle[i], 4096,
> PROT_READ | PROT_WRITE);
> + gem_set_domain(fd, relocs_bo_handle[i],
> + I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
> }
>
> /* repeat must be smaller than 4096/small_pitch */
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-10-17 13:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 18:56 [igt-dev] [PATCH i-g-t] i915/gem_persistent_relocs: Manage the domain for the GGTT access Chris Wilson
2019-10-16 21:21 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2019-10-17 13:38 ` Tvrtko Ursulin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdfe6069-d178-a448-72f2-a87a786f8cc8@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox