[igt-dev] [PATCH i-g-t] i915/gem_persistent_relocs: Manage the domain for the GGTT access

[igt-dev] [PATCH i-g-t] i915/gem_persistent_relocs: Manage the domain for the GGTT access

[Chris Wilson]

Since the GGTT fault will overlap with the pwrite access, there is no
implicit moment at which the kernel will automagically flush the backing
store. Userspace has to be explicit in its domain control, or do itself.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112037
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/gem_persistent_relocs.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/i915/gem_persistent_relocs.c b/tests/i915/gem_persistent_relocs.c
index 2ab7091ad..20ee03027 100644
--- a/tests/i915/gem_persistent_relocs.c
+++ b/tests/i915/gem_persistent_relocs.c
@@ -224,8 +224,11 @@ static void do_test(int fd, bool faulting_reloc)
 
 		relocs_bo_handle[i] = gem_create(fd, 4096);
 		gem_write(fd, relocs_bo_handle[i], 0, reloc, sizeof(reloc));
+
 		gtt_relocs_ptr[i] = gem_mmap__gtt(fd, relocs_bo_handle[i], 4096,
 						  PROT_READ | PROT_WRITE);
+		gem_set_domain(fd, relocs_bo_handle[i],
+			       I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
 	}
 
 	/* repeat must be smaller than 4096/small_pitch */
-- 
2.23.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for i915/gem_persistent_relocs: Manage the domain for the GGTT access

[Patchwork]

== Series Details ==

Series: i915/gem_persistent_relocs: Manage the domain for the GGTT access
URL   : https://patchwork.freedesktop.org/series/68120/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7112 -> IGTPW_3579
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_3579 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_3579, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3579/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3579:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live_execlists:
    - fi-kbl-7500u:       [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7112/fi-kbl-7500u/igt@i915_selftest@live_execlists.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3579/fi-kbl-7500u/igt@i915_selftest@live_execlists.html
    - fi-bxt-dsi:         [PASS][3] -> [DMESG-FAIL][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7112/fi-bxt-dsi/igt@i915_selftest@live_execlists.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3579/fi-bxt-dsi/igt@i915_selftest@live_execlists.html

  
Known issues
------------

  Here are the changes found in IGTPW_3579 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [PASS][5] -> [FAIL][6] ([fdo#111407])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7112/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3579/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u2:          [PASS][7] -> [FAIL][8] ([fdo#103167])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7112/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3579/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html

  * igt@prime_busy@basic-wait-after-default:
    - fi-icl-u3:          [PASS][9] -> [DMESG-WARN][10] ([fdo#107724]) +1 similar issue
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7112/fi-icl-u3/igt@prime_busy@basic-wait-after-default.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3579/fi-icl-u3/igt@prime_busy@basic-wait-after-default.html

  
#### Possible fixes ####

  * igt@gem_ctx_create@basic-files:
    - {fi-tgl-u}:         [INCOMPLETE][11] ([fdo#111735]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7112/fi-tgl-u/igt@gem_ctx_create@basic-files.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3579/fi-tgl-u/igt@gem_ctx_create@basic-files.html

  * igt@gem_tiled_pread_basic:
    - fi-icl-u3:          [DMESG-WARN][13] ([fdo#107724]) -> [PASS][14] +1 similar issue
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7112/fi-icl-u3/igt@gem_tiled_pread_basic.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3579/fi-icl-u3/igt@gem_tiled_pread_basic.html

  * igt@i915_selftest@live_execlists:
    - {fi-icl-guc}:       [DMESG-FAIL][15] -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7112/fi-icl-guc/igt@i915_selftest@live_execlists.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3579/fi-icl-guc/igt@i915_selftest@live_execlists.html
    - fi-skl-6770hq:      [DMESG-FAIL][17] -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7112/fi-skl-6770hq/igt@i915_selftest@live_execlists.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3579/fi-skl-6770hq/igt@i915_selftest@live_execlists.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-cfl-8109u:       [DMESG-FAIL][19] -> [PASS][20] +1 similar issue
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7112/fi-cfl-8109u/igt@i915_selftest@live_gem_contexts.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3579/fi-cfl-8109u/igt@i915_selftest@live_gem_contexts.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-hsw-peppy:       [DMESG-WARN][21] ([fdo#102614]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7112/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3579/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
  [fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
  [fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747


Participating hosts (52 -> 46)
------------------------------

  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5231 -> IGTPW_3579

  CI-20190529: 20190529
  CI_DRM_7112: bb40330c82b49d8deb0040574139f7bc82857bf8 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3579: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3579/index.html
  IGT_5231: e293051f8f99c72cb01d21e4b73a5928ea351eb3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3579/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] i915/gem_persistent_relocs: Manage the domain for the GGTT access

[Tvrtko Ursulin]

On 16/10/2019 19:56, Chris Wilson wrote:
> Since the GGTT fault will overlap with the pwrite access, there is no
> implicit moment at which the kernel will automagically flush the backing
> store. Userspace has to be explicit in its domain control, or do itself.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112037
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/i915/gem_persistent_relocs.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tests/i915/gem_persistent_relocs.c b/tests/i915/gem_persistent_relocs.c
> index 2ab7091ad..20ee03027 100644
> --- a/tests/i915/gem_persistent_relocs.c
> +++ b/tests/i915/gem_persistent_relocs.c
> @@ -224,8 +224,11 @@ static void do_test(int fd, bool faulting_reloc)
>   
>   		relocs_bo_handle[i] = gem_create(fd, 4096);
>   		gem_write(fd, relocs_bo_handle[i], 0, reloc, sizeof(reloc));
> +
>   		gtt_relocs_ptr[i] = gem_mmap__gtt(fd, relocs_bo_handle[i], 4096,
>   						  PROT_READ | PROT_WRITE);
> +		gem_set_domain(fd, relocs_bo_handle[i],
> +			       I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
>   	}
>   
>   	/* repeat must be smaller than 4096/small_pitch */
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev