Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Jeevan B <jeevan.b@intel.com>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 4/5] tests/kms_draw_crc: Use 4 tiling when filling framebuffer
Date: Tue, 15 Mar 2022 18:00:43 +0200	[thread overview]
Message-ID: <ce66978e-e21e-3f96-9fc5-e63bc3228bfb@gmail.com> (raw)
In-Reply-To: <20220309164452.8240-5-jeevan.b@intel.com>

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

On 9.3.2022 18.44, Jeevan B wrote:
> From: Mika Kahola <mika.kahola@intel.com>
> 
> For platforms with 4 tiling, let's use 4 tiling instead of Y tiling.
> 
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
>   tests/i915/kms_draw_crc.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c
> index 33b7bdf4..33fefed4 100644
> --- a/tests/i915/kms_draw_crc.c
> +++ b/tests/i915/kms_draw_crc.c
> @@ -226,6 +226,7 @@ static void fill_fb_subtest(void)
>   	int rc;
>   	struct igt_fb fb;
>   	igt_crc_t base_crc, crc;
> +	bool has_4tile = intel_get_device_info(intel_get_drm_devid(drm_fd))->has_4tile;
>   
>   	igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay,
>   		      DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &fb);
> @@ -248,7 +249,9 @@ static void fill_fb_subtest(void)
>   	igt_assert_crc_equal(&crc, &base_crc);
>   
>   	if (intel_display_ver(intel_get_drm_devid(drm_fd)) >= 9) {
> -		get_fill_crc(I915_FORMAT_MOD_Y_TILED, &crc);
> +		get_fill_crc(has_4tile ?
> +			     I915_FORMAT_MOD_4_TILED : I915_FORMAT_MOD_Y_TILED,
> +			     &crc);
>   		igt_assert_crc_equal(&crc, &base_crc);
>   	}
>   

  reply	other threads:[~2022-03-15 16:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-09 16:44 [igt-dev] [PATCH i-g-t 0/5] Add tile 4 plane format support Jeevan B
2022-03-09 16:44 ` [igt-dev] [PATCH i-g-t 1/5] lib/igt_draw: Use XY_FAST_COLOR_BLT on DG2 Jeevan B
2022-03-15 15:59   ` Juha-Pekka Heikkila
2022-03-09 16:44 ` [igt-dev] [PATCH i-g-t 2/5] igt/tests: Add support for Tile4(TileF) format to tests/kms_addfb_basic Jeevan B
2022-03-15 15:59   ` Juha-Pekka Heikkila
2022-03-09 16:44 ` [igt-dev] [PATCH i-g-t 3/5] tests/kms_frontbuffer_tracking: Add support for 4 tiling Jeevan B
2022-03-15 16:00   ` Juha-Pekka Heikkila
2022-03-09 16:44 ` [igt-dev] [PATCH i-g-t 4/5] tests/kms_draw_crc: Use 4 tiling when filling framebuffer Jeevan B
2022-03-15 16:00   ` Juha-Pekka Heikkila [this message]
2022-03-09 16:44 ` [igt-dev] [PATCH i-g-t 5/5] tests/kms_plane_scaling: Adding Tile-4 support Jeevan B
2022-03-15 16:01   ` Juha-Pekka Heikkila
2022-03-09 18:16 ` [igt-dev] ✓ Fi.CI.BAT: success for Add tile 4 plane format support Patchwork
2022-03-10  4:11 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce66978e-e21e-3f96-9fc5-e63bc3228bfb@gmail.com \
    --to=juhapekka.heikkila@gmail.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox