Re: [PATCH i-g-t] lib/igt_core: Distinguish dynamic subtest in finished messages

[Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>]

On Wed, 2026-06-10 at 17:29 +0200, Kamil Konieczny wrote:
> Hi Swati,
> On 2026-06-09 at 01:08:07 +0530, Swati Sharma wrote:
> > The exit_subtest() function always printed 'finished subtest' in kmsg
> > and trace output regardless of whether it was a regular subtest or a
> > dynamic subtest finishing. The 'starting' messages already correctly
> > distinguish between the two ('starting subtest' vs 'starting dynamic
> > subtest').
> > 
> > Fix the 'finished' messages to print 'finished dynamic subtest' for
> > dynamic subtests, matching the starting message convention. This makes
> > syslog parsing and test hang detection more accurate.
> 
> Should you add Closes tag here? See
> https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/work_items/198
> Fix multiple results from one (dynamic) subtest reported
> 
> +cc Janusz
> Cc: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> 
> > 
> > Assisted-by: GitHub Copilot:Claude Opus 4.6
> > Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> > ---
> >  lib/igt_core.c | 10 ++++++----
> >  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> This could potentailly affect other CI pipelines, so
> +cc Vitaly.
> 
> Regards,
> Kamil
> 
> > 
> > diff --git a/lib/igt_core.c b/lib/igt_core.c
> > index dc3ac5304..a0d9c9d7d 100644
> > --- a/lib/igt_core.c
> > +++ b/lib/igt_core.c
> > @@ -1733,10 +1733,12 @@ __noreturn static void exit_subtest(const char *result)
> >  				*subtest_name,
> >  				result,
> >  				igt_time_elapsed(thentime, &now));
> > -	igt_kmsg(KMSG_INFO "%s: finished subtest %s, %s\n",
> > -		 command_str, *subtest_name, result);
> > -	igt_trace("%s: finished subtest %s, %s\n",
> > -		  command_str, *subtest_name, result);
> > +	igt_kmsg(KMSG_INFO "%s: finished %s %s, %s\n",
> > +		 command_str, in_dynamic_subtest ? "dynamic subtest" : "subtest",
> > +		 *subtest_name, result);
> > +	igt_trace("%s: finished %s %s, %s\n",
> > +		  command_str, in_dynamic_subtest ? "dynamic subtest" : "subtest",
> > +		  *subtest_name, result);

Isn't igt_runner watching those messages?  Won't it be confused if not
adjusted to the new message content?

Thanks,
Janusz

> >  
> >  	igt_terminate_spins();
> >  
> > -- 
> > 2.25.1
> >