Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] lib/igt_core: Distinguish dynamic subtest in finished messages
@ 2026-06-08 19:38 Swati Sharma
  2026-06-09  0:43 ` ✓ Xe.CI.BAT: success for " Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 10+ messages in thread
From: Swati Sharma @ 2026-06-08 19:38 UTC (permalink / raw)
  To: igt-dev; +Cc: kamil.konieczny, zbigniew.kempczynski, Swati Sharma

The exit_subtest() function always printed 'finished subtest' in kmsg
and trace output regardless of whether it was a regular subtest or a
dynamic subtest finishing. The 'starting' messages already correctly
distinguish between the two ('starting subtest' vs 'starting dynamic
subtest').

Fix the 'finished' messages to print 'finished dynamic subtest' for
dynamic subtests, matching the starting message convention. This makes
syslog parsing and test hang detection more accurate.

Assisted-by: GitHub Copilot:Claude Opus 4.6
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 lib/igt_core.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/lib/igt_core.c b/lib/igt_core.c
index dc3ac5304..a0d9c9d7d 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -1733,10 +1733,12 @@ __noreturn static void exit_subtest(const char *result)
 				*subtest_name,
 				result,
 				igt_time_elapsed(thentime, &now));
-	igt_kmsg(KMSG_INFO "%s: finished subtest %s, %s\n",
-		 command_str, *subtest_name, result);
-	igt_trace("%s: finished subtest %s, %s\n",
-		  command_str, *subtest_name, result);
+	igt_kmsg(KMSG_INFO "%s: finished %s %s, %s\n",
+		 command_str, in_dynamic_subtest ? "dynamic subtest" : "subtest",
+		 *subtest_name, result);
+	igt_trace("%s: finished %s %s, %s\n",
+		  command_str, in_dynamic_subtest ? "dynamic subtest" : "subtest",
+		  *subtest_name, result);
 
 	igt_terminate_spins();
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2026-06-11  8:43 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-08 19:38 [PATCH i-g-t] lib/igt_core: Distinguish dynamic subtest in finished messages Swati Sharma
2026-06-09  0:43 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-06-09  0:50 ` ✓ i915.CI.BAT: " Patchwork
2026-06-09  6:32 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-06-09  9:48 ` [PATCH i-g-t] " Samala, Pranay
2026-06-09 10:03 ` ✗ i915.CI.Full: failure for " Patchwork
2026-06-10 15:29 ` [PATCH i-g-t] " Kamil Konieczny
2026-06-10 15:53   ` vitaly prosyak
2026-06-10 22:53     ` Alex Hung
2026-06-11  8:42   ` Janusz Krzysztofik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox