Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] tests/intel/xe_exec_atomic: fix basic-inc-all
@ 2024-01-29 18:54 Kamil Konieczny
  2024-01-29 19:26 ` ✓ CI.xeBAT: success for " Patchwork
                   ` (6 more replies)
  0 siblings, 7 replies; 12+ messages in thread
From: Kamil Konieczny @ 2024-01-29 18:54 UTC (permalink / raw)
  To: igt-dev; +Cc: Nirmoy Das

Previous test removed skips on unsupported system memory on dGPU
but did it only for basic-dec-all. Fix it for second test
basic-inc-all. Also while at this, use drm_open_driver and
drm_close_driver which takes care of xe device get/put.

Cc: Nirmoy Das <nirmoy.das@intel.com>
Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 tests/intel/xe_exec_atomic.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/tests/intel/xe_exec_atomic.c b/tests/intel/xe_exec_atomic.c
index 48c70ec72..d9790da78 100644
--- a/tests/intel/xe_exec_atomic.c
+++ b/tests/intel/xe_exec_atomic.c
@@ -124,10 +124,8 @@ igt_main
 	struct drm_xe_engine_class_instance *hwe;
 	int fd;
 
-	igt_fixture {
+	igt_fixture
 		fd = drm_open_driver(DRIVER_XE);
-		xe_device_get(fd);
-	}
 
 	igt_subtest_with_dynamic("basic-dec-all") {
 		xe_for_each_engine(fd, hwe) {
@@ -152,8 +150,8 @@ igt_main
 			uint64_t memreg = all_memory_regions(fd), region;
 
 			xe_for_each_mem_region(fd, memreg, region) {
-
-				igt_skip_on(!has_atomics(fd, region));
+				if (!has_atomics(fd, region))
+					continue;
 
 				igt_dynamic_f("Engine-%s-Instance-%d-Tile-%d-%s-memory",
 					      xe_engine_class_string(hwe->engine_class),
@@ -165,8 +163,6 @@ igt_main
 		}
 	}
 
-	igt_fixture {
-		xe_device_put(fd);
-		close(fd);
-	}
+	igt_fixture
+		drm_close_driver(fd);
 }
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2024-02-02  8:38 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-29 18:54 [PATCH i-g-t] tests/intel/xe_exec_atomic: fix basic-inc-all Kamil Konieczny
2024-01-29 19:26 ` ✓ CI.xeBAT: success for " Patchwork
2024-01-29 19:40 ` ✓ Fi.CI.BAT: " Patchwork
2024-01-30  2:28 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-01-30  9:01   ` Kamil Konieczny
2024-01-30  8:57 ` [PATCH i-g-t] " Kamil Konieczny
2024-01-30  9:05   ` Mauro Carvalho Chehab
2024-01-30  9:33 ` Nirmoy Das
2024-02-01  5:31 ` ✗ Fi.CI.IGT: failure for " Patchwork
2024-02-01 12:23   ` Kamil Konieczny
2024-02-02  8:37     ` Illipilli, TejasreeX
2024-02-02  8:16 ` ✓ Fi.CI.IGT: success " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox