Re: [igt-dev] [PATCH 2/2] i915/i915_fb_tiling: Check if device supports tiling

[Brian Welty <brian.welty@intel.com>]

On 11/15/2019 3:16 PM, Vanshidhar Konda wrote:
> Skip this test if the platform does not support setting tiling for frame
> buffer object.
> 

Looking over some other tests, I came across a libdrm function that uses SET_TILING,
drm_intel_bo_alloc_tiled().

Any chance you can expand your patch series to fix tests using that function as well?
It is not quite as easy, I believe you maybe shouldn't disable them all but should
maybe conditionally use drm_intel_bo_alloc_tiled() or drm_intel_bo_alloc().
Not sure.

Thanks,
-Brian


> Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
>  tests/i915/i915_fb_tiling.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/i915/i915_fb_tiling.c b/tests/i915/i915_fb_tiling.c
> index 7d5c3f1f..4ec84962 100644
> --- a/tests/i915/i915_fb_tiling.c
> +++ b/tests/i915/i915_fb_tiling.c
> @@ -32,6 +32,8 @@ igt_simple_main
>  	struct igt_fb fb;
>  	int ret;
>  
> +	igt_require(gem_has_legacy_hw_tiling(drm_fd));
> +
>  	igt_create_fb(drm_fd, 512, 512, DRM_FORMAT_XRGB8888,
>  		      LOCAL_I915_FORMAT_MOD_X_TILED, &fb);
>  
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev