[igt-dev] [PATCH 2/2] i915/i915_fb_tiling: Check if device supports tiling

[igt-dev] [PATCH 2/2] i915/i915_fb_tiling: Check if device supports tiling

[Vanshidhar Konda]

Skip this test if the platform does not support setting tiling for frame
buffer object.

Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
---
 tests/i915/i915_fb_tiling.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/i915/i915_fb_tiling.c b/tests/i915/i915_fb_tiling.c
index 7d5c3f1f..4ec84962 100644
--- a/tests/i915/i915_fb_tiling.c
+++ b/tests/i915/i915_fb_tiling.c
@@ -32,6 +32,8 @@ igt_simple_main
 	struct igt_fb fb;
 	int ret;
 
+	igt_require(gem_has_legacy_hw_tiling(drm_fd));
+
 	igt_create_fb(drm_fd, 512, 512, DRM_FORMAT_XRGB8888,
 		      LOCAL_I915_FORMAT_MOD_X_TILED, &fb);
 
-- 
2.24.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH 0/2] Check if get/set tiling is supported

[Vanshidhar Konda]

With Gen12 hardware, the GET/SET_TILING IOCTLs return EOPNOTSUPP error.
This change impacts usermode code. See this link for more discussion
about this change:
https://patchwork.freedesktop.org/patch/325343/

IGT tests have to be updated to check if these IOCTLs are supported.

Vanshidhar Konda (2):
  lib/ioctl_wrappers: Query if device supports set/get legacy tiling
  i915/i915_fb_tiling: Check if device supports tiling

 lib/ioctl_wrappers.c        | 16 ++++++++++++++++
 lib/ioctl_wrappers.h        |  1 +
 tests/i915/i915_fb_tiling.c |  2 ++
 3 files changed, 19 insertions(+)

-- 
2.24.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH 1/2] lib/ioctl_wrappers: Query if device supports set/get legacy tiling

[Vanshidhar Konda]

Add a method to query if the device supports setting and getting legacy
tiling formats for buffer objects.

Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 lib/ioctl_wrappers.c | 17 +++++++++++++++++
 lib/ioctl_wrappers.h |  1 +
 2 files changed, 18 insertions(+)

diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
index 628f8b83..aefe08d8 100644
--- a/lib/ioctl_wrappers.c
+++ b/lib/ioctl_wrappers.c
@@ -133,6 +133,23 @@ __gem_get_tiling(int fd, struct drm_i915_gem_get_tiling *arg)
 	return err;
 }
 
+/**
+ * gem_has_legacy_hw_tiling:
+ * @fd: open i915 drm file descriptor
+ *
+ * Feature check to query if the device supports setting/getting
+ * legacy tiling formats for buffer objects
+ *
+ * Returns: True if tiling is supported
+ */
+bool
+gem_has_legacy_hw_tiling(int fd)
+{
+	struct drm_i915_gem_get_tiling arg = {};
+
+	return (__gem_get_tiling(fd, &arg) != -EOPNOTSUPP);
+}
+
 /**
  * gem_get_tiling:
  * @fd: open i915 drm file descriptor
diff --git a/lib/ioctl_wrappers.h b/lib/ioctl_wrappers.h
index 03211c97..c9c96902 100644
--- a/lib/ioctl_wrappers.h
+++ b/lib/ioctl_wrappers.h
@@ -145,6 +145,7 @@ void gem_require_caching(int fd);
 void gem_require_ring(int fd, unsigned ring);
 bool gem_has_mocs_registers(int fd);
 void gem_require_mocs_registers(int fd);
+bool gem_has_legacy_hw_tiling(int fd);
 
 #define gem_has_ring(f, r) gem_context_has_engine(f, 0, r)
 
-- 
2.23.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH 2/2] i915/i915_fb_tiling: Check if device supports tiling

[Vanshidhar Konda]

Skip this test if the platform does not support setting tiling for frame
buffer object.

Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 tests/i915/i915_fb_tiling.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/i915/i915_fb_tiling.c b/tests/i915/i915_fb_tiling.c
index 7d5c3f1f..4ec84962 100644
--- a/tests/i915/i915_fb_tiling.c
+++ b/tests/i915/i915_fb_tiling.c
@@ -32,6 +32,8 @@ igt_simple_main
 	struct igt_fb fb;
 	int ret;
 
+	igt_require(gem_has_legacy_hw_tiling(drm_fd));
+
 	igt_create_fb(drm_fd, 512, 512, DRM_FORMAT_XRGB8888,
 		      LOCAL_I915_FORMAT_MOD_X_TILED, &fb);
 
-- 
2.23.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for Check if get/set tiling is supported

[Patchwork]

== Series Details ==

Series: Check if get/set tiling is supported
URL   : https://patchwork.freedesktop.org/series/69566/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7357 -> IGTPW_3717
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/index.html

Known issues
------------

  Here are the changes found in IGTPW_3717 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_chamelium@dp-crc-fast:
    - fi-kbl-7500u:       [PASS][1] -> [FAIL][2] ([fdo#109483] / [fdo#109635 ])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html

  * igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
    - fi-skl-6770hq:      [PASS][3] -> [FAIL][4] ([fdo#109495])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-skl-6770hq/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/fi-skl-6770hq/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u3:          [PASS][5] -> [FAIL][6] ([fdo#103167])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html

  
#### Possible fixes ####

  * igt@i915_module_load@reload-no-display:
    - fi-skl-lmem:        [DMESG-WARN][7] ([fdo#112261]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/fi-skl-lmem/igt@i915_module_load@reload-no-display.html

  * igt@kms_chamelium@hdmi-crc-fast:
    - fi-icl-u2:          [FAIL][9] ([fdo#109635 ]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][11] ([fdo#109483]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-hsw-peppy:       [DMESG-WARN][13] ([fdo#102614]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
  [fdo#109495]: https://bugs.freedesktop.org/show_bug.cgi?id=109495
  [fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635 
  [fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
  [fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298


Participating hosts (51 -> 45)
------------------------------

  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5288 -> IGTPW_3717

  CI-20190529: 20190529
  CI_DRM_7357: 315d68345bfe8da7b034123352106c6edbcc380d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3717: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/index.html
  IGT_5288: ff4551e36cd8e573ceb1e450d17a12e3298dc04c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for Check if get/set tiling is supported

[Patchwork]

== Series Details ==

Series: Check if get/set tiling is supported
URL   : https://patchwork.freedesktop.org/series/69566/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7357_full -> IGTPW_3717_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3717_full:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * {igt@gem_exec_parse_blt@bb-secure}:
    - shard-tglb:         NOTRUN -> [SKIP][1] +2 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-tglb2/igt@gem_exec_parse_blt@bb-secure.html

  
Known issues
------------

  Here are the changes found in IGTPW_3717_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@rcs0-s3:
    - shard-kbl:          [PASS][2] -> [DMESG-WARN][3] ([fdo#108566]) +1 similar issue
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-kbl4/igt@gem_ctx_isolation@rcs0-s3.html

  * igt@gem_ctx_persistence@vcs1-mixed-process:
    - shard-iclb:         [PASS][4] -> [SKIP][5] ([fdo#109276] / [fdo#112080]) +1 similar issue
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb1/igt@gem_ctx_persistence@vcs1-mixed-process.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-iclb6/igt@gem_ctx_persistence@vcs1-mixed-process.html

  * igt@gem_ctx_shared@exec-single-timeline-bsd:
    - shard-iclb:         [PASS][6] -> [SKIP][7] ([fdo#110841])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb6/igt@gem_ctx_shared@exec-single-timeline-bsd.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd.html

  * igt@gem_eio@kms:
    - shard-snb:          [PASS][8] -> [INCOMPLETE][9] ([fdo#105411])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-snb7/igt@gem_eio@kms.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-snb7/igt@gem_eio@kms.html

  * igt@gem_exec_schedule@in-order-bsd:
    - shard-iclb:         [PASS][10] -> [SKIP][11] ([fdo#112146]) +3 similar issues
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb8/igt@gem_exec_schedule@in-order-bsd.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-iclb1/igt@gem_exec_schedule@in-order-bsd.html

  * igt@gem_exec_schedule@preempt-queue-chain-render:
    - shard-tglb:         [PASS][12] -> [INCOMPLETE][13] ([fdo#111606] / [fdo#111677])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb8/igt@gem_exec_schedule@preempt-queue-chain-render.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-tglb6/igt@gem_exec_schedule@preempt-queue-chain-render.html

  * igt@gem_sync@basic-store-each:
    - shard-tglb:         [PASS][14] -> [INCOMPLETE][15] ([fdo#111647] / [fdo#111747])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb4/igt@gem_sync@basic-store-each.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-tglb5/igt@gem_sync@basic-store-each.html

  * igt@gem_userptr_blits@sync-unmap:
    - shard-snb:          [PASS][16] -> [DMESG-WARN][17] ([fdo#111870])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-snb4/igt@gem_userptr_blits@sync-unmap.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-snb4/igt@gem_userptr_blits@sync-unmap.html

  * igt@gem_workarounds@suspend-resume-context:
    - shard-apl:          [PASS][18] -> [DMESG-WARN][19] ([fdo#108566]) +2 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-apl6/igt@gem_workarounds@suspend-resume-context.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-apl6/igt@gem_workarounds@suspend-resume-context.html

  * igt@i915_pm_rpm@system-suspend:
    - shard-tglb:         [PASS][20] -> [INCOMPLETE][21] ([fdo#111747] / [fdo#111850])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb8/igt@i915_pm_rpm@system-suspend.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-tglb8/igt@i915_pm_rpm@system-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
    - shard-tglb:         [PASS][22] -> [FAIL][23] ([fdo#103167]) +2 similar issues
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
    - shard-iclb:         [PASS][24] -> [FAIL][25] ([fdo#103167]) +5 similar issues
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

  * igt@kms_plane@plane-position-covered-pipe-a-planes:
    - shard-glk:          [PASS][26] -> [FAIL][27] ([fdo#110038])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-glk9/igt@kms_plane@plane-position-covered-pipe-a-planes.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-glk7/igt@kms_plane@plane-position-covered-pipe-a-planes.html
    - shard-apl:          [PASS][28] -> [FAIL][29] ([fdo#110038])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-apl8/igt@kms_plane@plane-position-covered-pipe-a-planes.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-apl7/igt@kms_plane@plane-position-covered-pipe-a-planes.html
    - shard-kbl:          [PASS][30] -> [FAIL][31] ([fdo#110038])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-kbl3/igt@kms_plane@plane-position-covered-pipe-a-planes.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-kbl2/igt@kms_plane@plane-position-covered-pipe-a-planes.html

  * igt@kms_plane_lowres@pipe-a-tiling-y:
    - shard-iclb:         [PASS][32] -> [FAIL][33] ([fdo#103166])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-y.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-y.html

  * igt@kms_psr@psr2_cursor_blt:
    - shard-iclb:         [PASS][34] -> [SKIP][35] ([fdo#109441]) +1 similar issue
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-iclb3/igt@kms_psr@psr2_cursor_blt.html

  * igt@kms_vblank@pipe-c-ts-continuation-suspend:
    - shard-tglb:         [PASS][36] -> [INCOMPLETE][37] ([fdo#111832] / [fdo#111850]) +1 similar issue
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb1/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-tglb3/igt@kms_vblank@pipe-c-ts-continuation-suspend.html

  * igt@perf_pmu@busy-no-semaphores-vcs1:
    - shard-iclb:         [PASS][38] -> [SKIP][39] ([fdo#112080]) +8 similar issues
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb1/igt@perf_pmu@busy-no-semaphores-vcs1.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-iclb5/igt@perf_pmu@busy-no-semaphores-vcs1.html

  * igt@prime_busy@hang-bsd2:
    - shard-iclb:         [PASS][40] -> [SKIP][41] ([fdo#109276]) +21 similar issues
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb2/igt@prime_busy@hang-bsd2.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-iclb8/igt@prime_busy@hang-bsd2.html

  * igt@prime_vgem@basic-sync-default:
    - shard-iclb:         [PASS][42] -> [INCOMPLETE][43] ([fdo#107713])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb2/igt@prime_vgem@basic-sync-default.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-iclb3/igt@prime_vgem@basic-sync-default.html

  
#### Possible fixes ####

  * igt@gem_busy@busy-vcs1:
    - shard-iclb:         [SKIP][44] ([fdo#112080]) -> [PASS][45] +10 similar issues
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb6/igt@gem_busy@busy-vcs1.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-iclb1/igt@gem_busy@busy-vcs1.html

  * igt@gem_ctx_isolation@vcs0-s3:
    - shard-tglb:         [INCOMPLETE][46] ([fdo#111832]) -> [PASS][47]
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb8/igt@gem_ctx_isolation@vcs0-s3.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-tglb2/igt@gem_ctx_isolation@vcs0-s3.html

  * igt@gem_ctx_persistence@vcs1-hostile-preempt:
    - shard-iclb:         [SKIP][48] ([fdo#109276] / [fdo#112080]) -> [PASS][49] +1 similar issue
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb6/igt@gem_ctx_persistence@vcs1-hostile-preempt.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-iclb2/igt@gem_ctx_persistence@vcs1-hostile-preempt.html

  * igt@gem_ctx_shared@exec-single-timeline-bsd1:
    - shard-iclb:         [SKIP][50] ([fdo#109276]) -> [PASS][51] +9 similar issues
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd1.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd1.html

  * igt@gem_eio@in-flight-1us:
    - shard-snb:          [FAIL][52] ([fdo#111946]) -> [PASS][53]
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-snb7/igt@gem_eio@in-flight-1us.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-snb4/igt@gem_eio@in-flight-1us.html

  * igt@gem_eio@in-flight-suspend:
    - shard-tglb:         [INCOMPLETE][54] ([fdo#111832] / [fdo#111850] / [fdo#112081]) -> [PASS][55]
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb1/igt@gem_eio@in-flight-suspend.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-tglb2/igt@gem_eio@in-flight-suspend.html

  * igt@gem_eio@unwedge-stress:
    - shard-snb:          [FAIL][56] ([fdo#109661]) -> [PASS][57]
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-snb1/igt@gem_eio@unwedge-stress.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-snb6/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_schedule@preempt-bsd:
    - shard-iclb:         [SKIP][58] ([fdo#112146]) -> [PASS][59] +1 similar issue
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb4/igt@gem_exec_schedule@preempt-bsd.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-iclb6/igt@gem_exec_schedule@preempt-bsd.html

  * igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
    - shard-iclb:         [TIMEOUT][60] ([fdo#112068 ]) -> [PASS][61]
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb8/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-iclb3/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html

  * igt@gem_userptr_blits@sync-unmap-after-close:
    - shard-hsw:          [DMESG-WARN][62] ([fdo#111870]) -> [PASS][63]
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-hsw1/igt@gem_userptr_blits@sync-unmap-after-close.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-hsw6/igt@gem_userptr_blits@sync-unmap-after-close.html

  * igt@gem_userptr_blits@sync-unmap-cycles:
    - shard-snb:          [DMESG-WARN][64] ([fdo#111870]) -> [PASS][65] +1 similar issue
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-snb7/igt@gem_userptr_blits@sync-unmap-cycles.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-snb2/igt@gem_userptr_blits@sync-unmap-cycles.html

  * igt@i915_pm_dc@dc5-dpms:
    - shard-iclb:         [FAIL][66] ([fdo#111795 ]) -> [PASS][67]
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb3/igt@i915_pm_dc@dc5-dpms.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-iclb5/igt@i915_pm_dc@dc5-dpms.html

  * igt@i915_selftest@live_hangcheck:
    - shard-hsw:          [DMESG-FAIL][68] ([fdo#111991]) -> [PASS][69]
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-hsw5/igt@i915_selftest@live_hangcheck.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-hsw5/igt@i915_selftest@live_hangcheck.html

  * igt@kms_cursor_crc@pipe-b-cursor-128x42-random:
    - shard-apl:          [FAIL][70] ([fdo#103232]) -> [PASS][71]
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-apl7/igt@kms_cursor_crc@pipe-b-cursor-128x42-random.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-apl4/igt@kms_cursor_crc@pipe-b-cursor-128x42-random.html
    - shard-kbl:          [FAIL][72] ([fdo#103232]) -> [PASS][73]
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-kbl6/igt@kms_cursor_crc@pipe-b-cursor-128x42-random.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-kbl1/igt@kms_cursor_crc@pipe-b-cursor-128x42-random.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-tglb:         [INCOMPLETE][74] ([fdo#111747] / [fdo#111832] / [fdo#111850]) -> [PASS][75]
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb5/igt@kms_fbcon_fbt@fbc-suspend.html
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-tglb9/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_flip@flip-vs-suspend-interruptible:
    - shard-apl:          [DMESG-WARN][76] ([fdo#108566]) -> [PASS][77] +1 similar issue
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible.html
    - shard-kbl:          [DMESG-WARN][78] ([fdo#108566]) -> [PASS][79] +2 similar issues
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt:
    - shard-iclb:         [FAIL][80] ([fdo#103167]) -> [PASS][81] +4 similar issues
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt.html
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-shrfb-scaledprimary:
    - shard-tglb:         [FAIL][82] ([fdo#103167]) -> [PASS][83] +2 similar issues
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb9/igt@kms_frontbuffer_tracking@fbcpsr-shrfb-scaledprimary.html
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-shrfb-scaledprimary.html

  * igt@kms_psr@psr2_sprite_render:
    - shard-iclb:         [SKIP][84] ([fdo#109441]) -> [PASS][85] +1 similar issue
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb6/igt@kms_psr@psr2_sprite_render.html
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-iclb2/igt@kms_psr@psr2_sprite_render.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-tglb:         [INCOMPLETE][86] ([fdo#111832] / [fdo#111850]) -> [PASS][87] +1 similar issue
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-tglb8/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend:
    - shard-tglb:         [INCOMPLETE][88] ([fdo#111850]) -> [PASS][89]
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb7/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-tglb5/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html

  
#### Warnings ####

  * igt@gem_ctx_isolation@vcs1-nonpriv-switch:
    - shard-iclb:         [SKIP][90] ([fdo#109276] / [fdo#112080]) -> [FAIL][91] ([fdo#111329])
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb5/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html

  * igt@kms_atomic_transition@6x-modeset-transitions-nonblocking-fencing:
    - shard-tglb:         [SKIP][92] ([fdo#112016 ] / [fdo#112021 ]) -> [SKIP][93] ([fdo#112021 ])
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb1/igt@kms_atomic_transition@6x-modeset-transitions-nonblocking-fencing.html
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/shard-tglb9/igt@kms_atomic_transition@6x-modeset-transitions-nonblocking-fencing.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
  [fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038
  [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
  [fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
  [fdo#111606]: https://bugs.freedesktop.org/show_bug.cgi?id=111606
  [fdo#111647]: https://bugs.freedesktop.org/show_bug.cgi?id=111647
  [fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677
  [fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
  [fdo#111795 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111795 
  [fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
  [fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
  [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
  [fdo#111946]: https://bugs.freedesktop.org/show_bug.cgi?id=111946
  [fdo#111991]: https://bugs.freedesktop.org/show_bug.cgi?id=111991
  [fdo#112016 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112016 
  [fdo#112021 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112021 
  [fdo#112068 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112068 
  [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
  [fdo#112081]: https://bugs.freedesktop.org/show_bug.cgi?id=112081
  [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146


Participating hosts (11 -> 8)
------------------------------

  Missing    (3): pig-skl-6260u pig-glk-j5005 pig-hsw-4770r 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5288 -> IGTPW_3717
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_7357: 315d68345bfe8da7b034123352106c6edbcc380d @ git://anongit.freedeskto

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3717/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH 2/2] i915/i915_fb_tiling: Check if device supports tiling

[Brian Welty]

On 11/15/2019 3:16 PM, Vanshidhar Konda wrote:
> Skip this test if the platform does not support setting tiling for frame
> buffer object.
> 

Looking over some other tests, I came across a libdrm function that uses SET_TILING,
drm_intel_bo_alloc_tiled().

Any chance you can expand your patch series to fix tests using that function as well?
It is not quite as easy, I believe you maybe shouldn't disable them all but should
maybe conditionally use drm_intel_bo_alloc_tiled() or drm_intel_bo_alloc().
Not sure.

Thanks,
-Brian


> Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
>  tests/i915/i915_fb_tiling.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/i915/i915_fb_tiling.c b/tests/i915/i915_fb_tiling.c
> index 7d5c3f1f..4ec84962 100644
> --- a/tests/i915/i915_fb_tiling.c
> +++ b/tests/i915/i915_fb_tiling.c
> @@ -32,6 +32,8 @@ igt_simple_main
>  	struct igt_fb fb;
>  	int ret;
>  
> +	igt_require(gem_has_legacy_hw_tiling(drm_fd));
> +
>  	igt_create_fb(drm_fd, 512, 512, DRM_FORMAT_XRGB8888,
>  		      LOCAL_I915_FORMAT_MOD_X_TILED, &fb);
>  
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH 2/2] i915/i915_fb_tiling: Check if device supports tiling

[Vanshidhar Konda]

On Tue, Nov 19, 2019 at 02:23:41PM -0800, Brian Welty wrote:
>
>
>On 11/15/2019 3:16 PM, Vanshidhar Konda wrote:
>> Skip this test if the platform does not support setting tiling for frame
>> buffer object.
>>
>
>Looking over some other tests, I came across a libdrm function that uses SET_TILING,
>drm_intel_bo_alloc_tiled().
>
>Any chance you can expand your patch series to fix tests using that function as well?

The change to igt doesn't apply directly to libdrm. libdrm change will
have to come seperately.

>It is not quite as easy, I believe you maybe shouldn't disable them all but should
>maybe conditionally use drm_intel_bo_alloc_tiled() or drm_intel_bo_alloc().
>Not sure.

I was asked to put FIXME in the patches where I'm skipping execution of these tests.
I was thinking that since the GET/SET_TILING feature doesn't exist anymore the only
solution was to just remove these tests. I'm going to start a discussion on this to
finalize if the change is just a FIXME or if that is the final change.

Once we close on that discussion, I think we can fix on whether these methods
should fail with an error and the tests calling these need to be fixed.
For now things still seem to be in a limbo.

Vanshi

>
>Thanks,
>-Brian
>
>
>> Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
>> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>> ---
>>  tests/i915/i915_fb_tiling.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/tests/i915/i915_fb_tiling.c b/tests/i915/i915_fb_tiling.c
>> index 7d5c3f1f..4ec84962 100644
>> --- a/tests/i915/i915_fb_tiling.c
>> +++ b/tests/i915/i915_fb_tiling.c
>> @@ -32,6 +32,8 @@ igt_simple_main
>>  	struct igt_fb fb;
>>  	int ret;
>>
>> +	igt_require(gem_has_legacy_hw_tiling(drm_fd));
>> +
>>  	igt_create_fb(drm_fd, 512, 512, DRM_FORMAT_XRGB8888,
>>  		      LOCAL_I915_FORMAT_MOD_X_TILED, &fb);
>>
>>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH 2/2] i915/i915_fb_tiling: Check if device supports tiling

[Brian Welty]

On 11/19/2019 2:33 PM, Vanshidhar Konda wrote:
> On Tue, Nov 19, 2019 at 02:23:41PM -0800, Brian Welty wrote:
>>
>>
>> On 11/15/2019 3:16 PM, Vanshidhar Konda wrote:
>>> Skip this test if the platform does not support setting tiling for frame
>>> buffer object.
>>>
>>
>> Looking over some other tests, I came across a libdrm function that uses SET_TILING,
>> drm_intel_bo_alloc_tiled().
>>
>> Any chance you can expand your patch series to fix tests using that function as well?
> 
> The change to igt doesn't apply directly to libdrm. libdrm change will
> have to come seperately.

Yes, libdrm changes would be separate.
I only meant that until that happens, the igts could be fixed to use igt_require
before the offending libdrm function calls.  Just as you have done here....
so just as you have identified not to call igt_create_fb(), there are few libdrm
functions that should not be used by igts either (at least not unless 'legacy tiling'
is supported).

> 
>> It is not quite as easy, I believe you maybe shouldn't disable them all but should
>> maybe conditionally use drm_intel_bo_alloc_tiled() or drm_intel_bo_alloc().
>> Not sure.
> 
> I was asked to put FIXME in the patches where I'm skipping execution of these tests.
> I was thinking that since the GET/SET_TILING feature doesn't exist anymore the only
> solution was to just remove these tests. I'm going to start a discussion on this to
> finalize if the change is just a FIXME or if that is the final change.
> 
> Once we close on that discussion, I think we can fix on whether these methods
> should fail with an error and the tests calling these need to be fixed.
> For now things still seem to be in a limbo.
> 
> Vanshi
> 
>>
>> Thanks,
>> -Brian
>>
>>
>>> Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
>>> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>>> ---
>>>  tests/i915/i915_fb_tiling.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/tests/i915/i915_fb_tiling.c b/tests/i915/i915_fb_tiling.c
>>> index 7d5c3f1f..4ec84962 100644
>>> --- a/tests/i915/i915_fb_tiling.c
>>> +++ b/tests/i915/i915_fb_tiling.c
>>> @@ -32,6 +32,8 @@ igt_simple_main
>>>      struct igt_fb fb;
>>>      int ret;
>>>
>>> +    igt_require(gem_has_legacy_hw_tiling(drm_fd));
>>> +
>>>      igt_create_fb(drm_fd, 512, 512, DRM_FORMAT_XRGB8888,
>>>                LOCAL_I915_FORMAT_MOD_X_TILED, &fb);
>>>
>>>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH 2/2] i915/i915_fb_tiling: Check if device supports tiling

[Vanshidhar Konda]

On Tue, Nov 19, 2019 at 02:44:28PM -0800, Brian Welty wrote:
>
>
>On 11/19/2019 2:33 PM, Vanshidhar Konda wrote:
>> On Tue, Nov 19, 2019 at 02:23:41PM -0800, Brian Welty wrote:
>>>
>>>
>>> On 11/15/2019 3:16 PM, Vanshidhar Konda wrote:
>>>> Skip this test if the platform does not support setting tiling for frame
>>>> buffer object.
>>>>
>>>
>>> Looking over some other tests, I came across a libdrm function that uses SET_TILING,
>>> drm_intel_bo_alloc_tiled().
>>>
>>> Any chance you can expand your patch series to fix tests using that function as well?
>>
>> The change to igt doesn't apply directly to libdrm. libdrm change will
>> have to come seperately.
>
>Yes, libdrm changes would be separate.
>I only meant that until that happens, the igts could be fixed to use igt_require
>before the offending libdrm function calls.  Just as you have done here....
>so just as you have identified not to call igt_create_fb(), there are few libdrm
>functions that should not be used by igts either (at least not unless 'legacy tiling'
>is supported).

Oh yeah. I think I should do that. I'm trying to find the easiest way
to gather a list of all the tests that fail with this signature and
disable/skip them all with the same patch.

I'm currently working on hacking the BAT tests so that we can call
VLK-4351 finished. We probably need another JIRA item to work on all
the other tests that need to be fixed/skipped.

Vanshi

>
>>
>>> It is not quite as easy, I believe you maybe shouldn't disable them all but should
>>> maybe conditionally use drm_intel_bo_alloc_tiled() or drm_intel_bo_alloc().
>>> Not sure.
>>
>> I was asked to put FIXME in the patches where I'm skipping execution of these tests.
>> I was thinking that since the GET/SET_TILING feature doesn't exist anymore the only
>> solution was to just remove these tests. I'm going to start a discussion on this to
>> finalize if the change is just a FIXME or if that is the final change.
>>
>> Once we close on that discussion, I think we can fix on whether these methods
>> should fail with an error and the tests calling these need to be fixed.
>> For now things still seem to be in a limbo.
>>
>> Vanshi
>>
>>>
>>> Thanks,
>>> -Brian
>>>
>>>
>>>> Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
>>>> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>>>> ---
>>>>  tests/i915/i915_fb_tiling.c | 2 ++
>>>>  1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/tests/i915/i915_fb_tiling.c b/tests/i915/i915_fb_tiling.c
>>>> index 7d5c3f1f..4ec84962 100644
>>>> --- a/tests/i915/i915_fb_tiling.c
>>>> +++ b/tests/i915/i915_fb_tiling.c
>>>> @@ -32,6 +32,8 @@ igt_simple_main
>>>>      struct igt_fb fb;
>>>>      int ret;
>>>>
>>>> +    igt_require(gem_has_legacy_hw_tiling(drm_fd));
>>>> +
>>>>      igt_create_fb(drm_fd, 512, 512, DRM_FORMAT_XRGB8888,
>>>>                LOCAL_I915_FORMAT_MOD_X_TILED, &fb);
>>>>
>>>>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev