[igt-dev] [PATCH v2 0/1] Skip 2x-cursor-vs-flip subtests for gen > 9

[igt-dev] [PATCH v2 0/1] Skip 2x-cursor-vs-flip subtests for gen > 9

[Neel Desai]

Skip the following for gen > 9

1.) tests/kms_cursor_legacy@2x-cursor-vs-flip-atomic
2.) tests/kms_cursor_legacy@2x-cursor-vs-flip-legacy
3.) tests/kms_cursor_legacy@2x-long-cursor-vs-flip-atomic
4.) tests/kms_cursor_legacy@2x-long-cursor-vs-flip-legacy

Due to DDB allocation changes, we have to add all the planes to the
drm_atomic_state post gen 9. When the watermarks are computed by the
kernel, the cursor plane is added to the drm_atomic_state which
introduces a dependency on hw_done object when the kernel processes
DRM_IOCTL_MODE_ATOMIC and DRM_IOCTL_MODE_CURSOR in parallel. There is no
race-free way to handle this corner case. These subtests made sense for
older generations but not anymore. Hence, skipping these sub-tests post
gen 9.

Neel Desai (1):
  tests/kms_cursor_legacy: Skip 2x-cursor-vs-flip subtests for gen > 9

 tests/kms_cursor_legacy.c | 3 +++
 1 file changed, 3 insertions(+)

--
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH v2 1/1] tests/kms_cursor_legacy: Skip 2x-cursor-vs-flip subtests for gen > 9

[Neel Desai]

Due to DDB allocation changes, we have to add all the planes to the
drm_atomic_state post gen 9. When the watermarks are computed by the
kernel, the cursor plane is added to the drm_atomic_state which
introduces a dependency on hw_done object when the kernel processes
DRM_IOCTL_MODE_ATOMIC and DRM_IOCTL_MODE_CURSOR in parallel. There is no
race-free way to handle this corner case. These subtests made sense for
older generations but not anymore. Hence, skipping these sub-tests post
gen 9.

Reference: https://bugs.freedesktop.org/show_bug.cgi?id=109079
Signed-off-by: Neel Desai <neel.desai@intel.com>
cc: Sudeep Dutt <sudeep.dutt@intel.com>
cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_cursor_legacy.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
index d6987eea..645c0b93 100644
--- a/tests/kms_cursor_legacy.c
+++ b/tests/kms_cursor_legacy.c
@@ -1115,6 +1115,7 @@ static void cursor_vs_flip(igt_display_t *display, enum flip_test mode, int nloo

 static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool atomic)
 {
+	const int gen = intel_gen(intel_get_drm_devid(display->drm_fd));
 	struct drm_mode_cursor arg[2][2];
 	struct drm_event_vblank vbl;
 	struct igt_fb fb_info[2], cursor_fb;
@@ -1126,6 +1127,8 @@ static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool
 	};
 	igt_output_t *outputs[2];

+	igt_require(gen <= 9);
+
 	shared = mmap(NULL, PAGE_SIZE, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
 	igt_assert(shared != MAP_FAILED);

--
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH v2 1/1] tests/kms_cursor_legacy: Skip 2x-cursor-vs-flip subtests for gen > 9

[Ville Syrjälä]

On Tue, Mar 12, 2019 at 09:12:44AM -0700, Neel Desai wrote:
> Due to DDB allocation changes, we have to add all the planes to the
> drm_atomic_state post gen 9.

As we discussed on irc that is not true. The cursor has a fixed
allocation and thus never needs to be added to the state on account
of ddb allocation changing (except for full modesets). So the real
reason for the cursor being added to the state is something else.
I think the answer has something more to do with the selected
max watermark level.

Also I'm not entirely convinced that the fixed allocation scheme
is working quite right currently. We never seem to check that we
actually have enough ddb space for the selected max watermark
level for the cursor. We should add such a check, and we also may
have to change how we calculate the size of the fixed cursor ddb
allocation to make sure the cursor isn't needlessly limiting the
max watermark level we can use.

> When the watermarks are computed by the
> kernel, the cursor plane is added to the drm_atomic_state which
> introduces a dependency on hw_done object when the kernel processes
> DRM_IOCTL_MODE_ATOMIC and DRM_IOCTL_MODE_CURSOR in parallel. There is no
> race-free way to handle this corner case. These subtests made sense for
> older generations but not anymore. Hence, skipping these sub-tests post
> gen 9.
> 
> Reference: https://bugs.freedesktop.org/show_bug.cgi?id=109079
> Signed-off-by: Neel Desai <neel.desai@intel.com>
> cc: Sudeep Dutt <sudeep.dutt@intel.com>
> cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  tests/kms_cursor_legacy.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> index d6987eea..645c0b93 100644
> --- a/tests/kms_cursor_legacy.c
> +++ b/tests/kms_cursor_legacy.c
> @@ -1115,6 +1115,7 @@ static void cursor_vs_flip(igt_display_t *display, enum flip_test mode, int nloo
> 
>  static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool atomic)
>  {
> +	const int gen = intel_gen(intel_get_drm_devid(display->drm_fd));
>  	struct drm_mode_cursor arg[2][2];
>  	struct drm_event_vblank vbl;
>  	struct igt_fb fb_info[2], cursor_fb;
> @@ -1126,6 +1127,8 @@ static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool
>  	};
>  	igt_output_t *outputs[2];
> 
> +	igt_require(gen <= 9);
> +
>  	shared = mmap(NULL, PAGE_SIZE, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
>  	igt_assert(shared != MAP_FAILED);
> 
> --
> 2.17.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH v2 1/1] tests/kms_cursor_legacy: Skip 2x-cursor-vs-flip subtests for gen > 9

[Desai, Neel]

According to Maarten, it does change during modeset of the other pipe. The ddb allocation might not change in size, but during modeset of the other pipe, the position of the cursor DDB may change and CUR_BUF_CFG() will have to be called..

-----Original Message-----
From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com] 
Sent: Tuesday, March 12, 2019 9:45 AM
To: Desai, Neel <neel.desai@intel.com>
Cc: Dutt, Sudeep <sudeep.dutt@intel.com>; maarten.lankhorst@linux.intel.com; igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH v2 1/1] tests/kms_cursor_legacy: Skip 2x-cursor-vs-flip subtests for gen > 9

On Tue, Mar 12, 2019 at 09:12:44AM -0700, Neel Desai wrote:
> Due to DDB allocation changes, we have to add all the planes to the 
> drm_atomic_state post gen 9.

As we discussed on irc that is not true. The cursor has a fixed allocation and thus never needs to be added to the state on account of ddb allocation changing (except for full modesets). So the real reason for the cursor being added to the state is something else.
I think the answer has something more to do with the selected max watermark level.

Also I'm not entirely convinced that the fixed allocation scheme is working quite right currently. We never seem to check that we actually have enough ddb space for the selected max watermark level for the cursor. We should add such a check, and we also may have to change how we calculate the size of the fixed cursor ddb allocation to make sure the cursor isn't needlessly limiting the max watermark level we can use.

> When the watermarks are computed by the kernel, the cursor plane is 
> added to the drm_atomic_state which introduces a dependency on hw_done 
> object when the kernel processes DRM_IOCTL_MODE_ATOMIC and 
> DRM_IOCTL_MODE_CURSOR in parallel. There is no race-free way to handle 
> this corner case. These subtests made sense for older generations but 
> not anymore. Hence, skipping these sub-tests post gen 9.
> 
> Reference: https://bugs.freedesktop.org/show_bug.cgi?id=109079
> Signed-off-by: Neel Desai <neel.desai@intel.com>
> cc: Sudeep Dutt <sudeep.dutt@intel.com>
> cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  tests/kms_cursor_legacy.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c 
> index d6987eea..645c0b93 100644
> --- a/tests/kms_cursor_legacy.c
> +++ b/tests/kms_cursor_legacy.c
> @@ -1115,6 +1115,7 @@ static void cursor_vs_flip(igt_display_t 
> *display, enum flip_test mode, int nloo
> 
>  static void two_screens_cursor_vs_flip(igt_display_t *display, int 
> nloops, bool atomic)  {
> +	const int gen = intel_gen(intel_get_drm_devid(display->drm_fd));
>  	struct drm_mode_cursor arg[2][2];
>  	struct drm_event_vblank vbl;
>  	struct igt_fb fb_info[2], cursor_fb; @@ -1126,6 +1127,8 @@ static 
> void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool
>  	};
>  	igt_output_t *outputs[2];
> 
> +	igt_require(gen <= 9);
> +
>  	shared = mmap(NULL, PAGE_SIZE, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
>  	igt_assert(shared != MAP_FAILED);
> 
> --
> 2.17.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH v2 1/1] tests/kms_cursor_legacy: Skip 2x-cursor-vs-flip subtests for gen > 9

[Ville Syrjälä]

On Tue, Mar 12, 2019 at 04:46:56PM +0000, Desai, Neel wrote:
> According to Maarten, it does change during modeset of the other pipe. The ddb allocation might not change in size, but during modeset of the other pipe, the position of the cursor DDB may change and CUR_BUF_CFG() will have to be called..

Sure, but we're just testing flips vs. cursor. There should be no
modesets apart from the initial setup.

> 
> -----Original Message-----
> From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com] 
> Sent: Tuesday, March 12, 2019 9:45 AM
> To: Desai, Neel <neel.desai@intel.com>
> Cc: Dutt, Sudeep <sudeep.dutt@intel.com>; maarten.lankhorst@linux.intel.com; igt-dev@lists.freedesktop.org
> Subject: Re: [igt-dev] [PATCH v2 1/1] tests/kms_cursor_legacy: Skip 2x-cursor-vs-flip subtests for gen > 9
> 
> On Tue, Mar 12, 2019 at 09:12:44AM -0700, Neel Desai wrote:
> > Due to DDB allocation changes, we have to add all the planes to the 
> > drm_atomic_state post gen 9.
> 
> As we discussed on irc that is not true. The cursor has a fixed allocation and thus never needs to be added to the state on account of ddb allocation changing (except for full modesets). So the real reason for the cursor being added to the state is something else.
> I think the answer has something more to do with the selected max watermark level.
> 
> Also I'm not entirely convinced that the fixed allocation scheme is working quite right currently. We never seem to check that we actually have enough ddb space for the selected max watermark level for the cursor. We should add such a check, and we also may have to change how we calculate the size of the fixed cursor ddb allocation to make sure the cursor isn't needlessly limiting the max watermark level we can use.
> 
> > When the watermarks are computed by the kernel, the cursor plane is 
> > added to the drm_atomic_state which introduces a dependency on hw_done 
> > object when the kernel processes DRM_IOCTL_MODE_ATOMIC and 
> > DRM_IOCTL_MODE_CURSOR in parallel. There is no race-free way to handle 
> > this corner case. These subtests made sense for older generations but 
> > not anymore. Hence, skipping these sub-tests post gen 9.
> > 
> > Reference: https://bugs.freedesktop.org/show_bug.cgi?id=109079
> > Signed-off-by: Neel Desai <neel.desai@intel.com>
> > cc: Sudeep Dutt <sudeep.dutt@intel.com>
> > cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > ---
> >  tests/kms_cursor_legacy.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c 
> > index d6987eea..645c0b93 100644
> > --- a/tests/kms_cursor_legacy.c
> > +++ b/tests/kms_cursor_legacy.c
> > @@ -1115,6 +1115,7 @@ static void cursor_vs_flip(igt_display_t 
> > *display, enum flip_test mode, int nloo
> > 
> >  static void two_screens_cursor_vs_flip(igt_display_t *display, int 
> > nloops, bool atomic)  {
> > +	const int gen = intel_gen(intel_get_drm_devid(display->drm_fd));
> >  	struct drm_mode_cursor arg[2][2];
> >  	struct drm_event_vblank vbl;
> >  	struct igt_fb fb_info[2], cursor_fb; @@ -1126,6 +1127,8 @@ static 
> > void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool
> >  	};
> >  	igt_output_t *outputs[2];
> > 
> > +	igt_require(gen <= 9);
> > +
> >  	shared = mmap(NULL, PAGE_SIZE, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> >  	igt_assert(shared != MAP_FAILED);
> > 
> > --
> > 2.17.1
> > 
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> 
> --
> Ville Syrjälä
> Intel

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH v2 1/1] tests/kms_cursor_legacy: Skip 2x-cursor-vs-flip subtests for gen > 9

[Neel Desai]

On Tue, Mar 12, 2019 at 07:06:22PM +0200, Ville Syrjälä wrote:
>On Tue, Mar 12, 2019 at 04:46:56PM +0000, Desai, Neel wrote:
>> According to Maarten, it does change during modeset of the other pipe. The ddb allocation might not change in size, but during modeset of the other pipe, the position of the cursor DDB may change and CUR_BUF_CFG() will have to be called..
>
>Sure, but we're just testing flips vs. cursor. There should be no
>modesets apart from the initial setup.
>
>>
>> -----Original Message-----
>> From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
>> Sent: Tuesday, March 12, 2019 9:45 AM
>> To: Desai, Neel <neel.desai@intel.com>
>> Cc: Dutt, Sudeep <sudeep.dutt@intel.com>; maarten.lankhorst@linux.intel.com; igt-dev@lists.freedesktop.org
>> Subject: Re: [igt-dev] [PATCH v2 1/1] tests/kms_cursor_legacy: Skip 2x-cursor-vs-flip subtests for gen > 9
>>
>> On Tue, Mar 12, 2019 at 09:12:44AM -0700, Neel Desai wrote:
>> > Due to DDB allocation changes, we have to add all the planes to the
>> > drm_atomic_state post gen 9.
>>
>> As we discussed on irc that is not true. The cursor has a fixed allocation and thus never needs to be added to the state on account of ddb allocation changing (except for full modesets). So the real reason for the cursor being added to the state is something else.
>> I think the answer has something more to do with the selected max watermark level.
>>
>> Also I'm not entirely convinced that the fixed allocation scheme is working quite right currently. We never seem to check that we actually have enough ddb space for the selected max watermark level for the cursor. We should add such a check, and we also may have to change how we calculate the size of the fixed cursor ddb allocation to make sure the cursor isn't needlessly limiting the max watermark level we can use.
>>
>> > When the watermarks are computed by the kernel, the cursor plane is
>> > added to the drm_atomic_state which introduces a dependency on hw_done
>> > object when the kernel processes DRM_IOCTL_MODE_ATOMIC and
>> > DRM_IOCTL_MODE_CURSOR in parallel. There is no race-free way to handle
>> > this corner case. These subtests made sense for older generations but
>> > not anymore. Hence, skipping these sub-tests post gen 9.
>> >
>> > Reference: https://bugs.freedesktop.org/show_bug.cgi?id=109079
>> > Signed-off-by: Neel Desai <neel.desai@intel.com>
>> > cc: Sudeep Dutt <sudeep.dutt@intel.com>
>> > cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> > ---
>> >  tests/kms_cursor_legacy.c | 3 +++
>> >  1 file changed, 3 insertions(+)
>> >
>> > diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
>> > index d6987eea..645c0b93 100644
>> > --- a/tests/kms_cursor_legacy.c
>> > +++ b/tests/kms_cursor_legacy.c
>> > @@ -1115,6 +1115,7 @@ static void cursor_vs_flip(igt_display_t
>> > *display, enum flip_test mode, int nloo
>> >
>> >  static void two_screens_cursor_vs_flip(igt_display_t *display, int
>> > nloops, bool atomic)  {
>> > +	const int gen = intel_gen(intel_get_drm_devid(display->drm_fd));
>> >  	struct drm_mode_cursor arg[2][2];
>> >  	struct drm_event_vblank vbl;
>> >  	struct igt_fb fb_info[2], cursor_fb; @@ -1126,6 +1127,8 @@ static
>> > void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool
>> >  	};
>> >  	igt_output_t *outputs[2];
>> >
>> > +	igt_require(gen <= 9);
>> > +
>> >  	shared = mmap(NULL, PAGE_SIZE, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
>> >  	igt_assert(shared != MAP_FAILED);
>> >
>> > --
>> > 2.17.1
>> >
>> > _______________________________________________
>> > igt-dev mailing list
>> > igt-dev@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
>>
>> --
>> Ville Syrjälä
>> Intel
>
>-- 
>Ville Syrjälä
>Intel

>Sure, but we're just testing flips vs. cursor. There should be no
>modesets apart from the initial setup
We are testing cursor vs flips on two screens
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH v2 1/1] tests/kms_cursor_legacy: Skip 2x-cursor-vs-flip subtests for gen > 9

[Ville Syrjälä]

On Tue, Mar 12, 2019 at 06:44:41PM +0200, Ville Syrjälä wrote:
> On Tue, Mar 12, 2019 at 09:12:44AM -0700, Neel Desai wrote:
> > Due to DDB allocation changes, we have to add all the planes to the
> > drm_atomic_state post gen 9.
> 
> As we discussed on irc that is not true. The cursor has a fixed
> allocation and thus never needs to be added to the state on account
> of ddb allocation changing (except for full modesets). So the real
> reason for the cursor being added to the state is something else.
> I think the answer has something more to do with the selected
> max watermark level.
> 
> Also I'm not entirely convinced that the fixed allocation scheme
> is working quite right currently. We never seem to check that we
> actually have enough ddb space for the selected max watermark
> level for the cursor. We should add such a check, and we also may
> have to change how we calculate the size of the fixed cursor ddb
> allocation to make sure the cursor isn't needlessly limiting the
> max watermark level we can use.

Yeah, turns out the currect code was totally broke. I just fired
off some patches to fix it. 

> 
> > When the watermarks are computed by the
> > kernel, the cursor plane is added to the drm_atomic_state which
> > introduces a dependency on hw_done object when the kernel processes
> > DRM_IOCTL_MODE_ATOMIC and DRM_IOCTL_MODE_CURSOR in parallel. There is no
> > race-free way to handle this corner case. These subtests made sense for
> > older generations but not anymore. Hence, skipping these sub-tests post
> > gen 9.
> > 
> > Reference: https://bugs.freedesktop.org/show_bug.cgi?id=109079
> > Signed-off-by: Neel Desai <neel.desai@intel.com>
> > cc: Sudeep Dutt <sudeep.dutt@intel.com>
> > cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > ---
> >  tests/kms_cursor_legacy.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> > index d6987eea..645c0b93 100644
> > --- a/tests/kms_cursor_legacy.c
> > +++ b/tests/kms_cursor_legacy.c
> > @@ -1115,6 +1115,7 @@ static void cursor_vs_flip(igt_display_t *display, enum flip_test mode, int nloo
> > 
> >  static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool atomic)
> >  {
> > +	const int gen = intel_gen(intel_get_drm_devid(display->drm_fd));
> >  	struct drm_mode_cursor arg[2][2];
> >  	struct drm_event_vblank vbl;
> >  	struct igt_fb fb_info[2], cursor_fb;
> > @@ -1126,6 +1127,8 @@ static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool
> >  	};
> >  	igt_output_t *outputs[2];
> > 
> > +	igt_require(gen <= 9);
> > +
> >  	shared = mmap(NULL, PAGE_SIZE, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> >  	igt_assert(shared != MAP_FAILED);
> > 
> > --
> > 2.17.1
> > 
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> 
> -- 
> Ville Syrjälä
> Intel

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH v2 0/1] Skip 2x-cursor-vs-flip subtests for gen > 9

[Chris Wilson]

Quoting Neel Desai (2019-03-12 16:12:43)
> Skip the following for gen > 9
> 
> 1.) tests/kms_cursor_legacy@2x-cursor-vs-flip-atomic
> 2.) tests/kms_cursor_legacy@2x-cursor-vs-flip-legacy
> 3.) tests/kms_cursor_legacy@2x-long-cursor-vs-flip-atomic
> 4.) tests/kms_cursor_legacy@2x-long-cursor-vs-flip-legacy
> 
> Due to DDB allocation changes, we have to add all the planes to the
> drm_atomic_state post gen 9. When the watermarks are computed by the
> kernel, the cursor plane is added to the drm_atomic_state which
> introduces a dependency on hw_done object when the kernel processes
> DRM_IOCTL_MODE_ATOMIC and DRM_IOCTL_MODE_CURSOR in parallel. There is no
> race-free way to handle this corner case. These subtests made sense for
> older generations but not anymore. Hence, skipping these sub-tests post
> gen 9.

Or fail. Mark it as expected; come back when problem is solved or HW has
moved on.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH v2 0/1] Skip 2x-cursor-vs-flip subtests for gen > 9

[Chris Wilson]

Quoting Chris Wilson (2019-03-12 16:21:55)
> Quoting Neel Desai (2019-03-12 16:12:43)
> > Skip the following for gen > 9
> > 
> > 1.) tests/kms_cursor_legacy@2x-cursor-vs-flip-atomic
> > 2.) tests/kms_cursor_legacy@2x-cursor-vs-flip-legacy
> > 3.) tests/kms_cursor_legacy@2x-long-cursor-vs-flip-atomic
> > 4.) tests/kms_cursor_legacy@2x-long-cursor-vs-flip-legacy
> > 
> > Due to DDB allocation changes, we have to add all the planes to the
> > drm_atomic_state post gen 9. When the watermarks are computed by the
> > kernel, the cursor plane is added to the drm_atomic_state which
> > introduces a dependency on hw_done object when the kernel processes
> > DRM_IOCTL_MODE_ATOMIC and DRM_IOCTL_MODE_CURSOR in parallel. There is no
> > race-free way to handle this corner case. These subtests made sense for
> > older generations but not anymore. Hence, skipping these sub-tests post
> > gen 9.
> 
> Or fail. Mark it as expected; come back when problem is solved or HW has
> moved on.

To be a little more verbose, the user expectations haven't changed, and
so the failure is a valid indication that the UX is subpar.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for Skip 2x-cursor-vs-flip subtests for gen > 9

[Patchwork]

== Series Details ==

Series: Skip 2x-cursor-vs-flip subtests for gen > 9
URL   : https://patchwork.freedesktop.org/series/57887/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5737 -> IGTPW_2598
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/57887/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2598 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_cs_nop@fork-gfx0:
    - fi-icl-u2:          NOTRUN -> SKIP [fdo#109315] +17

  * igt@gem_ctx_create@basic-files:
    - fi-gdg-551:         NOTRUN -> SKIP [fdo#109271] +106

  * igt@gem_exec_basic@gtt-bsd2:
    - fi-byt-clapper:     NOTRUN -> SKIP [fdo#109271] +57

  * igt@gem_exec_basic@readonly-bsd1:
    - fi-snb-2520m:       NOTRUN -> SKIP [fdo#109271] +57
    - fi-icl-u2:          NOTRUN -> SKIP [fdo#109276] +7

  * igt@gem_exec_parse@basic-allowed:
    - fi-icl-u2:          NOTRUN -> SKIP [fdo#109289] +1

  * igt@i915_selftest@live_contexts:
    - fi-icl-u2:          NOTRUN -> DMESG-FAIL [fdo#108569]

  * igt@kms_addfb_basic@addfb25-y-tiled-small:
    - fi-byt-n2820:       NOTRUN -> SKIP [fdo#109271] +56

  * igt@kms_busy@basic-flip-c:
    - fi-blb-e6850:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-byt-clapper:     NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-gdg-551:         NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-snb-2520m:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-byt-n2820:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_chamelium@dp-edid-read:
    - fi-icl-u2:          NOTRUN -> SKIP [fdo#109316] +2

  * igt@kms_chamelium@hdmi-edid-read:
    - fi-hsw-peppy:       NOTRUN -> SKIP [fdo#109271] +46

  * igt@kms_chamelium@vga-hpd-fast:
    - fi-icl-u2:          NOTRUN -> SKIP [fdo#109309] +1

  * igt@kms_force_connector_basic@prune-stale-modes:
    - fi-icl-u2:          NOTRUN -> SKIP [fdo#109285] +3

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u3:          PASS -> FAIL [fdo#103167]
    - fi-hsw-peppy:       NOTRUN -> DMESG-FAIL [fdo#102614] / [fdo#107814]
    - fi-icl-u2:          NOTRUN -> FAIL [fdo#103167]
    - fi-byt-clapper:     NOTRUN -> FAIL [fdo#103167]

  * igt@kms_pipe_crc_basic@hang-read-crc-pipe-c:
    - fi-blb-e6850:       NOTRUN -> SKIP [fdo#109271] +48

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
    - fi-byt-clapper:     NOTRUN -> FAIL [fdo#103191] / [fdo#107362]

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-blb-e6850:       INCOMPLETE [fdo#107718] -> PASS

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#107814]: https://bugs.freedesktop.org/show_bug.cgi?id=107814
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
  [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#109316]: https://bugs.freedesktop.org/show_bug.cgi?id=109316
  [fdo#110028]: https://bugs.freedesktop.org/show_bug.cgi?id=110028


Participating hosts (41 -> 43)
------------------------------

  Additional (7): fi-hsw-peppy fi-icl-u2 fi-snb-2520m fi-gdg-551 fi-icl-y fi-byt-n2820 fi-byt-clapper 
  Missing    (5): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-ctg-p8600 fi-bdw-samus 


Build changes
-------------

    * IGT: IGT_4883 -> IGTPW_2598

  CI_DRM_5737: d5bb7d77aa77996702426496078a597f30bead58 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2598: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2598/
  IGT_4883: b25e06d6ddf2e42044cd9c93b613cbc7339a8c33 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2598/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for Skip 2x-cursor-vs-flip subtests for gen > 9

[Patchwork]

== Series Details ==

Series: Skip 2x-cursor-vs-flip subtests for gen > 9
URL   : https://patchwork.freedesktop.org/series/57887/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5737_full -> IGTPW_2598_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_2598_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2598_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/57887/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_2598_full:

### IGT changes ###

#### Possible regressions ####

  * igt@runner@aborted:
    - shard-apl:          NOTRUN -> FAIL

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * {igt@kms_plane@pixel-format-pipe-a-planes}:
    - shard-apl:          NOTRUN -> FAIL

  
Known issues
------------

  Here are the changes found in IGTPW_2598_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_param@invalid-param-set:
    - shard-snb:          NOTRUN -> FAIL [fdo#109674]

  * igt@gem_exec_big:
    - shard-hsw:          PASS -> TIMEOUT [fdo#107936]

  * igt@gem_exec_schedule@preempt-other-chain-blt:
    - shard-snb:          NOTRUN -> SKIP [fdo#109271] +109

  * igt@i915_pm_rpm@dpms-lpsp:
    - shard-kbl:          NOTRUN -> SKIP [fdo#109271] +31

  * igt@kms_atomic_transition@3x-modeset-transitions:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_atomic_transition@5x-modeset-transitions-nonblocking:
    - shard-kbl:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1

  * igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
    - shard-apl:          PASS -> INCOMPLETE [fdo#103927]

  * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
    - shard-kbl:          PASS -> DMESG-WARN [fdo#107956] +1
    - shard-snb:          PASS -> DMESG-WARN [fdo#107956]
    - shard-hsw:          PASS -> DMESG-WARN [fdo#107956]

  * igt@kms_color@pipe-a-degamma:
    - shard-glk:          NOTRUN -> FAIL [fdo#104782] / [fdo#108145]

  * igt@kms_color@pipe-c-ctm-max:
    - shard-kbl:          PASS -> FAIL [fdo#108147]
    - shard-apl:          PASS -> FAIL [fdo#108147]

  * igt@kms_cursor_crc@cursor-128x128-random:
    - shard-apl:          PASS -> FAIL [fdo#103232] +5

  * igt@kms_cursor_crc@cursor-128x128-suspend:
    - shard-glk:          NOTRUN -> FAIL [fdo#103232] +1

  * igt@kms_cursor_crc@cursor-64x21-onscreen:
    - shard-kbl:          PASS -> FAIL [fdo#103232] +1

  * igt@kms_cursor_crc@cursor-alpha-opaque:
    - shard-apl:          PASS -> FAIL [fdo#109350]

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
    - shard-apl:          PASS -> FAIL [fdo#103167] +3

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
    - shard-glk:          PASS -> FAIL [fdo#103167] +6

  * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] +10

  * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
    - shard-kbl:          NOTRUN -> FAIL [fdo#108145] / [fdo#108590]

  * igt@kms_psr@basic:
    - shard-apl:          NOTRUN -> SKIP [fdo#109271] +4

  * igt@kms_rotation_crc@multiplane-rotation:
    - shard-kbl:          PASS -> INCOMPLETE [fdo#103665]

  * igt@kms_setmode@invalid-clone-exclusive-crtc:
    - shard-apl:          PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] / [fdo#109373]

  * igt@kms_universal_plane@cursor-fb-leak-pipe-d:
    - shard-snb:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +8

  * igt@kms_vblank@pipe-a-ts-continuation-modeset:
    - shard-apl:          PASS -> FAIL [fdo#104894] +1

  * igt@tools_test@tools_test:
    - shard-glk:          PASS -> SKIP [fdo#109271] +1

  * igt@vgem_basic@unload:
    - shard-kbl:          PASS -> SKIP [fdo#109271]
    - shard-hsw:          PASS -> SKIP [fdo#109271]
    - shard-apl:          PASS -> SKIP [fdo#109271]

  
#### Possible fixes ####

  * igt@kms_busy@extended-pageflip-hang-newfb-render-b:
    - shard-glk:          DMESG-WARN [fdo#107956] -> PASS

  * igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
    - shard-glk:          FAIL [fdo#108145] -> PASS

  * igt@kms_color@pipe-c-legacy-gamma:
    - shard-apl:          FAIL [fdo#104782] -> PASS

  * igt@kms_cursor_crc@cursor-128x42-random:
    - shard-apl:          FAIL [fdo#103232] -> PASS +1

  * igt@kms_cursor_crc@cursor-256x256-sliding:
    - shard-kbl:          FAIL [fdo#103232] -> PASS +1

  * igt@kms_cursor_crc@cursor-64x64-suspend:
    - shard-apl:          FAIL [fdo#103191] / [fdo#103232] -> PASS
    - shard-kbl:          FAIL [fdo#103191] / [fdo#103232] -> PASS

  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
    - shard-hsw:          FAIL [fdo#105767] -> PASS

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-apl:          DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS +2
    - shard-glk:          FAIL [fdo#102887] / [fdo#105363] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
    - shard-apl:          FAIL [fdo#103167] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
    - shard-glk:          FAIL [fdo#103167] -> PASS +3

  * {igt@kms_plane@plane-position-covered-pipe-a-planes}:
    - shard-apl:          FAIL [fdo#110038] -> PASS +1

  * {igt@kms_plane_multiple@atomic-pipe-a-tiling-none}:
    - shard-apl:          FAIL [fdo#110037] -> PASS

  * {igt@kms_plane_multiple@atomic-pipe-a-tiling-y}:
    - shard-glk:          FAIL [fdo#110037] -> PASS

  * igt@kms_setmode@basic:
    - shard-kbl:          FAIL [fdo#99912] -> PASS

  * igt@kms_universal_plane@universal-plane-pipe-a-functional:
    - shard-apl:          FAIL [fdo#103166] -> PASS

  * igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
    - shard-kbl:          INCOMPLETE [fdo#103665] -> PASS +1

  * igt@kms_vblank@pipe-c-ts-continuation-suspend:
    - shard-apl:          FAIL [fdo#104894] -> PASS +1
    - shard-kbl:          FAIL [fdo#104894] -> PASS

  * igt@perf@rc6-disable:
    - shard-kbl:          FAIL [fdo#103179] -> PASS

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103179]: https://bugs.freedesktop.org/show_bug.cgi?id=103179
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
  [fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
  [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
  [fdo#107936]: https://bugs.freedesktop.org/show_bug.cgi?id=107936
  [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
  [fdo#108590]: https://bugs.freedesktop.org/show_bug.cgi?id=108590
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
  [fdo#109373]: https://bugs.freedesktop.org/show_bug.cgi?id=109373
  [fdo#109674]: https://bugs.freedesktop.org/show_bug.cgi?id=109674
  [fdo#110037]: https://bugs.freedesktop.org/show_bug.cgi?id=110037
  [fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 5)
------------------------------

  Missing    (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-iclb pig-skl-6260u 


Build changes
-------------

    * IGT: IGT_4883 -> IGTPW_2598
    * Piglit: piglit_4509 -> None

  CI_DRM_5737: d5bb7d77aa77996702426496078a597f30bead58 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2598: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2598/
  IGT_4883: b25e06d6ddf2e42044cd9c93b613cbc7339a8c33 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2598/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev