public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Karolina Stolarek <karolina.stolarek@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 0/4] Introduce blt_cmd_info struct
Date: Mon, 19 Dec 2022 12:49:07 +0100	[thread overview]
Message-ID: <cover.1671446367.git.karolina.stolarek@intel.com> (raw)

This patch series introduces a new way of checking if a specific
tiling format and/or blitter copy command is supported on
the current platform. Instead of using functions with hardcoded
devices, now we store information about available features in
blt_cmd_info struct, per gen or platform. We have two groups of
predicates that internally use blt_supports_command() and
blt_cmd_supports_tiling() that check a matching blt_cmd_info
instance and say if a feature is supported or not.

In addition to this, the patchset adds a simple fast-copy test
that uses the aforementioned predicates, and refactors block-copy
test to use them as well. Two other patches are a prep work for
the fast-copy test -- extracting needed functions and updating
fill_data() to support TileYF (available only for Pre-gen12).

As this is quite a big patch series, I decided to send it early,
i.e. without doc comments. The plan is to add them in v2 (which
is bound to happen, given the scope of the series). Some of the
patches have my comments/thoughts on the solution I propose,
consulting them before the review will be very much appreciated.

Karolina Stolarek (4):
  lib: Describe supported blitter commands and tiling formats
  lib/i915_blt: Check for Tile-YF in fast_copy
  lib/i915_blt: Extract init functions for blt_copy_object
  tests/gem_exercise_blt: Add fast-copy test

 lib/i915/blt_tiling.c          | 371 +++++++++++++++++++++++++++++++++
 lib/i915/blt_tiling.h          |  64 ++++++
 lib/i915/i915_blt.c            | 150 ++++++++-----
 lib/i915/i915_blt.h            |  36 +++-
 lib/meson.build                |   1 +
 tests/i915/gem_ccs.c           |  96 +--------
 tests/i915/gem_exercise_blt.c  | 216 +++++++++++++++++++
 tests/i915/gem_lmem_swapping.c |  36 ----
 tests/meson.build              |   1 +
 9 files changed, 780 insertions(+), 191 deletions(-)
 create mode 100644 lib/i915/blt_tiling.c
 create mode 100644 lib/i915/blt_tiling.h
 create mode 100644 tests/i915/gem_exercise_blt.c

-- 
2.25.1

             reply	other threads:[~2022-12-19 11:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-19 11:49 Karolina Stolarek [this message]
2022-12-19 11:49 ` [igt-dev] [PATCH i-g-t 1/4] lib: Describe supported blitter commands and tiling formats Karolina Stolarek
2022-12-20 11:49   ` Zbigniew Kempczyński
2022-12-21  9:09     ` Karolina Stolarek
2022-12-21 17:58     ` Kamil Konieczny
2022-12-22  9:51       ` Karolina Stolarek
2022-12-21 18:31   ` Kamil Konieczny
2022-12-22 10:00     ` Karolina Stolarek
2022-12-19 11:49 ` [igt-dev] [PATCH i-g-t 2/4] lib/i915_blt: Check for Tile-YF in fast_copy Karolina Stolarek
2022-12-19 11:49 ` [igt-dev] [PATCH i-g-t 3/4] lib/i915_blt: Extract init functions for blt_copy_object Karolina Stolarek
2022-12-20 11:51   ` Zbigniew Kempczyński
2022-12-21 13:59   ` Kamil Konieczny
2022-12-22  9:50     ` Karolina Stolarek
2022-12-22 10:20       ` Kamil Konieczny
2022-12-22 10:23         ` Karolina Stolarek
2022-12-19 11:49 ` [igt-dev] [PATCH i-g-t 4/4] tests/gem_exercise_blt: Add fast-copy test Karolina Stolarek
2022-12-19 13:23 ` [igt-dev] ✓ Fi.CI.BAT: success for Introduce blt_cmd_info struct Patchwork
2022-12-20  3:12 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-12-20  8:11   ` Karolina Stolarek
2022-12-20 12:09     ` Yedireswarapu, SaiX Nandan
2022-12-20 11:25 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
2022-12-21 16:56 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1671446367.git.karolina.stolarek@intel.com \
    --to=karolina.stolarek@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox