Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v2 0/8] tools/gputop: add i915 PMU engine monitoring
@ 2026-10-01 11:13 Sebastian Brzezinka
  2026-10-01 11:13 ` [PATCH i-g-t v2 1/8] tools/gputop/xe_gputop: fix struct layout and PMU read Sebastian Brzezinka
                   ` (11 more replies)
  0 siblings, 12 replies; 17+ messages in thread
From: Sebastian Brzezinka @ 2026-10-01 11:13 UTC (permalink / raw)
  To: igt-dev
  Cc: Sebastian Brzezinka, kamil.konieczny, krzysztof.karas,
	krzysztof.niemiec

This series fixes the existing (currently disabled/broken) xe PMU
backend for gputop, adds an equivalent i915 PMU backend, and wires
both into the main gputop display loop so that per-engine busyness
is shown for whichever Intel GPU driver is bound. It also adds
tools_test subtests covering engine discovery, graceful handling of
denied PMU access, and PMU sampling correctness.

v2:
  - pmu_read_multi() stays void for xe: its percentage calculation
    doesn't need the time value, unlike i915.
  - Simplified the commit message.
  - gputop_no_crash_unprivileged now uses igt_system_quiet() instead
    of igt_system_cmd()

Sebastian Brzezinka (8):
  tools/gputop/xe_gputop: fix struct layout and PMU read
  tools/gputop/xe_gputop: fix missing igt_aux.h include for clamp()
  tools/gputop/xe_gputop: fix return logic, cleanup and div by zero bugs
  tools/gputop/i915_gputop: add i915 PMU engine monitoring
  tools/meson: build gputop PMU backends as part of gputop
  tools/gputop/utils: guard ANSI macros against redefinition
  tools/gputop: integrate i915 and xe PMU engine monitoring
  tests/tools_test: add gputop PMU engine monitoring subtests

 tests/tools_test.c         |  77 ++++++
 tools/gputop.c             | 222 ++++++++++++-----
 tools/gputop/i915_gputop.c | 474 +++++++++++++++++++++++++++++++++++++
 tools/gputop/i915_gputop.h |  56 +++++
 tools/gputop/utils.h       |   4 +
 tools/gputop/xe_gputop.c   |  48 +++-
 tools/gputop/xe_gputop.h   |   2 +-
 tools/meson.build          |  11 +-
 8 files changed, 820 insertions(+), 74 deletions(-)
 create mode 100644 tools/gputop/i915_gputop.c
 create mode 100644 tools/gputop/i915_gputop.h

-- 
2.55.0


^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2026-10-06  7:37 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-01 11:13 [PATCH i-g-t v2 0/8] tools/gputop: add i915 PMU engine monitoring Sebastian Brzezinka
2026-10-01 11:13 ` [PATCH i-g-t v2 1/8] tools/gputop/xe_gputop: fix struct layout and PMU read Sebastian Brzezinka
2026-10-06  6:11   ` Krzysztof Karas
2026-10-01 11:13 ` [PATCH i-g-t v2 2/8] tools/gputop/xe_gputop: fix missing igt_aux.h include for clamp() Sebastian Brzezinka
2026-10-06  6:13   ` Krzysztof Karas
2026-10-01 11:13 ` [PATCH i-g-t v2 3/8] tools/gputop/xe_gputop: fix return logic, cleanup and div by zero bugs Sebastian Brzezinka
2026-10-01 11:13 ` [PATCH i-g-t v2 4/8] tools/gputop/i915_gputop: add i915 PMU engine monitoring Sebastian Brzezinka
2026-10-06  6:32   ` Krzysztof Karas
2026-10-01 11:13 ` [PATCH i-g-t v2 5/8] tools/meson: build gputop PMU backends as part of gputop Sebastian Brzezinka
2026-10-01 11:13 ` [PATCH i-g-t v2 6/8] tools/gputop/utils: guard ANSI macros against redefinition Sebastian Brzezinka
2026-10-01 11:14 ` [PATCH i-g-t v2 7/8] tools/gputop: integrate i915 and xe PMU engine monitoring Sebastian Brzezinka
2026-10-06  7:36   ` Krzysztof Karas
2026-10-01 11:14 ` [PATCH i-g-t v2 8/8] tests/tools_test: add gputop PMU engine monitoring subtests Sebastian Brzezinka
2026-10-01 19:36 ` ✓ i915.CI.BAT: success for tools/gputop: add i915 PMU engine monitoring (rev3) Patchwork
2026-10-01 23:12 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-02  4:56 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-10-03  2:41 ` ✗ i915.CI.Full: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox