public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Kahola, Mika" <mika.kahola@intel.com>
To: "Summers, Stuart" <stuart.summers@intel.com>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t v2] lib/i915_pciids: Add missing device ID for ICL
Date: Tue, 2 Jul 2019 06:43:21 +0000	[thread overview]
Message-ID: <d0135ca9b402bd9254ebeeaee988979a77aa4bb5.camel@intel.com> (raw)
In-Reply-To: <84661bf6bcb90776e072436c5a6ac72751c45059.camel@intel.com>

On Mon, 2019-07-01 at 08:11 -0700, Summers, Stuart wrote:
> On Thu, 2019-06-27 at 13:59 +0300, Mika Kahola wrote:
> > We are missing PCI device ID for SKU ICLLP U GT 1.5F (0x8A54) as
> > per
> > BSPec.
> > 
> > Align with kernel commit 93d7a3b4be30 ("drm/i915/icl: Add missing
> > device ID")
> > 
> > BSpec: 19092
> 
> Should be 21141?
You're right. I'll fix that before merging the patch.

Thanks for the review!

Cheers,
Mika
> 
> > 
> > v2: Corresponding kernel commit added in commit message (Petri)
> > 
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> 
>   Reviewed-by: Stuart Summers <stuart.summers@intel.com>
> > ---
> >  lib/i915_pciids.h | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
> > index c7cdbfc4..0adce335 100644
> > --- a/lib/i915_pciids.h
> > +++ b/lib/i915_pciids.h
> > @@ -496,7 +496,8 @@
> >  	INTEL_VGA_DEVICE(0x8A56, info), \
> >  	INTEL_VGA_DEVICE(0x8A71, info), \
> >  	INTEL_VGA_DEVICE(0x8A70, info), \
> > -	INTEL_VGA_DEVICE(0x8A53, info)
> > +	INTEL_VGA_DEVICE(0x8A53, info), \
> > +	INTEL_VGA_DEVICE(0x8A54, info)
> >  
> >  /* EHL */
> >  #define INTEL_EHL_IDS(info) \
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

      reply	other threads:[~2019-07-02  6:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 10:59 [igt-dev] [PATCH i-g-t v2] lib/i915_pciids: Add missing device ID for ICL Mika Kahola
2019-06-27 12:02 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/i915_pciids: Add missing device ID for ICL (rev2) Patchwork
2019-06-28 10:39 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-07-01 15:11 ` [igt-dev] [PATCH i-g-t v2] lib/i915_pciids: Add missing device ID for ICL Summers, Stuart
2019-07-02  6:43   ` Kahola, Mika [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0135ca9b402bd9254ebeeaee988979a77aa4bb5.camel@intel.com \
    --to=mika.kahola@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=stuart.summers@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox