[igt-dev] [PATCH i-g-t v2] lib/i915_pciids: Add missing device ID for ICL

[igt-dev] [PATCH i-g-t v2] lib/i915_pciids: Add missing device ID for ICL

[Mika Kahola]

We are missing PCI device ID for SKU ICLLP U GT 1.5F (0x8A54) as per BSPec.

Align with kernel commit 93d7a3b4be30 ("drm/i915/icl: Add missing device ID")

BSpec: 19092

v2: Corresponding kernel commit added in commit message (Petri)

Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
 lib/i915_pciids.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
index c7cdbfc4..0adce335 100644
--- a/lib/i915_pciids.h
+++ b/lib/i915_pciids.h
@@ -496,7 +496,8 @@
 	INTEL_VGA_DEVICE(0x8A56, info), \
 	INTEL_VGA_DEVICE(0x8A71, info), \
 	INTEL_VGA_DEVICE(0x8A70, info), \
-	INTEL_VGA_DEVICE(0x8A53, info)
+	INTEL_VGA_DEVICE(0x8A53, info), \
+	INTEL_VGA_DEVICE(0x8A54, info)
 
 /* EHL */
 #define INTEL_EHL_IDS(info) \
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for lib/i915_pciids: Add missing device ID for ICL (rev2)

[Patchwork]

== Series Details ==

Series: lib/i915_pciids: Add missing device ID for ICL (rev2)
URL   : https://patchwork.freedesktop.org/series/62188/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6373 -> IGTPW_3204
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/62188/revisions/2/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3204 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_basic@create-close:
    - fi-icl-u3:          [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-icl-u3/igt@gem_basic@create-close.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/fi-icl-u3/igt@gem_basic@create-close.html

  * igt@gem_ctx_create@basic-files:
    - fi-icl-u3:          [PASS][3] -> [INCOMPLETE][4] ([fdo#107713] / [fdo#109100])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-icl-u3/igt@gem_ctx_create@basic-files.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/fi-icl-u3/igt@gem_ctx_create@basic-files.html

  
#### Possible fixes ####

  * igt@gem_ctx_switch@basic-default:
    - fi-icl-u2:          [INCOMPLETE][5] ([fdo#107713] / [fdo#108569]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-icl-u2/igt@gem_ctx_switch@basic-default.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/fi-icl-u2/igt@gem_ctx_switch@basic-default.html

  * igt@gem_mmap@basic-small-bo:
    - fi-icl-dsi:         [DMESG-WARN][7] ([fdo#106107]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-icl-dsi/igt@gem_mmap@basic-small-bo.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/fi-icl-dsi/igt@gem_mmap@basic-small-bo.html

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      [FAIL][9] ([fdo#108511]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html

  * igt@i915_selftest@live_client:
    - fi-icl-dsi:         [INCOMPLETE][11] ([fdo#107713]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-icl-dsi/igt@i915_selftest@live_client.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/fi-icl-dsi/igt@i915_selftest@live_client.html

  
  [fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100


Participating hosts (52 -> 44)
------------------------------

  Additional (1): fi-skl-gvtdvm 
  Missing    (9): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-cfl-8700k fi-pnv-d510 fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_5069 -> IGTPW_3204

  CI_DRM_6373: cc7ffe2a301509ba233652ec17d0f74c18b5c8a9 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3204: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/
  IGT_5069: 439a9f5d615f31f03cc3a3a5cbab19367a1af763 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for lib/i915_pciids: Add missing device ID for ICL (rev2)

[Patchwork]

== Series Details ==

Series: lib/i915_pciids: Add missing device ID for ICL (rev2)
URL   : https://patchwork.freedesktop.org/series/62188/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6373_full -> IGTPW_3204_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/62188/revisions/2/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3204_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_eio@in-flight-suspend:
    - shard-apl:          [PASS][1] -> [DMESG-WARN][2] ([fdo#108566]) +3 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-apl3/igt@gem_eio@in-flight-suspend.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-apl5/igt@gem_eio@in-flight-suspend.html

  * igt@gem_eio@unwedge-stress:
    - shard-snb:          [PASS][3] -> [FAIL][4] ([fdo#109661])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-snb6/igt@gem_eio@unwedge-stress.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-snb2/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_balancer@nop:
    - shard-iclb:         [PASS][5] -> [INCOMPLETE][6] ([fdo#107713])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb6/igt@gem_exec_balancer@nop.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-iclb2/igt@gem_exec_balancer@nop.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-glk:          [PASS][7] -> [DMESG-WARN][8] ([fdo#108686] / [fdo#110853])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-glk9/igt@gem_tiled_swapping@non-threaded.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-glk2/igt@gem_tiled_swapping@non-threaded.html

  * igt@kms_flip@flip-vs-suspend-interruptible:
    - shard-kbl:          [PASS][9] -> [INCOMPLETE][10] ([fdo#103665])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
    - shard-iclb:         [PASS][11] -> [FAIL][12] ([fdo#103167]) +5 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@fbc-2p-rte:
    - shard-hsw:          [PASS][13] -> [SKIP][14] ([fdo#109271]) +9 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-hsw6/igt@kms_frontbuffer_tracking@fbc-2p-rte.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-rte.html

  * igt@kms_plane_lowres@pipe-a-tiling-x:
    - shard-iclb:         [PASS][15] -> [FAIL][16] ([fdo#103166])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-x.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-x.html

  * igt@kms_psr@no_drrs:
    - shard-iclb:         [PASS][17] -> [FAIL][18] ([fdo#108341])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb6/igt@kms_psr@no_drrs.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-iclb1/igt@kms_psr@no_drrs.html

  * igt@kms_psr@psr2_basic:
    - shard-iclb:         [PASS][19] -> [SKIP][20] ([fdo#109441]) +1 similar issue
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb2/igt@kms_psr@psr2_basic.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-iclb4/igt@kms_psr@psr2_basic.html

  * igt@kms_setmode@basic:
    - shard-kbl:          [PASS][21] -> [FAIL][22] ([fdo#99912])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-kbl2/igt@kms_setmode@basic.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-kbl7/igt@kms_setmode@basic.html

  * igt@kms_sysfs_edid_timing:
    - shard-iclb:         [PASS][23] -> [FAIL][24] ([fdo#100047])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb5/igt@kms_sysfs_edid_timing.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-iclb2/igt@kms_sysfs_edid_timing.html

  
#### Possible fixes ####

  * igt@gem_workarounds@suspend-resume-fd:
    - shard-apl:          [DMESG-WARN][25] ([fdo#108566]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-apl1/igt@gem_workarounds@suspend-resume-fd.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-apl4/igt@gem_workarounds@suspend-resume-fd.html

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - shard-snb:          [SKIP][27] ([fdo#109271]) -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-snb6/igt@i915_pm_rc6_residency@rc6-accuracy.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-snb6/igt@i915_pm_rc6_residency@rc6-accuracy.html

  * igt@i915_pm_rpm@i2c:
    - shard-hsw:          [FAIL][29] ([fdo#104097]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-hsw1/igt@i915_pm_rpm@i2c.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-hsw5/igt@i915_pm_rpm@i2c.html

  * igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
    - shard-apl:          [DMESG-WARN][31] -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-apl5/igt@kms_atomic_transition@plane-all-modeset-transition-fencing.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-apl6/igt@kms_atomic_transition@plane-all-modeset-transition-fencing.html

  * igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque:
    - shard-kbl:          [FAIL][33] ([fdo#103232]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-kbl7/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite:
    - shard-hsw:          [SKIP][35] ([fdo#109271]) -> [PASS][36] +17 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-hsw8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt:
    - shard-iclb:         [FAIL][37] ([fdo#103167]) -> [PASS][38] +3 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html

  * igt@kms_psr@psr2_sprite_render:
    - shard-iclb:         [SKIP][39] ([fdo#109441]) -> [PASS][40] +1 similar issue
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/shard-iclb5/igt@kms_psr@psr2_sprite_render.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/shard-iclb2/igt@kms_psr@psr2_sprite_render.html

  
  [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
  [fdo#110853]: https://bugs.freedesktop.org/show_bug.cgi?id=110853
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 6)
------------------------------

  Missing    (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 


Build changes
-------------

  * IGT: IGT_5069 -> IGTPW_3204
  * Piglit: piglit_4509 -> None

  CI_DRM_6373: cc7ffe2a301509ba233652ec17d0f74c18b5c8a9 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3204: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/
  IGT_5069: 439a9f5d615f31f03cc3a3a5cbab19367a1af763 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3204/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] lib/i915_pciids: Add missing device ID for ICL

[Summers, Stuart]

[-- Attachment #1.1: Type: text/plain, Size: 993 bytes --]

On Thu, 2019-06-27 at 13:59 +0300, Mika Kahola wrote:
> We are missing PCI device ID for SKU ICLLP U GT 1.5F (0x8A54) as per
> BSPec.
> 
> Align with kernel commit 93d7a3b4be30 ("drm/i915/icl: Add missing
> device ID")
> 
> BSpec: 19092

Should be 21141?

> 
> v2: Corresponding kernel commit added in commit message (Petri)
> 
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
  Reviewed-by: Stuart Summers <stuart.summers@intel.com>
> ---
>  lib/i915_pciids.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
> index c7cdbfc4..0adce335 100644
> --- a/lib/i915_pciids.h
> +++ b/lib/i915_pciids.h
> @@ -496,7 +496,8 @@
>  	INTEL_VGA_DEVICE(0x8A56, info), \
>  	INTEL_VGA_DEVICE(0x8A71, info), \
>  	INTEL_VGA_DEVICE(0x8A70, info), \
> -	INTEL_VGA_DEVICE(0x8A53, info)
> +	INTEL_VGA_DEVICE(0x8A53, info), \
> +	INTEL_VGA_DEVICE(0x8A54, info)
>  
>  /* EHL */
>  #define INTEL_EHL_IDS(info) \

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3270 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] lib/i915_pciids: Add missing device ID for ICL

[Kahola, Mika]

On Mon, 2019-07-01 at 08:11 -0700, Summers, Stuart wrote:
> On Thu, 2019-06-27 at 13:59 +0300, Mika Kahola wrote:
> > We are missing PCI device ID for SKU ICLLP U GT 1.5F (0x8A54) as
> > per
> > BSPec.
> > 
> > Align with kernel commit 93d7a3b4be30 ("drm/i915/icl: Add missing
> > device ID")
> > 
> > BSpec: 19092
> 
> Should be 21141?
You're right. I'll fix that before merging the patch.

Thanks for the review!

Cheers,
Mika
> 
> > 
> > v2: Corresponding kernel commit added in commit message (Petri)
> > 
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> 
>   Reviewed-by: Stuart Summers <stuart.summers@intel.com>
> > ---
> >  lib/i915_pciids.h | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
> > index c7cdbfc4..0adce335 100644
> > --- a/lib/i915_pciids.h
> > +++ b/lib/i915_pciids.h
> > @@ -496,7 +496,8 @@
> >  	INTEL_VGA_DEVICE(0x8A56, info), \
> >  	INTEL_VGA_DEVICE(0x8A71, info), \
> >  	INTEL_VGA_DEVICE(0x8A70, info), \
> > -	INTEL_VGA_DEVICE(0x8A53, info)
> > +	INTEL_VGA_DEVICE(0x8A53, info), \
> > +	INTEL_VGA_DEVICE(0x8A54, info)
> >  
> >  /* EHL */
> >  #define INTEL_EHL_IDS(info) \
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev