Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Nemesa Garg <nemesa.garg@intel.com>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH] tests/kms_rmfb: Add check for xe driver
Date: Tue, 26 Sep 2023 15:57:47 +0530	[thread overview]
Message-ID: <d124a4fc-19ac-8722-1b2a-df724776467c@intel.com> (raw)
In-Reply-To: <32a7249f-a61d-c3bf-d397-5eb38d0e1c65@intel.com>

Also, add closes tag in the commit.

On 26-Sep-23 3:56 PM, Sharma, Swati2 wrote:
> Hi Nemesa,
> 
> Can you please add this test in fast-feedback and add as HAX patch,
> to check CI results.
> 
> On 22-Sep-23 9:43 PM, Nemesa Garg wrote:
>> As the xe check is missing the value of open_count
>> variable is not incrementing and because of this
>> during drm_close_driver operation based on open_count
>> value mutex is acquired and there is a callback to
>> lastclose function.
>>
>> Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
>> ---
>>   lib/drmtest.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/drmtest.c b/lib/drmtest.c
>> index e1da66c87..99b655680 100644
>> --- a/lib/drmtest.c
>> +++ b/lib/drmtest.c
>> @@ -649,7 +649,7 @@ int drm_open_driver(int chipset)
>>        * starting a test and we install an exit handler to wait until
>>        * idle before quitting.
>>        */
>> -    if (is_i915_device(fd)) {
>> +    if (is_i915_device(fd) || is_xe_device(fd)) {
>>           if (__sync_fetch_and_add(&open_count, 1) == 0) {
>>               __cancel_work_at_exit(fd);
>>               at_exit_drm_fd = drm_reopen_driver(fd);

  reply	other threads:[~2023-09-26 10:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-22 16:13 [igt-dev] [PATCH] tests/kms_rmfb: Add check for xe driver Nemesa Garg
2023-09-22 18:43 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-09-22 20:01 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-09-23 21:34 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-26 10:26 ` [igt-dev] [PATCH] " Sharma, Swati2
2023-09-26 10:27   ` Sharma, Swati2 [this message]
2023-09-26 12:02     ` Garg, Nemesa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d124a4fc-19ac-8722-1b2a-df724776467c@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=nemesa.garg@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox