Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] Revert "test/kms_atomic: Skip plane overlay test for amdgpu"
@ 2021-11-04 14:22 Rodrigo Siqueira
  2021-11-04 14:38 ` Simon Ser
                   ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Rodrigo Siqueira @ 2021-11-04 14:22 UTC (permalink / raw)
  To: igt-dev; +Cc: Simon Ser, Hayden Goodfellow

This reverts commit 080869f804cb86b25a38889e5ce9a870571cd8c4.

Thanks to Simon's patch to amd-staging-drm-next, we recently re-enabled
overlay support in our driver. We don't need to skip overlay tests in
the kms_atomic anymore; for this reason, this commit reverted the skip
when we have overlay tests.

Cc: Simon Ser <contact@emersion.fr>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Nicholas Choi <Nicholas.Choi@amd.com>
Cc: Hayden Goodfellow <Hayden.Goodfellow@amd.com>
Cc: Mark Yacoub <markyacoub@chromium.org>

Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
---
 tests/kms_atomic.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
index 1657624e..5295c8f5 100644
--- a/tests/kms_atomic.c
+++ b/tests/kms_atomic.c
@@ -502,13 +502,6 @@ static void plane_overlay(igt_pipe_t *pipe, igt_output_t *output, igt_plane_t *p
 	uint32_t w = mode->hdisplay / 2;
 	uint32_t h = mode->vdisplay / 2;
 
-	/* On AMD, with hardware cursor, overlay plane must fully cover
-	 * the primary plane (underlay). AMD does not support this test
-	 * scenario
-	 */
-	igt_require_f(!is_amdgpu_device(output->display->drm_fd),
-		      "Overlay must fully cover the primary plane on AMD\n");
-
 	igt_require(format != 0);
 
 	igt_create_pattern_fb(pipe->display->drm_fd, w, h,
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-11-10 16:25 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-04 14:22 [igt-dev] [PATCH i-g-t] Revert "test/kms_atomic: Skip plane overlay test for amdgpu" Rodrigo Siqueira
2021-11-04 14:38 ` Simon Ser
2021-11-09 15:52   ` Rodrigo Siqueira Jordao
2021-11-09 17:00     ` Vudum, Lakshminarayana
2021-11-10 15:25       ` Rodrigo Siqueira Jordao
2021-11-10 16:25         ` Vudum, Lakshminarayana
2021-11-04 15:27 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2021-11-09 16:55 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2021-11-09 18:47 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-11-10 16:07 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox