[igt-dev] [PATCH i-g-t] tests/i915/kms_dsc_helper: %s/platform/source

[igt-dev] [PATCH i-g-t] tests/i915/kms_dsc_helper: %s/platform/source

[Swati Sharma]

Rename function from platform to source.

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/i915/kms_dsc_helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/i915/kms_dsc_helper.c b/tests/i915/kms_dsc_helper.c
index df999c9bd..44edd5ca9 100644
--- a/tests/i915/kms_dsc_helper.c
+++ b/tests/i915/kms_dsc_helper.c
@@ -120,7 +120,7 @@ void force_dsc_output_format(int drmfd, igt_output_t *output,
 }
 
 /* YCbCr420 DSC is supported on display version 14+ with DSC1.2a */
-static bool is_dsc_output_format_supported_by_platform(int disp_ver, enum dsc_output_format output_format)
+static bool is_dsc_output_format_supported_by_source(int disp_ver, enum dsc_output_format output_format)
 {
 	if (disp_ver < 14 && output_format == DSC_FORMAT_YCBCR420) {
 		igt_debug("Output format DSC YCBCR420 not supported on D13 and older platforms\n");
@@ -133,7 +133,7 @@ static bool is_dsc_output_format_supported_by_platform(int disp_ver, enum dsc_ou
 bool is_dsc_output_format_supported(int drmfd, int disp_ver, igt_output_t *output,
 				    enum dsc_output_format output_format)
 {
-	if (!is_dsc_output_format_supported_by_platform(disp_ver, output_format))
+	if (!is_dsc_output_format_supported_by_source(disp_ver, output_format))
 		return false;
 
 	if (!igt_is_dsc_output_format_supported_by_sink(drmfd, output->name, output_format)) {
-- 
2.25.1

Re: [igt-dev] [PATCH i-g-t] tests/i915/kms_dsc_helper: %s/platform/source

[Karthik B S]

On 8/10/2023 3:41 PM, Swati Sharma wrote:
> Rename function from platform to source.
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/i915/kms_dsc_helper.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/i915/kms_dsc_helper.c b/tests/i915/kms_dsc_helper.c
> index df999c9bd..44edd5ca9 100644
> --- a/tests/i915/kms_dsc_helper.c
> +++ b/tests/i915/kms_dsc_helper.c
> @@ -120,7 +120,7 @@ void force_dsc_output_format(int drmfd, igt_output_t *output,
>   }
>   
>   /* YCbCr420 DSC is supported on display version 14+ with DSC1.2a */
> -static bool is_dsc_output_format_supported_by_platform(int disp_ver, enum dsc_output_format output_format)
> +static bool is_dsc_output_format_supported_by_source(int disp_ver, enum dsc_output_format output_format)
>   {
>   	if (disp_ver < 14 && output_format == DSC_FORMAT_YCBCR420) {
>   		igt_debug("Output format DSC YCBCR420 not supported on D13 and older platforms\n");
> @@ -133,7 +133,7 @@ static bool is_dsc_output_format_supported_by_platform(int disp_ver, enum dsc_ou
>   bool is_dsc_output_format_supported(int drmfd, int disp_ver, igt_output_t *output,
>   				    enum dsc_output_format output_format)
>   {
> -	if (!is_dsc_output_format_supported_by_platform(disp_ver, output_format))
> +	if (!is_dsc_output_format_supported_by_source(disp_ver, output_format))
>   		return false;
>   
>   	if (!igt_is_dsc_output_format_supported_by_sink(drmfd, output->name, output_format)) {

[igt-dev] ○ CI.xeBAT: info for tests/i915/kms_dsc_helper: %s/platform/source

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

== Series Details ==

Series: tests/i915/kms_dsc_helper: %s/platform/source
URL   : https://patchwork.freedesktop.org/series/122275/
State : info

== Summary ==

Participating hosts:
bat-pvc-2
bat-atsm-2
bat-dg2-oem2
bat-adlp-7
Missing hosts results[0]:
Results: [IGTPW_9565](https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_9565/index.html)



[-- Attachment #2: Type: text/html, Size: 859 bytes --]

[igt-dev] ✗ Fi.CI.BAT: failure for tests/i915/kms_dsc_helper: %s/platform/source

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 8418 bytes --]

== Series Details ==

Series: tests/i915/kms_dsc_helper: %s/platform/source
URL   : https://patchwork.freedesktop.org/series/122275/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13499 -> IGTPW_9565
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_9565 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_9565, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/index.html

Participating hosts (43 -> 42)
------------------------------

  Missing    (1): fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_9565:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_exec_suspend@basic-s3@smem:
    - fi-elk-e7500:       [PASS][1] -> [ABORT][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13499/fi-elk-e7500/igt@gem_exec_suspend@basic-s3@smem.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/fi-elk-e7500/igt@gem_exec_suspend@basic-s3@smem.html

  
Known issues
------------

  Here are the changes found in IGTPW_9565 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rpm@basic-rte:
    - fi-cfl-8109u:       [PASS][3] -> [FAIL][4] ([i915#7940])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13499/fi-cfl-8109u/igt@i915_pm_rpm@basic-rte.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/fi-cfl-8109u/igt@i915_pm_rpm@basic-rte.html

  * igt@i915_pm_rpm@module-reload:
    - fi-rkl-11600:       [PASS][5] -> [FAIL][6] ([i915#7940])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13499/fi-rkl-11600/igt@i915_pm_rpm@module-reload.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/fi-rkl-11600/igt@i915_pm_rpm@module-reload.html

  * igt@i915_selftest@live@gt_heartbeat:
    - bat-jsl-1:          [PASS][7] -> [DMESG-FAIL][8] ([i915#5334])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13499/bat-jsl-1/igt@i915_selftest@live@gt_heartbeat.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/bat-jsl-1/igt@i915_selftest@live@gt_heartbeat.html

  * igt@i915_selftest@live@migrate:
    - bat-dg2-11:         [PASS][9] -> [DMESG-WARN][10] ([i915#7699])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13499/bat-dg2-11/igt@i915_selftest@live@migrate.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/bat-dg2-11/igt@i915_selftest@live@migrate.html

  * igt@i915_selftest@live@slpc:
    - bat-mtlp-6:         [PASS][11] -> [DMESG-WARN][12] ([i915#6367])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13499/bat-mtlp-6/igt@i915_selftest@live@slpc.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/bat-mtlp-6/igt@i915_selftest@live@slpc.html
    - bat-rpls-2:         NOTRUN -> [DMESG-WARN][13] ([i915#6367])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/bat-rpls-2/igt@i915_selftest@live@slpc.html

  * igt@kms_chamelium_hpd@common-hpd-after-suspend:
    - bat-rpls-2:         NOTRUN -> [SKIP][14] ([i915#7828])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/bat-rpls-2/igt@kms_chamelium_hpd@common-hpd-after-suspend.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
    - bat-dg2-11:         NOTRUN -> [SKIP][15] ([i915#1845] / [i915#5354]) +3 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html

  * igt@kms_pipe_crc_basic@suspend-read-crc:
    - bat-rpls-2:         NOTRUN -> [SKIP][16] ([i915#1845])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/bat-rpls-2/igt@kms_pipe_crc_basic@suspend-read-crc.html

  
#### Possible fixes ####

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - bat-adlp-9:         [FAIL][17] ([i915#7940]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13499/bat-adlp-9/igt@i915_pm_rpm@basic-pci-d3-state.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/bat-adlp-9/igt@i915_pm_rpm@basic-pci-d3-state.html
    - fi-kbl-x1275:       [SKIP][19] ([fdo#109271]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13499/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html

  * igt@i915_pm_rpm@basic-rte:
    - fi-cfl-guc:         [FAIL][21] ([i915#7940]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13499/fi-cfl-guc/igt@i915_pm_rpm@basic-rte.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/fi-cfl-guc/igt@i915_pm_rpm@basic-rte.html

  * igt@i915_pm_rpm@module-reload:
    - fi-tgl-1115g4:      [FAIL][23] ([i915#7940]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13499/fi-tgl-1115g4/igt@i915_pm_rpm@module-reload.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/fi-tgl-1115g4/igt@i915_pm_rpm@module-reload.html

  * igt@i915_selftest@live@requests:
    - bat-rpls-2:         [ABORT][25] ([i915#7913] / [i915#7982]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13499/bat-rpls-2/igt@i915_selftest@live@requests.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/bat-rpls-2/igt@i915_selftest@live@requests.html

  * igt@i915_selftest@live@workarounds:
    - bat-mtlp-6:         [DMESG-FAIL][27] ([i915#6763]) -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13499/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/bat-mtlp-6/igt@i915_selftest@live@workarounds.html

  
#### Warnings ####

  * igt@i915_selftest@live@requests:
    - bat-rpls-1:         [ABORT][29] ([i915#7911] / [i915#7920] / [i915#7982]) -> [ABORT][30] ([i915#4983] / [i915#7911] / [i915#7920])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13499/bat-rpls-1/igt@i915_selftest@live@requests.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/bat-rpls-1/igt@i915_selftest@live@requests.html

  * igt@kms_psr@sprite_plane_onoff:
    - bat-rplp-1:         [SKIP][31] ([i915#1072]) -> [ABORT][32] ([i915#8442] / [i915#8668] / [i915#8712])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13499/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html

  
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#6763]: https://gitlab.freedesktop.org/drm/intel/issues/6763
  [i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
  [i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
  [i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
  [i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
  [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
  [i915#8712]: https://gitlab.freedesktop.org/drm/intel/issues/8712


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7426 -> IGTPW_9565

  CI-20190529: 20190529
  CI_DRM_13499: 21dbe1891710d9c00e491bc4da1b593e3a31ad61 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_9565: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/index.html
  IGT_7426: 67e7470eb79ca386087775d0b1b51c164abbf9c8 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9565/index.html

[-- Attachment #2: Type: text/html, Size: 10049 bytes --]

Re: [igt-dev] [PATCH i-g-t] tests/i915/kms_dsc_helper: %s/platform/source

[Kamil Konieczny]

Hi Swati,

small nit regarding subject, imho better:
rename by_platform to by_source

Also it looks better without '%'.

On 2023-08-10 at 15:41:42 +0530, Swati Sharma wrote:
> Rename function from platform to source.
-------- ^
Technically speaking you rename a word in function, not all name
so it may be written here. Also maybe write few words why?

Regards,
Kamil

> 
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
>  tests/i915/kms_dsc_helper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/kms_dsc_helper.c b/tests/i915/kms_dsc_helper.c
> index df999c9bd..44edd5ca9 100644
> --- a/tests/i915/kms_dsc_helper.c
> +++ b/tests/i915/kms_dsc_helper.c
> @@ -120,7 +120,7 @@ void force_dsc_output_format(int drmfd, igt_output_t *output,
>  }
>  
>  /* YCbCr420 DSC is supported on display version 14+ with DSC1.2a */
> -static bool is_dsc_output_format_supported_by_platform(int disp_ver, enum dsc_output_format output_format)
> +static bool is_dsc_output_format_supported_by_source(int disp_ver, enum dsc_output_format output_format)
>  {
>  	if (disp_ver < 14 && output_format == DSC_FORMAT_YCBCR420) {
>  		igt_debug("Output format DSC YCBCR420 not supported on D13 and older platforms\n");
> @@ -133,7 +133,7 @@ static bool is_dsc_output_format_supported_by_platform(int disp_ver, enum dsc_ou
>  bool is_dsc_output_format_supported(int drmfd, int disp_ver, igt_output_t *output,
>  				    enum dsc_output_format output_format)
>  {
> -	if (!is_dsc_output_format_supported_by_platform(disp_ver, output_format))
> +	if (!is_dsc_output_format_supported_by_source(disp_ver, output_format))
>  		return false;
>  
>  	if (!igt_is_dsc_output_format_supported_by_sink(drmfd, output->name, output_format)) {
> -- 
> 2.25.1
>