Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v3 0/6] test/kms_colorop_helper: don't request colorop updates indefinitely
@ 2026-08-11 14:23 Melissa Wen
  2026-08-11 14:23 ` [PATCH i-g-t v3 1/6] lib/igt_kms: clear colorop-changed flag after commit Melissa Wen
                   ` (8 more replies)
  0 siblings, 9 replies; 16+ messages in thread
From: Melissa Wen @ 2026-08-11 14:23 UTC (permalink / raw)
  To: Petri Latvala, Arkadiusz Hiler, Kamil Konieczny,
	Juha-Pekka Heikkila, Bhanuprakash Modem, Ashutosh Dixit,
	Karthik B S
  Cc: Chaitanya Kumar Borah, igt-dev, kernel-dev, Alex Hung,
	Swati Sharma, John Harrison, Rodrigo Siqueira, Simon Ser,
	Xaver Hugl, Harry Wentland, Uma Shankar

After committing colorop settings, colorops are still flagged as
changed, even if there is no new request for updates. This v3 addresses
Chaitanya's comments [v2] to fix an extra space and split one commit
into three, as follows:

- Patch 1 clears colorop flag after commit so that the next patch
  doesn't try to re-submit changes on inactive color pipeline.

- Patch 2 prevents colorop to be marked as changed just because it was
  checking if a property enum value is supported. These changes are
  consistent with the current expetation of allowing property changes in
  colorop that are part of a current active color pipeline or a color
  pipeline that will be activated or deactived in the same atomic commit;
  but rejecting attempts to change inactive colorops.

- Patch 3 (new): was detached from previous-version patch 3 to only
  verify colorop properties in planes that support plane COLOR_PIPELINE
  property, i.e. planes that has a colorop pipeline, since not all planes
  have to support it.

- Patch 4 (new): was also detached from previous-version patch 3 and now
  it basically keeps a primary plane always active for a given CRTC,
  even though colorop properties of an overlay plane is under testing.

- Patch 5: is the main change of previous-version patch 3 that fixes
  kms_properties to match colorop update requirements of an active plane
  color pipeline.

- Patch 6 just ensure that kms_color_pipeline expects an intel device
  and will not run otherwise. As color validation works better with
  writeback then CRC, other devices should prefer kms_colorop if they have
  writeback support. If not, they should work on adapting
  kms_color_pipeline according to their specs.

[v1] https://lore.kernel.org/igt-dev/20260602211259.898147-1-mwen@igalia.com/

Lemme know your thought!

Melissa

Melissa Wen (6):
  lib/igt_kms: clear colorop-changed flag after commit
  test/kms_colorop_helper: only check if a given enum value exist
  tests/kms_properties: don't check colorop if no plane color pipeline prop
  tests/kms_properties: keep primary plane enabled for each CRTC
  tests/kms_properties: check colorop properties on active color pipelines
  tests/kms_color_pipeline: skip if not an intel device

 lib/igt_kms.c              | 41 ++++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h              |  4 ++++
 tests/kms_color_pipeline.c |  1 +
 tests/kms_colorop_helper.c |  4 +++-
 tests/kms_properties.c     | 26 ++++++++++++++++++++++--
 5 files changed, 73 insertions(+), 3 deletions(-)

-- 
2.53.0


^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2026-08-14  4:06 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-11 14:23 [PATCH i-g-t v3 0/6] test/kms_colorop_helper: don't request colorop updates indefinitely Melissa Wen
2026-08-11 14:23 ` [PATCH i-g-t v3 1/6] lib/igt_kms: clear colorop-changed flag after commit Melissa Wen
2026-08-11 16:37   ` Jani Nikula
2026-08-14  3:39   ` Alex Hung
2026-08-11 14:23 ` [PATCH i-g-t v3 2/6] test/kms_colorop_helper: only check if a given enum value exist Melissa Wen
2026-08-14  3:41   ` Alex Hung
2026-08-11 14:23 ` [PATCH i-g-t v3 3/6] tests/kms_properties: don't check colorop if no plane color pipeline prop Melissa Wen
2026-08-14  3:44   ` Alex Hung
2026-08-11 14:23 ` [PATCH i-g-t v3 4/6] tests/kms_properties: keep primary plane enabled for each CRTC Melissa Wen
2026-08-14  4:05   ` Alex Hung
2026-08-11 14:23 ` [PATCH i-g-t v3 6/6] tests/kms_color_pipeline: skip if not an intel device Melissa Wen
2026-08-14  3:55   ` Alex Hung
2026-08-11 16:43 ` ✓ Xe.CI.BAT: success for test/kms_colorop_helper: don't request colorop updates indefinitely (rev2) Patchwork
2026-08-11 16:59 ` ✓ i915.CI.BAT: " Patchwork
2026-08-11 18:43 ` ✓ Xe.CI.FULL: " Patchwork
2026-08-11 19:21 ` ✗ i915.CI.Full: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox