From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
igt-dev@lists.freedesktop.org
Cc: Simon Ser <contact@emersion.fr>
Subject: Re: [igt-dev] [i-g-t] Revert "syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE"
Date: Mon, 13 Nov 2023 11:57:45 +0200 [thread overview]
Message-ID: <db3b1986-771f-456b-aab4-5ef4cf86c84d@gmail.com> (raw)
In-Reply-To: <20231113094353.1232575-1-bhanuprakash.modem@intel.com>
Acked-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
On 13.11.2023 11.43, Bhanuprakash Modem wrote:
> This reverts commit f6f5903348eff6510f8877043f9397a2a5cb94b3.
>
> This patch is causing the regression in CI.
>
> [1767/1775] Generating i915_tests.rst with a custom command
> FAILED: docs/testplan/i915_tests.rst
> ./igt_doc.py --config ../tests/intel/i915_test_config.json --rest docs/testplan/i915_tests.rst --check-testlist --igt-build-path ./build
> Warning: Documented igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted doesn't exist on source files
> Warning: Documented igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted-signaled doesn't exist on source files
> Warning: Documented igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted-submitted doesn't exist on source files
> Warning: Documented igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted-submitted-signaled doesn't exist on source files
> Warning: Documented igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted doesn't exist on source files
> Warning: Documented igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted-signaled doesn't exist on source files
> Warning: Documented igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted-submitted doesn't exist on source files
> Warning: Documented igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted-submitted-signaled doesn't exist on source files
> Warning: Documented igt@syncobj_timeline@invalid-single-wait-all-available-unsubmitted doesn't exist on source files
> Warning: Documented igt@syncobj_timeline@invalid-single-wait-available-unsubmitted doesn't exist on source files
> Warning: Missing documentation for igt@syncobj_timeline@etime-multi-wait-all-available-unsubmitted
> Warning: Missing documentation for igt@syncobj_timeline@etime-multi-wait-all-available-unsubmitted-signaled
> Warning: Missing documentation for igt@syncobj_timeline@etime-multi-wait-all-available-unsubmitted-submitted
> Warning: Missing documentation for igt@syncobj_timeline@etime-multi-wait-all-available-unsubmitted-submitted-signaled
> Warning: Missing documentation for igt@syncobj_timeline@etime-multi-wait-available-unsubmitted
> Warning: Missing documentation for igt@syncobj_timeline@etime-single-wait-all-available-unsubmitted
> Warning: Missing documentation for igt@syncobj_timeline@etime-single-wait-available-unsubmitted
> Warning: Missing documentation for igt@syncobj_timeline@multi-wait-available-unsubmitted-signaled
> Warning: Missing documentation for igt@syncobj_timeline@multi-wait-available-unsubmitted-submitted
> Warning: Missing documentation for igt@syncobj_timeline@multi-wait-available-unsubmitted-submitted-signaled
> Please refer: docs/test_documentation.md for more details
> [1771/1775] Compiling C object runner/runner_test.p/runner_tests.c.o
> ninja: build stopped: subcommand failed.
>
> Cc: Erik Kurzinger <ekurzinger@nvidia.com>
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Simon Ser <contact@emersion.fr>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
> tests/syncobj_timeline.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/syncobj_timeline.c b/tests/syncobj_timeline.c
> index 0422bca51..b4e1d093a 100644
> --- a/tests/syncobj_timeline.c
> +++ b/tests/syncobj_timeline.c
> @@ -1782,7 +1782,7 @@ igt_main
> WAIT_SIGNALED)) != 1)
> continue;
>
> - if ((flags & WAIT_UNSUBMITTED) && !((flags & WAIT_FOR_SUBMIT) || (flags & WAIT_AVAILABLE)))
> + if ((flags & WAIT_UNSUBMITTED) && !(flags & WAIT_FOR_SUBMIT))
> err = -EINVAL;
> else if (!(flags & WAIT_SIGNALED) && !((flags & WAIT_SUBMITTED) && (flags & WAIT_AVAILABLE)))
> err = -ETIME;
> @@ -1851,7 +1851,7 @@ igt_main
> continue;
>
> err = 0;
> - if ((flags & WAIT_UNSUBMITTED) && !((flags & WAIT_FOR_SUBMIT) || (flags & WAIT_AVAILABLE))) {
> + if ((flags & WAIT_UNSUBMITTED) && !(flags & WAIT_FOR_SUBMIT)) {
> err = -EINVAL;
> } else if (flags & WAIT_ALL) {
> if (flags & (WAIT_UNSUBMITTED | WAIT_SUBMITTED))
next prev parent reply other threads:[~2023-11-13 9:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 9:43 [igt-dev] [i-g-t] Revert "syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE" Bhanuprakash Modem
2023-11-13 9:55 ` Simon Ser
2023-11-13 9:59 ` Juha-Pekka Heikkila
2023-11-13 10:02 ` Simon Ser
2023-11-13 10:06 ` Juha-Pekka Heikkila
2023-11-13 10:30 ` Simon Ser
2023-11-13 10:44 ` Juha-Pekka Heikkila
2023-11-13 11:46 ` Simon Ser
2023-11-13 10:04 ` Modem, Bhanuprakash
2023-11-13 9:57 ` Juha-Pekka Heikkila [this message]
2023-11-13 11:51 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db3b1986-771f-456b-aab4-5ef4cf86c84d@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=bhanuprakash.modem@intel.com \
--cc=contact@emersion.fr \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox