From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Simon Ser <contact@emersion.fr>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [i-g-t] Revert "syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE"
Date: Mon, 13 Nov 2023 12:44:34 +0200 [thread overview]
Message-ID: <f4924d25-142d-458d-bdbd-ee4b799e5308@gmail.com> (raw)
In-Reply-To: <i8_3cM1wQXQV0rRJ1PxYHAe03idImtlCfV5UXOCcGrCxTt0ta1pjY0SuhPZvLTIyXqtLco3NawRlMKPy5ANYBwChb6oXvdQ2xcAKLF6QPdo=@emersion.fr>
On 13.11.2023 12.30, Simon Ser wrote:
> On Monday, November 13th, 2023 at 11:06, Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> wrote:
>
>> On 13.11.2023 12.02, Simon Ser wrote:
>>
>>> On Monday, November 13th, 2023 at 10:59, Juha-Pekka Heikkila juhapekka.heikkila@gmail.com wrote:
>>>
>>>> On 13.11.2023 11.55, Simon Ser wrote:
>>>>
>>>>> NACK. Please fix your docs/testplan/i915_tests.rst instead.
>>>>
>>>> Let's do fixes outside of master branch where it doesn't bother others.
>>>
>>> Sorry, but no. This commit fixes a bug already. The CI regression is
>>> completely unrelated, and Intel-specific, I really don't understand why
>>> it happens in the first place.
>>>
>>> Is it by design that actual bug fixes break Intel CI?
>>
>> As is this is blocking others totally unrelated to this. This patch
>> never passed ci in the first place hence never should've been merged.
>> Let's fix it somewhere else than on everyone's build machines independently.
>
> If we want a quick fix, we can disable the broken Intel CI, instead of
> reverting a completely correct bugfix.
Simon, disabling CI doesn't universally fix the build for everyone. If
you don't use testplan it's your story but it's not the story for all
other igt users. Passing ci testing is the requirement for merging,
that's why ci is running on patch sets. This reverted patch didn't even
build in ci and after you merged it others started to see what ci
already had reported about this patch.
/Juha-Pekka
next prev parent reply other threads:[~2023-11-13 10:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 9:43 [igt-dev] [i-g-t] Revert "syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE" Bhanuprakash Modem
2023-11-13 9:55 ` Simon Ser
2023-11-13 9:59 ` Juha-Pekka Heikkila
2023-11-13 10:02 ` Simon Ser
2023-11-13 10:06 ` Juha-Pekka Heikkila
2023-11-13 10:30 ` Simon Ser
2023-11-13 10:44 ` Juha-Pekka Heikkila [this message]
2023-11-13 11:46 ` Simon Ser
2023-11-13 10:04 ` Modem, Bhanuprakash
2023-11-13 9:57 ` Juha-Pekka Heikkila
2023-11-13 11:51 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4924d25-142d-458d-bdbd-ee4b799e5308@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=contact@emersion.fr \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox