From: "Nilawar, Badal" <badal.nilawar@intel.com>
To: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v3] tests/xe: Verify actual frequency on the basis of GT state
Date: Wed, 19 Jul 2023 11:05:35 +0530 [thread overview]
Message-ID: <db5db432-54b1-71d2-28e2-765897acf451@intel.com> (raw)
In-Reply-To: <87cz0phy5u.wl-ashutosh.dixit@intel.com>
On 18-07-2023 23:58, Dixit, Ashutosh wrote:
> On Tue, 18 Jul 2023 11:24:55 -0700, Dixit, Ashutosh wrote:
>>
>> Sorry I missed this yesterday. Basically why do we have the
>> igt_wait(xe_is_gt_in_c6()) above at the top when we are waking up the gt
>> when reading cur freq later?
>>
>> Maybe instead of this usleep, we can this do here:
>>
>> igt_assert(igt_wait(xe_is_gt_in_c6(fd, gt_id), 1000, 1));
>
> Actually, maybe:
>
> igt_assert(igt_wait(xe_is_gt_in_c6(fd, gt_id), 1000, 10))Sure I will make this change.
>
>>
>> And get rid of the igt_require(igt_wait()) at the top?
This is added to skip test if RC6 disabled or not working. As discussed
offline I will move this to igt_main.
Regards,
Badal
>>
>> Thanks.
>> --
>> Ashutosh
next prev parent reply other threads:[~2023-07-19 5:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 11:17 [igt-dev] [PATCH i-g-t v3] tests/xe: Verify actual frequency on the basis of GT state Badal Nilawar
2023-07-18 14:10 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/xe: Verify actual frequency on the basis of GT state (rev2) Patchwork
2023-07-18 14:38 ` [igt-dev] ○ CI.xeBAT: info " Patchwork
2023-07-18 18:24 ` [igt-dev] [PATCH i-g-t v3] tests/xe: Verify actual frequency on the basis of GT state Dixit, Ashutosh
2023-07-18 18:28 ` Dixit, Ashutosh
2023-07-19 5:35 ` Nilawar, Badal [this message]
2023-07-19 5:54 ` Nilawar, Badal
2023-07-19 13:40 ` Dixit, Ashutosh
2023-07-18 18:51 ` [igt-dev] ✗ Fi.CI.IGT: failure for tests/xe: Verify actual frequency on the basis of GT state (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db5db432-54b1-71d2-28e2-765897acf451@intel.com \
--to=badal.nilawar@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox