* [igt-dev] [PATCH i-g-t] i915/gem_exec_limit: Limit to a maximum of 120s
@ 2019-01-14 9:16 Chris Wilson
2019-01-14 9:42 ` [Intel-gfx] " Tvrtko Ursulin
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chris Wilson @ 2019-01-14 9:16 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
Each individual pass is as effective at spotting an error using the
Chinese whisper as any other, so the effectiveness of adding more passes
rapidly diminishes. To keep the tests bounded within time, limit a
subtest to a mere 150s!
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108592
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/gem_exec_whisper.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/tests/i915/gem_exec_whisper.c b/tests/i915/gem_exec_whisper.c
index 81303f847..d2ee98399 100644
--- a/tests/i915/gem_exec_whisper.c
+++ b/tests/i915/gem_exec_whisper.c
@@ -189,12 +189,12 @@ static void whisper(int fd, unsigned engine, unsigned flags)
unsigned engines[16];
unsigned nengine;
uint32_t batch[16];
- int i, n, pass, loc;
unsigned int relocations = 0;
unsigned int reloc_migrations = 0;
unsigned int reloc_interruptions = 0;
unsigned int eb_migrations = 0;
uint64_t old_offset;
+ int i, n, loc;
int debugfs;
if (flags & PRIORITY) {
@@ -323,7 +323,9 @@ static void whisper(int fd, unsigned engine, unsigned flags)
}
igt_while_interruptible(flags & INTERRUPTIBLE) {
- for (pass = 0; pass < 1024; pass++) {
+ unsigned int pass = 0;
+
+ igt_until_timeout(150) {
uint64_t offset;
if (!(flags & FORKED))
@@ -384,10 +386,10 @@ static void whisper(int fd, unsigned engine, unsigned flags)
handle[1] = batches[n].handle;
batches[n-1].handle =
gem_open(this_fd,
- gem_flink(fd, handle[0]));
+ gem_flink(fd, handle[0]));
batches[n].handle =
gem_open(this_fd,
- gem_flink(fd, handle[1]));
+ gem_flink(fd, handle[1]));
if (flags & PRIORITY)
ctx_set_random_priority(this_fd, 0);
}
@@ -462,6 +464,9 @@ static void whisper(int fd, unsigned engine, unsigned flags)
store = tmp[1];
scratch = tmp[0];
+
+ if (++pass == 1024)
+ break;
}
}
igt_info("Number of migrations for execbuf: %d\n", eb_migrations);
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_limit: Limit to a maximum of 120s
2019-01-14 9:16 [igt-dev] [PATCH i-g-t] i915/gem_exec_limit: Limit to a maximum of 120s Chris Wilson
@ 2019-01-14 9:42 ` Tvrtko Ursulin
2019-01-14 9:53 ` [igt-dev] " Chris Wilson
2019-01-14 9:45 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-14 11:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Tvrtko Ursulin @ 2019-01-14 9:42 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
On 14/01/2019 09:16, Chris Wilson wrote:
> Each individual pass is as effective at spotting an error using the
> Chinese whisper as any other, so the effectiveness of adding more passes
> rapidly diminishes. To keep the tests bounded within time, limit a
> subtest to a mere 150s!
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108592
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_exec_whisper.c | 13 +++++++++----
I was wondering what gem_exec_limit was! :)
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/tests/i915/gem_exec_whisper.c b/tests/i915/gem_exec_whisper.c
> index 81303f847..d2ee98399 100644
> --- a/tests/i915/gem_exec_whisper.c
> +++ b/tests/i915/gem_exec_whisper.c
> @@ -189,12 +189,12 @@ static void whisper(int fd, unsigned engine, unsigned flags)
> unsigned engines[16];
> unsigned nengine;
> uint32_t batch[16];
> - int i, n, pass, loc;
> unsigned int relocations = 0;
> unsigned int reloc_migrations = 0;
> unsigned int reloc_interruptions = 0;
> unsigned int eb_migrations = 0;
> uint64_t old_offset;
> + int i, n, loc;
> int debugfs;
>
> if (flags & PRIORITY) {
> @@ -323,7 +323,9 @@ static void whisper(int fd, unsigned engine, unsigned flags)
> }
>
> igt_while_interruptible(flags & INTERRUPTIBLE) {
> - for (pass = 0; pass < 1024; pass++) {
> + unsigned int pass = 0;
> +
> + igt_until_timeout(150) {
> uint64_t offset;
>
> if (!(flags & FORKED))
> @@ -384,10 +386,10 @@ static void whisper(int fd, unsigned engine, unsigned flags)
> handle[1] = batches[n].handle;
> batches[n-1].handle =
> gem_open(this_fd,
> - gem_flink(fd, handle[0]));
> + gem_flink(fd, handle[0]));
> batches[n].handle =
> gem_open(this_fd,
> - gem_flink(fd, handle[1]));
> + gem_flink(fd, handle[1]));
> if (flags & PRIORITY)
> ctx_set_random_priority(this_fd, 0);
> }
> @@ -462,6 +464,9 @@ static void whisper(int fd, unsigned engine, unsigned flags)
>
> store = tmp[1];
> scratch = tmp[0];
> +
> + if (++pass == 1024)
> + break;
> }
> }
> igt_info("Number of migrations for execbuf: %d\n", eb_migrations);
Log number of passes while at it?
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_exec_limit: Limit to a maximum of 120s
2019-01-14 9:16 [igt-dev] [PATCH i-g-t] i915/gem_exec_limit: Limit to a maximum of 120s Chris Wilson
2019-01-14 9:42 ` [Intel-gfx] " Tvrtko Ursulin
@ 2019-01-14 9:45 ` Patchwork
2019-01-14 11:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-01-14 9:45 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_exec_limit: Limit to a maximum of 120s
URL : https://patchwork.freedesktop.org/series/55156/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5413 -> IGTPW_2231
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/55156/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2231 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@i915_selftest@live_evict:
- fi-bsw-kefka: PASS -> DMESG-WARN [fdo#107709]
* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]
#### Possible fixes ####
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: FAIL [fdo#103167] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108915]: https://bugs.freedesktop.org/show_bug.cgi?id=108915
[fdo#109241]: https://bugs.freedesktop.org/show_bug.cgi?id=109241
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
Participating hosts (38 -> 42)
------------------------------
Additional (7): fi-hsw-peppy fi-skl-6260u fi-ilk-650 fi-snb-2520m fi-skl-iommu fi-icl-y fi-skl-6700k2
Missing (3): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan
Build changes
-------------
* IGT: IGT_4765 -> IGTPW_2231
CI_DRM_5413: 9751ba94138d1dfbf427f84c05984d9657ccc356 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2231: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2231/
IGT_4765: fde4dce431bf324939a982017169214e0fa00d4f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2231/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/gem_exec_limit: Limit to a maximum of 120s
2019-01-14 9:42 ` [Intel-gfx] " Tvrtko Ursulin
@ 2019-01-14 9:53 ` Chris Wilson
0 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2019-01-14 9:53 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx; +Cc: igt-dev
Quoting Tvrtko Ursulin (2019-01-14 09:42:55)
>
> On 14/01/2019 09:16, Chris Wilson wrote:
> > +
> > + if (++pass == 1024)
> > + break;
> > }
> > }
> > igt_info("Number of migrations for execbuf: %d\n", eb_migrations);
>
> Log number of passes while at it?
Threw the log inside the while(interruptible) loop, which may be
temporarily confusing, but more likely to be useful :)
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for i915/gem_exec_limit: Limit to a maximum of 120s
2019-01-14 9:16 [igt-dev] [PATCH i-g-t] i915/gem_exec_limit: Limit to a maximum of 120s Chris Wilson
2019-01-14 9:42 ` [Intel-gfx] " Tvrtko Ursulin
2019-01-14 9:45 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-01-14 11:42 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-01-14 11:42 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_exec_limit: Limit to a maximum of 120s
URL : https://patchwork.freedesktop.org/series/55156/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5413_full -> IGTPW_2231_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/55156/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2231_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956] +1
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_color@pipe-c-ctm-max:
- shard-kbl: PASS -> FAIL [fdo#108147]
- shard-apl: PASS -> FAIL [fdo#108147]
* igt@kms_cursor_crc@cursor-128x42-onscreen:
- shard-glk: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-apl: PASS -> FAIL [fdo#103232] +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
- shard-apl: PASS -> FAIL [fdo#103167] +5
- shard-kbl: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: PASS -> FAIL [fdo#103167] +8
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +2
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparant-fb:
- shard-kbl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: PASS -> FAIL [fdo#103166] +7
* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- shard-kbl: PASS -> FAIL [fdo#103166] +1
* igt@kms_properties@connector-properties-legacy:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
* igt@vgem_basic@mmap:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
#### Possible fixes ####
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-glk: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-64x64-random:
- shard-kbl: FAIL [fdo#103232] -> PASS
- shard-apl: FAIL [fdo#103232] -> PASS
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: DMESG-WARN [fdo#103313] -> PASS
* igt@kms_flip@wf_vblank-ts-check:
- shard-apl: DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS +4
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- shard-apl: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-glk: FAIL [fdo#103167] -> PASS +4
- shard-kbl: FAIL [fdo#103167] -> PASS
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: FAIL [fdo#108948] -> PASS
- shard-apl: FAIL [fdo#108948] -> PASS
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: FAIL [fdo#108145] -> PASS
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-glk: FAIL [fdo#108145] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS +1
- shard-kbl: FAIL [fdo#103166] -> PASS
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +1
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: DMESG-FAIL [fdo#108950] -> PASS
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
* igt@pm_rc6_residency@rc6-accuracy:
- shard-kbl: {SKIP} [fdo#109271] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#108950]: https://bugs.freedesktop.org/show_bug.cgi?id=108950
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4765 -> IGTPW_2231
* Piglit: piglit_4509 -> None
CI_DRM_5413: 9751ba94138d1dfbf427f84c05984d9657ccc356 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2231: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2231/
IGT_4765: fde4dce431bf324939a982017169214e0fa00d4f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2231/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-14 11:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-14 9:16 [igt-dev] [PATCH i-g-t] i915/gem_exec_limit: Limit to a maximum of 120s Chris Wilson
2019-01-14 9:42 ` [Intel-gfx] " Tvrtko Ursulin
2019-01-14 9:53 ` [igt-dev] " Chris Wilson
2019-01-14 9:45 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-14 11:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox