* [igt-dev] [PATCH i-g-t] tests/kms_prime: Fix compiler warning @ 2019-09-18 9:59 Mika Kahola 2019-09-18 10:35 ` Petri Latvala 2019-09-18 12:18 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 0 siblings, 2 replies; 4+ messages in thread From: Mika Kahola @ 2019-09-18 9:59 UTC (permalink / raw) To: igt-dev; +Cc: petri.latvala Fix compiler warning about ../tests/kms_prime.c: In function ‘setup_display’: ../tests/kms_prime.c:74:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] igt_output_t *output = igt_get_single_output_for_pipe(display, pipe); Signed-off-by: Mika Kahola <mika.kahola@intel.com> --- tests/kms_prime.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/kms_prime.c b/tests/kms_prime.c index 17599573..3241c514 100644 --- a/tests/kms_prime.c +++ b/tests/kms_prime.c @@ -69,9 +69,11 @@ static bool has_prime_export(int fd) static igt_output_t *setup_display(int importer_fd, igt_display_t *display, enum pipe pipe) { + igt_output_t *output; + igt_display_require(display, importer_fd); igt_skip_on(pipe >= display->n_pipes); - igt_output_t *output = igt_get_single_output_for_pipe(display, pipe); + output = igt_get_single_output_for_pipe(display, pipe); igt_require_f(output, "No connector found for pipe %s\n", kmstest_pipe_name(pipe)); -- 2.17.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_prime: Fix compiler warning 2019-09-18 9:59 [igt-dev] [PATCH i-g-t] tests/kms_prime: Fix compiler warning Mika Kahola @ 2019-09-18 10:35 ` Petri Latvala 2019-09-23 10:51 ` Kahola, Mika 2019-09-18 12:18 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 1 sibling, 1 reply; 4+ messages in thread From: Petri Latvala @ 2019-09-18 10:35 UTC (permalink / raw) To: Mika Kahola; +Cc: igt-dev On Wed, Sep 18, 2019 at 12:59:19PM +0300, Mika Kahola wrote: > Fix compiler warning about > > ../tests/kms_prime.c: In function ‘setup_display’: > ../tests/kms_prime.c:74:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] > igt_output_t *output = igt_get_single_output_for_pipe(display, pipe); > > Signed-off-by: Mika Kahola <mika.kahola@intel.com> Reviewed-by: Petri Latvala <petri.latvala@intel.com> > --- > tests/kms_prime.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/kms_prime.c b/tests/kms_prime.c > index 17599573..3241c514 100644 > --- a/tests/kms_prime.c > +++ b/tests/kms_prime.c > @@ -69,9 +69,11 @@ static bool has_prime_export(int fd) > static igt_output_t *setup_display(int importer_fd, igt_display_t *display, > enum pipe pipe) > { > + igt_output_t *output; > + > igt_display_require(display, importer_fd); > igt_skip_on(pipe >= display->n_pipes); > - igt_output_t *output = igt_get_single_output_for_pipe(display, pipe); > + output = igt_get_single_output_for_pipe(display, pipe); > > igt_require_f(output, "No connector found for pipe %s\n", > kmstest_pipe_name(pipe)); > -- > 2.17.1 > > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_prime: Fix compiler warning 2019-09-18 10:35 ` Petri Latvala @ 2019-09-23 10:51 ` Kahola, Mika 0 siblings, 0 replies; 4+ messages in thread From: Kahola, Mika @ 2019-09-23 10:51 UTC (permalink / raw) To: Latvala, Petri; +Cc: igt-dev@lists.freedesktop.org Pushed. Thanks for the review! On Wed, 2019-09-18 at 13:35 +0300, Petri Latvala wrote: > On Wed, Sep 18, 2019 at 12:59:19PM +0300, Mika Kahola wrote: > > Fix compiler warning about > > > > ../tests/kms_prime.c: In function ‘setup_display’: > > ../tests/kms_prime.c:74:2: warning: ISO C90 forbids mixed > > declarations and code [-Wdeclaration-after-statement] > > igt_output_t *output = igt_get_single_output_for_pipe(display, > > pipe); > > > > Signed-off-by: Mika Kahola <mika.kahola@intel.com> > > Reviewed-by: Petri Latvala <petri.latvala@intel.com> > > > > --- > > tests/kms_prime.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/tests/kms_prime.c b/tests/kms_prime.c > > index 17599573..3241c514 100644 > > --- a/tests/kms_prime.c > > +++ b/tests/kms_prime.c > > @@ -69,9 +69,11 @@ static bool has_prime_export(int fd) > > static igt_output_t *setup_display(int importer_fd, igt_display_t > > *display, > > enum pipe pipe) > > { > > + igt_output_t *output; > > + > > igt_display_require(display, importer_fd); > > igt_skip_on(pipe >= display->n_pipes); > > - igt_output_t *output = igt_get_single_output_for_pipe(display, > > pipe); > > + output = igt_get_single_output_for_pipe(display, pipe); > > > > igt_require_f(output, "No connector found for pipe %s\n", > > kmstest_pipe_name(pipe)); > > -- > > 2.17.1 > > > > _______________________________________________ > > igt-dev mailing list > > igt-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/igt-dev _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_prime: Fix compiler warning 2019-09-18 9:59 [igt-dev] [PATCH i-g-t] tests/kms_prime: Fix compiler warning Mika Kahola 2019-09-18 10:35 ` Petri Latvala @ 2019-09-18 12:18 ` Patchwork 1 sibling, 0 replies; 4+ messages in thread From: Patchwork @ 2019-09-18 12:18 UTC (permalink / raw) To: Mika Kahola; +Cc: igt-dev == Series Details == Series: tests/kms_prime: Fix compiler warning URL : https://patchwork.freedesktop.org/series/66852/ State : success == Summary == CI Bug Log - changes from CI_DRM_6915 -> IGTPW_3474 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/66852/revisions/1/mbox/ Known issues ------------ Here are the changes found in IGTPW_3474 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_module_load@reload: - fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724] / [fdo#111214]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6915/fi-icl-u3/igt@i915_module_load@reload.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3474/fi-icl-u3/igt@i915_module_load@reload.html * igt@i915_selftest@live_gem_contexts: - fi-cfl-guc: [PASS][3] -> [INCOMPLETE][4] ([fdo#106070] / [fdo#111700]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6915/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3474/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html * igt@i915_selftest@live_hugepages: - fi-snb-2600: [PASS][5] -> [INCOMPLETE][6] ([fdo#105411]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6915/fi-snb-2600/igt@i915_selftest@live_hugepages.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3474/fi-snb-2600/igt@i915_selftest@live_hugepages.html * igt@kms_prop_blob@basic: - fi-icl-u3: [PASS][7] -> [DMESG-WARN][8] ([fdo#107724]) +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6915/fi-icl-u3/igt@kms_prop_blob@basic.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3474/fi-icl-u3/igt@kms_prop_blob@basic.html #### Possible fixes #### * igt@gem_ctx_create@basic-files: - fi-bxt-dsi: [INCOMPLETE][9] ([fdo#103927]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6915/fi-bxt-dsi/igt@gem_ctx_create@basic-files.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3474/fi-bxt-dsi/igt@gem_ctx_create@basic-files.html * igt@gem_exec_fence@nb-await-default: - {fi-tgl-u}: [FAIL][11] ([fdo#111562] / [fdo#111597]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6915/fi-tgl-u/igt@gem_exec_fence@nb-await-default.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3474/fi-tgl-u/igt@gem_exec_fence@nb-await-default.html * igt@gem_mmap_gtt@basic-write-no-prefault: - fi-icl-u3: [DMESG-WARN][13] ([fdo#107724]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6915/fi-icl-u3/igt@gem_mmap_gtt@basic-write-no-prefault.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3474/fi-icl-u3/igt@gem_mmap_gtt@basic-write-no-prefault.html #### Warnings #### * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [FAIL][15] ([fdo#111096]) -> [FAIL][16] ([fdo#111407]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6915/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3474/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411 [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602 [fdo#106070]: https://bugs.freedesktop.org/show_bug.cgi?id=106070 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566 [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045 [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096 [fdo#111214]: https://bugs.freedesktop.org/show_bug.cgi?id=111214 [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407 [fdo#111562]: https://bugs.freedesktop.org/show_bug.cgi?id=111562 [fdo#111597]: https://bugs.freedesktop.org/show_bug.cgi?id=111597 [fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600 [fdo#111700]: https://bugs.freedesktop.org/show_bug.cgi?id=111700 Participating hosts (56 -> 48) ------------------------------ Missing (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-icl-u2 fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5190 -> IGTPW_3474 CI-20190529: 20190529 CI_DRM_6915: c72f7d5ea4386172247558b74c1f8012b35800b7 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_3474: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3474/ IGT_5190: 0e9510b83502af3e230870df2d66d4f68918d3a4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3474/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-23 10:51 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-09-18 9:59 [igt-dev] [PATCH i-g-t] tests/kms_prime: Fix compiler warning Mika Kahola 2019-09-18 10:35 ` Petri Latvala 2019-09-23 10:51 ` Kahola, Mika 2019-09-18 12:18 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox