[igt-dev] [PATCH i-g-t] lib/igt_draw: Only skip when width/x is not a multiple of 2.

[igt-dev] [PATCH i-g-t] lib/igt_draw: Only skip when width/x is not a multiple of 2.

[Maarten Lankhorst]

Y and height have no such restrictions, since pixel size has no
relation to height.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 lib/igt_draw.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index 05821480bc80..84dd212c1daf 100644
--- a/lib/igt_draw.c
+++ b/lib/igt_draw.c
@@ -581,9 +581,7 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
 	 * smaller bpps you won't succeeed if you need to copy "half" of a 32bpp
 	 * pixel or something similar. */
 	igt_skip_on(rect->x % (32 / buf->bpp) != 0 ||
-		    rect->y % (32 / buf->bpp) != 0 ||
-		    rect->w % (32 / buf->bpp) != 0 ||
-		    rect->h % (32 / buf->bpp) != 0);
+		    rect->w % (32 / buf->bpp) != 0);
 
 	igt_require(gem_get_tiling(fd, buf->handle, &tiling, &swizzle));
 
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_draw: Only skip when width/x is not a multiple of 2.

[Patchwork]

== Series Details ==

Series: lib/igt_draw: Only skip when width/x is not a multiple of 2.
URL   : https://patchwork.freedesktop.org/series/51748/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_5054 -> IGTPW_2016 =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_2016 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2016, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/51748/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_2016:

  === IGT changes ===

    ==== Possible regressions ====

    igt@drv_selftest@live_contexts:
      fi-kbl-7560u:       PASS -> INCOMPLETE

    
    ==== Warnings ====

    igt@drv_selftest@live_contexts:
      fi-icl-u:           DMESG-FAIL (fdo#108569) -> INCOMPLETE

    
== Known issues ==

  Here are the changes found in IGTPW_2016 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_mmap_gtt@basic-copy:
      fi-glk-dsi:         PASS -> INCOMPLETE (k.org#198133, fdo#103359)

    igt@kms_chamelium@dp-edid-read:
      fi-kbl-7500u:       PASS -> WARN (fdo#102672)

    igt@kms_flip@basic-flip-vs-modeset:
      fi-skl-6700hq:      PASS -> DMESG-WARN (fdo#105998) +1

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-byt-clapper:     PASS -> FAIL (fdo#103191, fdo#107362)

    
    ==== Possible fixes ====

    igt@gem_ctx_create@basic-files:
      fi-icl-u2:          DMESG-WARN (fdo#107724) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     FAIL (fdo#103167) -> PASS

    
  fdo#102672 https://bugs.freedesktop.org/show_bug.cgi?id=102672
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
  fdo#108569 https://bugs.freedesktop.org/show_bug.cgi?id=108569
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (46 -> 44) ==

  Additional (2): fi-skl-iommu fi-pnv-d510 
  Missing    (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4699 -> IGTPW_2016

  CI_DRM_5054: dfa9e5c2b4b958e77c1109477b94c5c8615e25cc @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2016: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2016/
  IGT_4699: 1270ec553741ac20c45178d2b26f9a9562ea565f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2016/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/igt_draw: Only skip when width/x is not a multiple of 2.

[Ville Syrjälä]

On Tue, Oct 30, 2018 at 12:26:46PM +0100, Maarten Lankhorst wrote:
> Y and height have no such restrictions, since pixel size has no
> relation to height.
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  lib/igt_draw.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/lib/igt_draw.c b/lib/igt_draw.c
> index 05821480bc80..84dd212c1daf 100644
> --- a/lib/igt_draw.c
> +++ b/lib/igt_draw.c
> @@ -581,9 +581,7 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
>  	 * smaller bpps you won't succeeed if you need to copy "half" of a 32bpp
>  	 * pixel or something similar. */
>  	igt_skip_on(rect->x % (32 / buf->bpp) != 0 ||
> -		    rect->y % (32 / buf->bpp) != 0 ||
> -		    rect->w % (32 / buf->bpp) != 0 ||
> -		    rect->h % (32 / buf->bpp) != 0);
> +		    rect->w % (32 / buf->bpp) != 0);

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Adding 16bpp support to rendercopy shouldn't be too hard...

>  
>  	igt_require(gem_get_tiling(fd, buf->handle, &tiling, &swizzle));
>  
> -- 
> 2.19.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/igt_draw: Only skip when width/x is not a multiple of 2.

[Maarten Lankhorst]

Op 30-10-18 om 14:34 schreef Ville Syrjälä:
> On Tue, Oct 30, 2018 at 12:26:46PM +0100, Maarten Lankhorst wrote:
>> Y and height have no such restrictions, since pixel size has no
>> relation to height.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> ---
>>  lib/igt_draw.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/lib/igt_draw.c b/lib/igt_draw.c
>> index 05821480bc80..84dd212c1daf 100644
>> --- a/lib/igt_draw.c
>> +++ b/lib/igt_draw.c
>> @@ -581,9 +581,7 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
>>  	 * smaller bpps you won't succeeed if you need to copy "half" of a 32bpp
>>  	 * pixel or something similar. */
>>  	igt_skip_on(rect->x % (32 / buf->bpp) != 0 ||
>> -		    rect->y % (32 / buf->bpp) != 0 ||
>> -		    rect->w % (32 / buf->bpp) != 0 ||
>> -		    rect->h % (32 / buf->bpp) != 0);
>> +		    rect->w % (32 / buf->bpp) != 0);
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Adding 16bpp support to rendercopy shouldn't be too hard...


Thanks, pushed. Will take a look at how to add it to rendercopy.

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev