public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	igt-dev@lists.freedesktop.org, Intel-gfx@lists.freedesktop.org,
	Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 1/4] intel_gpu_top: Fix man page formatting
Date: Thu, 26 Jan 2023 16:09:29 +0000	[thread overview]
Message-ID: <e3b0efd8-7e4a-9bdf-4725-128c4637e806@linux.intel.com> (raw)
In-Reply-To: <20230126153938.3iotcb52eawnwbcl@kamilkon-desk1>


On 26/01/2023 15:39, Kamil Konieczny wrote:
> On 2023-01-12 at 17:47:27 +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> New lines are not respected when rst2man generates the page so try to work
>> around that by followin advice from the Internet.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Thanks! Later I noticed there is one more thing which currently renders 
badly, this line:

   -o <file path | ->

Are you okay with re-review if I can fix that one too and respin?

Regards,

Tvrtko

>> ---
>>   man/intel_gpu_top.rst | 15 ++++++++-------
>>   1 file changed, 8 insertions(+), 7 deletions(-)
>>
>> diff --git a/man/intel_gpu_top.rst b/man/intel_gpu_top.rst
>> index 748c7740c800..b0c95446a011 100644
>> --- a/man/intel_gpu_top.rst
>> +++ b/man/intel_gpu_top.rst
>> @@ -53,13 +53,14 @@ RUNTIME CONTROL
>>   
>>   Supported keys:
>>   
>> -    'q'    Exit from the tool.
>> -    'h'    Show interactive help.
>> -    '1'    Toggle between aggregated engine class and physical engine mode.
>> -    'n'    Toggle display of numeric client busyness overlay.
>> -    's'    Toggle between sort modes (runtime, total runtime, pid, client id).
>> -    'i'    Toggle display of clients which used no GPU time.
>> -    'H'    Toggle between per PID aggregation and individual clients.
>> +|
>> +|    'q'    Exit from the tool.
>> +|    'h'    Show interactive help.
>> +|    '1'    Toggle between aggregated engine class and physical engine mode.
>> +|    'n'    Toggle display of numeric client busyness overlay.
>> +|    's'    Toggle between sort modes (runtime, total runtime, pid, client id).
>> +|    'i'    Toggle display of clients which used no GPU time.
>> +|    'H'    Toggle between per PID aggregation and individual clients.
>>   
>>   DEVICE SELECTION
>>   ================
>> -- 
>> 2.34.1
>>

  reply	other threads:[~2023-01-26 16:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12 17:47 [igt-dev] [PATCH i-g-t 0/4] Some intel_gpu_top tweaks Tvrtko Ursulin
2023-01-12 17:47 ` [igt-dev] [PATCH i-g-t 1/4] intel_gpu_top: Fix man page formatting Tvrtko Ursulin
2023-01-26 15:39   ` Kamil Konieczny
2023-01-26 16:09     ` Tvrtko Ursulin [this message]
2023-01-26 17:08       ` Kamil Konieczny
2023-01-12 17:47 ` [igt-dev] [PATCH i-g-t 2/4] intel_gpu_top: Automatically enclose JSON output into brackets Tvrtko Ursulin
2023-01-26 15:41   ` [igt-dev] [Intel-gfx] " Kamil Konieczny
2023-01-26 16:10     ` Tvrtko Ursulin
2023-01-12 17:47 ` [igt-dev] [PATCH i-g-t 3/4] intel_gpu_top: Add command line switch to start in physical engine mode Tvrtko Ursulin
2023-01-26 15:48   ` [igt-dev] [Intel-gfx] " Kamil Konieczny
2023-01-12 17:47 ` [igt-dev] [PATCH i-g-t 4/4] intel_gpu_top: Aggregate engine classes in all output modes Tvrtko Ursulin
2023-01-26 15:50   ` [igt-dev] [Intel-gfx] " Kamil Konieczny
2023-01-26 16:12     ` Tvrtko Ursulin
2023-01-12 18:34 ` [igt-dev] ✓ Fi.CI.BAT: success for Some intel_gpu_top tweaks Patchwork
2023-01-13  7:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-01-26 15:53 ` [igt-dev] [Intel-gfx] [PATCH i-g-t 0/4] " Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3b0efd8-7e4a-9bdf-4725-128c4637e806@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=tvrtko.ursulin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox