Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 4/4] intel_gpu_top: Aggregate engine classes in all output modes

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 26/01/2023 15:50, Kamil Konieczny wrote:
> On 2023-01-12 at 17:47:30 +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Use the same default for stdout and JSON output modes as it is for
>> interactive.
>>
>> Previously added command line switch can be used to go back to showing all
>> physical engines.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
> 
> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Downside with this one is that the default output for -l and -J modes 
will change. Which may result in bug reports. I am undecided on 
balance.. should have tagged it as RFC really. Thoughts?

Regards,

Tvrtko

>> ---
>>   tools/intel_gpu_top.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
>> index e91b47baf72b..7aa233570463 100644
>> --- a/tools/intel_gpu_top.c
>> +++ b/tools/intel_gpu_top.c
>> @@ -2509,11 +2509,12 @@ int main(int argc, char **argv)
>>   	if (signal(SIGINT, sigint_handler) == SIG_ERR)
>>   		fprintf(stderr, "Failed to install signal handler!\n");
>>   
>> +	class_view = !physical_engines;
>> +
>>   	switch (output_mode) {
>>   	case INTERACTIVE:
>>   		pops = &term_pops;
>>   		interactive_stdin();
>> -		class_view = !physical_engines;
>>   		break;
>>   	case STDOUT:
>>   		pops = &stdout_pops;
>> -- 
>> 2.34.1
>>