public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Souza, Jose" <jose.souza@intel.com>
To: "Latvala, Petri" <petri.latvala@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
	"Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>,
	"Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t v3 1/2] tests/intel-ci: Add basic PSR2 tests to fast feedback test list
Date: Wed, 23 Jan 2019 23:59:56 +0000	[thread overview]
Message-ID: <e64f3111c4040ba97d3f69bdb8ab16031c4bd8c3.camel@intel.com> (raw)
In-Reply-To: <642db4b96db1775294d30cb45f08f4bae4b6a637.camel@intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 2288 bytes --]

On Wed, 2019-01-23 at 21:00 +0000, Souza, Jose wrote:
> On Wed, 2019-01-23 at 13:37 +0200, Petri Latvala wrote:
> > On Tue, Jan 22, 2019 at 05:09:49PM -0800, José Roberto de Souza
> > wrote:
> > > Lets run the same PSR1 basic tests for PSR2 to caught PSR2
> > > regressions faster.
> > > 
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > ---
> > >  tests/intel-ci/fast-feedback.testlist | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-
> > > ci/fast-feedback.testlist
> > > index da3c4c8e..e48cb8a5 100644
> > > --- a/tests/intel-ci/fast-feedback.testlist
> > > +++ b/tests/intel-ci/fast-feedback.testlist
> > > @@ -227,6 +227,10 @@ igt@kms_psr@primary_page_flip
> > >  igt@kms_psr@cursor_plane_move
> > >  igt@kms_psr@sprite_plane_onoff
> > >  igt@kms_psr@primary_mmap_gtt
> > > +igt@kms_psr@psr2_primary_page_flip
> > > +igt@kms_psr@psr2_cursor_plane_move
> > > +igt@kms_psr@psr2_sprite_plane_onoff
> > > +igt@kms_psr@psr2_primary_mmap_gtt
> > 
> > The BAT results mail said success because these are new tests, but
> > do
> > note that they failed. They must pass to get onto the BAT list.
> > 
> > 
> 
> <7>[   91.805388] [drm:intel_psr_compute_config [i915]] PSR2 not
> enabled, resolution 3840x2160 > max supported 3640x2304
> 
> It failed because the GEN9 PSR2 HW only supports resolutions up to
> 3640x2304, so it switched back go PSR1 and the test failed because it
> was expecting a PSR2 state not a PSR1.
> 
> I talked with DK, he thinks that the panel should be replaced in that
> machine so we can have some PSR2 test coverage in GEN9.
> 
> If not possible we should add more code in igt_fixture() to check if
> PSR2 is supported but that could potentially hide PSR2 issues behind
> tests skipped or whitelist PSR2 tests in fi-whl-u.

Bypassed with: https://patchwork.freedesktop.org/patch/279874/

Let me know what you guys think about this.

> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

      reply	other threads:[~2019-01-23 23:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23  1:09 [igt-dev] [PATCH i-g-t v3 1/2] tests/intel-ci: Add basic PSR2 tests to fast feedback test list José Roberto de Souza
2019-01-23  1:09 ` [igt-dev] [PATCH i-g-t v3 2/2] test: Add PSR2 selective update tests José Roberto de Souza
2019-01-23  5:30   ` Dhinakaran Pandiyan
2019-01-23 22:41     ` Souza, Jose
2019-01-23  2:03 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/2] tests/intel-ci: Add basic PSR2 tests to fast feedback test list Patchwork
2019-01-23  6:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-01-23 11:37 ` [igt-dev] [PATCH i-g-t v3 1/2] " Petri Latvala
2019-01-23 12:07   ` Daniel Vetter
2019-01-23 16:45     ` Rodrigo Vivi
2019-01-23 16:51       ` Daniel Vetter
2019-01-23 17:17         ` Rodrigo Vivi
2019-01-23 19:29           ` Dhinakaran Pandiyan
2019-01-24 12:55           ` Daniel Vetter
2019-01-24 22:11             ` Rodrigo Vivi
2019-01-25  9:45               ` Daniel Vetter
2019-01-25 11:03                 ` Martin Peres
2019-01-25 11:27                   ` Tomi Sarvela
2019-01-23 21:00   ` Souza, Jose
2019-01-23 23:59     ` Souza, Jose [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e64f3111c4040ba97d3f69bdb8ab16031c4bd8c3.camel@intel.com \
    --to=jose.souza@intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox