* [igt-dev] [PATCH 1/1] lib/vfs_file_max(): initialize static variable
@ 2019-04-16 13:57 Caz Yokoyama
2019-04-16 14:30 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/1] " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Caz Yokoyama @ 2019-04-16 13:57 UTC (permalink / raw)
To: igt-dev
I believe un-initialized static variable is most probably not zero.
Correct me if I am wrong.
Signed-off-by: Caz Yokoyama <caz.yokoyama@intel.com>
---
lib/intel_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/intel_os.c b/lib/intel_os.c
index dd93bea1..a4fe6b34 100644
--- a/lib/intel_os.c
+++ b/lib/intel_os.c
@@ -281,7 +281,7 @@ void *intel_get_total_pinnable_mem(size_t *total)
static uint64_t vfs_file_max(void)
{
- static long long unsigned max;
+ static long long unsigned max = 0;
if (max == 0) {
FILE *file = fopen("/proc/sys/fs/file-max", "r");
max = 80000;
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/1] lib/vfs_file_max(): initialize static variable
2019-04-16 13:57 [igt-dev] [PATCH 1/1] lib/vfs_file_max(): initialize static variable Caz Yokoyama
@ 2019-04-16 14:30 ` Patchwork
2019-04-16 15:55 ` [igt-dev] [PATCH 1/1] " Caz Yokoyama
2019-04-16 20:25 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [1/1] " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-04-16 14:30 UTC (permalink / raw)
To: Caz Yokoyama; +Cc: igt-dev
== Series Details ==
Series: series starting with [1/1] lib/vfs_file_max(): initialize static variable
URL : https://patchwork.freedesktop.org/series/59583/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5938 -> IGTPW_2867
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59583/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2867 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> SKIP [fdo#109271] +38
* igt@amdgpu/amd_cs_nop@fork-compute0:
- fi-icl-y: NOTRUN -> SKIP [fdo#109315] +17
* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109315] +17
* igt@gem_exec_basic@basic-bsd2:
- fi-icl-y: NOTRUN -> SKIP [fdo#109276] +7
* igt@gem_exec_basic@gtt-bsd1:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109276] +7
* igt@gem_exec_parse@basic-rejected:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109289] +1
- fi-icl-y: NOTRUN -> SKIP [fdo#109289] +1
* igt@kms_chamelium@dp-crc-fast:
- fi-icl-y: NOTRUN -> SKIP [fdo#109284] +8
* igt@kms_chamelium@hdmi-edid-read:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109284] +8
* igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size:
- fi-glk-dsi: PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]
* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-y: NOTRUN -> SKIP [fdo#109285] +3
* igt@kms_force_connector_basic@prune-stale-modes:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109285] +3
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] +1
* igt@kms_psr@cursor_plane_move:
- fi-skl-6260u: NOTRUN -> SKIP [fdo#109271] +37
* igt@kms_psr@primary_mmap_gtt:
- fi-icl-y: NOTRUN -> SKIP [fdo#110189] +3
* igt@prime_vgem@basic-fence-flip:
- fi-icl-y: NOTRUN -> SKIP [fdo#109294]
#### Possible fixes ####
* igt@i915_selftest@live_contexts:
- fi-skl-gvtdvm: DMESG-FAIL [fdo#110235 ] -> PASS
* igt@i915_selftest@live_execlists:
- fi-apl-guc: INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: FAIL [fdo#103167] -> PASS
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (47 -> 44)
------------------------------
Additional (3): fi-icl-y fi-bdw-5557u fi-skl-6260u
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4951 -> IGTPW_2867
CI_DRM_5938: 61a332623362ea87cdde81115229b1b955335654 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2867: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2867/
IGT_4951: cc9a60c029432b5843724e4f2c57f9f815f7adbb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2867/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH 1/1] lib/vfs_file_max(): initialize static variable
2019-04-16 13:57 [igt-dev] [PATCH 1/1] lib/vfs_file_max(): initialize static variable Caz Yokoyama
2019-04-16 14:30 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/1] " Patchwork
@ 2019-04-16 15:55 ` Caz Yokoyama
2019-04-16 20:25 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [1/1] " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Caz Yokoyama @ 2019-04-16 15:55 UTC (permalink / raw)
To: igt-dev
Drop.
Static is always initialized to 0, no need to explicitly initialize.
Thank you, Ashutosh.
-caz
On Tue, 2019-04-16 at 06:57 -0700, Caz Yokoyama wrote:
> I believe un-initialized static variable is most probably not zero.
> Correct me if I am wrong.
>
> Signed-off-by: Caz Yokoyama <caz.yokoyama@intel.com>
> ---
> lib/intel_os.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/intel_os.c b/lib/intel_os.c
> index dd93bea1..a4fe6b34 100644
> --- a/lib/intel_os.c
> +++ b/lib/intel_os.c
> @@ -281,7 +281,7 @@ void *intel_get_total_pinnable_mem(size_t *total)
>
> static uint64_t vfs_file_max(void)
> {
> - static long long unsigned max;
> + static long long unsigned max = 0;
> if (max == 0) {
> FILE *file = fopen("/proc/sys/fs/file-max", "r");
> max = 80000;
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [1/1] lib/vfs_file_max(): initialize static variable
2019-04-16 13:57 [igt-dev] [PATCH 1/1] lib/vfs_file_max(): initialize static variable Caz Yokoyama
2019-04-16 14:30 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/1] " Patchwork
2019-04-16 15:55 ` [igt-dev] [PATCH 1/1] " Caz Yokoyama
@ 2019-04-16 20:25 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-04-16 20:25 UTC (permalink / raw)
To: Caz Yokoyama; +Cc: igt-dev
== Series Details ==
Series: series starting with [1/1] lib/vfs_file_max(): initialize static variable
URL : https://patchwork.freedesktop.org/series/59583/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5938_full -> IGTPW_2867_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59583/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2867_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_parallel@bsd2-fds:
- shard-iclb: NOTRUN -> SKIP [fdo#109276] +12
* igt@gem_softpin@noreloc-s3:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@gem_userptr_blits@coherency-sync:
- shard-iclb: NOTRUN -> SKIP [fdo#109290]
* igt@i915_pm_lpsp@edp-native:
- shard-iclb: NOTRUN -> SKIP [fdo#109301]
* igt@kms_atomic_transition@3x-modeset-transitions-nonblocking-fencing:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_atomic_transition@6x-modeset-transitions:
- shard-iclb: NOTRUN -> SKIP [fdo#109278] +11
* igt@kms_chamelium@hdmi-crc-planes-random:
- shard-iclb: NOTRUN -> SKIP [fdo#109284] +4
* igt@kms_color@pipe-b-degamma:
- shard-iclb: NOTRUN -> FAIL [fdo#104782] +1
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-kbl: PASS -> FAIL [fdo#103232]
- shard-apl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-512x170-onscreen:
- shard-iclb: NOTRUN -> SKIP [fdo#109279]
* igt@kms_cursor_legacy@cursora-vs-flipb-varying-size:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] +10
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: PASS -> FAIL [fdo#102887] / [fdo#105363]
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-kbl: PASS -> DMESG-WARN [fdo#103313]
* igt@kms_force_connector_basic@prune-stale-modes:
- shard-iclb: NOTRUN -> SKIP [fdo#109285]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-gtt:
- shard-iclb: NOTRUN -> SKIP [fdo#109280] +26
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
- shard-iclb: PASS -> FAIL [fdo#103167] +6
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: NOTRUN -> FAIL [fdo#109247] +1
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-iclb: PASS -> FAIL [fdo#109247] +11
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-onoff:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +2
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +38
* igt@kms_lease@page_flip_implicit_plane:
- shard-iclb: NOTRUN -> FAIL [fdo#110281]
* igt@kms_plane_scaling@pipe-b-scaler-with-rotation:
- shard-iclb: NOTRUN -> FAIL [fdo#109052]
* igt@kms_psr2_su@page_flip:
- shard-iclb: PASS -> SKIP [fdo#109642]
* igt@kms_psr@primary_mmap_cpu:
- shard-iclb: PASS -> FAIL [fdo#107383] / [fdo#110215] +1
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: PASS -> SKIP [fdo#109441] +2
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: NOTRUN -> SKIP [fdo#109441] +2
* igt@kms_vblank@pipe-b-wait-idle:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: PASS -> DMESG-WARN [fdo#108566] +3
* igt@kms_vrr@flip-basic:
- shard-iclb: NOTRUN -> SKIP [fdo#109502]
* igt@perf@per-context-mode-unprivileged:
- shard-iclb: NOTRUN -> SKIP [fdo#109289] +1
* igt@prime_nv_pcopy@test3_2:
- shard-iclb: NOTRUN -> SKIP [fdo#109291] +2
* igt@prime_vgem@fence-flip-hang:
- shard-iclb: NOTRUN -> SKIP [fdo#109295]
#### Possible fixes ####
* igt@gem_tiled_swapping@non-threaded:
- shard-snb: FAIL [fdo#108686] -> PASS
* igt@i915_pm_rpm@i2c:
- shard-iclb: DMESG-WARN [fdo#109982] -> PASS
* igt@i915_suspend@debugfs-reader:
- shard-apl: DMESG-WARN [fdo#108566] -> PASS +7
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-iclb: INCOMPLETE -> PASS
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt:
- shard-iclb: FAIL [fdo#109247] -> PASS +12
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: FAIL [fdo#103167] -> PASS +4
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-glk: SKIP [fdo#109271] -> PASS
* igt@kms_plane_scaling@pipe-a-scaler-with-rotation:
- shard-glk: SKIP [fdo#109271] / [fdo#109278] -> PASS
* igt@kms_psr@psr2_dpms:
- shard-iclb: SKIP [fdo#109441] -> PASS +2
* igt@kms_psr@sprite_render:
- shard-iclb: FAIL [fdo#107383] / [fdo#110215] -> PASS +2
* igt@perf@oa-exponents:
- shard-glk: FAIL [fdo#105483] -> PASS
#### Warnings ####
* igt@perf_pmu@most-busy-idle-check-all-vcs1:
- shard-apl: SKIP [fdo#109271] -> INCOMPLETE [fdo#103927]
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105483]: https://bugs.freedesktop.org/show_bug.cgi?id=105483
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109052]: https://bugs.freedesktop.org/show_bug.cgi?id=109052
[fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109301]: https://bugs.freedesktop.org/show_bug.cgi?id=109301
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109502]: https://bugs.freedesktop.org/show_bug.cgi?id=109502
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#109982]: https://bugs.freedesktop.org/show_bug.cgi?id=109982
[fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215
[fdo#110281]: https://bugs.freedesktop.org/show_bug.cgi?id=110281
Participating hosts (10 -> 6)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005
Build changes
-------------
* IGT: IGT_4951 -> IGTPW_2867
* Piglit: piglit_4509 -> None
CI_DRM_5938: 61a332623362ea87cdde81115229b1b955335654 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2867: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2867/
IGT_4951: cc9a60c029432b5843724e4f2c57f9f815f7adbb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2867/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-16 20:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-16 13:57 [igt-dev] [PATCH 1/1] lib/vfs_file_max(): initialize static variable Caz Yokoyama
2019-04-16 14:30 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/1] " Patchwork
2019-04-16 15:55 ` [igt-dev] [PATCH 1/1] " Caz Yokoyama
2019-04-16 20:25 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [1/1] " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox