* [igt-dev] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field
@ 2023-05-15 13:36 Tvrtko Ursulin
2023-05-15 13:36 ` [igt-dev] [PATCH i-g-t 1/2] gputop: Move client name last Tvrtko Ursulin
` (6 more replies)
0 siblings, 7 replies; 12+ messages in thread
From: Tvrtko Ursulin @ 2023-05-15 13:36 UTC (permalink / raw)
To: igt-dev, Intel-gfx; +Cc: Rob Clark, Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Rob,
I thought maybe when you add memory stats the same field order like top(1)
would feel more natural? That is client name comes last and is left justified.
All other stats then come in the middle, between PID and NAME.
DRM minor 0
PID render copy video video-enhance NAME
2704 |▌ || || || | kwin_x11
2734 |▏ || || || | plasmashell
3932 | || || || | krunner
4414 | || || || | xdg-desktop-por
1999477 | || || || | firefox
2162094 | || || || | thunderbir
intel-gpu-top: Intel Alderlake_s (Gen12) @ /dev/dri/card0 - 15/ 15 MHz
99% RC6; 0.01/ 5.46 W; 34 irqs/s
ENGINES BUSY MI_SEMA MI_WAIT
Render/3D 1.31% |▌ | 0% 0%
Blitter 0.00% | | 0% 0%
Video 0.00% | | 0% 0%
VideoEnhance 0.00% | | 0% 0%
PID Render/3D Blitter Video VideoEnhance NAME
2734 |▏ || || || | plasmashell
2704 |▏ || || || | kwin_x11
1837 |▏ || || || | Xorg
3429732 | || || || | kwrite
2162094 | || || || | thunderbird
Cc: Rob Clark <robdclark@chromium.org>
Tvrtko Ursulin (2):
gputop: Move client name last
intel_gpu_top: Move client name last
tools/gputop.c | 19 +++++++++----------
tools/intel_gpu_top.c | 19 +++++++++----------
2 files changed, 18 insertions(+), 20 deletions(-)
--
2.37.2
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] [PATCH i-g-t 1/2] gputop: Move client name last
2023-05-15 13:36 [igt-dev] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field Tvrtko Ursulin
@ 2023-05-15 13:36 ` Tvrtko Ursulin
2023-05-23 10:50 ` [igt-dev] [Intel-gfx] " Kamil Konieczny
2023-05-15 13:36 ` [igt-dev] [PATCH i-g-t 2/2] intel_gpu_top: " Tvrtko Ursulin
` (5 subsequent siblings)
6 siblings, 1 reply; 12+ messages in thread
From: Tvrtko Ursulin @ 2023-05-15 13:36 UTC (permalink / raw)
To: igt-dev, Intel-gfx; +Cc: Rob Clark, Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Move client name to be the right most field which visually aligns better
with top(1) and prepares for inserting memory usage fields somewhere in
the middle.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Rob Clark <robdclark@chromium.org>
---
tools/gputop.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/tools/gputop.c b/tools/gputop.c
index 4fb5ce63e07c..681f0a6bb748 100644
--- a/tools/gputop.c
+++ b/tools/gputop.c
@@ -80,15 +80,15 @@ print_client_header(struct igt_drm_client *c, int lines, int con_w, int con_h,
return lines;
putchar('\n');
- len = printf("%*s %*s ",
- c->clients->max_pid_len, "PID",
- c->clients->max_name_len, "NAME");
+ len = printf("%*s ", c->clients->max_pid_len, "PID");
if (c->engines->num_engines) {
unsigned int i;
int width;
- *engine_w = width = (con_w - len) / c->engines->num_engines;
+ *engine_w = width =
+ (con_w - len - c->clients->max_name_len - 1) /
+ c->engines->num_engines;
for (i = 0; i <= c->engines->max_engine_id; i++) {
const char *name = c->engines->names[i];
@@ -109,8 +109,7 @@ print_client_header(struct igt_drm_client *c, int lines, int con_w, int con_h,
}
}
- n_spaces(con_w - len);
- printf("\033[0m\n");
+ printf(" %-*s\033[0m\n", con_w - len - 1, "NAME");
return lines;
}
@@ -128,6 +127,7 @@ print_client(struct igt_drm_client *c, struct igt_drm_client **prevc,
unsigned int period_us, int *engine_w)
{
unsigned int i;
+ int len;
/* Filter out idle clients. */
if (!c->total_runtime || c->samples < 2)
@@ -142,9 +142,7 @@ print_client(struct igt_drm_client *c, struct igt_drm_client **prevc,
*prevc = c;
- printf("%*s %*s ",
- c->clients->max_pid_len, c->pid_str,
- c->clients->max_name_len, c->print_name);
+ len = printf("%*s ", c->clients->max_pid_len, c->pid_str);
lines++;
for (i = 0; c->samples > 1 && i <= c->engines->max_engine_id; i++) {
@@ -164,9 +162,10 @@ print_client(struct igt_drm_client *c, struct igt_drm_client **prevc,
pct = 100.0;
print_percentage_bar(pct, *engine_w);
+ len += *engine_w;
}
- putchar('\n');
+ printf(" %-*s\n", con_w - len - 1, c->print_name);
return lines;
}
--
2.37.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [igt-dev] [PATCH i-g-t 2/2] intel_gpu_top: Move client name last
2023-05-15 13:36 [igt-dev] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field Tvrtko Ursulin
2023-05-15 13:36 ` [igt-dev] [PATCH i-g-t 1/2] gputop: Move client name last Tvrtko Ursulin
@ 2023-05-15 13:36 ` Tvrtko Ursulin
2023-05-23 10:51 ` [igt-dev] [Intel-gfx] " Kamil Konieczny
2023-05-15 14:14 ` [igt-dev] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field Rob Clark
` (4 subsequent siblings)
6 siblings, 1 reply; 12+ messages in thread
From: Tvrtko Ursulin @ 2023-05-15 13:36 UTC (permalink / raw)
To: igt-dev, Intel-gfx; +Cc: Rob Clark, Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Move client name to be the right most field which visually aligns better
with top(1) and prepares for inserting memory usage fields somewhere in
the middle.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Rob Clark <robdclark@chromium.org>
---
tools/intel_gpu_top.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 453090c298bc..937280a7151a 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -1809,9 +1809,7 @@ print_clients_header(struct igt_drm_clients *clients, int lines,
return lines;
printf("\033[7m");
- len = printf("%*s %*s ",
- clients->max_pid_len, "PID",
- clients->max_name_len, "NAME");
+ len = printf("%*s ", clients->max_pid_len, "PID");
if (lines++ >= con_h || len >= con_w)
return lines;
@@ -1825,7 +1823,9 @@ print_clients_header(struct igt_drm_clients *clients, int lines,
num_active++;
}
- *class_w = width = (con_w - len) / num_active;
+ *class_w = width =
+ (con_w - len - clients->max_name_len - 1) /
+ num_active;
for (i = 0; i <= iclients->classes.max_engine_id; i++) {
const char *name = iclients->classes.names[i];
@@ -1846,8 +1846,7 @@ print_clients_header(struct igt_drm_clients *clients, int lines,
}
}
- n_spaces(con_w - len);
- printf("\033[0m\n");
+ printf(" %-*s\033[0m\n", con_w - len - 1, "NAME");
} else {
if (iclients->classes.num_engines)
pops->open_struct("clients");
@@ -1866,6 +1865,7 @@ print_client(struct igt_drm_client *c, struct engines *engines, double t, int li
struct igt_drm_clients *clients = c->clients;
struct intel_clients *iclients = clients->private_data;
unsigned int i;
+ int len;
if (output_mode == INTERACTIVE) {
if (filter_idle && (!c->total_runtime || c->samples < 2))
@@ -1873,9 +1873,7 @@ print_client(struct igt_drm_client *c, struct engines *engines, double t, int li
lines++;
- printf("%*s %*s ",
- clients->max_pid_len, c->pid_str,
- clients->max_name_len, c->print_name);
+ len = printf("%*s ", clients->max_pid_len, c->pid_str);
for (i = 0;
c->samples > 1 && i <= iclients->classes.max_engine_id;
@@ -1898,9 +1896,10 @@ print_client(struct igt_drm_client *c, struct engines *engines, double t, int li
print_percentage_bar(pct, max, *class_w,
numeric_clients);
+ len += *class_w;
}
- putchar('\n');
+ printf(" %-*s\n", con_w - len - 1, c->print_name);
} else if (output_mode == JSON) {
char buf[64];
--
2.37.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field
2023-05-15 13:36 [igt-dev] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field Tvrtko Ursulin
2023-05-15 13:36 ` [igt-dev] [PATCH i-g-t 1/2] gputop: Move client name last Tvrtko Ursulin
2023-05-15 13:36 ` [igt-dev] [PATCH i-g-t 2/2] intel_gpu_top: " Tvrtko Ursulin
@ 2023-05-15 14:14 ` Rob Clark
2023-05-23 9:36 ` Tvrtko Ursulin
2023-05-15 15:28 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
` (3 subsequent siblings)
6 siblings, 1 reply; 12+ messages in thread
From: Rob Clark @ 2023-05-15 14:14 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev, Intel-gfx, Tvrtko Ursulin
On Mon, May 15, 2023 at 6:36 AM Tvrtko Ursulin
<tvrtko.ursulin@linux.intel.com> wrote:
>
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Rob,
>
> I thought maybe when you add memory stats the same field order like top(1)
> would feel more natural? That is client name comes last and is left justified.
> All other stats then come in the middle, between PID and NAME.
>
> DRM minor 0
> PID render copy video video-enhance NAME
> 2704 |▌ || || || | kwin_x11
> 2734 |▏ || || || | plasmashell
> 3932 | || || || | krunner
> 4414 | || || || | xdg-desktop-por
> 1999477 | || || || | firefox
> 2162094 | || || || | thunderbir
Seems like a good idea, and more in line with top/htop/nvtop
BR,
-R
> intel-gpu-top: Intel Alderlake_s (Gen12) @ /dev/dri/card0 - 15/ 15 MHz
> 99% RC6; 0.01/ 5.46 W; 34 irqs/s
>
> ENGINES BUSY MI_SEMA MI_WAIT
> Render/3D 1.31% |▌ | 0% 0%
> Blitter 0.00% | | 0% 0%
> Video 0.00% | | 0% 0%
> VideoEnhance 0.00% | | 0% 0%
>
> PID Render/3D Blitter Video VideoEnhance NAME
> 2734 |▏ || || || | plasmashell
> 2704 |▏ || || || | kwin_x11
> 1837 |▏ || || || | Xorg
> 3429732 | || || || | kwrite
> 2162094 | || || || | thunderbird
>
> Cc: Rob Clark <robdclark@chromium.org>
>
> Tvrtko Ursulin (2):
> gputop: Move client name last
> intel_gpu_top: Move client name last
>
> tools/gputop.c | 19 +++++++++----------
> tools/intel_gpu_top.c | 19 +++++++++----------
> 2 files changed, 18 insertions(+), 20 deletions(-)
>
> --
> 2.37.2
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] ✗ GitLab.Pipeline: warning for gputop/intel_gpu_top: Move name to be the last field
2023-05-15 13:36 [igt-dev] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field Tvrtko Ursulin
` (2 preceding siblings ...)
2023-05-15 14:14 ` [igt-dev] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field Rob Clark
@ 2023-05-15 15:28 ` Patchwork
2023-05-15 16:01 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
` (2 subsequent siblings)
6 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-05-15 15:28 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
== Series Details ==
Series: gputop/intel_gpu_top: Move name to be the last field
URL : https://patchwork.freedesktop.org/series/117768/
State : warning
== Summary ==
Pipeline status: FAILED.
see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/881545 for the overview.
build:tests-fedora-oldest-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/41747357):
Program igt_doc.py found: YES (/builds/gfx-ci/igt-ci-tags/scripts/igt_doc.py)
Program gen_rst_index skipped: feature sphinx disabled
Native dependency gtk-doc found: YES 1.29
Program generate_description_xml.py found: YES (/builds/gfx-ci/igt-ci-tags/docs/reference/igt-gpu-tools/generate_description_xml.py)
Program generate_programs_xml.sh found: YES (/builds/gfx-ci/igt-ci-tags/docs/reference/igt-gpu-tools/generate_programs_xml.sh)
Configuring version.xml using configuration
Program sphinx-build skipped: feature sphinx disabled
Program rst2html-3 found: NO
Program rst2html found: YES (/usr/bin/rst2html)
Program rst2pdf found: NO
docs/testplan/meson.build:35:1: ERROR: The += operator currently only works with arrays, strings or ints
A full log can be found at /builds/gfx-ci/igt-ci-tags/build/meson-logs/meson-log.txt
section_end:1684164286:step_script
section_start:1684164286:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1684164287:cleanup_file_variables
ERROR: Job failed: exit code 1
== Logs ==
For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/881545
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for gputop/intel_gpu_top: Move name to be the last field
2023-05-15 13:36 [igt-dev] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field Tvrtko Ursulin
` (3 preceding siblings ...)
2023-05-15 15:28 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
@ 2023-05-15 16:01 ` Patchwork
2023-05-15 19:01 ` [igt-dev] ✓ Fi.CI.BAT: success for gputop/intel_gpu_top: Move name to be the last field (rev2) Patchwork
2023-05-16 1:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-05-15 16:01 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 7585 bytes --]
== Series Details ==
Series: gputop/intel_gpu_top: Move name to be the last field
URL : https://patchwork.freedesktop.org/series/117768/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13148 -> IGTPW_8959
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_8959 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_8959, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/index.html
Participating hosts (36 -> 37)
------------------------------
Additional (2): fi-kbl-soraka fi-apl-guc
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8959:
### IGT changes ###
#### Possible regressions ####
* igt@dmabuf@all-tests@dma_fence:
- fi-blb-e6850: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/fi-blb-e6850/igt@dmabuf@all-tests@dma_fence.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/fi-blb-e6850/igt@dmabuf@all-tests@dma_fence.html
* igt@dmabuf@all-tests@sanitycheck:
- fi-blb-e6850: [PASS][3] -> [ABORT][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/fi-blb-e6850/igt@dmabuf@all-tests@sanitycheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/fi-blb-e6850/igt@dmabuf@all-tests@sanitycheck.html
Known issues
------------
Here are the changes found in IGTPW_8959 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-apl-guc: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/fi-apl-guc/igt@gem_lmem_swapping@basic.html
- fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_pm_backlight@basic-brightness@edp-1:
- bat-rplp-1: NOTRUN -> [ABORT][8] ([i915#7077])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/bat-rplp-1/igt@i915_pm_backlight@basic-brightness@edp-1.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][9] ([i915#1886] / [i915#7913])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-rpls-2: NOTRUN -> [ABORT][10] ([i915#6687])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][11] ([fdo#109271]) +14 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_chamelium_hpd@vga-hpd-fast:
- fi-apl-guc: NOTRUN -> [SKIP][12] ([fdo#109271]) +20 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/fi-apl-guc/igt@kms_chamelium_hpd@vga-hpd-fast.html
* igt@kms_psr@primary_mmap_gtt:
- bat-rplp-1: NOTRUN -> [SKIP][13] ([i915#1072])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-rplp-1: NOTRUN -> [SKIP][14] ([i915#3555] / [i915#4579])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
- fi-kbl-soraka: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#4579])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/fi-kbl-soraka/igt@kms_setmode@basic-clone-single-crtc.html
- fi-apl-guc: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#4579])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/fi-apl-guc/igt@kms_setmode@basic-clone-single-crtc.html
#### Possible fixes ####
* igt@i915_selftest@live@reset:
- bat-rpls-2: [ABORT][17] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/bat-rpls-2/igt@i915_selftest@live@reset.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@i915_selftest@live@slpc:
- bat-rpls-1: [DMESG-WARN][19] ([i915#6367] / [i915#7953]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/bat-rpls-1/igt@i915_selftest@live@slpc.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
- bat-dg2-8: [FAIL][21] ([i915#7932]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
#### Warnings ####
* igt@kms_psr@sprite_plane_onoff:
- bat-rplp-1: [ABORT][23] ([i915#8442]) -> [SKIP][24] ([i915#1072])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7953]: https://gitlab.freedesktop.org/drm/intel/issues/7953
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7290 -> IGTPW_8959
CI-20190529: 20190529
CI_DRM_13148: 57a535e042517014a85f33be6fa5ed22145c56e9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8959: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/index.html
IGT_7290: 0261157319fe993ccefaf270b2fc7a8ebef418ae @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8959/index.html
[-- Attachment #2: Type: text/html, Size: 9342 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for gputop/intel_gpu_top: Move name to be the last field (rev2)
2023-05-15 13:36 [igt-dev] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field Tvrtko Ursulin
` (4 preceding siblings ...)
2023-05-15 16:01 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
@ 2023-05-15 19:01 ` Patchwork
2023-05-16 1:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-05-15 19:01 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 7555 bytes --]
== Series Details ==
Series: gputop/intel_gpu_top: Move name to be the last field (rev2)
URL : https://patchwork.freedesktop.org/series/117768/
State : success
== Summary ==
CI Bug Log - changes from IGT_7291 -> IGTPW_8963
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/index.html
Participating hosts (37 -> 36)
------------------------------
Additional (1): bat-mtlp-8
Missing (2): fi-kbl-soraka fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_8963 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@basic-rte:
- bat-adlp-9: [PASS][1] -> [ABORT][2] ([i915#7977])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/bat-adlp-9/igt@i915_pm_rpm@basic-rte.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/bat-adlp-9/igt@i915_pm_rpm@basic-rte.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [PASS][3] -> [DMESG-FAIL][4] ([i915#5334])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@migrate:
- bat-dg2-11: [PASS][5] -> [DMESG-WARN][6] ([i915#7699] / [i915#7953])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/bat-dg2-11/igt@i915_selftest@live@migrate.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/bat-dg2-11/igt@i915_selftest@live@migrate.html
- bat-atsm-1: [PASS][7] -> [DMESG-FAIL][8] ([i915#7699] / [i915#7913])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/bat-atsm-1/igt@i915_selftest@live@migrate.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/bat-atsm-1/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@reset:
- bat-rpls-1: NOTRUN -> [ABORT][9] ([i915#4983] / [i915#7461] / [i915#7953] / [i915#8347] / [i915#8384])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@i915_selftest@live@slpc:
- bat-rpls-2: NOTRUN -> [DMESG-WARN][10] ([i915#6367])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/bat-rpls-2/igt@i915_selftest@live@slpc.html
* igt@kms_pipe_crc_basic@hang-read-crc@pipe-c-dp-1:
- bat-adlp-9: [PASS][11] -> [FAIL][12] ([i915#6818])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/bat-adlp-9/igt@kms_pipe_crc_basic@hang-read-crc@pipe-c-dp-1.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/bat-adlp-9/igt@kms_pipe_crc_basic@hang-read-crc@pipe-c-dp-1.html
* igt@kms_pipe_crc_basic@hang-read-crc@pipe-d-dp-1:
- bat-adlp-9: [PASS][13] -> [FAIL][14] ([i915#7336])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/bat-adlp-9/igt@kms_pipe_crc_basic@hang-read-crc@pipe-d-dp-1.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/bat-adlp-9/igt@kms_pipe_crc_basic@hang-read-crc@pipe-d-dp-1.html
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1:
- bat-dg2-8: [PASS][15] -> [FAIL][16] ([i915#7932])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1.html
#### Possible fixes ####
* igt@i915_selftest@live@mman:
- bat-rpls-2: [TIMEOUT][17] ([i915#6794] / [i915#7392]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/bat-rpls-2/igt@i915_selftest@live@mman.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/bat-rpls-2/igt@i915_selftest@live@mman.html
* igt@i915_selftest@live@requests:
- bat-rpls-1: [ABORT][19] ([i915#7911] / [i915#7920] / [i915#7953]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/bat-rpls-1/igt@i915_selftest@live@requests.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/bat-rpls-1/igt@i915_selftest@live@requests.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
- bat-dg2-8: [FAIL][21] ([i915#7932]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
[i915#6818]: https://gitlab.freedesktop.org/drm/intel/issues/6818
[i915#7336]: https://gitlab.freedesktop.org/drm/intel/issues/7336
[i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7953]: https://gitlab.freedesktop.org/drm/intel/issues/7953
[i915#7977]: https://gitlab.freedesktop.org/drm/intel/issues/7977
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7291 -> IGTPW_8963
CI-20190529: 20190529
CI_DRM_13148: 57a535e042517014a85f33be6fa5ed22145c56e9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8963: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/index.html
IGT_7291: a536bd30aaeb1ab02dc4f37d2d723c37be356d8d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/index.html
[-- Attachment #2: Type: text/html, Size: 7614 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for gputop/intel_gpu_top: Move name to be the last field (rev2)
2023-05-15 13:36 [igt-dev] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field Tvrtko Ursulin
` (5 preceding siblings ...)
2023-05-15 19:01 ` [igt-dev] ✓ Fi.CI.BAT: success for gputop/intel_gpu_top: Move name to be the last field (rev2) Patchwork
@ 2023-05-16 1:23 ` Patchwork
6 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-05-16 1:23 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 17286 bytes --]
== Series Details ==
Series: gputop/intel_gpu_top: Move name to be the last field (rev2)
URL : https://patchwork.freedesktop.org/series/117768/
State : success
== Summary ==
CI Bug Log - changes from IGT_7291_full -> IGTPW_8963_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/index.html
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in IGTPW_8963_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@verify-random-ccs:
- shard-glk: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#4613]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-glk9/igt@gem_lmem_swapping@verify-random-ccs.html
* igt@gem_ppgtt@blt-vs-render-ctxn:
- shard-snb: [PASS][2] -> [DMESG-FAIL][3] ([i915#8295])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/shard-snb5/igt@gem_ppgtt@blt-vs-render-ctxn.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-snb6/igt@gem_ppgtt@blt-vs-render-ctxn.html
* igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs:
- shard-glk: NOTRUN -> [SKIP][4] ([fdo#109271]) +96 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-glk7/igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-glk: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#3323])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-glk8/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gen9_exec_parse@allowed-all:
- shard-apl: [PASS][6] -> [ABORT][7] ([i915#5566])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/shard-apl2/igt@gen9_exec_parse@allowed-all.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-apl4/igt@gen9_exec_parse@allowed-all.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-apl: [PASS][8] -> [DMESG-FAIL][9] ([i915#5334])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/shard-apl2/igt@i915_selftest@live@gt_heartbeat.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-apl2/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#3886]) +4 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-glk7/igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_cursor_crc@cursor-random-max-size:
- shard-glk: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4579]) +7 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-glk1/igt@kms_cursor_crc@cursor-random-max-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [PASS][12] -> [FAIL][13] ([i915#2346]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-vga1:
- shard-snb: [PASS][14] -> [FAIL][15] ([i915#79])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/shard-snb7/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-vga1.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-snb2/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-vga1.html
* igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1:
- shard-glk: [PASS][16] -> [FAIL][17] ([i915#79])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/shard-glk4/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-glk8/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1.html
* igt@kms_plane_alpha_blend@alpha-opaque-fb@pipe-a-hdmi-a-1:
- shard-glk: NOTRUN -> [FAIL][18] ([i915#4573]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-glk4/igt@kms_plane_alpha_blend@alpha-opaque-fb@pipe-a-hdmi-a-1.html
* igt@kms_psr2_su@page_flip-nv12:
- shard-glk: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#658]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-glk5/igt@kms_psr2_su@page_flip-nv12.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-glk: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#533])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-glk5/igt@kms_vblank@pipe-d-wait-idle.html
#### Possible fixes ####
* igt@gem_ctx_freq@sysfs:
- {shard-dg1}: [FAIL][21] ([i915#6786]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/shard-dg1-17/igt@gem_ctx_freq@sysfs.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-dg1-16/igt@gem_ctx_freq@sysfs.html
* igt@gem_eio@hibernate:
- {shard-dg1}: [ABORT][23] ([i915#7975] / [i915#8213]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/shard-dg1-14/igt@gem_eio@hibernate.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-dg1-17/igt@gem_eio@hibernate.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- {shard-rkl}: [FAIL][25] ([i915#2842]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/shard-rkl-1/igt@gem_exec_fair@basic-none-share@rcs0.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-rkl-7/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-tglu}: [FAIL][27] ([i915#2842]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/shard-tglu-4/igt@gem_exec_fair@basic-pace-share@rcs0.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-tglu-8/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][29] ([i915#2842]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/shard-apl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-apl7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_schedule@u-fairslice@vecs0:
- {shard-rkl}: [ABORT][31] -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/shard-rkl-6/igt@gem_exec_schedule@u-fairslice@vecs0.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-rkl-4/igt@gem_exec_schedule@u-fairslice@vecs0.html
* igt@gem_exec_suspend@basic-s0@smem:
- {shard-tglu}: [ABORT][33] ([i915#7953]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/shard-tglu-9/igt@gem_exec_suspend@basic-s0@smem.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-tglu-10/igt@gem_exec_suspend@basic-s0@smem.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- {shard-dg1}: [TIMEOUT][35] ([i915#5493]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/shard-dg1-14/igt@gem_lmem_swapping@smem-oom@lmem0.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-dg1-18/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@i915_pm_dc@dc6-dpms:
- {shard-tglu}: [FAIL][37] ([i915#3989] / [i915#454]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/shard-tglu-3/igt@i915_pm_dc@dc6-dpms.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-tglu-2/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- {shard-rkl}: [SKIP][39] ([i915#1397]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/shard-rkl-3/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-rkl-7/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
* igt@kms_cursor_legacy@forked-move@pipe-b:
- {shard-rkl}: [INCOMPLETE][41] ([i915#8011]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/shard-rkl-7/igt@kms_cursor_legacy@forked-move@pipe-b.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-rkl-3/igt@kms_cursor_legacy@forked-move@pipe-b.html
* igt@perf_pmu@all-busy-idle-check-all:
- {shard-dg1}: [FAIL][43] ([i915#5234]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/shard-dg1-15/igt@perf_pmu@all-busy-idle-check-all.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-dg1-12/igt@perf_pmu@all-busy-idle-check-all.html
* igt@perf_pmu@idle@rcs0:
- {shard-dg1}: [FAIL][45] ([i915#4349]) -> [PASS][46] +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7291/shard-dg1-18/igt@perf_pmu@idle@rcs0.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/shard-dg1-16/igt@perf_pmu@idle@rcs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5234]: https://gitlab.freedesktop.org/drm/intel/issues/5234
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7953]: https://gitlab.freedesktop.org/drm/intel/issues/7953
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8295]: https://gitlab.freedesktop.org/drm/intel/issues/8295
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7291 -> IGTPW_8963
CI-20190529: 20190529
CI_DRM_13148: 57a535e042517014a85f33be6fa5ed22145c56e9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8963: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/index.html
IGT_7291: a536bd30aaeb1ab02dc4f37d2d723c37be356d8d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8963/index.html
[-- Attachment #2: Type: text/html, Size: 13446 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field
2023-05-15 14:14 ` [igt-dev] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field Rob Clark
@ 2023-05-23 9:36 ` Tvrtko Ursulin
0 siblings, 0 replies; 12+ messages in thread
From: Tvrtko Ursulin @ 2023-05-23 9:36 UTC (permalink / raw)
To: Rob Clark; +Cc: igt-dev, Intel-gfx, Tvrtko Ursulin
On 15/05/2023 15:14, Rob Clark wrote:
> On Mon, May 15, 2023 at 6:36 AM Tvrtko Ursulin
> <tvrtko.ursulin@linux.intel.com> wrote:
>>
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Rob,
>>
>> I thought maybe when you add memory stats the same field order like top(1)
>> would feel more natural? That is client name comes last and is left justified.
>> All other stats then come in the middle, between PID and NAME.
>>
>> DRM minor 0
>> PID render copy video video-enhance NAME
>> 2704 |▌ || || || | kwin_x11
>> 2734 |▏ || || || | plasmashell
>> 3932 | || || || | krunner
>> 4414 | || || || | xdg-desktop-por
>> 1999477 | || || || | firefox
>> 2162094 | || || || | thunderbir
>
> Seems like a good idea, and more in line with top/htop/nvtop
A-b/R-b? Or you go ahead with meminfo changes and I can rebase this on
top later. I am okay either way.
Regards,
Tvrtko
> BR,
> -R
>
>> intel-gpu-top: Intel Alderlake_s (Gen12) @ /dev/dri/card0 - 15/ 15 MHz
>> 99% RC6; 0.01/ 5.46 W; 34 irqs/s
>>
>> ENGINES BUSY MI_SEMA MI_WAIT
>> Render/3D 1.31% |▌ | 0% 0%
>> Blitter 0.00% | | 0% 0%
>> Video 0.00% | | 0% 0%
>> VideoEnhance 0.00% | | 0% 0%
>>
>> PID Render/3D Blitter Video VideoEnhance NAME
>> 2734 |▏ || || || | plasmashell
>> 2704 |▏ || || || | kwin_x11
>> 1837 |▏ || || || | Xorg
>> 3429732 | || || || | kwrite
>> 2162094 | || || || | thunderbird
>>
>> Cc: Rob Clark <robdclark@chromium.org>
>>
>> Tvrtko Ursulin (2):
>> gputop: Move client name last
>> intel_gpu_top: Move client name last
>>
>> tools/gputop.c | 19 +++++++++----------
>> tools/intel_gpu_top.c | 19 +++++++++----------
>> 2 files changed, 18 insertions(+), 20 deletions(-)
>>
>> --
>> 2.37.2
>>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 1/2] gputop: Move client name last
2023-05-15 13:36 ` [igt-dev] [PATCH i-g-t 1/2] gputop: Move client name last Tvrtko Ursulin
@ 2023-05-23 10:50 ` Kamil Konieczny
0 siblings, 0 replies; 12+ messages in thread
From: Kamil Konieczny @ 2023-05-23 10:50 UTC (permalink / raw)
To: igt-dev; +Cc: Rob Clark, Intel-gfx
On 2023-05-15 at 14:36:29 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Move client name to be the right most field which visually aligns better
> with top(1) and prepares for inserting memory usage fields somewhere in
> the middle.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Rob Clark <robdclark@chromium.org>
Acked-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
> tools/gputop.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/tools/gputop.c b/tools/gputop.c
> index 4fb5ce63e07c..681f0a6bb748 100644
> --- a/tools/gputop.c
> +++ b/tools/gputop.c
> @@ -80,15 +80,15 @@ print_client_header(struct igt_drm_client *c, int lines, int con_w, int con_h,
> return lines;
>
> putchar('\n');
> - len = printf("%*s %*s ",
> - c->clients->max_pid_len, "PID",
> - c->clients->max_name_len, "NAME");
> + len = printf("%*s ", c->clients->max_pid_len, "PID");
>
> if (c->engines->num_engines) {
> unsigned int i;
> int width;
>
> - *engine_w = width = (con_w - len) / c->engines->num_engines;
> + *engine_w = width =
> + (con_w - len - c->clients->max_name_len - 1) /
> + c->engines->num_engines;
>
> for (i = 0; i <= c->engines->max_engine_id; i++) {
> const char *name = c->engines->names[i];
> @@ -109,8 +109,7 @@ print_client_header(struct igt_drm_client *c, int lines, int con_w, int con_h,
> }
> }
>
> - n_spaces(con_w - len);
> - printf("\033[0m\n");
> + printf(" %-*s\033[0m\n", con_w - len - 1, "NAME");
>
> return lines;
> }
> @@ -128,6 +127,7 @@ print_client(struct igt_drm_client *c, struct igt_drm_client **prevc,
> unsigned int period_us, int *engine_w)
> {
> unsigned int i;
> + int len;
>
> /* Filter out idle clients. */
> if (!c->total_runtime || c->samples < 2)
> @@ -142,9 +142,7 @@ print_client(struct igt_drm_client *c, struct igt_drm_client **prevc,
>
> *prevc = c;
>
> - printf("%*s %*s ",
> - c->clients->max_pid_len, c->pid_str,
> - c->clients->max_name_len, c->print_name);
> + len = printf("%*s ", c->clients->max_pid_len, c->pid_str);
> lines++;
>
> for (i = 0; c->samples > 1 && i <= c->engines->max_engine_id; i++) {
> @@ -164,9 +162,10 @@ print_client(struct igt_drm_client *c, struct igt_drm_client **prevc,
> pct = 100.0;
>
> print_percentage_bar(pct, *engine_w);
> + len += *engine_w;
> }
>
> - putchar('\n');
> + printf(" %-*s\n", con_w - len - 1, c->print_name);
>
> return lines;
> }
> --
> 2.37.2
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 2/2] intel_gpu_top: Move client name last
2023-05-15 13:36 ` [igt-dev] [PATCH i-g-t 2/2] intel_gpu_top: " Tvrtko Ursulin
@ 2023-05-23 10:51 ` Kamil Konieczny
2023-05-24 13:10 ` Tvrtko Ursulin
0 siblings, 1 reply; 12+ messages in thread
From: Kamil Konieczny @ 2023-05-23 10:51 UTC (permalink / raw)
To: igt-dev; +Cc: Rob Clark, Intel-gfx
On 2023-05-15 at 14:36:30 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Move client name to be the right most field which visually aligns better
> with top(1) and prepares for inserting memory usage fields somewhere in
> the middle.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Rob Clark <robdclark@chromium.org>
Acked-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
> tools/intel_gpu_top.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 453090c298bc..937280a7151a 100644
> --- a/tools/intel_gpu_top.c
> +++ b/tools/intel_gpu_top.c
> @@ -1809,9 +1809,7 @@ print_clients_header(struct igt_drm_clients *clients, int lines,
> return lines;
>
> printf("\033[7m");
> - len = printf("%*s %*s ",
> - clients->max_pid_len, "PID",
> - clients->max_name_len, "NAME");
> + len = printf("%*s ", clients->max_pid_len, "PID");
>
> if (lines++ >= con_h || len >= con_w)
> return lines;
> @@ -1825,7 +1823,9 @@ print_clients_header(struct igt_drm_clients *clients, int lines,
> num_active++;
> }
>
> - *class_w = width = (con_w - len) / num_active;
> + *class_w = width =
> + (con_w - len - clients->max_name_len - 1) /
> + num_active;
>
> for (i = 0; i <= iclients->classes.max_engine_id; i++) {
> const char *name = iclients->classes.names[i];
> @@ -1846,8 +1846,7 @@ print_clients_header(struct igt_drm_clients *clients, int lines,
> }
> }
>
> - n_spaces(con_w - len);
> - printf("\033[0m\n");
> + printf(" %-*s\033[0m\n", con_w - len - 1, "NAME");
> } else {
> if (iclients->classes.num_engines)
> pops->open_struct("clients");
> @@ -1866,6 +1865,7 @@ print_client(struct igt_drm_client *c, struct engines *engines, double t, int li
> struct igt_drm_clients *clients = c->clients;
> struct intel_clients *iclients = clients->private_data;
> unsigned int i;
> + int len;
>
> if (output_mode == INTERACTIVE) {
> if (filter_idle && (!c->total_runtime || c->samples < 2))
> @@ -1873,9 +1873,7 @@ print_client(struct igt_drm_client *c, struct engines *engines, double t, int li
>
> lines++;
>
> - printf("%*s %*s ",
> - clients->max_pid_len, c->pid_str,
> - clients->max_name_len, c->print_name);
> + len = printf("%*s ", clients->max_pid_len, c->pid_str);
>
> for (i = 0;
> c->samples > 1 && i <= iclients->classes.max_engine_id;
> @@ -1898,9 +1896,10 @@ print_client(struct igt_drm_client *c, struct engines *engines, double t, int li
>
> print_percentage_bar(pct, max, *class_w,
> numeric_clients);
> + len += *class_w;
> }
>
> - putchar('\n');
> + printf(" %-*s\n", con_w - len - 1, c->print_name);
> } else if (output_mode == JSON) {
> char buf[64];
>
> --
> 2.37.2
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 2/2] intel_gpu_top: Move client name last
2023-05-23 10:51 ` [igt-dev] [Intel-gfx] " Kamil Konieczny
@ 2023-05-24 13:10 ` Tvrtko Ursulin
0 siblings, 0 replies; 12+ messages in thread
From: Tvrtko Ursulin @ 2023-05-24 13:10 UTC (permalink / raw)
To: Kamil Konieczny, igt-dev, Intel-gfx, Rob Clark
On 23/05/2023 11:51, Kamil Konieczny wrote:
> On 2023-05-15 at 14:36:30 +0100, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Move client name to be the right most field which visually aligns better
>> with top(1) and prepares for inserting memory usage fields somewhere in
>> the middle.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: Rob Clark <robdclark@chromium.org>
>
> Acked-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Thanks Kamil, I've pushed this now having seen Rob will need to rebase
his series anyway.
Regards,
Tvrtko
>
>> ---
>> tools/intel_gpu_top.c | 19 +++++++++----------
>> 1 file changed, 9 insertions(+), 10 deletions(-)
>>
>> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
>> index 453090c298bc..937280a7151a 100644
>> --- a/tools/intel_gpu_top.c
>> +++ b/tools/intel_gpu_top.c
>> @@ -1809,9 +1809,7 @@ print_clients_header(struct igt_drm_clients *clients, int lines,
>> return lines;
>>
>> printf("\033[7m");
>> - len = printf("%*s %*s ",
>> - clients->max_pid_len, "PID",
>> - clients->max_name_len, "NAME");
>> + len = printf("%*s ", clients->max_pid_len, "PID");
>>
>> if (lines++ >= con_h || len >= con_w)
>> return lines;
>> @@ -1825,7 +1823,9 @@ print_clients_header(struct igt_drm_clients *clients, int lines,
>> num_active++;
>> }
>>
>> - *class_w = width = (con_w - len) / num_active;
>> + *class_w = width =
>> + (con_w - len - clients->max_name_len - 1) /
>> + num_active;
>>
>> for (i = 0; i <= iclients->classes.max_engine_id; i++) {
>> const char *name = iclients->classes.names[i];
>> @@ -1846,8 +1846,7 @@ print_clients_header(struct igt_drm_clients *clients, int lines,
>> }
>> }
>>
>> - n_spaces(con_w - len);
>> - printf("\033[0m\n");
>> + printf(" %-*s\033[0m\n", con_w - len - 1, "NAME");
>> } else {
>> if (iclients->classes.num_engines)
>> pops->open_struct("clients");
>> @@ -1866,6 +1865,7 @@ print_client(struct igt_drm_client *c, struct engines *engines, double t, int li
>> struct igt_drm_clients *clients = c->clients;
>> struct intel_clients *iclients = clients->private_data;
>> unsigned int i;
>> + int len;
>>
>> if (output_mode == INTERACTIVE) {
>> if (filter_idle && (!c->total_runtime || c->samples < 2))
>> @@ -1873,9 +1873,7 @@ print_client(struct igt_drm_client *c, struct engines *engines, double t, int li
>>
>> lines++;
>>
>> - printf("%*s %*s ",
>> - clients->max_pid_len, c->pid_str,
>> - clients->max_name_len, c->print_name);
>> + len = printf("%*s ", clients->max_pid_len, c->pid_str);
>>
>> for (i = 0;
>> c->samples > 1 && i <= iclients->classes.max_engine_id;
>> @@ -1898,9 +1896,10 @@ print_client(struct igt_drm_client *c, struct engines *engines, double t, int li
>>
>> print_percentage_bar(pct, max, *class_w,
>> numeric_clients);
>> + len += *class_w;
>> }
>>
>> - putchar('\n');
>> + printf(" %-*s\n", con_w - len - 1, c->print_name);
>> } else if (output_mode == JSON) {
>> char buf[64];
>>
>> --
>> 2.37.2
>>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-05-24 13:10 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-15 13:36 [igt-dev] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field Tvrtko Ursulin
2023-05-15 13:36 ` [igt-dev] [PATCH i-g-t 1/2] gputop: Move client name last Tvrtko Ursulin
2023-05-23 10:50 ` [igt-dev] [Intel-gfx] " Kamil Konieczny
2023-05-15 13:36 ` [igt-dev] [PATCH i-g-t 2/2] intel_gpu_top: " Tvrtko Ursulin
2023-05-23 10:51 ` [igt-dev] [Intel-gfx] " Kamil Konieczny
2023-05-24 13:10 ` Tvrtko Ursulin
2023-05-15 14:14 ` [igt-dev] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field Rob Clark
2023-05-23 9:36 ` Tvrtko Ursulin
2023-05-15 15:28 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2023-05-15 16:01 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2023-05-15 19:01 ` [igt-dev] ✓ Fi.CI.BAT: success for gputop/intel_gpu_top: Move name to be the last field (rev2) Patchwork
2023-05-16 1:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox