Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Karthik B S <karthik.b.s@intel.com>
To: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
	<igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [i-g-t] tests/intel/kms_pm_lpsp: Fix test constraint for bigjoiner
Date: Fri, 3 Nov 2023 13:34:45 +0530	[thread overview]
Message-ID: <e770ce76-8ffc-affc-5d02-6fc12d24158f@intel.com> (raw)
In-Reply-To: <20231031110424.4127934-1-bhanuprakash.modem@intel.com>


On 10/31/2023 4:34 PM, Bhanuprakash Modem wrote:
> If there is no Bigjoiner involved, the test constraint returns
> 'false', which causes the test to be skipped. Fix the test
> constraint logic to handle both bigjoiner & non-bigjoiner cases.
>
> Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/9340
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/intel/kms_pm_lpsp.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/intel/kms_pm_lpsp.c b/tests/intel/kms_pm_lpsp.c
> index cb3c3e379..a85e4e795 100644
> --- a/tests/intel/kms_pm_lpsp.c
> +++ b/tests/intel/kms_pm_lpsp.c
> @@ -174,9 +174,11 @@ static bool test_constraint(data_t *data)
>   
>   			return true;
>   		}
> +
> +		return false;
>   	}
>   
> -	return false;
> +	return true;
>   }
>   
>   static void test_lpsp(data_t *data)

      parent reply	other threads:[~2023-11-03  8:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-31 11:04 [igt-dev] [i-g-t] tests/intel/kms_pm_lpsp: Fix test constraint for bigjoiner Bhanuprakash Modem
2023-10-31 12:30 ` [igt-dev] ✓ CI.xeBAT: success for " Patchwork
2023-10-31 12:37 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2023-10-31 17:38 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/intel/kms_pm_lpsp: Fix test constraint for bigjoiner (rev2) Patchwork
2023-10-31 18:36 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-11-02  8:00 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-11-03  8:04 ` Karthik B S [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e770ce76-8ffc-affc-5d02-6fc12d24158f@intel.com \
    --to=karthik.b.s@intel.com \
    --cc=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox