public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] intel-ci: Delegate exhaustive fault-injection to the idle runs
@ 2020-02-04 11:48 Chris Wilson
  2020-02-04 12:53 ` Martin Peres
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Chris Wilson @ 2020-02-04 11:48 UTC (permalink / raw)
  To: igt-dev; +Cc: Tomi Sarvela, Petri Latvala

i915_module_reload/fault-injection is valuable for its exhaustive trawl
through (hopefully) every path that hits i915_probe_error, unfortunately
such thoroughness comes at a cost. On kbl-guc, it takes almost 3minutes,
and on tgl-y takes over 4 minutes, which is unacceptable for BAT, so leave
it to the shards and idle runs to catch unusual errors on module load.

v2: remove blacklisting to allow module-reload in shards.

Tomi prefers not to have to manually create a runlist for the idle-runs,
so let's take a risk by allowing the module-reload within the shards.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Martin Peres <martin.peres@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
---
 tests/intel-ci/blacklist.txt          | 2 +-
 tests/intel-ci/fast-feedback.testlist | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index 723f24457..181c8cd5f 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -12,7 +12,7 @@ igt@drm_mm(@.*)?
 # self-contained tests, leading to random
 # failures in tests run afterwards.
 ###############################################
-igt@i915_module_load(@.*)?
+#igt@i915_module_load(@.*)? # danger, danger; hope for taints!
 igt@i915_pm_rpm@module-reload
 igt@i915_pm_rpm@gem-execbuf-stress-extra-wait
 ###############################################
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 40d273c1d..467e11267 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -172,6 +172,4 @@ igt@vgem_basic@sysfs
 
 igt@vgem_basic@unload
 igt@i915_module_load@reload
-igt@i915_module_load@reload-no-display
-igt@i915_module_load@reload-with-fault-injection
 igt@i915_pm_rpm@module-reload
-- 
2.25.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [igt-dev] [PATCH i-g-t] intel-ci: Delegate exhaustive fault-injection to the idle runs
@ 2019-12-04 17:48 Chris Wilson
  2019-12-05 13:06 ` Petri Latvala
  0 siblings, 1 reply; 7+ messages in thread
From: Chris Wilson @ 2019-12-04 17:48 UTC (permalink / raw)
  To: igt-dev

i915_module_reload/fault-injection is valuable for its exhaustive trawl
through (hopefully) every path that hits i915_probe_error, unfortunately
such thoroughness comes at a cost. On kbl-guc, it takes almost 3minutes,
which is unacceptable for BAT, so leave it to the shards and idle runs
to catch unusual errors on module load.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Martin Peres <martin.peres@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 tests/intel-ci/fast-feedback.testlist | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index d5f13bec2..14507c347 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -200,6 +200,4 @@ igt@vgem_basic@sysfs
 
 igt@vgem_basic@unload
 igt@i915_module_load@reload
-igt@i915_module_load@reload-no-display
-igt@i915_module_load@reload-with-fault-injection
 igt@i915_pm_rpm@module-reload
-- 
2.24.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-02-06 15:21 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-04 11:48 [igt-dev] [PATCH i-g-t] intel-ci: Delegate exhaustive fault-injection to the idle runs Chris Wilson
2020-02-04 12:53 ` Martin Peres
2020-02-04 15:44 ` [igt-dev] ✗ GitLab.Pipeline: warning for intel-ci: Delegate exhaustive fault-injection to the idle runs (rev2) Patchwork
2020-02-04 15:45 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-02-06 15:21 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2019-12-04 17:48 [igt-dev] [PATCH i-g-t] intel-ci: Delegate exhaustive fault-injection to the idle runs Chris Wilson
2019-12-05 13:06 ` Petri Latvala

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox