From: Karthik B S <karthik.b.s@intel.com>
To: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
<igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [i-g-t V3 26/52] tests/kms_plane_multiple: Add support for Bigjoiner
Date: Wed, 14 Sep 2022 10:23:57 +0530 [thread overview]
Message-ID: <e9589218-9fd7-0cf6-ad6f-5fe8c93959c3@intel.com> (raw)
In-Reply-To: <20220909140331.1041095-27-bhanuprakash.modem@intel.com>
On 9/9/2022 7:33 PM, Bhanuprakash Modem wrote:
> This patch will add a check to Skip the subtest if a selected pipe/output
> combo won't support Bigjoiner or 8K mode.
>
> Example:
> * Pipe-D wont support a mode > 5K
> * To use 8K mode on a pipe then consecutive pipe must be available & free.
>
> V2: - Use updated helper name
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
> tests/kms_plane_multiple.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
> index cbe8c189..4ab49624 100644
> --- a/tests/kms_plane_multiple.c
> +++ b/tests/kms_plane_multiple.c
> @@ -102,6 +102,7 @@ get_reference_crc(data_t *data, igt_output_t *output, enum pipe pipe,
> igt_plane_t *primary;
> int ret;
>
> + igt_display_reset(&data->display);
> igt_output_set_pipe(output, pipe);
>
> primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> @@ -289,6 +290,9 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
> bool loop_forever;
> char info[256];
>
> + igt_info("Using (pipe %s + %s) to run the subtest.\n",
> + kmstest_pipe_name(pipe), igt_output_name(output));
> +
> if (opt.iterations == LOOP_FOREVER) {
> loop_forever = true;
> sprintf(info, "forever");
> @@ -374,12 +378,17 @@ static void run_test(data_t *data, uint64_t modifier)
> {
> enum pipe pipe;
> igt_output_t *output;
> + igt_display_t *display = &data->display;
>
> - if (!igt_display_has_format_mod(&data->display, DRM_FORMAT_XRGB8888, modifier))
> + if (!igt_display_has_format_mod(display, DRM_FORMAT_XRGB8888, modifier))
> return;
>
> - for_each_pipe_with_valid_output(&data->display, pipe, output) {
> - igt_display_reset(&data->display);
> + for_each_pipe_with_valid_output(display, pipe, output) {
> + igt_display_reset(display);
> +
> + igt_output_set_pipe(output, pipe);
> + if (!i915_pipe_output_combo_valid(display))
> + continue;
>
> igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
> test_plane_position(data, pipe, output, modifier);
next prev parent reply other threads:[~2022-09-14 4:54 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 14:02 [igt-dev] [i-g-t V3 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 01/52] lib/igt_kms: Add a helper for valid pipe/output constraint Bhanuprakash Modem
2022-09-12 8:54 ` Petri Latvala
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 02/52] lib/igt_kms: Bigjoiner check in max_bpc constraint Bhanuprakash Modem
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 03/52] tests/kms_async_flips: Add support for Bigjoiner Bhanuprakash Modem
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 04/52] tests/kms_atomic: " Bhanuprakash Modem
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 05/52] tests/kms_atomic_interruptible: " Bhanuprakash Modem
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 06/52] tests/kms_atomic_transition: " Bhanuprakash Modem
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 07/52] tests/kms_color_helper: Helper to check Bigjoiner constraint Bhanuprakash Modem
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 08/52] tests/kms_color: Add support for Bigjoiner Bhanuprakash Modem
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 09/52] tests/chamelium/kms_color_chamelium: " Bhanuprakash Modem
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 10/52] tests/kms_concurrent: " Bhanuprakash Modem
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 11/52] tests/kms_content_protection: " Bhanuprakash Modem
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 12/52] tests/kms_cursor_crc: " Bhanuprakash Modem
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 13/52] tests/kms_cursor_edge_walk: " Bhanuprakash Modem
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 14/52] tests/kms_cursor_legacy: " Bhanuprakash Modem
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 15/52] tests/kms_display_modes: " Bhanuprakash Modem
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 16/52] tests/kms_dp_tiled_display: " Bhanuprakash Modem
2022-09-14 4:54 ` Karthik B S
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 17/52] tests/kms_flip_event_leak: " Bhanuprakash Modem
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 18/52] tests/kms_invalid_mode: " Bhanuprakash Modem
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 19/52] tests/kms_lease: " Bhanuprakash Modem
2022-09-09 14:02 ` [igt-dev] [i-g-t V3 20/52] tests/kms_multipipe_modeset: Find the suitable mode instead of using default Bhanuprakash Modem
2022-09-28 8:34 ` Karthik B S
2022-09-28 9:13 ` Modem, Bhanuprakash
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 21/52] tests/kms_pipe_crc_basic: Add support for Bigjoiner Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 22/52] tests/kms_plane: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 23/52] tests/kms_plane_alpha_blend: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 24/52] tests/kms_plane_cursor: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 25/52] tests/kms_plane_lowres: " Bhanuprakash Modem
2022-09-14 4:52 ` Karthik B S
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 26/52] tests/kms_plane_multiple: " Bhanuprakash Modem
2022-09-14 4:53 ` Karthik B S [this message]
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 27/52] tests/kms_plane_scaling: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 28/52] tests/kms_prime: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 29/52] tests/kms_properties: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 30/52] tests/kms_rmfb: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 31/52] tests/kms_rotation_crc: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 32/52] tests/kms_scaling_modes: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 33/52] tests/kms_sequence: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 34/52] tests/kms_universal_plane: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 35/52] tests/kms_vblank: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 36/52] tests/kms_vrr: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 37/52] tests/i915/kms_big_fb: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 38/52] tests/i915/kms_big_joiner: Negative tests " Bhanuprakash Modem
2022-09-21 15:57 ` [igt-dev] [i-g-t V4 " Bhanuprakash Modem
2022-09-23 4:39 ` Karthik B S
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 39/52] tests/i915/kms_busy: Add support " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 40/52] tests/i915/kms_ccs: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 41/52] tests/i915/kms_cdclk: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 42/52] tests/i915/kms_draw_crc: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 43/52] tests/i915/kms_fence_pin_leak: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 44/52] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 45/52] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 46/52] tests/i915/kms_frontbuffer_tracking: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 47/52] tests/i915/kms_mmap_write_crc: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 48/52] tests/i915/kms_psr2_sf: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 49/52] tests/i915/kms_psr2_su: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 50/52] tests/i915/kms_psr: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 51/52] tests/i915/kms_psr_stress_test: " Bhanuprakash Modem
2022-09-09 14:03 ` [igt-dev] [i-g-t V3 52/52] tests/i915/kms_pwrite_crc: " Bhanuprakash Modem
2022-09-09 14:51 ` [igt-dev] ✓ Fi.CI.BAT: success for Add IGT support for Bigjoiner (rev2) Patchwork
2022-09-09 18:11 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-22 12:20 ` [igt-dev] ✗ Fi.CI.BUILD: failure for Add IGT support for Bigjoiner (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9589218-9fd7-0cf6-ad6f-5fe8c93959c3@intel.com \
--to=karthik.b.s@intel.com \
--cc=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox