Re: [igt-dev] [i-g-t] tests/i915/i915_pm_dc: Remove PC8+ dependency from DC9

["Gupta, Anshuman" <anshuman.gupta@intel.com>]

> -----Original Message-----
> From: Vivi, Rodrigo <rodrigo.vivi@intel.com>
> Sent: Monday, July 11, 2022 7:44 PM
> To: igt-dev@lists.freedesktop.org; Srivatsa, Anusha
> <anusha.srivatsa@intel.com>; Gupta, Anshuman <anshuman.gupta@intel.com>
> Subject: Re: [igt-dev] [i-g-t] tests/i915/i915_pm_dc: Remove PC8+ dependency
> from DC9
> 
> On Mon, Jul 11, 2022 at 02:00:42PM +0000, Vivi, Rodrigo wrote:
> > On Mon, 2022-07-11 at 04:11 +0000, Gupta, Anshuman wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Srivatsa, Anusha <anusha.srivatsa@intel.com>
> > > > Sent: Friday, July 8, 2022 11:48 PM
> > > > To: igt-dev@lists.freedesktop.org
> > > > Cc: Srivatsa, Anusha <anusha.srivatsa@intel.com>; Deak, Imre
> > > > <imre.deak@intel.com>; Gupta, Anshuman <anshuman.gupta@intel.com>;
> > > > Vivi, Rodrigo <rodrigo.vivi@intel.com>
> > > > Subject: [i-g-t] tests/i915/i915_pm_dc: Remove PC8+ dependency
> > > > from
> > > > DC9
> > > >
> > > > Different from DC6, DC9 does not depend on BIOS/PCU to execute
> > > > save and restore or any other sequence when going to PC9/PC10
> > > Commit message should explain this is a change for all DGFX platform.
> >
> > yeap. the commit message needs to change as well.
> 
> I meant to say commit subject...
> 
> >
> > and I'd say preferably we would have that IS_DGFX patch in place and
> > use that instead of individual platforms.
> >
> > That patch got nacked because has_lmem is preferred, but in this case
> > the lmem check makes not much sense and the clean way is the IS_DGFX.
> > So maybe we have a good reason after all..
Agree we will need a IS_DGFX() check, probably we can relay on below debugfs for that
# cat /sys/kernel/debug/dri/1/i915_gpu_info |  grep  "is_dgfx: yes"
is_dgfx: yes

Thanks,
Anshuman Gupta.
> >
> >
> > > Thanks,
> > > Anshuman Gupta.
> > > >
> > > > DC9 actually depends on D3 and PCODE simply remove power if SW
> > > > allowed
> > > >
> > > > v2: resrict the check for igfx only.
> > > >
> > > > Cc: Imre Deak <imre.deak@intel.com>
> > > > Cc: Anshuman Gupta <anshuman.gupta@intel.com>
> > > > Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>(v2)
> > > > ---
> > > >  tests/i915/i915_pm_dc.c | 5 +++--
> > > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
> > > > index a780f2cb..5132734b 100644
> > > > --- a/tests/i915/i915_pm_dc.c
> > > > +++ b/tests/i915/i915_pm_dc.c
> > > > @@ -532,8 +532,9 @@ int main(int argc, char *argv[])
> > > >
> > > >  igt_describe("This test validates display engine entry to DC9
> > > > state");
> > > >  igt_subtest("dc9-dpms") {
> > > > -
> > > > igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.msr_fd),
> > > > -"PC8+ residencies not supported\n");
> > > > +if (!(IS_DG1(data.devid) || IS_DG2(data.devid)))
> > > > +
> > > > igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.msr_fd),
> > > > +      "PC8+ residencies not supported\n");
> > > >  test_dc9_dpms(&data);
> > > >  }
> > > >
> > > > --
> > > > 2.25.1
> > >
> >