From: "Gupta, Anshuman" <anshuman.gupta@intel.com>
To: "Srivatsa, Anusha" <anusha.srivatsa@intel.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Cc: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: Re: [igt-dev] [i-g-t] tests/i915/i915_pm_dc: Remove PC8+ dependency from DC9
Date: Mon, 11 Jul 2022 04:11:00 +0000 [thread overview]
Message-ID: <19d53e1a0dee4cb28ddbc68ec7859d65@intel.com> (raw)
In-Reply-To: <20220708181744.398984-1-anusha.srivatsa@intel.com>
> -----Original Message-----
> From: Srivatsa, Anusha <anusha.srivatsa@intel.com>
> Sent: Friday, July 8, 2022 11:48 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Srivatsa, Anusha <anusha.srivatsa@intel.com>; Deak, Imre
> <imre.deak@intel.com>; Gupta, Anshuman <anshuman.gupta@intel.com>; Vivi,
> Rodrigo <rodrigo.vivi@intel.com>
> Subject: [i-g-t] tests/i915/i915_pm_dc: Remove PC8+ dependency from DC9
>
> Different from DC6, DC9 does not depend on BIOS/PCU to execute save and
> restore or any other sequence when going to PC9/PC10
Commit message should explain this is a change for all DGFX platform.
Thanks,
Anshuman Gupta.
>
> DC9 actually depends on D3 and PCODE simply remove power if SW allowed
>
> v2: resrict the check for igfx only.
>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Anshuman Gupta <anshuman.gupta@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>(v2)
> ---
> tests/i915/i915_pm_dc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c index
> a780f2cb..5132734b 100644
> --- a/tests/i915/i915_pm_dc.c
> +++ b/tests/i915/i915_pm_dc.c
> @@ -532,8 +532,9 @@ int main(int argc, char *argv[])
>
> igt_describe("This test validates display engine entry to DC9 state");
> igt_subtest("dc9-dpms") {
> -
> igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.msr_fd),
> - "PC8+ residencies not supported\n");
> + if (!(IS_DG1(data.devid) || IS_DG2(data.devid)))
> +
> igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.msr_fd),
> + "PC8+ residencies not supported\n");
> test_dc9_dpms(&data);
> }
>
> --
> 2.25.1
next prev parent reply other threads:[~2022-07-11 4:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 18:17 [igt-dev] [i-g-t] tests/i915/i915_pm_dc: Remove PC8+ dependency from DC9 Anusha Srivatsa
2022-07-08 18:50 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2022-07-08 19:07 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-07-09 5:09 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-07-11 4:11 ` Gupta, Anshuman [this message]
2022-07-11 14:00 ` [igt-dev] [i-g-t] " Vivi, Rodrigo
2022-07-11 14:14 ` Rodrigo Vivi
2022-07-11 16:01 ` Gupta, Anshuman
2022-07-11 15:05 ` Srivatsa, Anusha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19d53e1a0dee4cb28ddbc68ec7859d65@intel.com \
--to=anshuman.gupta@intel.com \
--cc=anusha.srivatsa@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox