* [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes
@ 2018-11-03 11:28 Juha-Pekka Heikkila
2018-11-03 12:09 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (27 more replies)
0 siblings, 28 replies; 49+ messages in thread
From: Juha-Pekka Heikkila @ 2018-11-03 11:28 UTC (permalink / raw)
To: igt-dev
Fix creation of gem buffer so that used bpp will always have value other
than 0.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
tests/kms_available_modes_crc.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/kms_available_modes_crc.c b/tests/kms_available_modes_crc.c
index 45a4775..006c2db 100644
--- a/tests/kms_available_modes_crc.c
+++ b/tests/kms_available_modes_crc.c
@@ -164,7 +164,7 @@ static const struct {
#ifdef DRM_FORMAT_P016
{ DRM_FORMAT_P016, 0, P010, 0x8000eb00},
#endif
- { 0, 0, 0, 0 }
+ { 0, 0, SKIP4, 0 }
};
/*
@@ -232,13 +232,13 @@ static bool fill_in_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
writesize = data->size;
break;
}
- igt_info("Format %s CRC comparison skipped by design.\n",
- (char*)&fillers[i].fourcc);
+ igt_info("Format %.4s CRC comparison skipped by design.\n",
+ (char*)&format);
return false;
default:
- igt_info("Unsupported mode for test %s\n",
- (char*)&fillers[i].fourcc);
+ igt_info("Unsupported mode for test %.4s\n",
+ (char*)&format);
return false;
}
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 49+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
@ 2018-11-03 12:09 ` Patchwork
2018-11-03 13:00 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
` (26 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-11-03 12:09 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes
URL : https://patchwork.freedesktop.org/series/52000/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5081 -> IGTPW_2033 =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_2033 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2033, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_2033:
=== IGT changes ===
==== Warnings ====
igt@pm_rpm@module-reload:
fi-hsw-4770r: PASS -> SKIP
== Known issues ==
Here are the changes found in IGTPW_2033 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-reload-inject:
fi-hsw-4770r: PASS -> DMESG-WARN (fdo#107924, fdo#107425)
igt@gem_exec_suspend@basic-s3:
fi-kbl-soraka: NOTRUN -> INCOMPLETE (fdo#107859, fdo#107774, fdo#107556)
igt@gem_exec_suspend@basic-s4-devices:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-skl-guc: PASS -> FAIL (fdo#103191, fdo#107362)
==== Possible fixes ====
igt@gem_cpu_reloc@basic:
fi-kbl-7560u: INCOMPLETE (fdo#103665) -> PASS
igt@kms_flip@basic-flip-vs-modeset:
fi-skl-6700hq: DMESG-WARN (fdo#105998) -> PASS +1
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107425 https://bugs.freedesktop.org/show_bug.cgi?id=107425
fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107774 https://bugs.freedesktop.org/show_bug.cgi?id=107774
fdo#107859 https://bugs.freedesktop.org/show_bug.cgi?id=107859
fdo#107924 https://bugs.freedesktop.org/show_bug.cgi?id=107924
== Participating hosts (50 -> 45) ==
Additional (1): fi-kbl-soraka
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-u
== Build changes ==
* IGT: IGT_4705 -> IGTPW_2033
CI_DRM_5081: f5e16acf6c85d38756c3efdb77ec6aede55df0ba @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2033: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2033/
IGT_4705: 7983e19ed62ec8db1884f55e07e458a62cc51e37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2033/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_available_modes_crc: Fix handling of unknown single plane modes
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
2018-11-03 12:09 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-11-03 13:00 ` Patchwork
2018-11-03 14:28 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
` (25 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-11-03 13:00 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes
URL : https://patchwork.freedesktop.org/series/52000/
State : failure
== Summary ==
= CI Bug Log - changes from IGT_4705_full -> IGTPW_2033_full =
== Summary - FAILURE ==
Serious unknown changes coming with IGTPW_2033_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2033_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_2033_full:
=== IGT changes ===
==== Possible regressions ====
igt@kms_properties@connector-properties-atomic:
shard-apl: PASS -> FAIL
shard-glk: PASS -> FAIL
shard-hsw: PASS -> FAIL
shard-kbl: PASS -> FAIL
==== Warnings ====
igt@perf_pmu@rc6:
shard-kbl: SKIP -> PASS
== Known issues ==
Here are the changes found in IGTPW_2033_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_busy@extended-modeset-hang-newfb-render-a:
shard-hsw: PASS -> DMESG-WARN (fdo#107956)
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
shard-snb: PASS -> DMESG-WARN (fdo#107956)
igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
shard-glk: PASS -> FAIL (fdo#108145)
igt@kms_color@pipe-b-degamma:
shard-apl: PASS -> FAIL (fdo#104782)
igt@kms_cursor_crc@cursor-128x42-random:
shard-apl: PASS -> INCOMPLETE (fdo#103927)
igt@kms_cursor_crc@cursor-64x21-random:
shard-apl: PASS -> DMESG-FAIL (fdo#103232, fdo#105602, fdo#103558)
shard-kbl: PASS -> FAIL (fdo#103232) +1
igt@kms_cursor_crc@cursor-64x64-dpms:
shard-apl: PASS -> FAIL (fdo#103232) +2
igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
shard-glk: PASS -> DMESG-WARN (fdo#105763, fdo#106538) +1
igt@kms_flip@flip-vs-absolute-wf_vblank:
shard-apl: PASS -> DMESG-WARN (fdo#105602, fdo#103558) +21
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc:
shard-glk: PASS -> FAIL (fdo#103167) +4
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
shard-kbl: PASS -> FAIL (fdo#103167) +1
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
shard-apl: PASS -> FAIL (fdo#103167) +3
igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
shard-apl: PASS -> FAIL (fdo#108145)
igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb:
shard-glk: NOTRUN -> FAIL (fdo#108145)
igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
shard-apl: PASS -> FAIL (fdo#103166) +2
shard-kbl: PASS -> FAIL (fdo#103166)
igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
shard-glk: PASS -> FAIL (fdo#103166) +2
igt@kms_setmode@basic:
shard-apl: PASS -> DMESG-FAIL (fdo#103558, fdo#105602, fdo#99912)
==== Possible fixes ====
igt@gem_exec_schedule@preempt-contexts-render:
shard-glk: DMESG-WARN (fdo#105763, fdo#106538) -> PASS +1
igt@gem_ppgtt@blt-vs-render-ctxn:
shard-kbl: INCOMPLETE (fdo#106887, fdo#103665, fdo#106023) -> PASS
igt@kms_available_modes_crc@available_mode_test_crc:
shard-snb: FAIL (fdo#106641) -> PASS
igt@kms_color@pipe-c-ctm-max:
shard-kbl: FAIL (fdo#108147) -> PASS
shard-apl: FAIL (fdo#108147) -> PASS
igt@kms_color@pipe-c-legacy-gamma:
shard-apl: FAIL (fdo#104782) -> PASS
igt@kms_cursor_crc@cursor-128x42-sliding:
shard-apl: FAIL (fdo#103232) -> PASS +2
igt@kms_cursor_crc@cursor-256x256-sliding:
shard-glk: FAIL (fdo#103232) -> PASS +1
igt@kms_draw_crc@draw-method-rgb565-render-ytiled:
shard-apl: INCOMPLETE (fdo#103927) -> SKIP
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
shard-kbl: FAIL (fdo#103167) -> PASS
shard-apl: FAIL (fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-wc:
shard-glk: INCOMPLETE (k.org#198133, fdo#103359) -> PASS
igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-wc:
shard-glk: FAIL (fdo#103167) -> PASS +1
igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS
igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
shard-glk: FAIL (fdo#103166) -> PASS +2
shard-apl: FAIL (fdo#103166) -> PASS
igt@kms_setmode@basic:
shard-kbl: FAIL (fdo#99912) -> PASS
==== Warnings ====
igt@kms_plane@pixel-format-pipe-c-planes:
shard-apl: FAIL (fdo#103166) -> DMESG-FAIL (fdo#103166, fdo#105602, fdo#103558)
igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
shard-apl: FAIL (fdo#108145) -> DMESG-FAIL (fdo#108145, fdo#105602, fdo#103558)
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#106887 https://bugs.freedesktop.org/show_bug.cgi?id=106887
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108147 https://bugs.freedesktop.org/show_bug.cgi?id=108147
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (6 -> 5) ==
Missing (1): shard-skl
== Build changes ==
* IGT: IGT_4705 -> IGTPW_2033
* Linux: CI_DRM_5079 -> CI_DRM_5081
CI_DRM_5079: fc3d54b430337be9c61a524c65b521761d6664a8 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_5081: f5e16acf6c85d38756c3efdb77ec6aede55df0ba @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2033: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2033/
IGT_4705: 7983e19ed62ec8db1884f55e07e458a62cc51e37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2033/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
2018-11-03 12:09 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-11-03 13:00 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2018-11-03 14:28 ` Patchwork
2018-11-03 15:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
` (24 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-11-03 14:28 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes
URL : https://patchwork.freedesktop.org/series/52000/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5081 -> IGTPW_2035 =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_2035 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2035, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_2035:
=== IGT changes ===
==== Warnings ====
igt@drv_selftest@live_execlists:
fi-icl-u2: PASS -> SKIP +2
== Known issues ==
Here are the changes found in IGTPW_2035 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
fi-kbl-soraka: NOTRUN -> INCOMPLETE (fdo#107556, fdo#107859, fdo#107774)
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191)
==== Possible fixes ====
igt@gem_cpu_reloc@basic:
fi-kbl-7560u: INCOMPLETE (fdo#103665) -> PASS
igt@kms_flip@basic-flip-vs-modeset:
fi-skl-6700hq: DMESG-WARN (fdo#105998) -> PASS +1
==== Warnings ====
igt@drv_selftest@live_contexts:
fi-icl-u2: DMESG-FAIL (fdo#108569) -> INCOMPLETE (fdo#108315)
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
fdo#107774 https://bugs.freedesktop.org/show_bug.cgi?id=107774
fdo#107859 https://bugs.freedesktop.org/show_bug.cgi?id=107859
fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315
fdo#108569 https://bugs.freedesktop.org/show_bug.cgi?id=108569
== Participating hosts (50 -> 44) ==
Additional (1): fi-kbl-soraka
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-pnv-d510 fi-icl-u
== Build changes ==
* IGT: IGT_4705 -> IGTPW_2035
CI_DRM_5081: f5e16acf6c85d38756c3efdb77ec6aede55df0ba @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2035: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2035/
IGT_4705: 7983e19ed62ec8db1884f55e07e458a62cc51e37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2035/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (2 preceding siblings ...)
2018-11-03 14:28 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
@ 2018-11-03 15:18 ` Patchwork
2018-11-05 9:54 ` [igt-dev] [PATCH i-g-t] " Maarten Lankhorst
` (23 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-11-03 15:18 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes
URL : https://patchwork.freedesktop.org/series/52000/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4705_full -> IGTPW_2035_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_2035_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2035_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_2035_full:
=== IGT changes ===
==== Warnings ====
igt@perf_pmu@rc6:
shard-kbl: SKIP -> PASS
igt@pm_rc6_residency@rc6-accuracy:
shard-kbl: PASS -> SKIP
== Known issues ==
Here are the changes found in IGTPW_2035_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_parse@load-register-reg:
shard-snb: SKIP -> INCOMPLETE (fdo#105411)
igt@kms_busy@extended-modeset-hang-newfb-render-a:
shard-hsw: PASS -> DMESG-WARN (fdo#107956)
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
shard-snb: PASS -> DMESG-WARN (fdo#107956)
igt@kms_color@pipe-a-legacy-gamma:
shard-apl: PASS -> FAIL (fdo#108145, fdo#104782)
igt@kms_color@pipe-b-ctm-max:
shard-apl: PASS -> FAIL (fdo#108147)
shard-kbl: PASS -> FAIL (fdo#108147)
igt@kms_cursor_crc@cursor-128x128-random:
shard-apl: PASS -> FAIL (fdo#103232) +2
igt@kms_cursor_crc@cursor-256x256-random:
shard-glk: PASS -> FAIL (fdo#103232)
shard-kbl: PASS -> FAIL (fdo#103232) +1
igt@kms_cursor_crc@cursor-256x256-suspend:
shard-apl: PASS -> FAIL (fdo#103191, fdo#103232)
igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-untiled:
shard-apl: PASS -> INCOMPLETE (fdo#103927)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
shard-apl: PASS -> FAIL (fdo#103167) +2
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
shard-glk: PASS -> FAIL (fdo#103167) +8
igt@kms_pipe_crc_basic@hang-read-crc-pipe-c:
shard-apl: PASS -> DMESG-WARN (fdo#103558, fdo#105602) +2
igt@kms_plane@plane-position-covered-pipe-c-planes:
shard-apl: PASS -> FAIL (fdo#103166) +1
igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
shard-apl: PASS -> FAIL (fdo#108145)
igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb:
shard-glk: NOTRUN -> FAIL (fdo#108145)
igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
shard-glk: PASS -> FAIL (fdo#103166) +3
igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
shard-kbl: PASS -> FAIL (fdo#103166)
igt@kms_properties@connector-properties-atomic:
shard-apl: PASS -> FAIL (fdo#108642)
shard-glk: PASS -> FAIL (fdo#108642)
shard-hsw: PASS -> FAIL (fdo#108642)
shard-kbl: PASS -> FAIL (fdo#108642)
igt@kms_rotation_crc@primary-rotation-180:
shard-snb: PASS -> FAIL (fdo#103925)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
igt@perf_pmu@rc6-runtime-pm:
shard-glk: PASS -> FAIL (fdo#105010)
==== Possible fixes ====
igt@gem_exec_schedule@preempt-contexts-render:
shard-glk: DMESG-WARN (fdo#106538, fdo#105763) -> PASS +1
igt@gem_ppgtt@blt-vs-render-ctxn:
shard-kbl: INCOMPLETE (fdo#106887, fdo#106023, fdo#103665) -> PASS
igt@kms_busy@extended-modeset-hang-newfb-render-b:
shard-snb: DMESG-WARN (fdo#107956) -> PASS
igt@kms_color@pipe-c-ctm-max:
shard-kbl: FAIL (fdo#108147) -> PASS
shard-apl: FAIL (fdo#108147) -> PASS
igt@kms_color@pipe-c-legacy-gamma:
shard-apl: FAIL (fdo#104782) -> PASS
igt@kms_cursor_crc@cursor-128x42-sliding:
shard-apl: FAIL (fdo#103232) -> PASS +1
igt@kms_cursor_crc@cursor-256x256-sliding:
shard-glk: FAIL (fdo#103232) -> PASS +1
igt@kms_draw_crc@draw-method-rgb565-render-ytiled:
shard-apl: INCOMPLETE (fdo#103927) -> SKIP
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
shard-kbl: FAIL (fdo#103167) -> PASS +1
shard-apl: FAIL (fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-wc:
shard-glk: INCOMPLETE (k.org#198133, fdo#103359) -> PASS
igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-wc:
shard-glk: FAIL (fdo#103167) -> PASS +3
igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS
igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
shard-glk: FAIL (fdo#103166) -> PASS +1
shard-apl: FAIL (fdo#103166) -> PASS +1
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105010 https://bugs.freedesktop.org/show_bug.cgi?id=105010
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106887 https://bugs.freedesktop.org/show_bug.cgi?id=106887
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108147 https://bugs.freedesktop.org/show_bug.cgi?id=108147
fdo#108642 https://bugs.freedesktop.org/show_bug.cgi?id=108642
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (6 -> 5) ==
Missing (1): shard-skl
== Build changes ==
* IGT: IGT_4705 -> IGTPW_2035
* Linux: CI_DRM_5079 -> CI_DRM_5081
CI_DRM_5079: fc3d54b430337be9c61a524c65b521761d6664a8 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_5081: f5e16acf6c85d38756c3efdb77ec6aede55df0ba @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2035: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2035/
IGT_4705: 7983e19ed62ec8db1884f55e07e458a62cc51e37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2035/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (3 preceding siblings ...)
2018-11-03 15:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2018-11-05 9:54 ` Maarten Lankhorst
2018-11-05 11:24 ` Juha-Pekka Heikkila
2018-11-05 11:32 ` [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons Juha-Pekka Heikkila
` (22 subsequent siblings)
27 siblings, 1 reply; 49+ messages in thread
From: Maarten Lankhorst @ 2018-11-05 9:54 UTC (permalink / raw)
To: Juha-Pekka Heikkila, igt-dev
Op 03-11-18 om 12:28 schreef Juha-Pekka Heikkila:
> Fix creation of gem buffer so that used bpp will always have value other
> than 0.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> tests/kms_available_modes_crc.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/kms_available_modes_crc.c b/tests/kms_available_modes_crc.c
> index 45a4775..006c2db 100644
> --- a/tests/kms_available_modes_crc.c
> +++ b/tests/kms_available_modes_crc.c
> @@ -164,7 +164,7 @@ static const struct {
> #ifdef DRM_FORMAT_P016
> { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
> #endif
> - { 0, 0, 0, 0 }
> + { 0, 0, SKIP4, 0 }
Remove this entry, and make the loop
for (i = 0; i < ARRAY_SIZE(fillers); i++) { }
if (i == ARRAY_SIZE(fillers))
return false;
?
This should prevent it from ever being a problem in the first place.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes
2018-11-05 9:54 ` [igt-dev] [PATCH i-g-t] " Maarten Lankhorst
@ 2018-11-05 11:24 ` Juha-Pekka Heikkila
2018-11-05 12:42 ` Maarten Lankhorst
0 siblings, 1 reply; 49+ messages in thread
From: Juha-Pekka Heikkila @ 2018-11-05 11:24 UTC (permalink / raw)
To: Maarten Lankhorst, igt-dev
On 05.11.2018 11:54, Maarten Lankhorst wrote:
> Op 03-11-18 om 12:28 schreef Juha-Pekka Heikkila:
>> Fix creation of gem buffer so that used bpp will always have value other
>> than 0.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>> ---
>> tests/kms_available_modes_crc.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/tests/kms_available_modes_crc.c b/tests/kms_available_modes_crc.c
>> index 45a4775..006c2db 100644
>> --- a/tests/kms_available_modes_crc.c
>> +++ b/tests/kms_available_modes_crc.c
>> @@ -164,7 +164,7 @@ static const struct {
>> #ifdef DRM_FORMAT_P016
>> { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
>> #endif
>> - { 0, 0, 0, 0 }
>> + { 0, 0, SKIP4, 0 }
> Remove this entry, and make the loop
> for (i = 0; i < ARRAY_SIZE(fillers); i++) { }
>
> if (i == ARRAY_SIZE(fillers))
> return false;
>
> ?
>
> This should prevent it from ever being a problem in the first place.
>
I was thinking this at first too but that 'skip4' flag is used to skip
CRC checking at later time. This test runs in two levels, at first try
to enable plane format and then do CRC. This last element is for the
case where plane format was not hardcoded here.
I did have another look at this test and made another patch which also
relax CRC checking so this test will pass on our modern HW, I got idea
from Ville's usage of gamma on kms_plane. I'll put it on the list in a
minute.
/Juha-Pekka
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (4 preceding siblings ...)
2018-11-05 9:54 ` [igt-dev] [PATCH i-g-t] " Maarten Lankhorst
@ 2018-11-05 11:32 ` Juha-Pekka Heikkila
2018-11-05 12:19 ` Maarten Lankhorst
2018-12-13 11:16 ` Juha-Pekka Heikkila
2018-11-05 12:10 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev2) Patchwork
` (21 subsequent siblings)
27 siblings, 2 replies; 49+ messages in thread
From: Juha-Pekka Heikkila @ 2018-11-05 11:32 UTC (permalink / raw)
To: igt-dev
Fixed handling of single plane modes so used bpp never get to
be 0 and ease off crc comparison a bit with gamma tables as
idea of this test is to see found modes are able to initialize.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106641
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
tests/kms_available_modes_crc.c | 78 ++++++++++++++++++++++++-----------------
1 file changed, 45 insertions(+), 33 deletions(-)
diff --git a/tests/kms_available_modes_crc.c b/tests/kms_available_modes_crc.c
index 45a4775..69b3306 100644
--- a/tests/kms_available_modes_crc.c
+++ b/tests/kms_available_modes_crc.c
@@ -54,6 +54,12 @@ typedef struct {
igt_crc_t cursor_crc;
igt_crc_t fullscreen_crc;
+
+ /*
+ * If there's unknown format setting up mode can fail
+ * without failing entire test.
+ */
+ bool allow_fail;
} data_t;
@@ -133,19 +139,10 @@ static const struct {
{ DRM_FORMAT_RGB565, 0, BYTES_PP_2, 0xffff},
{ DRM_FORMAT_XRGB8888, 0, BYTES_PP_4, 0xffffffff},
{ DRM_FORMAT_XBGR8888, 0, BYTES_PP_4, 0xffffffff},
-
- /*
- * following two are skipped because blending seems to work
- * incorrectly with exception of AR24 on cursor plane.
- * Test still creates the planes, just filling plane
- * and getting crc is skipped.
- */
- { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff},
- { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff},
-
+ { DRM_FORMAT_ARGB8888, 0, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_ABGR8888, 0, BYTES_PP_4, 0x00ffffff},
{ DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff},
{ DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff},
-
{ DRM_FORMAT_YUYV, 0, BYTES_PP_4, 0x80eb80eb},
{ DRM_FORMAT_YVYU, 0, BYTES_PP_4, 0x80eb80eb},
{ DRM_FORMAT_VYUY, 0, BYTES_PP_4, 0xeb80eb80},
@@ -164,7 +161,7 @@ static const struct {
#ifdef DRM_FORMAT_P016
{ DRM_FORMAT_P016, 0, P010, 0x8000eb00},
#endif
- { 0, 0, 0, 0 }
+ { 0, 0, SKIP4, 0 }
};
/*
@@ -221,24 +218,9 @@ static bool fill_in_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
writesize = data->size+data->size/2;
break;
case SKIP4:
- if (fillers[i].fourcc == DRM_FORMAT_ARGB8888 &&
- plane->type == DRM_PLANE_TYPE_CURSOR) {
- /*
- * special for cursor plane where blending works correctly.
- */
- ptemp_32_buf = (unsigned int*)data->buf;
- for (c = 0; c < data->size/4; c++)
- ptemp_32_buf[c] = fillers[i].value;
- writesize = data->size;
- break;
- }
- igt_info("Format %s CRC comparison skipped by design.\n",
- (char*)&fillers[i].fourcc);
-
- return false;
default:
- igt_info("Unsupported mode for test %s\n",
- (char*)&fillers[i].fourcc);
+ igt_info("Unsupported mode for testing CRC %.4s\n",
+ (char*)&format);
return false;
}
@@ -261,6 +243,8 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
int bpp = 0;
int i;
+ data->allow_fail = false;
+
mode = igt_output_get_mode(output);
if (plane->type != DRM_PLANE_TYPE_CURSOR) {
w = mode->hdisplay;
@@ -289,6 +273,8 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
break;
case SKIP4:
+ data->allow_fail = true;
+ /* fall through */
case BYTES_PP_4:
bpp = 32;
break;
@@ -412,7 +398,8 @@ test_one_mode(data_t* data, igt_output_t *output, igt_plane_t* plane,
igt_warn("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
free(crccompare[0]);
free(crccompare[1]);
- rVal++;
+ if (!data->allow_fail)
+ rVal++;
}
} else {
if (!igt_check_crc_equal(¤t_crc,
@@ -422,14 +409,15 @@ test_one_mode(data_t* data, igt_output_t *output, igt_plane_t* plane,
igt_warn("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
free(crccompare[0]);
free(crccompare[1]);
- rVal++;
+ if (!data->allow_fail)
+ rVal++;
}
}
}
remove_fb(data, output, plane);
return rVal;
}
- return 1;
+ return data->allow_fail?0:1;
}
@@ -438,16 +426,31 @@ test_available_modes(data_t* data)
{
igt_output_t *output;
igt_plane_t *plane;
+ igt_pipe_t *pipe_obj;
int modeindex;
enum pipe pipe;
- int invalids = 0;
+ int invalids = 0, i, lut_size;
+ uint16_t *lut;
drmModePlane *modePlane;
+ drmModeCrtc *crtc;
char planetype[3][8] = {"OVERLAY\0", "PRIMARY\0", "CURSOR\0" };
for_each_pipe_with_valid_output(&data->display, pipe, output) {
igt_output_set_pipe(output, pipe);
igt_display_commit2(&data->display, data->commit);
+ pipe_obj = &data->display.pipes[pipe];
+ crtc = drmModeGetCrtc(data->gfx_fd, pipe_obj->crtc_id);
+ lut_size = crtc->gamma_size;
+ drmModeFreeCrtc(crtc);
+ lut = malloc(sizeof(uint16_t) * lut_size);
+
+ for (i = 0; i < lut_size; i++)
+ lut[i] = (i * 0xffff / (lut_size - 1)) & 0xfc00;
+
+ drmModeCrtcSetGamma(data->gfx_fd, pipe_obj->crtc_id,
+ lut_size, lut, lut, lut);
+
data->pipe_crc = igt_pipe_crc_new(data->gfx_fd, pipe,
INTEL_PIPE_CRC_SOURCE_AUTO);
@@ -484,6 +487,15 @@ test_available_modes(data_t* data)
igt_pipe_crc_stop(data->pipe_crc);
igt_pipe_crc_free(data->pipe_crc);
igt_display_commit2(&data->display, data->commit);
+
+ for (i = 0; i < lut_size; i++)
+ lut[i] = i * 0xffff / (lut_size - 1);
+
+ drmModeCrtcSetGamma(data->gfx_fd, pipe_obj->crtc_id,
+ lut_size, lut, lut, lut);
+ free(lut);
+
+ igt_output_set_pipe(output, PIPE_ANY);
}
igt_assert(invalids == 0);
}
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 49+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev2)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (5 preceding siblings ...)
2018-11-05 11:32 ` [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons Juha-Pekka Heikkila
@ 2018-11-05 12:10 ` Patchwork
2018-11-08 11:51 ` Patchwork
` (20 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-11-05 12:10 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev2)
URL : https://patchwork.freedesktop.org/series/52000/
State : failure
== Summary ==
= CI Bug Log - changes from IGT_4707 -> IGTPW_2039 =
== Summary - FAILURE ==
Serious unknown changes coming with IGTPW_2039 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2039, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/2/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_2039:
=== IGT changes ===
==== Possible regressions ====
igt@kms_chamelium@common-hpd-after-suspend:
fi-skl-6700k2: PASS -> WARN
==== Warnings ====
igt@drv_selftest@live_guc:
fi-apl-guc: PASS -> SKIP
== Known issues ==
Here are the changes found in IGTPW_2039 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
fi-byt-clapper: PASS -> FAIL (fdo#107362)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-cfl-8109u: PASS -> INCOMPLETE (fdo#106070, fdo#108126)
==== Possible fixes ====
igt@drv_selftest@live_coherency:
fi-gdg-551: DMESG-FAIL (fdo#107164) -> PASS
igt@gem_ctx_create@basic-files:
fi-bsw-n3050: FAIL (fdo#108656) -> PASS
fi-bsw-kefka: FAIL (fdo#108656) -> PASS
==== Warnings ====
igt@drv_selftest@live_execlists:
fi-apl-guc: DMESG-WARN (fdo#108622) -> INCOMPLETE (fdo#106693, fdo#103927)
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#106070 https://bugs.freedesktop.org/show_bug.cgi?id=106070
fdo#106693 https://bugs.freedesktop.org/show_bug.cgi?id=106693
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#108126 https://bugs.freedesktop.org/show_bug.cgi?id=108126
fdo#108622 https://bugs.freedesktop.org/show_bug.cgi?id=108622
fdo#108656 https://bugs.freedesktop.org/show_bug.cgi?id=108656
== Participating hosts (48 -> 46) ==
Additional (2): fi-ilk-650 fi-snb-2520m
Missing (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* IGT: IGT_4707 -> IGTPW_2039
CI_DRM_5085: 6ae61ee5db4af12c0b21bf39e0400ccf024187c4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2039: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2039/
IGT_4707: 5f2af06b5c1934ff4d5ed3ea55efc306289f1c53 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2039/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons
2018-11-05 11:32 ` [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons Juha-Pekka Heikkila
@ 2018-11-05 12:19 ` Maarten Lankhorst
2018-12-13 11:16 ` Juha-Pekka Heikkila
1 sibling, 0 replies; 49+ messages in thread
From: Maarten Lankhorst @ 2018-11-05 12:19 UTC (permalink / raw)
To: Juha-Pekka Heikkila, igt-dev
Op 05-11-18 om 12:32 schreef Juha-Pekka Heikkila:
> Fixed handling of single plane modes so used bpp never get to
> be 0 and ease off crc comparison a bit with gamma tables as
> idea of this test is to see found modes are able to initialize.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106641
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> tests/kms_available_modes_crc.c | 78 ++++++++++++++++++++++++-----------------
> 1 file changed, 45 insertions(+), 33 deletions(-)
>
> diff --git a/tests/kms_available_modes_crc.c b/tests/kms_available_modes_crc.c
> index 45a4775..69b3306 100644
> --- a/tests/kms_available_modes_crc.c
> +++ b/tests/kms_available_modes_crc.c
> @@ -54,6 +54,12 @@ typedef struct {
>
> igt_crc_t cursor_crc;
> igt_crc_t fullscreen_crc;
> +
> + /*
> + * If there's unknown format setting up mode can fail
> + * without failing entire test.
> + */
> + bool allow_fail;
> } data_t;
>
>
> @@ -133,19 +139,10 @@ static const struct {
> { DRM_FORMAT_RGB565, 0, BYTES_PP_2, 0xffff},
> { DRM_FORMAT_XRGB8888, 0, BYTES_PP_4, 0xffffffff},
> { DRM_FORMAT_XBGR8888, 0, BYTES_PP_4, 0xffffffff},
> -
> - /*
> - * following two are skipped because blending seems to work
> - * incorrectly with exception of AR24 on cursor plane.
> - * Test still creates the planes, just filling plane
> - * and getting crc is skipped.
> - */
> - { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff},
> - { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff},
> -
> + { DRM_FORMAT_ARGB8888, 0, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_ABGR8888, 0, BYTES_PP_4, 0x00ffffff},
> { DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff},
> { DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff},
> -
> { DRM_FORMAT_YUYV, 0, BYTES_PP_4, 0x80eb80eb},
> { DRM_FORMAT_YVYU, 0, BYTES_PP_4, 0x80eb80eb},
> { DRM_FORMAT_VYUY, 0, BYTES_PP_4, 0xeb80eb80},
> @@ -164,7 +161,7 @@ static const struct {
> #ifdef DRM_FORMAT_P016
> { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
> #endif
> - { 0, 0, 0, 0 }
> + { 0, 0, SKIP4, 0 }
> };
>
> /*
> @@ -221,24 +218,9 @@ static bool fill_in_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
> writesize = data->size+data->size/2;
> break;
> case SKIP4:
> - if (fillers[i].fourcc == DRM_FORMAT_ARGB8888 &&
> - plane->type == DRM_PLANE_TYPE_CURSOR) {
> - /*
> - * special for cursor plane where blending works correctly.
> - */
> - ptemp_32_buf = (unsigned int*)data->buf;
> - for (c = 0; c < data->size/4; c++)
> - ptemp_32_buf[c] = fillers[i].value;
> - writesize = data->size;
> - break;
> - }
> - igt_info("Format %s CRC comparison skipped by design.\n",
> - (char*)&fillers[i].fourcc);
> -
> - return false;
> default:
> - igt_info("Unsupported mode for test %s\n",
> - (char*)&fillers[i].fourcc);
> + igt_info("Unsupported mode for testing CRC %.4s\n",
> + (char*)&format);
> return false;
> }
>
> @@ -261,6 +243,8 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
> int bpp = 0;
> int i;
>
> + data->allow_fail = false;
> +
> mode = igt_output_get_mode(output);
> if (plane->type != DRM_PLANE_TYPE_CURSOR) {
> w = mode->hdisplay;
> @@ -289,6 +273,8 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
> break;
>
> case SKIP4:
> + data->allow_fail = true;
> + /* fall through */
> case BYTES_PP_4:
> bpp = 32;
> break;
> @@ -412,7 +398,8 @@ test_one_mode(data_t* data, igt_output_t *output, igt_plane_t* plane,
> igt_warn("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
> free(crccompare[0]);
> free(crccompare[1]);
> - rVal++;
> + if (!data->allow_fail)
> + rVal++;
> }
> } else {
> if (!igt_check_crc_equal(¤t_crc,
> @@ -422,14 +409,15 @@ test_one_mode(data_t* data, igt_output_t *output, igt_plane_t* plane,
> igt_warn("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
> free(crccompare[0]);
> free(crccompare[1]);
> - rVal++;
> + if (!data->allow_fail)
> + rVal++;
> }
> }
> }
> remove_fb(data, output, plane);
> return rVal;
> }
> - return 1;
> + return data->allow_fail?0:1;
> }
>
>
> @@ -438,16 +426,31 @@ test_available_modes(data_t* data)
> {
> igt_output_t *output;
> igt_plane_t *plane;
> + igt_pipe_t *pipe_obj;
> int modeindex;
> enum pipe pipe;
> - int invalids = 0;
> + int invalids = 0, i, lut_size;
> + uint16_t *lut;
> drmModePlane *modePlane;
> + drmModeCrtc *crtc;
> char planetype[3][8] = {"OVERLAY\0", "PRIMARY\0", "CURSOR\0" };
>
> for_each_pipe_with_valid_output(&data->display, pipe, output) {
> igt_output_set_pipe(output, pipe);
> igt_display_commit2(&data->display, data->commit);
>
> + pipe_obj = &data->display.pipes[pipe];
> + crtc = drmModeGetCrtc(data->gfx_fd, pipe_obj->crtc_id);
> + lut_size = crtc->gamma_size;
> + drmModeFreeCrtc(crtc);
if (igt_pipe_obj_get_prop(IGT_CRTC_GAMMA_LUT_SIZE)) {
lut_size = igt_pipe_get_prop(IGT_CRTC_GAMMA_LUT_SIZE)
etc?
}
> + lut = malloc(sizeof(uint16_t) * lut_size);
> +
> + for (i = 0; i < lut_size; i++)
> + lut[i] = (i * 0xffff / (lut_size - 1)) & 0xfc00;
> +
> + drmModeCrtcSetGamma(data->gfx_fd, pipe_obj->crtc_id,
> + lut_size, lut, lut, lut);
And call igt_pipe_replace_prop_blob() with IGT_CRTC_GAMMA_LUT instead, it will be committed on next igt_display_commit2()
> data->pipe_crc = igt_pipe_crc_new(data->gfx_fd, pipe,
> INTEL_PIPE_CRC_SOURCE_AUTO);
>
> @@ -484,6 +487,15 @@ test_available_modes(data_t* data)
> igt_pipe_crc_stop(data->pipe_crc);
> igt_pipe_crc_free(data->pipe_crc);
> igt_display_commit2(&data->display, data->commit);
> +
> + for (i = 0; i < lut_size; i++)
> + lut[i] = i * 0xffff / (lut_size - 1);
> +
> + drmModeCrtcSetGamma(data->gfx_fd, pipe_obj->crtc_id,
> + lut_size, lut, lut, lut);
> + free(lut);
> + igt_output_set_pipe(output, PIPE_ANY);
Same here. We're trying to keep out the legacy crap where possible. :)
Hm, is the igt_display_commit2() at the end needed, or could it be an igt_display_reset at the start?
If you can't put in a reset, then igt_pipe_replace_prop_blob(IGT_CRTC_GAMMA_LUT, NULL, 0)
> }
> igt_assert(invalids == 0);
> }
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes
2018-11-05 11:24 ` Juha-Pekka Heikkila
@ 2018-11-05 12:42 ` Maarten Lankhorst
2018-11-05 13:29 ` Juha-Pekka Heikkila
0 siblings, 1 reply; 49+ messages in thread
From: Maarten Lankhorst @ 2018-11-05 12:42 UTC (permalink / raw)
To: juhapekka.heikkila, igt-dev
Op 05-11-18 om 12:24 schreef Juha-Pekka Heikkila:
> On 05.11.2018 11:54, Maarten Lankhorst wrote:
>> Op 03-11-18 om 12:28 schreef Juha-Pekka Heikkila:
>>> Fix creation of gem buffer so that used bpp will always have value other
>>> than 0.
>>>
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
>>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>>> ---
>>> tests/kms_available_modes_crc.c | 10 +++++-----
>>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/tests/kms_available_modes_crc.c b/tests/kms_available_modes_crc.c
>>> index 45a4775..006c2db 100644
>>> --- a/tests/kms_available_modes_crc.c
>>> +++ b/tests/kms_available_modes_crc.c
>>> @@ -164,7 +164,7 @@ static const struct {
>>> #ifdef DRM_FORMAT_P016
>>> { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
>>> #endif
>>> - { 0, 0, 0, 0 }
>>> + { 0, 0, SKIP4, 0 }
>> Remove this entry, and make the loop
>> for (i = 0; i < ARRAY_SIZE(fillers); i++) { }
>>
>> if (i == ARRAY_SIZE(fillers))
>> return false;
>>
>> ?
>>
>> This should prevent it from ever being a problem in the first place.
>>
>
> I was thinking this at first too but that 'skip4' flag is used to skip CRC checking at later time. This test runs in two levels, at first try to enable plane format and then do CRC. This last element is for the case where plane format was not hardcoded here.
>
> I did have another look at this test and made another patch which also relax CRC checking so this test will pass on our modern HW, I got idea from Ville's usage of gamma on kms_plane. I'll put it on the list in a minute.
We shouldn't test unknown modes at least. SKIP4 was specifically added for Alpha RGB formats on gen9-10, because in some cases fully transparant and fully opaque framebuffers would have rounding errors resulting in a small mismatch picked up by the CRC tests.
This is exactly why it might not be a good idea to randomly apply gamma tables hiding those rounding errors. In the future we want to prevent future occurences. If it's just the YUV formats that need a small correction to be fully white, we need to document it explicitly and not paper over it.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes
2018-11-05 12:42 ` Maarten Lankhorst
@ 2018-11-05 13:29 ` Juha-Pekka Heikkila
0 siblings, 0 replies; 49+ messages in thread
From: Juha-Pekka Heikkila @ 2018-11-05 13:29 UTC (permalink / raw)
To: Maarten Lankhorst, igt-dev
On 05.11.2018 14:42, Maarten Lankhorst wrote:
> Op 05-11-18 om 12:24 schreef Juha-Pekka Heikkila:
>> On 05.11.2018 11:54, Maarten Lankhorst wrote:
>>> Op 03-11-18 om 12:28 schreef Juha-Pekka Heikkila:
>>>> Fix creation of gem buffer so that used bpp will always have value other
>>>> than 0.
>>>>
>>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
>>>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>>>> ---
>>>> tests/kms_available_modes_crc.c | 10 +++++-----
>>>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/tests/kms_available_modes_crc.c b/tests/kms_available_modes_crc.c
>>>> index 45a4775..006c2db 100644
>>>> --- a/tests/kms_available_modes_crc.c
>>>> +++ b/tests/kms_available_modes_crc.c
>>>> @@ -164,7 +164,7 @@ static const struct {
>>>> #ifdef DRM_FORMAT_P016
>>>> { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
>>>> #endif
>>>> - { 0, 0, 0, 0 }
>>>> + { 0, 0, SKIP4, 0 }
>>> Remove this entry, and make the loop
>>> for (i = 0; i < ARRAY_SIZE(fillers); i++) { }
>>>
>>> if (i == ARRAY_SIZE(fillers))
>>> return false;
>>>
>>> ?
>>>
>>> This should prevent it from ever being a problem in the first place.
>>>
>>
>> I was thinking this at first too but that 'skip4' flag is used to skip CRC checking at later time. This test runs in two levels, at first try to enable plane format and then do CRC. This last element is for the case where plane format was not hardcoded here.
>>
>> I did have another look at this test and made another patch which also relax CRC checking so this test will pass on our modern HW, I got idea from Ville's usage of gamma on kms_plane. I'll put it on the list in a minute.
> We shouldn't test unknown modes at least. SKIP4 was specifically added for Alpha RGB formats on gen9-10, because in some cases fully transparant and fully opaque framebuffers would have rounding errors resulting in a small mismatch picked up by the CRC tests.
While I agree for the most part this test is from the time when IGT
supported much fever fb formats than now. It really wanted to test all
formats which kernel advertised by trying to set up plane using those
formats. This is why this test doesn't try to do anything difficult.
Those alpha bugs btw are not small rounding errors. If you try setting
up sprite plane w/ rgb-alpha on top of primary plane with semicomplex
image you don't need CRC to see those errors. :/
>
> This is exactly why it might not be a good idea to randomly apply gamma tables hiding those rounding errors. In the future we want to prevent future occurences. If it's just the YUV formats that need a small correction to be fully white, we need to document it explicitly and not paper over it.
>
For those tests there are more complex tests which will try to apply
more features and see what happen. This test was just to see what fb
formats kernel advertised and what will happen if try to use those.
In those ways I'd be ok just ditching this test as I think it probably
doesn't anymore serve its original purpose but until that is done this
test can be made to serve its original purpose with just using gamma table.
I just checked kms_plane also seems to apply gamma for all tests.
/Juha-Pekka
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev2)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (6 preceding siblings ...)
2018-11-05 12:10 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev2) Patchwork
@ 2018-11-08 11:51 ` Patchwork
2018-11-08 12:48 ` Patchwork
` (19 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-11-08 11:51 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev2)
URL : https://patchwork.freedesktop.org/series/52000/
State : failure
== Summary ==
= CI Bug Log - changes from IGT_4712 -> IGTPW_2047 =
== Summary - FAILURE ==
Serious unknown changes coming with IGTPW_2047 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2047, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/2/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_2047:
=== IGT changes ===
==== Possible regressions ====
igt@pm_rpm@module-reload:
fi-kbl-7567u: PASS -> DMESG-WARN
==== Warnings ====
igt@drv_selftest@live_hangcheck:
fi-icl-u: SKIP -> PASS
igt@pm_rpm@basic-rte:
fi-kbl-7567u: PASS -> SKIP +2
== Known issues ==
Here are the changes found in IGTPW_2047 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-reload:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@drv_module_reload@basic-reload-inject:
fi-kbl-7567u: PASS -> DMESG-WARN (fdo#105602) +1
igt@drv_selftest@live_coherency:
fi-gdg-551: PASS -> DMESG-FAIL (fdo#107164)
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
fi-byt-clapper: PASS -> FAIL (fdo#103191, fdo#107362)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-byt-clapper: PASS -> INCOMPLETE (fdo#102657)
fi-kbl-7567u: PASS -> DMESG-WARN (fdo#105602, fdo#105079) +1
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-kbl-7567u: PASS -> DMESG-FAIL (fdo#105079)
==== Possible fixes ====
igt@drv_selftest@live_execlists:
fi-icl-u: INCOMPLETE (fdo#108315) -> PASS
igt@gem_ctx_create@basic-files:
fi-icl-u2: DMESG-WARN (fdo#107724) -> PASS
igt@kms_chamelium@common-hpd-after-suspend:
fi-skl-6700k2: FAIL (fdo#103841) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#107362) -> PASS
==== Warnings ====
igt@drv_selftest@live_contexts:
fi-icl-u: INCOMPLETE (fdo#108315) -> DMESG-FAIL (fdo#108569)
fdo#102657 https://bugs.freedesktop.org/show_bug.cgi?id=102657
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#105079 https://bugs.freedesktop.org/show_bug.cgi?id=105079
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315
fdo#108569 https://bugs.freedesktop.org/show_bug.cgi?id=108569
== Participating hosts (52 -> 47) ==
Additional (1): fi-cnl-u
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* IGT: IGT_4712 -> IGTPW_2047
CI_DRM_5097: c20dfc4f015dfd41246beb7d72338aa50543a5ef @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2047: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2047/
IGT_4712: a3ede1b535ac8137f6949c468edd7054453d5dae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2047/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev2)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (7 preceding siblings ...)
2018-11-08 11:51 ` Patchwork
@ 2018-11-08 12:48 ` Patchwork
2018-11-08 12:51 ` Patchwork
` (18 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-11-08 12:48 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev2)
URL : https://patchwork.freedesktop.org/series/52000/
State : failure
== Summary ==
= CI Bug Log - changes from IGT_4712 -> IGTPW_2047 =
== Summary - FAILURE ==
Serious unknown changes coming with IGTPW_2047 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2047, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/2/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_2047:
=== IGT changes ===
==== Possible regressions ====
igt@pm_rpm@module-reload:
fi-kbl-7567u: PASS -> DMESG-WARN
==== Warnings ====
igt@drv_selftest@live_hangcheck:
fi-icl-u: SKIP -> PASS
igt@pm_rpm@basic-rte:
fi-kbl-7567u: PASS -> SKIP +2
== Known issues ==
Here are the changes found in IGTPW_2047 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-reload:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@drv_module_reload@basic-reload-inject:
fi-kbl-7567u: PASS -> DMESG-WARN (fdo#105602) +1
igt@drv_selftest@live_coherency:
fi-gdg-551: PASS -> DMESG-FAIL (fdo#107164)
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
fi-byt-clapper: PASS -> FAIL (fdo#103191, fdo#107362)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-byt-clapper: PASS -> INCOMPLETE (fdo#102657)
fi-kbl-7567u: PASS -> DMESG-WARN (fdo#105602, fdo#105079) +1
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-kbl-7567u: PASS -> DMESG-FAIL (fdo#105079)
==== Possible fixes ====
igt@drv_selftest@live_execlists:
fi-icl-u: INCOMPLETE (fdo#108315) -> PASS
igt@gem_ctx_create@basic-files:
fi-icl-u2: DMESG-WARN (fdo#107724) -> PASS
igt@kms_chamelium@common-hpd-after-suspend:
fi-skl-6700k2: FAIL (fdo#103841) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#107362) -> PASS
==== Warnings ====
igt@drv_selftest@live_contexts:
fi-icl-u: INCOMPLETE (fdo#108315) -> DMESG-FAIL (fdo#108569)
fdo#102657 https://bugs.freedesktop.org/show_bug.cgi?id=102657
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#105079 https://bugs.freedesktop.org/show_bug.cgi?id=105079
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315
fdo#108569 https://bugs.freedesktop.org/show_bug.cgi?id=108569
== Participating hosts (52 -> 47) ==
Additional (1): fi-cnl-u
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* IGT: IGT_4712 -> IGTPW_2047
CI_DRM_5097: c20dfc4f015dfd41246beb7d72338aa50543a5ef @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2047: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2047/
IGT_4712: a3ede1b535ac8137f6949c468edd7054453d5dae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2047/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev2)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (8 preceding siblings ...)
2018-11-08 12:48 ` Patchwork
@ 2018-11-08 12:51 ` Patchwork
2018-11-08 12:57 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
` (17 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-11-08 12:51 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev2)
URL : https://patchwork.freedesktop.org/series/52000/
State : failure
== Summary ==
= CI Bug Log - changes from IGT_4712 -> IGTPW_2047 =
== Summary - FAILURE ==
Serious unknown changes coming with IGTPW_2047 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2047, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/2/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_2047:
=== IGT changes ===
==== Possible regressions ====
igt@pm_rpm@module-reload:
fi-kbl-7567u: PASS -> DMESG-WARN
==== Warnings ====
igt@drv_selftest@live_hangcheck:
fi-icl-u: SKIP -> PASS
igt@pm_rpm@basic-rte:
fi-kbl-7567u: PASS -> SKIP +2
== Known issues ==
Here are the changes found in IGTPW_2047 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-reload:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@drv_module_reload@basic-reload-inject:
fi-kbl-7567u: PASS -> DMESG-WARN (fdo#105602) +1
igt@drv_selftest@live_coherency:
fi-gdg-551: PASS -> DMESG-FAIL (fdo#107164)
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-byt-clapper: PASS -> INCOMPLETE (fdo#102657)
fi-kbl-7567u: PASS -> DMESG-WARN (fdo#105079, fdo#105602) +1
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-kbl-7567u: PASS -> DMESG-FAIL (fdo#105079)
==== Possible fixes ====
igt@drv_selftest@live_execlists:
fi-icl-u: INCOMPLETE (fdo#108315) -> PASS
igt@gem_ctx_create@basic-files:
fi-icl-u2: DMESG-WARN (fdo#107724) -> PASS
igt@kms_chamelium@common-hpd-after-suspend:
fi-skl-6700k2: FAIL (fdo#103841) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#107362) -> PASS
==== Warnings ====
igt@drv_selftest@live_contexts:
fi-icl-u: INCOMPLETE (fdo#108315) -> DMESG-FAIL (fdo#108569)
fdo#102657 https://bugs.freedesktop.org/show_bug.cgi?id=102657
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#105079 https://bugs.freedesktop.org/show_bug.cgi?id=105079
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315
fdo#108569 https://bugs.freedesktop.org/show_bug.cgi?id=108569
== Participating hosts (52 -> 47) ==
Additional (1): fi-cnl-u
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* IGT: IGT_4712 -> IGTPW_2047
CI_DRM_5097: c20dfc4f015dfd41246beb7d72338aa50543a5ef @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2047: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2047/
IGT_4712: a3ede1b535ac8137f6949c468edd7054453d5dae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2047/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev2)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (9 preceding siblings ...)
2018-11-08 12:51 ` Patchwork
@ 2018-11-08 12:57 ` Patchwork
2018-11-08 20:15 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
` (16 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-11-08 12:57 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev2)
URL : https://patchwork.freedesktop.org/series/52000/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4712 -> IGTPW_2047 =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_2047 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2047, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/2/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_2047:
=== IGT changes ===
==== Warnings ====
igt@drv_selftest@live_hangcheck:
fi-icl-u: SKIP -> PASS
igt@pm_rpm@basic-rte:
fi-kbl-7567u: PASS -> SKIP +2
== Known issues ==
Here are the changes found in IGTPW_2047 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-reload:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@drv_module_reload@basic-reload-inject:
fi-kbl-7567u: PASS -> DMESG-WARN (fdo#105602) +1
igt@drv_selftest@live_coherency:
fi-gdg-551: PASS -> DMESG-FAIL (fdo#107164)
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-byt-clapper: PASS -> INCOMPLETE (fdo#102657)
fi-kbl-7567u: PASS -> DMESG-WARN (fdo#105602, fdo#105079) +1
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-kbl-7567u: PASS -> DMESG-FAIL (fdo#105079)
igt@pm_rpm@module-reload:
fi-kbl-7567u: PASS -> DMESG-WARN (fdo#108529)
==== Possible fixes ====
igt@drv_selftest@live_execlists:
fi-icl-u: INCOMPLETE (fdo#108315) -> PASS
igt@gem_ctx_create@basic-files:
fi-icl-u2: DMESG-WARN (fdo#107724) -> PASS
igt@kms_chamelium@common-hpd-after-suspend:
fi-skl-6700k2: FAIL (fdo#103841) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#107362) -> PASS
==== Warnings ====
igt@drv_selftest@live_contexts:
fi-icl-u: INCOMPLETE (fdo#108315) -> DMESG-FAIL (fdo#108569)
fdo#102657 https://bugs.freedesktop.org/show_bug.cgi?id=102657
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#105079 https://bugs.freedesktop.org/show_bug.cgi?id=105079
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315
fdo#108529 https://bugs.freedesktop.org/show_bug.cgi?id=108529
fdo#108569 https://bugs.freedesktop.org/show_bug.cgi?id=108569
== Participating hosts (52 -> 47) ==
Additional (1): fi-cnl-u
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* IGT: IGT_4712 -> IGTPW_2047
CI_DRM_5097: c20dfc4f015dfd41246beb7d72338aa50543a5ef @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2047: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2047/
IGT_4712: a3ede1b535ac8137f6949c468edd7054453d5dae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2047/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev2)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (10 preceding siblings ...)
2018-11-08 12:57 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
@ 2018-11-08 20:15 ` Patchwork
2018-11-09 6:44 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
` (15 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-11-08 20:15 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev2)
URL : https://patchwork.freedesktop.org/series/52000/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4712_full -> IGTPW_2047_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_2047_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2047_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/2/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_2047_full:
=== IGT changes ===
==== Warnings ====
igt@pm_rc6_residency@rc6-accuracy:
shard-snb: PASS -> SKIP
== Known issues ==
Here are the changes found in IGTPW_2047_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_available_modes_crc@available_mode_test_crc:
shard-apl: PASS -> FAIL (fdo#106641)
igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
shard-glk: PASS -> FAIL (fdo#108145)
igt@kms_cursor_crc@cursor-size-change:
shard-glk: PASS -> FAIL (fdo#103232)
shard-apl: PASS -> FAIL (fdo#103232)
shard-kbl: PASS -> FAIL (fdo#103232)
igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc:
shard-snb: PASS -> INCOMPLETE (fdo#105411)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
shard-apl: PASS -> FAIL (fdo#103167) +1
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
shard-glk: PASS -> FAIL (fdo#103167) +3
shard-kbl: PASS -> FAIL (fdo#103167) +1
igt@kms_plane@pixel-format-pipe-b-planes:
shard-kbl: PASS -> FAIL (fdo#103166)
igt@kms_plane@plane-position-covered-pipe-c-planes:
shard-glk: PASS -> FAIL (fdo#103166) +3
igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
shard-apl: PASS -> FAIL (fdo#103166) +4
igt@pm_rps@reset:
shard-apl: PASS -> FAIL (fdo#102250)
==== Possible fixes ====
igt@gem_exec_bad_domains@cpu-domain:
shard-apl: DMESG-WARN (fdo#105602, fdo#103558) -> PASS +5
igt@gem_pwrite_pread@snooped-copy-correctness:
shard-snb: INCOMPLETE (fdo#105411) -> PASS
igt@kms_available_modes_crc@available_mode_test_crc:
shard-hsw: FAIL (fdo#106641) -> PASS
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
shard-glk: DMESG-WARN (fdo#107956) -> PASS
igt@kms_color@pipe-b-legacy-gamma:
shard-apl: FAIL (fdo#104782) -> PASS
igt@kms_cursor_crc@cursor-256x256-suspend:
shard-apl: FAIL (fdo#103191, fdo#103232) -> PASS
igt@kms_cursor_crc@cursor-256x85-onscreen:
shard-apl: FAIL (fdo#103232) -> PASS +5
igt@kms_cursor_crc@cursor-64x64-dpms:
shard-kbl: FAIL (fdo#103232) -> PASS +3
igt@kms_cursor_crc@cursor-64x64-random:
shard-glk: FAIL (fdo#103232) -> PASS +4
igt@kms_cursor_legacy@cursor-vs-flip-toggle:
shard-hsw: FAIL (fdo#103355) -> PASS
igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
shard-glk: DMESG-WARN (fdo#105763, fdo#106538) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
shard-apl: FAIL (fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
shard-glk: FAIL (fdo#103167) -> PASS +1
igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
shard-glk: FAIL (fdo#108145) -> PASS
igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
shard-apl: FAIL (fdo#103166) -> PASS +3
igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
shard-glk: FAIL (fdo#103166) -> PASS +3
shard-kbl: FAIL (fdo#103166) -> PASS
igt@kms_setmode@basic-clone-single-crtc:
shard-snb: DMESG-WARN (fdo#107469) -> PASS +2
fdo#102250 https://bugs.freedesktop.org/show_bug.cgi?id=102250
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#107469 https://bugs.freedesktop.org/show_bug.cgi?id=107469
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
== Participating hosts (6 -> 5) ==
Missing (1): shard-skl
== Build changes ==
* IGT: IGT_4712 -> IGTPW_2047
CI_DRM_5097: c20dfc4f015dfd41246beb7d72338aa50543a5ef @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2047: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2047/
IGT_4712: a3ede1b535ac8137f6949c468edd7054453d5dae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2047/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev2)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (11 preceding siblings ...)
2018-11-08 20:15 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2018-11-09 6:44 ` Patchwork
2018-11-09 12:53 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
` (14 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-11-09 6:44 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev2)
URL : https://patchwork.freedesktop.org/series/52000/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4714 -> IGTPW_2051 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/2/mbox/
== Known issues ==
Here are the changes found in IGTPW_2051 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s4-devices:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@kms_frontbuffer_tracking@basic:
fi-icl-u2: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-byt-clapper: PASS -> FAIL (fdo#103191, fdo#107362)
==== Possible fixes ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#103191, fdo#107362) -> PASS
==== Warnings ====
igt@drv_selftest@live_contexts:
fi-icl-u2: INCOMPLETE (fdo#108315) -> DMESG-FAIL (fdo#108569)
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315
fdo#108569 https://bugs.freedesktop.org/show_bug.cgi?id=108569
== Participating hosts (53 -> 45) ==
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ctg-p8600 fi-pnv-d510
== Build changes ==
* IGT: IGT_4714 -> IGTPW_2051
CI_DRM_5106: 852b9329fbb6ea8bdbb3dac78328aae73d919305 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2051: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2051/
IGT_4714: cab148ca3ec904a94d0cd43476cf7e1f8663f906 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2051/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev2)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (12 preceding siblings ...)
2018-11-09 6:44 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
@ 2018-11-09 12:53 ` Patchwork
2018-12-13 11:56 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev3) Patchwork
` (13 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-11-09 12:53 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev2)
URL : https://patchwork.freedesktop.org/series/52000/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4714_full -> IGTPW_2051_full =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/2/mbox/
== Known issues ==
Here are the changes found in IGTPW_2051_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_suspend@shrink:
shard-glk: NOTRUN -> INCOMPLETE (fdo#106886, fdo#103359, k.org#198133)
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
shard-kbl: NOTRUN -> DMESG-WARN (fdo#107956) +1
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
shard-apl: PASS -> DMESG-WARN (fdo#107956)
igt@kms_color@pipe-b-degamma:
shard-apl: PASS -> FAIL (fdo#104782) +1
igt@kms_cursor_crc@cursor-256x256-sliding:
shard-glk: PASS -> FAIL (fdo#103232)
shard-hsw: PASS -> DMESG-FAIL (fdo#103232, fdo#102614)
igt@kms_cursor_crc@cursor-64x21-random:
shard-apl: PASS -> FAIL (fdo#103232) +3
igt@kms_cursor_crc@cursor-64x64-onscreen:
shard-kbl: PASS -> FAIL (fdo#103232) +1
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-gtt:
shard-snb: PASS -> INCOMPLETE (fdo#105411)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
shard-apl: PASS -> FAIL (fdo#103167)
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
shard-glk: PASS -> FAIL (fdo#103167)
igt@kms_plane@plane-position-covered-pipe-c-planes:
shard-apl: PASS -> FAIL (fdo#103166) +1
shard-glk: NOTRUN -> FAIL (fdo#103166) +1
igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
shard-glk: NOTRUN -> FAIL (fdo#108145) +2
igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
shard-kbl: PASS -> FAIL (fdo#103166) +1
igt@kms_properties@connector-properties-atomic:
shard-glk: NOTRUN -> FAIL (fdo#108642)
shard-hsw: NOTRUN -> FAIL (fdo#108642)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
igt@kms_vblank@pipe-a-ts-continuation-suspend:
shard-hsw: PASS -> FAIL (fdo#104894)
igt@pm_rpm@modeset-stress-extra-wait:
shard-apl: PASS -> INCOMPLETE (fdo#103927)
==== Possible fixes ====
igt@drv_suspend@forcewake:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS
igt@drv_suspend@shrink:
shard-snb: INCOMPLETE (fdo#105411, fdo#106886) -> PASS
igt@gem_ppgtt@blt-vs-render-ctx0:
shard-kbl: INCOMPLETE (fdo#103665, fdo#106887, fdo#106023) -> PASS
igt@kms_available_modes_crc@available_mode_test_crc:
shard-hsw: FAIL (fdo#106641) -> PASS
igt@kms_cursor_crc@cursor-128x42-sliding:
shard-kbl: FAIL (fdo#103232) -> PASS +3
igt@kms_cursor_crc@cursor-64x21-sliding:
shard-apl: FAIL (fdo#103232) -> PASS +3
igt@kms_cursor_crc@cursor-64x64-suspend:
shard-glk: FAIL (fdo#103232) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
shard-apl: FAIL (fdo#103167) -> PASS +1
igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
shard-apl: FAIL (fdo#103166) -> PASS +1
igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
shard-kbl: FAIL (fdo#103166) -> PASS
shard-glk: FAIL (fdo#103166) -> PASS +1
igt@kms_setmode@basic:
shard-kbl: FAIL (fdo#99912) -> PASS
igt@kms_vblank@pipe-a-query-busy:
shard-snb: INCOMPLETE (fdo#105411) -> PASS
igt@perf_pmu@busy-start-vcs0:
shard-apl: DMESG-WARN (fdo#105602, fdo#103558) -> PASS
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#104894 https://bugs.freedesktop.org/show_bug.cgi?id=104894
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#106887 https://bugs.freedesktop.org/show_bug.cgi?id=106887
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108642 https://bugs.freedesktop.org/show_bug.cgi?id=108642
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (6 -> 5) ==
Missing (1): shard-skl
== Build changes ==
* IGT: IGT_4714 -> IGTPW_2051
CI_DRM_5106: 852b9329fbb6ea8bdbb3dac78328aae73d919305 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2051: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2051/
IGT_4714: cab148ca3ec904a94d0cd43476cf7e1f8663f906 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2051/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons
2018-11-05 11:32 ` [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons Juha-Pekka Heikkila
2018-11-05 12:19 ` Maarten Lankhorst
@ 2018-12-13 11:16 ` Juha-Pekka Heikkila
2018-12-14 13:01 ` Juha-Pekka Heikkila
1 sibling, 1 reply; 49+ messages in thread
From: Juha-Pekka Heikkila @ 2018-12-13 11:16 UTC (permalink / raw)
To: igt-dev
Fixed handling of single plane modes so used bpp never get to
be 0 and ease off crc comparison a bit with gamma tables as
idea of this test is to see chosen modes are able to initialize.
Release output to PIPE_ANY at end of test per connector.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106641
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
tests/kms_available_modes_crc.c | 124 ++++++++++++++++++++++------------------
1 file changed, 69 insertions(+), 55 deletions(-)
diff --git a/tests/kms_available_modes_crc.c b/tests/kms_available_modes_crc.c
index 45a4775..e4c2097 100644
--- a/tests/kms_available_modes_crc.c
+++ b/tests/kms_available_modes_crc.c
@@ -54,6 +54,12 @@ typedef struct {
igt_crc_t cursor_crc;
igt_crc_t fullscreen_crc;
+
+ /*
+ * If there's unknown format setting up mode can fail
+ * without failing entire test.
+ */
+ bool allow_fail;
} data_t;
@@ -120,7 +126,6 @@ static void generate_comparison_crc_list(data_t *data, igt_output_t *output)
static const struct {
uint32_t fourcc;
- char zeropadding;
enum { BYTES_PP_1=1,
BYTES_PP_2=2,
BYTES_PP_4=4,
@@ -129,42 +134,33 @@ static const struct {
SKIP4 } bpp;
uint32_t value;
} fillers[] = {
- { DRM_FORMAT_C8, 0, BYTES_PP_1, 0xff},
- { DRM_FORMAT_RGB565, 0, BYTES_PP_2, 0xffff},
- { DRM_FORMAT_XRGB8888, 0, BYTES_PP_4, 0xffffffff},
- { DRM_FORMAT_XBGR8888, 0, BYTES_PP_4, 0xffffffff},
-
- /*
- * following two are skipped because blending seems to work
- * incorrectly with exception of AR24 on cursor plane.
- * Test still creates the planes, just filling plane
- * and getting crc is skipped.
- */
- { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff},
- { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff},
-
- { DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff},
- { DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff},
-
- { DRM_FORMAT_YUYV, 0, BYTES_PP_4, 0x80eb80eb},
- { DRM_FORMAT_YVYU, 0, BYTES_PP_4, 0x80eb80eb},
- { DRM_FORMAT_VYUY, 0, BYTES_PP_4, 0xeb80eb80},
- { DRM_FORMAT_UYVY, 0, BYTES_PP_4, 0xeb80eb80},
+ { DRM_FORMAT_C8, BYTES_PP_1, 0xff},
+ { DRM_FORMAT_RGB565, BYTES_PP_2, 0xffff},
+ { DRM_FORMAT_XRGB8888, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_XBGR8888, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_ARGB8888, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_ABGR8888, BYTES_PP_4, 0x00ffffff},
+ { DRM_FORMAT_XRGB2101010, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_XBGR2101010, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_YUYV, BYTES_PP_4, 0x80eb80eb},
+ { DRM_FORMAT_YVYU, BYTES_PP_4, 0x80eb80eb},
+ { DRM_FORMAT_VYUY, BYTES_PP_4, 0xeb80eb80},
+ { DRM_FORMAT_UYVY, BYTES_PP_4, 0xeb80eb80},
/*
* (semi-)planar formats
*/
- { DRM_FORMAT_NV12, 0, NV12, 0x80eb},
+ { DRM_FORMAT_NV12, NV12, 0x80eb},
#ifdef DRM_FORMAT_P010
- { DRM_FORMAT_P010, 0, P010, 0x8000eb00},
+ { DRM_FORMAT_P010, P010, 0x8000eb00},
#endif
#ifdef DRM_FORMAT_P012
- { DRM_FORMAT_P012, 0, P010, 0x8000eb00},
+ { DRM_FORMAT_P012, P010, 0x8000eb00},
#endif
#ifdef DRM_FORMAT_P016
- { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
+ { DRM_FORMAT_P016, P010, 0x8000eb00},
#endif
- { 0, 0, 0, 0 }
+ { 0, SKIP4, 0 }
};
/*
@@ -221,24 +217,9 @@ static bool fill_in_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
writesize = data->size+data->size/2;
break;
case SKIP4:
- if (fillers[i].fourcc == DRM_FORMAT_ARGB8888 &&
- plane->type == DRM_PLANE_TYPE_CURSOR) {
- /*
- * special for cursor plane where blending works correctly.
- */
- ptemp_32_buf = (unsigned int*)data->buf;
- for (c = 0; c < data->size/4; c++)
- ptemp_32_buf[c] = fillers[i].value;
- writesize = data->size;
- break;
- }
- igt_info("Format %s CRC comparison skipped by design.\n",
- (char*)&fillers[i].fourcc);
-
- return false;
default:
- igt_info("Unsupported mode for test %s\n",
- (char*)&fillers[i].fourcc);
+ igt_info("Unsupported mode for testing CRC %.4s\n",
+ (char*)&format);
return false;
}
@@ -261,6 +242,8 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
int bpp = 0;
int i;
+ data->allow_fail = false;
+
mode = igt_output_get_mode(output);
if (plane->type != DRM_PLANE_TYPE_CURSOR) {
w = mode->hdisplay;
@@ -289,6 +272,8 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
break;
case SKIP4:
+ data->allow_fail = true;
+ /* fall through */
case BYTES_PP_4:
bpp = 32;
break;
@@ -409,27 +394,29 @@ test_one_mode(data_t* data, igt_output_t *output, igt_plane_t* plane,
&data->fullscreen_crc)) {
crccompare[0] = igt_crc_to_string(¤t_crc);
crccompare[1] = igt_crc_to_string(&data->fullscreen_crc);
- igt_warn("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
+ igt_info("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
free(crccompare[0]);
free(crccompare[1]);
- rVal++;
+ if (!data->allow_fail)
+ rVal++;
}
} else {
if (!igt_check_crc_equal(¤t_crc,
&data->cursor_crc)) {
crccompare[0] = igt_crc_to_string(¤t_crc);
crccompare[1] = igt_crc_to_string(&data->cursor_crc);
- igt_warn("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
+ igt_info("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
free(crccompare[0]);
free(crccompare[1]);
- rVal++;
+ if (!data->allow_fail)
+ rVal++;
}
}
}
remove_fb(data, output, plane);
return rVal;
}
- return 1;
+ return data->allow_fail ? 0 : 1;
}
@@ -440,14 +427,40 @@ test_available_modes(data_t* data)
igt_plane_t *plane;
int modeindex;
enum pipe pipe;
- int invalids = 0;
+ int failed_crcs = 0, i, lut_size;
drmModePlane *modePlane;
char planetype[3][8] = {"OVERLAY\0", "PRIMARY\0", "CURSOR\0" };
+ struct {
+ uint16_t red;
+ uint16_t green;
+ uint16_t blue;
+ uint16_t reserved;
+ } *lut;
+
for_each_pipe_with_valid_output(&data->display, pipe, output) {
+ igt_display_reset(&data->display);
igt_output_set_pipe(output, pipe);
igt_display_commit2(&data->display, data->commit);
+ if (igt_pipe_obj_get_prop(&data->display.pipes[pipe],
+ IGT_CRTC_GAMMA_LUT_SIZE)) {
+ lut_size = igt_pipe_get_prop(&data->display, pipe,
+ IGT_CRTC_GAMMA_LUT_SIZE);
+ lut = calloc(sizeof(*lut), lut_size);
+
+ for (i = 0; i < lut_size; i++) {
+ lut[i].red = (i * 0xffff / (lut_size - 1)) & 0xfc00;
+ lut[i].green = (i * 0xffff / (lut_size - 1)) & 0xfc00;
+ lut[i].blue = (i * 0xffff / (lut_size - 1)) & 0xfc00;
+ }
+
+ igt_pipe_replace_prop_blob(&data->display, pipe,
+ IGT_CRTC_GAMMA_LUT,
+ lut, sizeof(*lut) * lut_size);
+ free(lut);
+ }
+
data->pipe_crc = igt_pipe_crc_new(data->gfx_fd, pipe,
INTEL_PIPE_CRC_SOURCE_AUTO);
@@ -475,17 +488,18 @@ test_available_modes(data_t* data)
planetype[plane->type],
(char*)&data->format.name);
- invalids += test_one_mode(data, output,
- plane,
- modePlane->formats[modeindex]);
+ failed_crcs += test_one_mode(data, output,
+ plane,
+ modePlane->formats[modeindex]);
}
drmModeFreePlane(modePlane);
}
igt_pipe_crc_stop(data->pipe_crc);
igt_pipe_crc_free(data->pipe_crc);
- igt_display_commit2(&data->display, data->commit);
+
+ igt_output_set_pipe(output, PIPE_ANY);
}
- igt_assert(invalids == 0);
+ igt_assert(failed_crcs == 0);
}
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 49+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev3)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (13 preceding siblings ...)
2018-11-09 12:53 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2018-12-13 11:56 ` Patchwork
2018-12-13 13:22 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
` (12 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-12-13 11:56 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev3)
URL : https://patchwork.freedesktop.org/series/52000/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5311 -> IGTPW_2148
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/3/mbox/
Known issues
------------
Here are the changes found in IGTPW_2148 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload:
- fi-kbl-7567u: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602]
* igt@i915_module_load@reload-with-fault-injection:
- fi-kbl-7567u: PASS -> DMESG-WARN [fdo#105602]
* igt@i915_selftest@live_hangcheck:
- fi-bwr-2160: PASS -> DMESG-FAIL [fdo#108735]
* igt@kms_flip@basic-flip-vs-dpms:
- fi-icl-u3: NOTRUN -> DMESG-WARN [fdo#108924] / [fdo#109044]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* {igt@runner@aborted}:
- fi-icl-u3: NOTRUN -> FAIL [fdo#108924]
- fi-kbl-7567u: NOTRUN -> FAIL [fdo#105602]
#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- fi-kbl-7560u: INCOMPLETE [fdo#103665] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108735]: https://bugs.freedesktop.org/show_bug.cgi?id=108735
[fdo#108924]: https://bugs.freedesktop.org/show_bug.cgi?id=108924
[fdo#109044]: https://bugs.freedesktop.org/show_bug.cgi?id=109044
Participating hosts (47 -> 43)
------------------------------
Additional (1): fi-icl-u3
Missing (5): fi-kbl-soraka fi-ilk-m540 fi-byt-j1900 fi-byt-squawks fi-ctg-p8600
Build changes
-------------
* IGT: IGT_4746 -> IGTPW_2148
CI_DRM_5311: a42fd8bf199784ee4ff1cdb5ee03eedd9a535d4a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2148: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2148/
IGT_4746: 2c793666d8c8328733f5769b16ae5858fee97f3f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2148/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev3)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (14 preceding siblings ...)
2018-12-13 11:56 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev3) Patchwork
@ 2018-12-13 13:22 ` Patchwork
2018-12-13 14:37 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev4) Patchwork
` (11 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-12-13 13:22 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev3)
URL : https://patchwork.freedesktop.org/series/52000/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5311_full -> IGTPW_2148_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2148_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2148_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/3/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2148_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: PASS -> FAIL
#### Warnings ####
* igt@pm_rc6_residency@rc6-accuracy:
- shard-kbl: SKIP -> PASS
- shard-snb: SKIP -> PASS
Known issues
------------
Here are the changes found in IGTPW_2148_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@pi-ringfull-bsd:
- shard-apl: NOTRUN -> FAIL [fdo#103158]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145]
- shard-kbl: PASS -> FAIL [fdo#107725] / [fdo#108145]
* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-kbl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: PASS -> FAIL [fdo#103232] +3
* igt@kms_cursor_crc@cursor-64x64-dpms:
- shard-glk: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232] +1
- shard-kbl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_flip@dpms-vs-vblank-race:
- shard-apl: PASS -> FAIL [fdo#103060]
* igt@kms_flip@flip-vs-expired-vblank:
- shard-snb: PASS -> FAIL [fdo#105363]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-apl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
- shard-glk: PASS -> FAIL [fdo#103167] +5
* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-glk: PASS -> FAIL [fdo#103166] +2
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: PASS -> FAIL [fdo#103166] +5
- shard-kbl: PASS -> FAIL [fdo#103166] +2
* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
#### Possible fixes ####
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS
- shard-apl: FAIL [fdo#103232] -> PASS +2
- shard-glk: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-512x512-onscreen:
- shard-apl: INCOMPLETE [fdo#103927] -> SKIP
* igt@kms_flip@modeset-vs-vblank-race:
- shard-apl: FAIL [fdo#103060] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-apl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt:
- shard-snb: INCOMPLETE [fdo#105411] / [fdo#107469] -> SKIP
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-glk: FAIL [fdo#103166] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- shard-apl: FAIL [fdo#103166] -> PASS
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-glk: DMESG-FAIL [fdo#105763] / [fdo#106538] -> PASS
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4746 -> IGTPW_2148
* Piglit: piglit_4509 -> None
CI_DRM_5311: a42fd8bf199784ee4ff1cdb5ee03eedd9a535d4a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2148: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2148/
IGT_4746: 2c793666d8c8328733f5769b16ae5858fee97f3f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2148/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev4)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (15 preceding siblings ...)
2018-12-13 13:22 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2018-12-13 14:37 ` Patchwork
2018-12-13 18:32 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev5) Patchwork
` (10 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-12-13 14:37 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev4)
URL : https://patchwork.freedesktop.org/series/52000/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5311 -> IGTPW_2154
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with IGTPW_2154 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2154, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/4/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2154:
### IGT changes ###
#### Warnings ####
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c:
- fi-kbl-7567u: PASS -> SKIP +33
Known issues
------------
Here are the changes found in IGTPW_2154 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@i915_module_load@reload-with-fault-injection:
- fi-kbl-7567u: PASS -> DMESG-WARN [fdo#105602] / [fdo#108529] +1
* igt@i915_selftest@live_hangcheck:
- fi-bwr-2160: PASS -> DMESG-FAIL [fdo#108735]
* igt@kms_flip@basic-flip-vs-dpms:
- fi-icl-u3: NOTRUN -> DMESG-WARN [fdo#108924] / [fdo#109044]
* igt@pm_rpm@module-reload:
- fi-kbl-7567u: PASS -> DMESG-WARN [fdo#108529]
* {igt@runner@aborted}:
- fi-icl-u3: NOTRUN -> FAIL [fdo#108924]
- fi-icl-y: NOTRUN -> FAIL [fdo#108070]
#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- fi-kbl-7560u: INCOMPLETE [fdo#103665] -> PASS
#### Warnings ####
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7567u: DMESG-WARN [fdo#108473] -> DMESG-FAIL [fdo#105079]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108070]: https://bugs.freedesktop.org/show_bug.cgi?id=108070
[fdo#108473]: https://bugs.freedesktop.org/show_bug.cgi?id=108473
[fdo#108529]: https://bugs.freedesktop.org/show_bug.cgi?id=108529
[fdo#108735]: https://bugs.freedesktop.org/show_bug.cgi?id=108735
[fdo#108924]: https://bugs.freedesktop.org/show_bug.cgi?id=108924
[fdo#109044]: https://bugs.freedesktop.org/show_bug.cgi?id=109044
Participating hosts (47 -> 44)
------------------------------
Additional (2): fi-icl-y fi-icl-u3
Missing (5): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-ctg-p8600 fi-skl-6700hq
Build changes
-------------
* IGT: IGT_4746 -> IGTPW_2154
CI_DRM_5311: a42fd8bf199784ee4ff1cdb5ee03eedd9a535d4a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2154: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2154/
IGT_4746: 2c793666d8c8328733f5769b16ae5858fee97f3f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2154/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev5)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (16 preceding siblings ...)
2018-12-13 14:37 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev4) Patchwork
@ 2018-12-13 18:32 ` Patchwork
2018-12-13 18:45 ` [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev4) Patchwork
` (9 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-12-13 18:32 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev5)
URL : https://patchwork.freedesktop.org/series/52000/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5312 -> IGTPW_2157
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with IGTPW_2157 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2157, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/5/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2157:
### IGT changes ###
#### Warnings ####
* igt@pm_rpm@basic-pci-d3-state:
- fi-byt-n2820: SKIP -> PASS
- fi-bsw-kefka: SKIP -> PASS
* igt@pm_rpm@basic-rte:
- fi-kbl-7567u: SKIP -> PASS +4
Known issues
------------
Here are the changes found in IGTPW_2157 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: PASS -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@prime_vgem@basic-fence-flip:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- fi-bsw-n3050: INCOMPLETE [fdo#105876] -> PASS
* igt@i915_module_load@reload-with-fault-injection:
- fi-kbl-7567u: DMESG-WARN [fdo#105602] / [fdo#108529] -> PASS +1
* igt@i915_selftest@live_coherency:
- fi-gdg-551: DMESG-FAIL [fdo#107164] -> PASS
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: FAIL [fdo#108767] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS +1
- fi-kbl-7567u: DMESG-FAIL [fdo#105079] -> PASS
* igt@pm_rpm@basic-rte:
- fi-byt-n2820: FAIL -> PASS
- fi-bsw-kefka: FAIL -> PASS
* igt@pm_rpm@module-reload:
- fi-kbl-7567u: DMESG-WARN [fdo#108529] -> PASS
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105876]: https://bugs.freedesktop.org/show_bug.cgi?id=105876
[fdo#107164]: https://bugs.freedesktop.org/show_bug.cgi?id=107164
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108529]: https://bugs.freedesktop.org/show_bug.cgi?id=108529
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
Participating hosts (53 -> 47)
------------------------------
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
Build changes
-------------
* IGT: IGT_4747 -> IGTPW_2157
CI_DRM_5312: e69755d086d38d559a362ed714036f883b7ba79a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2157: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2157/
IGT_4747: ad821d1dc5d0eea4ac3a0e8e29c56c7f66191108 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2157/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev4)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (17 preceding siblings ...)
2018-12-13 18:32 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev5) Patchwork
@ 2018-12-13 18:45 ` Patchwork
2018-12-13 18:47 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev6) Patchwork
` (8 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-12-13 18:45 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev4)
URL : https://patchwork.freedesktop.org/series/52000/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5311_full -> IGTPW_2154_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2154_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2154_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/4/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2154_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: PASS -> FAIL
* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-kbl: PASS -> FAIL
#### Warnings ####
* igt@pm_rc6_residency@rc6-accuracy:
- shard-kbl: SKIP -> PASS
- shard-snb: SKIP -> PASS
* igt@tools_test@tools_test:
- shard-apl: PASS -> SKIP
Known issues
------------
Here are the changes found in IGTPW_2154_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@pi-ringfull-bsd:
- shard-apl: NOTRUN -> FAIL [fdo#103158]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_cursor_crc@cursor-128x128-sliding:
- shard-kbl: PASS -> FAIL [fdo#103232] +1
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-glk: PASS -> FAIL [fdo#103232] +3
- shard-apl: PASS -> FAIL [fdo#103232] +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- shard-kbl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-apl: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-msflip-blt:
- shard-snb: SKIP -> INCOMPLETE [fdo#105411]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite:
- shard-glk: PASS -> FAIL [fdo#103167] +10
* igt@kms_frontbuffer_tracking@fbc-2p-rte:
- shard-glk: PASS -> FAIL [fdo#103167] / [fdo#105682]
* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-glk: PASS -> FAIL [fdo#108948]
- shard-apl: PASS -> FAIL [fdo#108948]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-apl: PASS -> FAIL [fdo#103166] +1
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +2
* igt@kms_plane_scaling@pipe-b-scaler-with-rotation:
- shard-glk: PASS -> DMESG-WARN [fdo#105763] / [fdo#106538]
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: PASS -> DMESG-WARN [fdo#105604]
* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]
* igt@perf_pmu@rc6-runtime-pm-long:
- shard-apl: PASS -> FAIL [fdo#105010]
- shard-glk: PASS -> FAIL [fdo#105010]
#### Possible fixes ####
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-glk: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-512x512-onscreen:
- shard-apl: INCOMPLETE [fdo#103927] -> SKIP
* igt@kms_flip@modeset-vs-vblank-race:
- shard-apl: FAIL [fdo#103060] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
- shard-apl: FAIL [fdo#103167] -> PASS
* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-apl: FAIL [fdo#103166] -> PASS +2
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-glk: FAIL [fdo#103166] -> PASS +1
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-glk: DMESG-FAIL [fdo#105763] / [fdo#106538] -> PASS
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105604]: https://bugs.freedesktop.org/show_bug.cgi?id=105604
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4746 -> IGTPW_2154
* Piglit: piglit_4509 -> None
CI_DRM_5311: a42fd8bf199784ee4ff1cdb5ee03eedd9a535d4a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2154: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2154/
IGT_4746: 2c793666d8c8328733f5769b16ae5858fee97f3f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2154/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev6)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (18 preceding siblings ...)
2018-12-13 18:45 ` [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev4) Patchwork
@ 2018-12-13 18:47 ` Patchwork
2018-12-13 22:27 ` [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev5) Patchwork
` (7 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-12-13 18:47 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev6)
URL : https://patchwork.freedesktop.org/series/52000/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5312 -> IGTPW_2158
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with IGTPW_2158 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2158, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/6/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2158:
### IGT changes ###
#### Warnings ####
* igt@pm_rpm@basic-pci-d3-state:
- fi-byt-n2820: SKIP -> PASS
- fi-bsw-kefka: SKIP -> PASS
* igt@pm_rpm@basic-rte:
- fi-kbl-7567u: SKIP -> PASS +4
Known issues
------------
Here are the changes found in IGTPW_2158 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_contexts:
- fi-kbl-7560u: PASS -> INCOMPLETE [fdo#108767]
#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- fi-bsw-n3050: INCOMPLETE [fdo#105876] -> PASS
* igt@i915_module_load@reload-with-fault-injection:
- fi-kbl-7567u: DMESG-WARN [fdo#105602] / [fdo#108529] -> PASS +1
* igt@i915_selftest@live_coherency:
- fi-gdg-551: DMESG-FAIL [fdo#107164] -> PASS
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: FAIL [fdo#108767] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS +1
- fi-kbl-7567u: DMESG-FAIL [fdo#105079] -> PASS
* igt@pm_rpm@basic-rte:
- fi-byt-n2820: FAIL -> PASS
- fi-bsw-kefka: FAIL -> PASS
* igt@pm_rpm@module-reload:
- fi-kbl-7567u: DMESG-WARN [fdo#108529] -> PASS
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105876]: https://bugs.freedesktop.org/show_bug.cgi?id=105876
[fdo#107164]: https://bugs.freedesktop.org/show_bug.cgi?id=107164
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108529]: https://bugs.freedesktop.org/show_bug.cgi?id=108529
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
Participating hosts (53 -> 46)
------------------------------
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-y
Build changes
-------------
* IGT: IGT_4747 -> IGTPW_2158
CI_DRM_5312: e69755d086d38d559a362ed714036f883b7ba79a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2158: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2158/
IGT_4747: ad821d1dc5d0eea4ac3a0e8e29c56c7f66191108 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2158/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev5)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (19 preceding siblings ...)
2018-12-13 18:47 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev6) Patchwork
@ 2018-12-13 22:27 ` Patchwork
2018-12-13 23:16 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev6) Patchwork
` (6 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-12-13 22:27 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev5)
URL : https://patchwork.freedesktop.org/series/52000/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5312_full -> IGTPW_2157_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2157_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2157_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/5/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2157_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_busy@extended-semaphore-blt:
- shard-hsw: PASS -> FAIL
#### Warnings ####
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-snb: SKIP -> PASS +1
Known issues
------------
Here are the changes found in IGTPW_2157_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_suspend@shrink:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#108784]
* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-hsw: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-glk: PASS -> FAIL [fdo#103232] +3
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: PASS -> FAIL [fdo#103232] +4
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-apl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: PASS -> FAIL [fdo#103167] +10
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-move:
- shard-snb: SKIP -> INCOMPLETE [fdo#105411]
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +3
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-glk: PASS -> FAIL [fdo#103166] +2
#### Possible fixes ####
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: FAIL [fdo#106641] -> PASS
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS
- shard-glk: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-kbl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: FAIL [fdo#103232] -> PASS +4
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS +1
* igt@kms_flip@dpms-vs-vblank-race-interruptible:
- shard-glk: FAIL [fdo#103060] -> PASS
* igt@kms_flip@flip-vs-panning-vs-hang-interruptible:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-kbl: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-apl: FAIL [fdo#103167] -> PASS +5
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-glk: FAIL [fdo#103167] -> PASS +2
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: FAIL [fdo#108145] -> PASS +2
* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- shard-kbl: FAIL [fdo#103166] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +4
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
* igt@perf_pmu@rc6-runtime-pm:
- shard-kbl: FAIL [fdo#105010] -> PASS
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4747 -> IGTPW_2157
* Piglit: piglit_4509 -> None
CI_DRM_5312: e69755d086d38d559a362ed714036f883b7ba79a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2157: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2157/
IGT_4747: ad821d1dc5d0eea4ac3a0e8e29c56c7f66191108 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2157/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev6)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (20 preceding siblings ...)
2018-12-13 22:27 ` [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev5) Patchwork
@ 2018-12-13 23:16 ` Patchwork
2018-12-14 13:25 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev7) Patchwork
` (5 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-12-13 23:16 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev6)
URL : https://patchwork.freedesktop.org/series/52000/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5312_full -> IGTPW_2158_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with IGTPW_2158_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2158_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/6/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2158_full:
### IGT changes ###
#### Warnings ####
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-snb: SKIP -> PASS +1
* igt@pm_rc6_residency@rc6-accuracy:
- shard-snb: PASS -> SKIP
Known issues
------------
Here are the changes found in IGTPW_2158_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_suspend@shrink:
- shard-snb: NOTRUN -> INCOMPLETE [fdo#105411] / [fdo#106886]
* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-hsw: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_color@pipe-a-degamma:
- shard-apl: PASS -> FAIL [fdo#104782] / [fdo#108145]
* igt@kms_color@pipe-c-legacy-gamma:
- shard-apl: PASS -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-128x128-dpms:
- shard-glk: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-256x85-onscreen:
- shard-apl: PASS -> FAIL [fdo#103232] +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-apl: PASS -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary:
- shard-glk: PASS -> FAIL [fdo#103167] +4
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-apl: PASS -> FAIL [fdo#108948]
* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-glk: PASS -> FAIL [fdo#103166] +1
* igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
- shard-apl: PASS -> FAIL [fdo#103166]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_setmode@basic:
- shard-hsw: PASS -> FAIL [fdo#99912]
#### Possible fixes ####
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-kbl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-glk: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: FAIL [fdo#103232] -> PASS +5
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS +1
* igt@kms_flip@dpms-vs-vblank-race-interruptible:
- shard-glk: FAIL [fdo#103060] -> PASS
* igt@kms_flip@flip-vs-panning-vs-hang-interruptible:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-kbl: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-apl: FAIL [fdo#103167] -> PASS +4
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-glk: FAIL [fdo#103167] -> PASS +2
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-kbl: FAIL [fdo#108145] -> PASS
- shard-apl: FAIL [fdo#108145] -> PASS
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: FAIL [fdo#108145] -> PASS +4
* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- shard-glk: FAIL [fdo#103166] -> PASS +2
- shard-kbl: FAIL [fdo#103166] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +4
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
* igt@perf_pmu@rc6-runtime-pm:
- shard-kbl: FAIL [fdo#105010] -> PASS
#### Warnings ####
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-glk: DMESG-FAIL [fdo#105763] / [fdo#106538] -> DMESG-WARN [fdo#105763] / [fdo#106538]
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4747 -> IGTPW_2158
* Piglit: piglit_4509 -> None
CI_DRM_5312: e69755d086d38d559a362ed714036f883b7ba79a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2158: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2158/
IGT_4747: ad821d1dc5d0eea4ac3a0e8e29c56c7f66191108 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2158/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons
2018-12-13 11:16 ` Juha-Pekka Heikkila
@ 2018-12-14 13:01 ` Juha-Pekka Heikkila
2018-12-18 14:40 ` Juha-Pekka Heikkila
0 siblings, 1 reply; 49+ messages in thread
From: Juha-Pekka Heikkila @ 2018-12-14 13:01 UTC (permalink / raw)
To: igt-dev
Fixed handling of single plane modes so used bpp never get to
be 0 and ease off crc comparison a bit with gamma tables as
idea of this test is to see chosen modes are able to initialize.
Release output to PIPE_ANY at end of test per connector.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106641
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
tests/kms_available_modes_crc.c | 124 ++++++++++++++++++++++------------------
1 file changed, 69 insertions(+), 55 deletions(-)
diff --git a/tests/kms_available_modes_crc.c b/tests/kms_available_modes_crc.c
index 45a4775..d7688ab 100644
--- a/tests/kms_available_modes_crc.c
+++ b/tests/kms_available_modes_crc.c
@@ -54,6 +54,12 @@ typedef struct {
igt_crc_t cursor_crc;
igt_crc_t fullscreen_crc;
+
+ /*
+ * If there's unknown format setting up mode can fail
+ * without failing entire test.
+ */
+ bool allow_fail;
} data_t;
@@ -120,7 +126,6 @@ static void generate_comparison_crc_list(data_t *data, igt_output_t *output)
static const struct {
uint32_t fourcc;
- char zeropadding;
enum { BYTES_PP_1=1,
BYTES_PP_2=2,
BYTES_PP_4=4,
@@ -129,42 +134,33 @@ static const struct {
SKIP4 } bpp;
uint32_t value;
} fillers[] = {
- { DRM_FORMAT_C8, 0, BYTES_PP_1, 0xff},
- { DRM_FORMAT_RGB565, 0, BYTES_PP_2, 0xffff},
- { DRM_FORMAT_XRGB8888, 0, BYTES_PP_4, 0xffffffff},
- { DRM_FORMAT_XBGR8888, 0, BYTES_PP_4, 0xffffffff},
-
- /*
- * following two are skipped because blending seems to work
- * incorrectly with exception of AR24 on cursor plane.
- * Test still creates the planes, just filling plane
- * and getting crc is skipped.
- */
- { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff},
- { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff},
-
- { DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff},
- { DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff},
-
- { DRM_FORMAT_YUYV, 0, BYTES_PP_4, 0x80eb80eb},
- { DRM_FORMAT_YVYU, 0, BYTES_PP_4, 0x80eb80eb},
- { DRM_FORMAT_VYUY, 0, BYTES_PP_4, 0xeb80eb80},
- { DRM_FORMAT_UYVY, 0, BYTES_PP_4, 0xeb80eb80},
+ { DRM_FORMAT_C8, BYTES_PP_1, 0xff},
+ { DRM_FORMAT_RGB565, BYTES_PP_2, 0xffff},
+ { DRM_FORMAT_XRGB8888, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_XBGR8888, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_ARGB8888, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_ABGR8888, BYTES_PP_4, 0x00ffffff},
+ { DRM_FORMAT_XRGB2101010, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_XBGR2101010, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_YUYV, BYTES_PP_4, 0x80eb80eb},
+ { DRM_FORMAT_YVYU, BYTES_PP_4, 0x80eb80eb},
+ { DRM_FORMAT_VYUY, BYTES_PP_4, 0xeb80eb80},
+ { DRM_FORMAT_UYVY, BYTES_PP_4, 0xeb80eb80},
/*
* (semi-)planar formats
*/
- { DRM_FORMAT_NV12, 0, NV12, 0x80eb},
+ { DRM_FORMAT_NV12, NV12, 0x80eb},
#ifdef DRM_FORMAT_P010
- { DRM_FORMAT_P010, 0, P010, 0x8000eb00},
+ { DRM_FORMAT_P010, P010, 0x8000eb00},
#endif
#ifdef DRM_FORMAT_P012
- { DRM_FORMAT_P012, 0, P010, 0x8000eb00},
+ { DRM_FORMAT_P012, P010, 0x8000eb00},
#endif
#ifdef DRM_FORMAT_P016
- { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
+ { DRM_FORMAT_P016, P010, 0x8000eb00},
#endif
- { 0, 0, 0, 0 }
+ { 0, SKIP4, 0 }
};
/*
@@ -221,24 +217,9 @@ static bool fill_in_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
writesize = data->size+data->size/2;
break;
case SKIP4:
- if (fillers[i].fourcc == DRM_FORMAT_ARGB8888 &&
- plane->type == DRM_PLANE_TYPE_CURSOR) {
- /*
- * special for cursor plane where blending works correctly.
- */
- ptemp_32_buf = (unsigned int*)data->buf;
- for (c = 0; c < data->size/4; c++)
- ptemp_32_buf[c] = fillers[i].value;
- writesize = data->size;
- break;
- }
- igt_info("Format %s CRC comparison skipped by design.\n",
- (char*)&fillers[i].fourcc);
-
- return false;
default:
- igt_info("Unsupported mode for test %s\n",
- (char*)&fillers[i].fourcc);
+ igt_info("Unsupported mode for testing CRC %.4s\n",
+ (char*)&format);
return false;
}
@@ -261,6 +242,8 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
int bpp = 0;
int i;
+ data->allow_fail = false;
+
mode = igt_output_get_mode(output);
if (plane->type != DRM_PLANE_TYPE_CURSOR) {
w = mode->hdisplay;
@@ -289,6 +272,8 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
break;
case SKIP4:
+ data->allow_fail = true;
+ /* fall through */
case BYTES_PP_4:
bpp = 32;
break;
@@ -409,27 +394,29 @@ test_one_mode(data_t* data, igt_output_t *output, igt_plane_t* plane,
&data->fullscreen_crc)) {
crccompare[0] = igt_crc_to_string(¤t_crc);
crccompare[1] = igt_crc_to_string(&data->fullscreen_crc);
- igt_warn("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
+ igt_info("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
free(crccompare[0]);
free(crccompare[1]);
- rVal++;
+ if (!data->allow_fail)
+ rVal++;
}
} else {
if (!igt_check_crc_equal(¤t_crc,
&data->cursor_crc)) {
crccompare[0] = igt_crc_to_string(¤t_crc);
crccompare[1] = igt_crc_to_string(&data->cursor_crc);
- igt_warn("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
+ igt_info("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
free(crccompare[0]);
free(crccompare[1]);
- rVal++;
+ if (!data->allow_fail)
+ rVal++;
}
}
}
remove_fb(data, output, plane);
return rVal;
}
- return 1;
+ return data->allow_fail ? 0 : 1;
}
@@ -440,14 +427,40 @@ test_available_modes(data_t* data)
igt_plane_t *plane;
int modeindex;
enum pipe pipe;
- int invalids = 0;
+ int failed_crcs = 0, i, lut_size;
drmModePlane *modePlane;
char planetype[3][8] = {"OVERLAY\0", "PRIMARY\0", "CURSOR\0" };
+ struct {
+ uint16_t red;
+ uint16_t green;
+ uint16_t blue;
+ uint16_t reserved;
+ } *lut;
+
for_each_pipe_with_valid_output(&data->display, pipe, output) {
+ igt_display_reset(&data->display);
igt_output_set_pipe(output, pipe);
igt_display_commit2(&data->display, data->commit);
+ if (igt_pipe_obj_has_prop(&data->display.pipes[pipe], IGT_CRTC_GAMMA_LUT_SIZE) &&
+ igt_pipe_obj_get_prop(&data->display.pipes[pipe], IGT_CRTC_GAMMA_LUT_SIZE)) {
+ lut_size = igt_pipe_get_prop(&data->display, pipe,
+ IGT_CRTC_GAMMA_LUT_SIZE);
+ lut = calloc(sizeof(*lut), lut_size);
+
+ for (i = 0; i < lut_size; i++) {
+ lut[i].red = (i * 0xffff / (lut_size - 1)) & 0xfc00;
+ lut[i].green = (i * 0xffff / (lut_size - 1)) & 0xfc00;
+ lut[i].blue = (i * 0xffff / (lut_size - 1)) & 0xfc00;
+ }
+
+ igt_pipe_replace_prop_blob(&data->display, pipe,
+ IGT_CRTC_GAMMA_LUT,
+ lut, sizeof(*lut) * lut_size);
+ free(lut);
+ }
+
data->pipe_crc = igt_pipe_crc_new(data->gfx_fd, pipe,
INTEL_PIPE_CRC_SOURCE_AUTO);
@@ -475,17 +488,18 @@ test_available_modes(data_t* data)
planetype[plane->type],
(char*)&data->format.name);
- invalids += test_one_mode(data, output,
- plane,
- modePlane->formats[modeindex]);
+ failed_crcs += test_one_mode(data, output,
+ plane,
+ modePlane->formats[modeindex]);
}
drmModeFreePlane(modePlane);
}
igt_pipe_crc_stop(data->pipe_crc);
igt_pipe_crc_free(data->pipe_crc);
- igt_display_commit2(&data->display, data->commit);
+
+ igt_output_set_pipe(output, PIPE_ANY);
}
- igt_assert(invalids == 0);
+ igt_assert(failed_crcs == 0);
}
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 49+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev7)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (21 preceding siblings ...)
2018-12-13 23:16 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev6) Patchwork
@ 2018-12-14 13:25 ` Patchwork
2018-12-14 15:12 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
` (4 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-12-14 13:25 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev7)
URL : https://patchwork.freedesktop.org/series/52000/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5317 -> IGTPW_2160
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/7/mbox/
Known issues
------------
Here are the changes found in IGTPW_2160 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
* igt@gem_exec_suspend@basic-s3:
- fi-byt-clapper: PASS -> INCOMPLETE [fdo#102657]
* igt@i915_selftest@live_hangcheck:
- fi-kbl-7560u: PASS -> INCOMPLETE [fdo#108044]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: PASS -> FAIL [fdo#108767]
* {igt@runner@aborted}:
- fi-icl-y: NOTRUN -> FAIL [fdo#108070]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102657]: https://bugs.freedesktop.org/show_bug.cgi?id=102657
[fdo#108044]: https://bugs.freedesktop.org/show_bug.cgi?id=108044
[fdo#108070]: https://bugs.freedesktop.org/show_bug.cgi?id=108070
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
Participating hosts (49 -> 47)
------------------------------
Additional (2): fi-icl-y fi-byt-j1900
Missing (4): fi-kbl-soraka fi-ctg-p8600 fi-byt-squawks fi-ilk-m540
Build changes
-------------
* IGT: IGT_4747 -> IGTPW_2160
CI_DRM_5317: 10c50ecb5eaa0176514e610d0c8bfd13babf88e0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2160: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2160/
IGT_4747: ad821d1dc5d0eea4ac3a0e8e29c56c7f66191108 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2160/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev7)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (22 preceding siblings ...)
2018-12-14 13:25 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev7) Patchwork
@ 2018-12-14 15:12 ` Patchwork
2018-12-18 14:58 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev8) Patchwork
` (3 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-12-14 15:12 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev7)
URL : https://patchwork.freedesktop.org/series/52000/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5317_full -> IGTPW_2160_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with IGTPW_2160_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2160_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/7/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2160_full:
### IGT changes ###
#### Warnings ####
* igt@tools_test@tools_test:
- shard-apl: PASS -> SKIP
Known issues
------------
Here are the changes found in IGTPW_2160_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_pwrite_pread@display-pwrite-blt-gtt_mmap-performance:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-apl: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-apl: PASS -> FAIL [fdo#106510] / [fdo#108145]
* igt@kms_color@pipe-a-degamma:
- shard-apl: NOTRUN -> FAIL [fdo#104782] / [fdo#108145]
- shard-kbl: PASS -> FAIL [fdo#104782] / [fdo#108145]
* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-glk: PASS -> FAIL [fdo#103232] +1
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_cursor_crc@cursor-256x256-dpms:
- shard-kbl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-64x21-sliding:
- shard-apl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-apl: PASS -> FAIL [fdo#103167] +2
- shard-glk: PASS -> FAIL [fdo#103167] +3
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-kbl: PASS -> FAIL [fdo#103167] +1
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-hsw: PASS -> DMESG-WARN [fdo#102614]
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +4
- shard-glk: PASS -> FAIL [fdo#103166] +2
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-kbl: PASS -> FAIL [fdo#103166] +1
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: PASS -> DMESG-WARN [fdo#105604]
* igt@perf_pmu@busy-double-start-bcs0:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
#### Possible fixes ####
* igt@gem_exec_fence@basic-await-default:
- shard-hsw: FAIL [fdo#108888] -> PASS
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: FAIL [fdo#106641] -> PASS
- shard-hsw: FAIL [fdo#106641] -> PASS
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-kbl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-glk: FAIL [fdo#103232] -> PASS +3
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: FAIL [fdo#103232] -> PASS +3
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS +1
* igt@kms_flip@flip-vs-modeset-vs-hang:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-kbl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-apl: FAIL [fdo#103167] -> PASS +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
- shard-glk: FAIL [fdo#103167] -> PASS +6
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-apl: FAIL [fdo#108145] -> PASS
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-apl: FAIL [fdo#103166] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- shard-kbl: FAIL [fdo#103166] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS +2
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-glk: DMESG-FAIL [fdo#105763] / [fdo#106538] -> PASS
* igt@kms_setmode@basic:
- shard-glk: FAIL [fdo#99912] -> PASS
#### Warnings ####
* igt@i915_suspend@shrink:
- shard-apl: INCOMPLETE [fdo#103927] / [fdo#106886] -> DMESG-WARN [fdo#108784]
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105604]: https://bugs.freedesktop.org/show_bug.cgi?id=105604
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784
[fdo#108888]: https://bugs.freedesktop.org/show_bug.cgi?id=108888
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4747 -> IGTPW_2160
* Piglit: piglit_4509 -> None
CI_DRM_5317: 10c50ecb5eaa0176514e610d0c8bfd13babf88e0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2160: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2160/
IGT_4747: ad821d1dc5d0eea4ac3a0e8e29c56c7f66191108 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2160/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons
2018-12-14 13:01 ` Juha-Pekka Heikkila
@ 2018-12-18 14:40 ` Juha-Pekka Heikkila
2018-12-19 13:41 ` Juha-Pekka Heikkila
0 siblings, 1 reply; 49+ messages in thread
From: Juha-Pekka Heikkila @ 2018-12-18 14:40 UTC (permalink / raw)
To: igt-dev
Fixed handling of single plane modes so used bpp never get to
be 0 and ease off crc comparison a bit with gamma tables as
idea of this test is to see chosen modes are able to initialize.
Release output to PIPE_ANY at end of test per connector.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106641
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
tests/kms_available_modes_crc.c | 119 ++++++++++++++++++++++------------------
1 file changed, 66 insertions(+), 53 deletions(-)
diff --git a/tests/kms_available_modes_crc.c b/tests/kms_available_modes_crc.c
index 45a4775..c56c63d 100644
--- a/tests/kms_available_modes_crc.c
+++ b/tests/kms_available_modes_crc.c
@@ -54,6 +54,12 @@ typedef struct {
igt_crc_t cursor_crc;
igt_crc_t fullscreen_crc;
+
+ /*
+ * If there's unknown format setting up mode can fail
+ * without failing entire test.
+ */
+ bool allow_fail;
} data_t;
@@ -120,7 +126,6 @@ static void generate_comparison_crc_list(data_t *data, igt_output_t *output)
static const struct {
uint32_t fourcc;
- char zeropadding;
enum { BYTES_PP_1=1,
BYTES_PP_2=2,
BYTES_PP_4=4,
@@ -129,42 +134,33 @@ static const struct {
SKIP4 } bpp;
uint32_t value;
} fillers[] = {
- { DRM_FORMAT_C8, 0, BYTES_PP_1, 0xff},
- { DRM_FORMAT_RGB565, 0, BYTES_PP_2, 0xffff},
- { DRM_FORMAT_XRGB8888, 0, BYTES_PP_4, 0xffffffff},
- { DRM_FORMAT_XBGR8888, 0, BYTES_PP_4, 0xffffffff},
-
- /*
- * following two are skipped because blending seems to work
- * incorrectly with exception of AR24 on cursor plane.
- * Test still creates the planes, just filling plane
- * and getting crc is skipped.
- */
- { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff},
- { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff},
-
- { DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff},
- { DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff},
-
- { DRM_FORMAT_YUYV, 0, BYTES_PP_4, 0x80eb80eb},
- { DRM_FORMAT_YVYU, 0, BYTES_PP_4, 0x80eb80eb},
- { DRM_FORMAT_VYUY, 0, BYTES_PP_4, 0xeb80eb80},
- { DRM_FORMAT_UYVY, 0, BYTES_PP_4, 0xeb80eb80},
+ { DRM_FORMAT_C8, BYTES_PP_1, 0xff},
+ { DRM_FORMAT_RGB565, BYTES_PP_2, 0xffff},
+ { DRM_FORMAT_XRGB8888, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_XBGR8888, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_ARGB8888, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_ABGR8888, BYTES_PP_4, 0x00ffffff},
+ { DRM_FORMAT_XRGB2101010, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_XBGR2101010, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_YUYV, BYTES_PP_4, 0x80eb80eb},
+ { DRM_FORMAT_YVYU, BYTES_PP_4, 0x80eb80eb},
+ { DRM_FORMAT_VYUY, BYTES_PP_4, 0xeb80eb80},
+ { DRM_FORMAT_UYVY, BYTES_PP_4, 0xeb80eb80},
/*
* (semi-)planar formats
*/
- { DRM_FORMAT_NV12, 0, NV12, 0x80eb},
+ { DRM_FORMAT_NV12, NV12, 0x80eb},
#ifdef DRM_FORMAT_P010
- { DRM_FORMAT_P010, 0, P010, 0x8000eb00},
+ { DRM_FORMAT_P010, P010, 0x8000eb00},
#endif
#ifdef DRM_FORMAT_P012
- { DRM_FORMAT_P012, 0, P010, 0x8000eb00},
+ { DRM_FORMAT_P012, P010, 0x8000eb00},
#endif
#ifdef DRM_FORMAT_P016
- { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
+ { DRM_FORMAT_P016, P010, 0x8000eb00},
#endif
- { 0, 0, 0, 0 }
+ { 0, SKIP4, 0 }
};
/*
@@ -221,24 +217,9 @@ static bool fill_in_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
writesize = data->size+data->size/2;
break;
case SKIP4:
- if (fillers[i].fourcc == DRM_FORMAT_ARGB8888 &&
- plane->type == DRM_PLANE_TYPE_CURSOR) {
- /*
- * special for cursor plane where blending works correctly.
- */
- ptemp_32_buf = (unsigned int*)data->buf;
- for (c = 0; c < data->size/4; c++)
- ptemp_32_buf[c] = fillers[i].value;
- writesize = data->size;
- break;
- }
- igt_info("Format %s CRC comparison skipped by design.\n",
- (char*)&fillers[i].fourcc);
-
- return false;
default:
- igt_info("Unsupported mode for test %s\n",
- (char*)&fillers[i].fourcc);
+ igt_info("Unsupported mode for testing CRC %.4s\n",
+ (char*)&format);
return false;
}
@@ -261,6 +242,8 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
int bpp = 0;
int i;
+ data->allow_fail = false;
+
mode = igt_output_get_mode(output);
if (plane->type != DRM_PLANE_TYPE_CURSOR) {
w = mode->hdisplay;
@@ -289,6 +272,8 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
break;
case SKIP4:
+ data->allow_fail = true;
+ /* fall through */
case BYTES_PP_4:
bpp = 32;
break;
@@ -412,7 +397,8 @@ test_one_mode(data_t* data, igt_output_t *output, igt_plane_t* plane,
igt_warn("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
free(crccompare[0]);
free(crccompare[1]);
- rVal++;
+ if (!data->allow_fail)
+ rVal++;
}
} else {
if (!igt_check_crc_equal(¤t_crc,
@@ -422,14 +408,15 @@ test_one_mode(data_t* data, igt_output_t *output, igt_plane_t* plane,
igt_warn("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
free(crccompare[0]);
free(crccompare[1]);
- rVal++;
+ if (!data->allow_fail)
+ rVal++;
}
}
}
remove_fb(data, output, plane);
return rVal;
}
- return 1;
+ return data->allow_fail ? 0 : 1;
}
@@ -440,14 +427,39 @@ test_available_modes(data_t* data)
igt_plane_t *plane;
int modeindex;
enum pipe pipe;
- int invalids = 0;
+ int failed_crcs = 0, i, lut_size;
drmModePlane *modePlane;
char planetype[3][8] = {"OVERLAY\0", "PRIMARY\0", "CURSOR\0" };
+ struct {
+ uint16_t red;
+ uint16_t green;
+ uint16_t blue;
+ uint16_t reserved;
+ } *lut;
+
for_each_pipe_with_valid_output(&data->display, pipe, output) {
+ igt_display_reset(&data->display);
igt_output_set_pipe(output, pipe);
igt_display_commit2(&data->display, data->commit);
+ if (igt_pipe_obj_has_prop(&data->display.pipes[pipe], IGT_CRTC_GAMMA_LUT_SIZE)) {
+ lut_size = igt_pipe_get_prop(&data->display, pipe,
+ IGT_CRTC_GAMMA_LUT_SIZE);
+ lut = calloc(sizeof(*lut), lut_size);
+
+ for (i = 0; i < lut_size; i++) {
+ lut[i].red = (i * 0xffff / (lut_size - 1)) & 0xfc00;
+ lut[i].green = (i * 0xffff / (lut_size - 1)) & 0xfc00;
+ lut[i].blue = (i * 0xffff / (lut_size - 1)) & 0xfc00;
+ }
+
+ igt_pipe_replace_prop_blob(&data->display, pipe,
+ IGT_CRTC_GAMMA_LUT,
+ lut, sizeof(*lut) * lut_size);
+ free(lut);
+ }
+
data->pipe_crc = igt_pipe_crc_new(data->gfx_fd, pipe,
INTEL_PIPE_CRC_SOURCE_AUTO);
@@ -475,17 +487,18 @@ test_available_modes(data_t* data)
planetype[plane->type],
(char*)&data->format.name);
- invalids += test_one_mode(data, output,
- plane,
- modePlane->formats[modeindex]);
+ failed_crcs += test_one_mode(data, output,
+ plane,
+ modePlane->formats[modeindex]);
}
drmModeFreePlane(modePlane);
}
igt_pipe_crc_stop(data->pipe_crc);
igt_pipe_crc_free(data->pipe_crc);
- igt_display_commit2(&data->display, data->commit);
+
+ igt_output_set_pipe(output, PIPE_ANY);
}
- igt_assert(invalids == 0);
+ igt_assert(failed_crcs == 0);
}
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 49+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev8)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (23 preceding siblings ...)
2018-12-14 15:12 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2018-12-18 14:58 ` Patchwork
2018-12-18 20:38 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
` (2 subsequent siblings)
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-12-18 14:58 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev8)
URL : https://patchwork.freedesktop.org/series/52000/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5329 -> IGTPW_2168
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/8/mbox/
Known issues
------------
Here are the changes found in IGTPW_2168 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_create@basic-files:
- fi-bsw-kefka: PASS -> DMESG-FAIL [fdo#108656]
* igt@i915_selftest@live_hangcheck:
- fi-bwr-2160: PASS -> DMESG-FAIL [fdo#108735]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: PASS -> FAIL [fdo#108767]
* igt@kms_flip@basic-flip-vs-dpms:
- fi-icl-u3: NOTRUN -> DMESG-WARN [fdo#108924] / [fdo#109044]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* {igt@runner@aborted}:
- fi-icl-u3: NOTRUN -> FAIL [fdo#108924]
- fi-bsw-kefka: NOTRUN -> FAIL [fdo#108656]
#### Possible fixes ####
* igt@i915_selftest@live_hangcheck:
- fi-kbl-7560u: INCOMPLETE [fdo#108044] -> PASS
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: DMESG-WARN [fdo#102614] -> PASS
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#107362] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108044]: https://bugs.freedesktop.org/show_bug.cgi?id=108044
[fdo#108656]: https://bugs.freedesktop.org/show_bug.cgi?id=108656
[fdo#108735]: https://bugs.freedesktop.org/show_bug.cgi?id=108735
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[fdo#108924]: https://bugs.freedesktop.org/show_bug.cgi?id=108924
[fdo#109044]: https://bugs.freedesktop.org/show_bug.cgi?id=109044
Participating hosts (49 -> 45)
------------------------------
Additional (1): fi-icl-u3
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
Build changes
-------------
* IGT: IGT_4749 -> IGTPW_2168
CI_DRM_5329: d8d4894604cf5d18815a77ce187a89e18a7909a3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2168: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2168/
IGT_4749: 270da20849db4d170db09673c6b67712c90ec9fe @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2168/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev8)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (24 preceding siblings ...)
2018-12-18 14:58 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev8) Patchwork
@ 2018-12-18 20:38 ` Patchwork
2018-12-19 14:04 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev9) Patchwork
2018-12-19 15:05 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-12-18 20:38 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev8)
URL : https://patchwork.freedesktop.org/series/52000/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5329_full -> IGTPW_2168_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2168_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2168_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/8/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2168_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: PASS -> FAIL
#### Warnings ####
* igt@perf_pmu@rc6:
- shard-kbl: PASS -> SKIP
* igt@pm_rc6_residency@rc6-accuracy:
- shard-snb: PASS -> SKIP
Known issues
------------
Here are the changes found in IGTPW_2168_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-glk: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_ccs@pipe-a-missing-ccs-buffer:
- shard-kbl: PASS -> DMESG-WARN [fdo#103313] / [fdo#103558] / [fdo#105602] +11
* igt@kms_cursor_crc@cursor-128x128-dpms:
- shard-kbl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-glk: NOTRUN -> FAIL [fdo#103232] +1
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-glk: PASS -> FAIL [fdo#103232] +7
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: PASS -> FAIL [fdo#103232] +3
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-kbl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_cursor_legacy@all-pipes-single-move:
- shard-kbl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +2
* igt@kms_flip@2x-plain-flip-fb-recreate:
- shard-hsw: PASS -> DMESG-FAIL [fdo#102614]
* igt@kms_flip@flip-vs-fences:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-kbl: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-apl: PASS -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-glk: PASS -> FAIL [fdo#103167] +6
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-kbl: PASS -> DMESG-WARN [fdo#103313] / [fdo#103558]
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: PASS -> FAIL [fdo#108948]
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: PASS -> FAIL [fdo#108948]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-glk: PASS -> FAIL [fdo#108145] +1
- shard-kbl: PASS -> FAIL [fdo#108145]
- shard-apl: PASS -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +4
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-apl: PASS -> FAIL [fdo#103166] +1
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-glk: NOTRUN -> FAIL [fdo#103166]
#### Possible fixes ####
* igt@gem_exec_fence@basic-await-default:
- shard-hsw: FAIL [fdo#108888] -> PASS
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-hsw: FAIL [fdo#106641] -> PASS
* igt@kms_cursor_crc@cursor-128x42-onscreen:
- shard-glk: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-64x21-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS +5
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-kbl: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: FAIL [fdo#103167] -> PASS +3
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: FAIL [fdo#103167] -> PASS +2
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-snb: INCOMPLETE [fdo#105411] / [fdo#107469] -> SKIP
* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-glk: FAIL [fdo#103166] -> PASS +3
- shard-kbl: FAIL [fdo#103166] -> PASS +1
* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-apl: FAIL [fdo#108145] -> PASS
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +4
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: DMESG-WARN [fdo#105604] -> PASS
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-hsw: FAIL [fdo#104894] -> PASS
#### Warnings ####
* igt@i915_suspend@shrink:
- shard-apl: INCOMPLETE [fdo#103927] / [fdo#106886] -> DMESG-WARN [fdo#108784]
- shard-snb: DMESG-WARN [fdo#108784] -> INCOMPLETE [fdo#105411] / [fdo#106886]
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105604]: https://bugs.freedesktop.org/show_bug.cgi?id=105604
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784
[fdo#108888]: https://bugs.freedesktop.org/show_bug.cgi?id=108888
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4749 -> IGTPW_2168
* Piglit: piglit_4509 -> None
CI_DRM_5329: d8d4894604cf5d18815a77ce187a89e18a7909a3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2168: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2168/
IGT_4749: 270da20849db4d170db09673c6b67712c90ec9fe @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2168/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons
2018-12-18 14:40 ` Juha-Pekka Heikkila
@ 2018-12-19 13:41 ` Juha-Pekka Heikkila
2019-01-23 19:40 ` Dhinakaran Pandiyan
` (3 more replies)
0 siblings, 4 replies; 49+ messages in thread
From: Juha-Pekka Heikkila @ 2018-12-19 13:41 UTC (permalink / raw)
To: igt-dev
Fixed handling of single plane modes so used bpp never get to
be 0 and ease off crc comparison a bit with gamma tables as
idea of this test is to see chosen modes are able to initialize.
Release output to PIPE_ANY at end of test per connector.
Reduce verboseness if there's no errors.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106641
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
tests/kms_available_modes_crc.c | 169 ++++++++++++++++++++--------------------
1 file changed, 86 insertions(+), 83 deletions(-)
diff --git a/tests/kms_available_modes_crc.c b/tests/kms_available_modes_crc.c
index 45a4775..04472d0 100644
--- a/tests/kms_available_modes_crc.c
+++ b/tests/kms_available_modes_crc.c
@@ -54,6 +54,12 @@ typedef struct {
igt_crc_t cursor_crc;
igt_crc_t fullscreen_crc;
+
+ /*
+ * If there's unknown format setting up mode can fail
+ * without failing entire test.
+ */
+ bool allow_fail;
} data_t;
@@ -120,7 +126,6 @@ static void generate_comparison_crc_list(data_t *data, igt_output_t *output)
static const struct {
uint32_t fourcc;
- char zeropadding;
enum { BYTES_PP_1=1,
BYTES_PP_2=2,
BYTES_PP_4=4,
@@ -129,42 +134,33 @@ static const struct {
SKIP4 } bpp;
uint32_t value;
} fillers[] = {
- { DRM_FORMAT_C8, 0, BYTES_PP_1, 0xff},
- { DRM_FORMAT_RGB565, 0, BYTES_PP_2, 0xffff},
- { DRM_FORMAT_XRGB8888, 0, BYTES_PP_4, 0xffffffff},
- { DRM_FORMAT_XBGR8888, 0, BYTES_PP_4, 0xffffffff},
-
- /*
- * following two are skipped because blending seems to work
- * incorrectly with exception of AR24 on cursor plane.
- * Test still creates the planes, just filling plane
- * and getting crc is skipped.
- */
- { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff},
- { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff},
-
- { DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff},
- { DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff},
-
- { DRM_FORMAT_YUYV, 0, BYTES_PP_4, 0x80eb80eb},
- { DRM_FORMAT_YVYU, 0, BYTES_PP_4, 0x80eb80eb},
- { DRM_FORMAT_VYUY, 0, BYTES_PP_4, 0xeb80eb80},
- { DRM_FORMAT_UYVY, 0, BYTES_PP_4, 0xeb80eb80},
+ { DRM_FORMAT_C8, BYTES_PP_1, 0xff},
+ { DRM_FORMAT_RGB565, BYTES_PP_2, 0xffff},
+ { DRM_FORMAT_XRGB8888, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_XBGR8888, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_ARGB8888, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_ABGR8888, BYTES_PP_4, 0x00ffffff},
+ { DRM_FORMAT_XRGB2101010, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_XBGR2101010, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_YUYV, BYTES_PP_4, 0x80eb80eb},
+ { DRM_FORMAT_YVYU, BYTES_PP_4, 0x80eb80eb},
+ { DRM_FORMAT_VYUY, BYTES_PP_4, 0xeb80eb80},
+ { DRM_FORMAT_UYVY, BYTES_PP_4, 0xeb80eb80},
/*
* (semi-)planar formats
*/
- { DRM_FORMAT_NV12, 0, NV12, 0x80eb},
+ { DRM_FORMAT_NV12, NV12, 0x80eb},
#ifdef DRM_FORMAT_P010
- { DRM_FORMAT_P010, 0, P010, 0x8000eb00},
+ { DRM_FORMAT_P010, P010, 0x8000eb00},
#endif
#ifdef DRM_FORMAT_P012
- { DRM_FORMAT_P012, 0, P010, 0x8000eb00},
+ { DRM_FORMAT_P012, P010, 0x8000eb00},
#endif
#ifdef DRM_FORMAT_P016
- { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
+ { DRM_FORMAT_P016, P010, 0x8000eb00},
#endif
- { 0, 0, 0, 0 }
+ { 0, SKIP4, 0 }
};
/*
@@ -221,24 +217,9 @@ static bool fill_in_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
writesize = data->size+data->size/2;
break;
case SKIP4:
- if (fillers[i].fourcc == DRM_FORMAT_ARGB8888 &&
- plane->type == DRM_PLANE_TYPE_CURSOR) {
- /*
- * special for cursor plane where blending works correctly.
- */
- ptemp_32_buf = (unsigned int*)data->buf;
- for (c = 0; c < data->size/4; c++)
- ptemp_32_buf[c] = fillers[i].value;
- writesize = data->size;
- break;
- }
- igt_info("Format %s CRC comparison skipped by design.\n",
- (char*)&fillers[i].fourcc);
-
- return false;
default:
- igt_info("Unsupported mode for test %s\n",
- (char*)&fillers[i].fourcc);
+ igt_info("Unsupported mode for testing CRC %.4s\n",
+ (char *)&format);
return false;
}
@@ -261,6 +242,8 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
int bpp = 0;
int i;
+ data->allow_fail = false;
+
mode = igt_output_get_mode(output);
if (plane->type != DRM_PLANE_TYPE_CURSOR) {
w = mode->hdisplay;
@@ -289,6 +272,8 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
break;
case SKIP4:
+ data->allow_fail = true;
+ /* fall through */
case BYTES_PP_4:
bpp = 32;
break;
@@ -319,7 +304,7 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
if(ret < 0) {
igt_info("Creating fb for format %s failed, return code %d\n",
- (char*)&data->format.name, ret);
+ (char *)&data->format.name, ret);
return false;
}
@@ -380,13 +365,14 @@ static bool prepare_crtc(data_t *data, igt_output_t *output,
static int
-test_one_mode(data_t* data, igt_output_t *output, igt_plane_t* plane,
- int mode)
+test_one_mode(data_t *data, igt_output_t *output, igt_plane_t *plane,
+ enum pipe pipe, int mode)
{
igt_crc_t current_crc;
signed rVal = 0;
bool do_crc;
- char* crccompare[2];
+ char *crccompare[2];
+ igt_crc_t *p_crc;
if (prepare_crtc(data, output, plane, mode)){
/*
@@ -404,32 +390,32 @@ test_one_mode(data_t* data, igt_output_t *output, igt_plane_t* plane,
if (do_crc) {
igt_pipe_crc_get_current(data->gfx_fd, data->pipe_crc, ¤t_crc);
- if (plane->type != DRM_PLANE_TYPE_CURSOR) {
- if (!igt_check_crc_equal(¤t_crc,
- &data->fullscreen_crc)) {
- crccompare[0] = igt_crc_to_string(¤t_crc);
- crccompare[1] = igt_crc_to_string(&data->fullscreen_crc);
- igt_warn("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
- free(crccompare[0]);
- free(crccompare[1]);
- rVal++;
- }
- } else {
- if (!igt_check_crc_equal(¤t_crc,
- &data->cursor_crc)) {
- crccompare[0] = igt_crc_to_string(¤t_crc);
- crccompare[1] = igt_crc_to_string(&data->cursor_crc);
- igt_warn("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
- free(crccompare[0]);
- free(crccompare[1]);
+ if (plane->type != DRM_PLANE_TYPE_CURSOR)
+ p_crc = &data->fullscreen_crc;
+ else
+ p_crc = &data->cursor_crc;
+
+ if (!igt_check_crc_equal(¤t_crc, p_crc)) {
+ crccompare[0] = igt_crc_to_string(¤t_crc);
+ crccompare[1] = igt_crc_to_string(p_crc);
+ igt_warn("crc mismatch on %s PIPE %s plane %d format %.4s. target %.8s, result %.8s.\n",
+ igt_output_name(output),
+ kmstest_pipe_name(pipe),
+ plane->index,
+ (char *)&data->format.name,
+ crccompare[0],
+ crccompare[1]);
+
+ free(crccompare[0]);
+ free(crccompare[1]);
+ if (!data->allow_fail)
rVal++;
- }
}
}
remove_fb(data, output, plane);
return rVal;
}
- return 1;
+ return data->allow_fail ? 0 : 1;
}
@@ -440,14 +426,38 @@ test_available_modes(data_t* data)
igt_plane_t *plane;
int modeindex;
enum pipe pipe;
- int invalids = 0;
+ int failed_crcs = 0, i, lut_size;
drmModePlane *modePlane;
- char planetype[3][8] = {"OVERLAY\0", "PRIMARY\0", "CURSOR\0" };
+
+ struct {
+ uint16_t red;
+ uint16_t green;
+ uint16_t blue;
+ uint16_t reserved;
+ } *lut;
for_each_pipe_with_valid_output(&data->display, pipe, output) {
+ igt_display_reset(&data->display);
igt_output_set_pipe(output, pipe);
igt_display_commit2(&data->display, data->commit);
+ if (igt_pipe_obj_has_prop(&data->display.pipes[pipe], IGT_CRTC_GAMMA_LUT_SIZE)) {
+ lut_size = igt_pipe_get_prop(&data->display, pipe,
+ IGT_CRTC_GAMMA_LUT_SIZE);
+ lut = calloc(sizeof(*lut), lut_size);
+
+ for (i = 0; i < lut_size; i++) {
+ lut[i].red = (i * 0xffff / (lut_size - 1)) & 0xfc00;
+ lut[i].green = (i * 0xffff / (lut_size - 1)) & 0xfc00;
+ lut[i].blue = (i * 0xffff / (lut_size - 1)) & 0xfc00;
+ }
+
+ igt_pipe_replace_prop_blob(&data->display, pipe,
+ IGT_CRTC_GAMMA_LUT,
+ lut, sizeof(*lut) * lut_size);
+ free(lut);
+ }
+
data->pipe_crc = igt_pipe_crc_new(data->gfx_fd, pipe,
INTEL_PIPE_CRC_SOURCE_AUTO);
@@ -467,25 +477,18 @@ test_available_modes(data_t* data)
modeindex++) {
data->format.dword = modePlane->formats[modeindex];
- igt_info("Testing connector %s using pipe %s" \
- " plane index %d type %s mode %s\n",
- igt_output_name(output),
- kmstest_pipe_name(pipe),
- plane->index,
- planetype[plane->type],
- (char*)&data->format.name);
-
- invalids += test_one_mode(data, output,
- plane,
- modePlane->formats[modeindex]);
+ failed_crcs += test_one_mode(data, output,
+ plane, pipe,
+ modePlane->formats[modeindex]);
}
drmModeFreePlane(modePlane);
}
igt_pipe_crc_stop(data->pipe_crc);
igt_pipe_crc_free(data->pipe_crc);
- igt_display_commit2(&data->display, data->commit);
+
+ igt_output_set_pipe(output, PIPE_ANY);
}
- igt_assert(invalids == 0);
+ igt_assert(failed_crcs == 0);
}
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 49+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev9)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (25 preceding siblings ...)
2018-12-18 20:38 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2018-12-19 14:04 ` Patchwork
2018-12-19 15:05 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-12-19 14:04 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev9)
URL : https://patchwork.freedesktop.org/series/52000/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5332 -> IGTPW_2169
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/9/mbox/
Known issues
------------
Here are the changes found in IGTPW_2169 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-compute:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#108094]
* igt@amdgpu/amd_prime@amd-to-i915:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#107341]
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* {igt@runner@aborted}:
- fi-icl-u3: NOTRUN -> FAIL [fdo#108866]
#### Possible fixes ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: DMESG-WARN [fdo#108965] -> PASS
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: FAIL [fdo#108767] -> PASS
* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#107362] -> PASS
#### Warnings ####
* igt@i915_selftest@live_contexts:
- fi-icl-u3: DMESG-FAIL [fdo#108569] -> INCOMPLETE [fdo#108315]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107341]: https://bugs.freedesktop.org/show_bug.cgi?id=107341
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094
[fdo#108315]: https://bugs.freedesktop.org/show_bug.cgi?id=108315
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[fdo#108866]: https://bugs.freedesktop.org/show_bug.cgi?id=108866
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
Participating hosts (50 -> 44)
------------------------------
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4750 -> IGTPW_2169
CI_DRM_5332: 29cd50b134a44bab74bfc8b275d24a32e140196c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2169: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2169/
IGT_4750: f05c8c2739dce89185349703062784a7745cab14 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2169/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev9)
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
` (26 preceding siblings ...)
2018-12-19 14:04 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev9) Patchwork
@ 2018-12-19 15:05 ` Patchwork
27 siblings, 0 replies; 49+ messages in thread
From: Patchwork @ 2018-12-19 15:05 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
== Series Details ==
Series: tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev9)
URL : https://patchwork.freedesktop.org/series/52000/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5332_full -> IGTPW_2169_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2169_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2169_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52000/revisions/9/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2169_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_busy@extended-semaphore-blt:
- shard-hsw: PASS -> FAIL
#### Warnings ####
* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-render:
- shard-apl: PASS -> SKIP +29
* igt@pm_rc6_residency@rc6-accuracy:
- shard-snb: PASS -> SKIP
Known issues
------------
Here are the changes found in IGTPW_2169_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_import_export@import-close-race-flink:
- shard-glk: PASS -> TIMEOUT [fdo#108667]
* igt@gem_eio@suspend:
- shard-kbl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105079] / [fdo#105602]
* igt@gem_workarounds@suspend-resume-fd:
- shard-apl: PASS -> DMESG-WARN [fdo#103558]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-hsw: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-kbl: PASS -> FAIL [fdo#107725] / [fdo#108145]
* igt@kms_color@pipe-c-degamma:
- shard-kbl: PASS -> FAIL [fdo#104782]
- shard-apl: PASS -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-apl: PASS -> FAIL [fdo#103232] +1
* igt@kms_cursor_crc@cursor-64x21-sliding:
- shard-apl: PASS -> DMESG-FAIL [fdo#103232] / [fdo#103558] / [fdo#105602]
* igt@kms_cursor_crc@cursor-64x64-random:
- shard-kbl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-glk: PASS -> FAIL [fdo#103232] +5
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_flip@flip-vs-fences:
- shard-kbl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +51
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-apl: PASS -> DMESG-FAIL [fdo#103167] / [fdo#103558] / [fdo#105602]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: PASS -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-glk: PASS -> FAIL [fdo#103167] +3
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-glk: PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]
* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-glk: PASS -> FAIL [fdo#103166] +4
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-glk: PASS -> FAIL [fdo#108145] +1
- shard-kbl: PASS -> FAIL [fdo#108145]
- shard-apl: PASS -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: PASS -> FAIL [fdo#103166] +2
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-apl: PASS -> DMESG-FAIL [fdo#103558] / [fdo#105602]
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: PASS -> DMESG-WARN [fdo#105604]
* igt@kms_setmode@basic:
- shard-hsw: PASS -> FAIL [fdo#99912]
* igt@kms_vblank@pipe-a-query-forked-busy-hang:
- shard-apl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +26
#### Possible fixes ####
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-hsw: FAIL [fdo#106641] -> PASS
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-apl: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-glk: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-256x256-dpms:
- shard-apl: FAIL [fdo#103232] -> SKIP +1
* igt@kms_cursor_legacy@pipe-a-torture-bo:
- shard-apl: DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS +7
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: FAIL [fdo#105363] -> PASS
* igt@kms_flip@modeset-vs-vblank-race-interruptible:
- shard-glk: FAIL [fdo#103060] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
- shard-apl: FAIL [fdo#103167] -> PASS +2
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
- shard-glk: FAIL [fdo#103167] -> PASS +4
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS +2
- shard-apl: FAIL [fdo#103166] -> PASS +1
- shard-kbl: FAIL [fdo#103166] -> PASS +1
* igt@perf_pmu@rc6-runtime-pm:
- shard-glk: FAIL [fdo#105010] -> PASS
- shard-apl: FAIL [fdo#105010] -> PASS
* igt@pm_rpm@system-suspend-execbuf:
- shard-kbl: INCOMPLETE [fdo#103665] / [fdo#107807] -> PASS
#### Warnings ####
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: FAIL [fdo#108145] -> DMESG-FAIL [fdo#103558] / [fdo#105602] / [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-apl: FAIL [fdo#103166] -> DMESG-WARN [fdo#103558] / [fdo#105602]
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-glk: DMESG-WARN [fdo#105763] / [fdo#106538] -> DMESG-FAIL [fdo#105763] / [fdo#106538]
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105604]: https://bugs.freedesktop.org/show_bug.cgi?id=105604
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108667]: https://bugs.freedesktop.org/show_bug.cgi?id=108667
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4750 -> IGTPW_2169
* Piglit: piglit_4509 -> None
CI_DRM_5332: 29cd50b134a44bab74bfc8b275d24a32e140196c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2169: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2169/
IGT_4750: f05c8c2739dce89185349703062784a7745cab14 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2169/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons
2018-12-19 13:41 ` Juha-Pekka Heikkila
@ 2019-01-23 19:40 ` Dhinakaran Pandiyan
2019-01-23 19:41 ` Dhinakaran Pandiyan
` (2 subsequent siblings)
3 siblings, 0 replies; 49+ messages in thread
From: Dhinakaran Pandiyan @ 2019-01-23 19:40 UTC (permalink / raw)
To: Juha-Pekka Heikkila, igt-dev
On Wed, 2018-12-19 at 15:41 +0200, Juha-Pekka Heikkila wrote:
> Fixed handling of single plane modes so used bpp never get to
> be 0 and ease off crc comparison a bit with gamma tables as
> idea of this test is to see chosen modes are able to initialize.
>
> Release output to PIPE_ANY at end of test per connector.
>
> Reduce verboseness if there's no errors.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106641
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> tests/kms_available_modes_crc.c | 169 ++++++++++++++++++++--------
> ------------
> 1 file changed, 86 insertions(+), 83 deletions(-)
>
> diff --git a/tests/kms_available_modes_crc.c
> b/tests/kms_available_modes_crc.c
> index 45a4775..04472d0 100644
> --- a/tests/kms_available_modes_crc.c
> +++ b/tests/kms_available_modes_crc.c
> @@ -54,6 +54,12 @@ typedef struct {
>
> igt_crc_t cursor_crc;
> igt_crc_t fullscreen_crc;
> +
> + /*
> + * If there's unknown format setting up mode can fail
> + * without failing entire test.
> + */
> + bool allow_fail;
> } data_t;
>
>
> @@ -120,7 +126,6 @@ static void generate_comparison_crc_list(data_t
> *data, igt_output_t *output)
>
> static const struct {
> uint32_t fourcc;
> - char zeropadding;
> enum { BYTES_PP_1=1,
> BYTES_PP_2=2,
> BYTES_PP_4=4,
> @@ -129,42 +134,33 @@ static const struct {
> SKIP4 } bpp;
> uint32_t value;
> } fillers[] = {
> - { DRM_FORMAT_C8, 0, BYTES_PP_1, 0xff},
> - { DRM_FORMAT_RGB565, 0, BYTES_PP_2, 0xffff},
> - { DRM_FORMAT_XRGB8888, 0, BYTES_PP_4, 0xffffffff},
> - { DRM_FORMAT_XBGR8888, 0, BYTES_PP_4, 0xffffffff},
> -
> - /*
> - * following two are skipped because blending seems to work
> - * incorrectly with exception of AR24 on cursor plane.
> - * Test still creates the planes, just filling plane
> - * and getting crc is skipped.
> - */
> - { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff},
> - { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff},
> -
> - { DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff},
> - { DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff},
> -
> - { DRM_FORMAT_YUYV, 0, BYTES_PP_4, 0x80eb80eb},
> - { DRM_FORMAT_YVYU, 0, BYTES_PP_4, 0x80eb80eb},
> - { DRM_FORMAT_VYUY, 0, BYTES_PP_4, 0xeb80eb80},
> - { DRM_FORMAT_UYVY, 0, BYTES_PP_4, 0xeb80eb80},
> + { DRM_FORMAT_C8, BYTES_PP_1, 0xff},
> + { DRM_FORMAT_RGB565, BYTES_PP_2, 0xffff},
> + { DRM_FORMAT_XRGB8888, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_XBGR8888, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_ARGB8888, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_ABGR8888, BYTES_PP_4, 0x00ffffff},
> + { DRM_FORMAT_XRGB2101010, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_XBGR2101010, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_YUYV, BYTES_PP_4, 0x80eb80eb},
> + { DRM_FORMAT_YVYU, BYTES_PP_4, 0x80eb80eb},
> + { DRM_FORMAT_VYUY, BYTES_PP_4, 0xeb80eb80},
> + { DRM_FORMAT_UYVY, BYTES_PP_4, 0xeb80eb80},
>
> /*
> * (semi-)planar formats
> */
> - { DRM_FORMAT_NV12, 0, NV12, 0x80eb},
> + { DRM_FORMAT_NV12, NV12, 0x80eb},
> #ifdef DRM_FORMAT_P010
> - { DRM_FORMAT_P010, 0, P010, 0x8000eb00},
> + { DRM_FORMAT_P010, P010, 0x8000eb00},
> #endif
> #ifdef DRM_FORMAT_P012
> - { DRM_FORMAT_P012, 0, P010, 0x8000eb00},
> + { DRM_FORMAT_P012, P010, 0x8000eb00},
> #endif
> #ifdef DRM_FORMAT_P016
> - { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
> + { DRM_FORMAT_P016, P010, 0x8000eb00},
> #endif
> - { 0, 0, 0, 0 }
> + { 0, SKIP4, 0 }
> };
>
> /*
> @@ -221,24 +217,9 @@ static bool fill_in_fb(data_t *data,
> igt_output_t *output, igt_plane_t *plane,
> writesize = data->size+data->size/2;
> break;
> case SKIP4:
> - if (fillers[i].fourcc == DRM_FORMAT_ARGB8888 &&
> - plane->type == DRM_PLANE_TYPE_CURSOR) {
> - /*
> - * special for cursor plane where blending works
> correctly.
> - */
> - ptemp_32_buf = (unsigned int*)data->buf;
> - for (c = 0; c < data->size/4; c++)
> - ptemp_32_buf[c] = fillers[i].value;
> - writesize = data->size;
> - break;
> - }
> - igt_info("Format %s CRC comparison skipped by
> design.\n",
> - (char*)&fillers[i].fourcc);
> -
> - return false;
> default:
> - igt_info("Unsupported mode for test %s\n",
> - (char*)&fillers[i].fourcc);
> + igt_info("Unsupported mode for testing CRC %.4s\n",
> + (char *)&format);
> return false;
> }
>
> @@ -261,6 +242,8 @@ static bool setup_fb(data_t *data, igt_output_t
> *output, igt_plane_t *plane,
> int bpp = 0;
> int i;
>
> + data->allow_fail = false;
> +
> mode = igt_output_get_mode(output);
> if (plane->type != DRM_PLANE_TYPE_CURSOR) {
> w = mode->hdisplay;
> @@ -289,6 +272,8 @@ static bool setup_fb(data_t *data, igt_output_t
> *output, igt_plane_t *plane,
> break;
>
> case SKIP4:
> + data->allow_fail = true;
> + /* fall through */
> case BYTES_PP_4:
> bpp = 32;
> break;
> @@ -319,7 +304,7 @@ static bool setup_fb(data_t *data, igt_output_t
> *output, igt_plane_t *plane,
>
> if(ret < 0) {
> igt_info("Creating fb for format %s failed, return code
> %d\n",
> - (char*)&data->format.name, ret);
> + (char *)&data->format.name, ret);
>
> return false;
> }
> @@ -380,13 +365,14 @@ static bool prepare_crtc(data_t *data,
> igt_output_t *output,
>
>
> static int
> -test_one_mode(data_t* data, igt_output_t *output, igt_plane_t*
> plane,
> - int mode)
> +test_one_mode(data_t *data, igt_output_t *output, igt_plane_t
> *plane,
> + enum pipe pipe, int mode)
> {
> igt_crc_t current_crc;
> signed rVal = 0;
> bool do_crc;
> - char* crccompare[2];
> + char *crccompare[2];
> + igt_crc_t *p_crc;
>
> if (prepare_crtc(data, output, plane, mode)){
> /*
> @@ -404,32 +390,32 @@ test_one_mode(data_t* data, igt_output_t
> *output, igt_plane_t* plane,
> if (do_crc) {
> igt_pipe_crc_get_current(data->gfx_fd, data-
> >pipe_crc, ¤t_crc);
>
> - if (plane->type != DRM_PLANE_TYPE_CURSOR) {
> - if (!igt_check_crc_equal(¤t_crc,
> - &data->fullscreen_crc)) {
> - crccompare[0] =
> igt_crc_to_string(¤t_crc);
> - crccompare[1] =
> igt_crc_to_string(&data->fullscreen_crc);
> - igt_warn("crc mismatch. target
> %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
> - free(crccompare[0]);
> - free(crccompare[1]);
> - rVal++;
> - }
> - } else {
> - if (!igt_check_crc_equal(¤t_crc,
> - &data->cursor_crc)) {
> - crccompare[0] =
> igt_crc_to_string(¤t_crc);
> - crccompare[1] =
> igt_crc_to_string(&data->cursor_crc);
> - igt_warn("crc mismatch. target
> %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
> - free(crccompare[0]);
> - free(crccompare[1]);
> + if (plane->type != DRM_PLANE_TYPE_CURSOR)
> + p_crc = &data->fullscreen_crc;
> + else
> + p_crc = &data->cursor_crc;
> +
> + if (!igt_check_crc_equal(¤t_crc, p_crc))
> {
> + crccompare[0] =
> igt_crc_to_string(¤t_crc);
> + crccompare[1] =
> igt_crc_to_string(p_crc);
> + igt_warn("crc mismatch on %s PIPE %s
> plane %d format %.4s. target %.8s, result %.8s.\n",
> + igt_output_name(output),
> + kmstest_pipe_name(pipe),
> + plane->index,
> + (char *)&data->format.name,
> + crccompare[0],
> + crccompare[1]);
Can you please split this debug print into a separate patch? That way
we can see which format/plane/pipe combination is failing on ICL while
you are working on the gamma fixes?
> +
> + free(crccompare[0]);
> + free(crccompare[1]);
> + if (!data->allow_fail)
> rVal++;
> - }
> }
> }
> remove_fb(data, output, plane);
> return rVal;
> }
> - return 1;
> + return data->allow_fail ? 0 : 1;
> }
>
>
> @@ -440,14 +426,38 @@ test_available_modes(data_t* data)
> igt_plane_t *plane;
> int modeindex;
> enum pipe pipe;
> - int invalids = 0;
> + int failed_crcs = 0, i, lut_size;
> drmModePlane *modePlane;
> - char planetype[3][8] = {"OVERLAY\0", "PRIMARY\0", "CURSOR\0" };
> +
> + struct {
> + uint16_t red;
> + uint16_t green;
> + uint16_t blue;
> + uint16_t reserved;
> + } *lut;
>
> for_each_pipe_with_valid_output(&data->display, pipe, output) {
> + igt_display_reset(&data->display);
> igt_output_set_pipe(output, pipe);
> igt_display_commit2(&data->display, data->commit);
>
> + if (igt_pipe_obj_has_prop(&data->display.pipes[pipe],
> IGT_CRTC_GAMMA_LUT_SIZE)) {
> + lut_size = igt_pipe_get_prop(&data->display,
> pipe,
> + IGT_CRTC_GAMMA_LUT
> _SIZE);
> + lut = calloc(sizeof(*lut), lut_size);
> +
> + for (i = 0; i < lut_size; i++) {
> + lut[i].red = (i * 0xffff / (lut_size -
> 1)) & 0xfc00;
> + lut[i].green = (i * 0xffff / (lut_size
> - 1)) & 0xfc00;
> + lut[i].blue = (i * 0xffff / (lut_size -
> 1)) & 0xfc00;
> + }
> +
> + igt_pipe_replace_prop_blob(&data->display,
> pipe,
> + IGT_CRTC_GAMMA_LUT,
> + lut, sizeof(*lut) *
> lut_size);
> + free(lut);
> + }
> +
> data->pipe_crc = igt_pipe_crc_new(data->gfx_fd, pipe,
> INTEL_PIPE_CRC_SOURCE
> _AUTO);
>
> @@ -467,25 +477,18 @@ test_available_modes(data_t* data)
> modeindex++) {
> data->format.dword = modePlane-
> >formats[modeindex];
>
> - igt_info("Testing connector %s using
> pipe %s" \
> - " plane index %d type %s mode
> %s\n",
> - igt_output_name(output),
> - kmstest_pipe_name(pipe),
> - plane->index,
> - planetype[plane->type],
> - (char*)&data->format.name);
> -
> - invalids += test_one_mode(data, output,
> - plane,
> - modePlane-
> >formats[modeindex]);
> + failed_crcs += test_one_mode(data,
> output,
> + plane,
> pipe,
> + modePlane-
> >formats[modeindex]);
> }
> drmModeFreePlane(modePlane);
> }
> igt_pipe_crc_stop(data->pipe_crc);
> igt_pipe_crc_free(data->pipe_crc);
> - igt_display_commit2(&data->display, data->commit);
> +
> + igt_output_set_pipe(output, PIPE_ANY);
> }
> - igt_assert(invalids == 0);
> + igt_assert(failed_crcs == 0);
> }
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons
2018-12-19 13:41 ` Juha-Pekka Heikkila
2019-01-23 19:40 ` Dhinakaran Pandiyan
@ 2019-01-23 19:41 ` Dhinakaran Pandiyan
2019-01-23 19:42 ` Dhinakaran Pandiyan
2019-01-23 19:50 ` Pandiyan, Dhinakaran
3 siblings, 0 replies; 49+ messages in thread
From: Dhinakaran Pandiyan @ 2019-01-23 19:41 UTC (permalink / raw)
To: Juha-Pekka Heikkila, igt-dev
On Wed, 2018-12-19 at 15:41 +0200, Juha-Pekka Heikkila wrote:
> Fixed handling of single plane modes so used bpp never get to
> be 0 and ease off crc comparison a bit with gamma tables as
> idea of this test is to see chosen modes are able to initialize.
>
> Release output to PIPE_ANY at end of test per connector.
>
> Reduce verboseness if there's no errors.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106641
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> tests/kms_available_modes_crc.c | 169 ++++++++++++++++++++--------
> ------------
> 1 file changed, 86 insertions(+), 83 deletions(-)
>
> diff --git a/tests/kms_available_modes_crc.c
> b/tests/kms_available_modes_crc.c
> index 45a4775..04472d0 100644
> --- a/tests/kms_available_modes_crc.c
> +++ b/tests/kms_available_modes_crc.c
> @@ -54,6 +54,12 @@ typedef struct {
>
> igt_crc_t cursor_crc;
> igt_crc_t fullscreen_crc;
> +
> + /*
> + * If there's unknown format setting up mode can fail
> + * without failing entire test.
> + */
> + bool allow_fail;
> } data_t;
>
>
> @@ -120,7 +126,6 @@ static void generate_comparison_crc_list(data_t
> *data, igt_output_t *output)
>
> static const struct {
> uint32_t fourcc;
> - char zeropadding;
> enum { BYTES_PP_1=1,
> BYTES_PP_2=2,
> BYTES_PP_4=4,
> @@ -129,42 +134,33 @@ static const struct {
> SKIP4 } bpp;
> uint32_t value;
> } fillers[] = {
> - { DRM_FORMAT_C8, 0, BYTES_PP_1, 0xff},
> - { DRM_FORMAT_RGB565, 0, BYTES_PP_2, 0xffff},
> - { DRM_FORMAT_XRGB8888, 0, BYTES_PP_4, 0xffffffff},
> - { DRM_FORMAT_XBGR8888, 0, BYTES_PP_4, 0xffffffff},
> -
> - /*
> - * following two are skipped because blending seems to work
> - * incorrectly with exception of AR24 on cursor plane.
> - * Test still creates the planes, just filling plane
> - * and getting crc is skipped.
> - */
> - { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff},
> - { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff},
> -
> - { DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff},
> - { DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff},
> -
> - { DRM_FORMAT_YUYV, 0, BYTES_PP_4, 0x80eb80eb},
> - { DRM_FORMAT_YVYU, 0, BYTES_PP_4, 0x80eb80eb},
> - { DRM_FORMAT_VYUY, 0, BYTES_PP_4, 0xeb80eb80},
> - { DRM_FORMAT_UYVY, 0, BYTES_PP_4, 0xeb80eb80},
> + { DRM_FORMAT_C8, BYTES_PP_1, 0xff},
> + { DRM_FORMAT_RGB565, BYTES_PP_2, 0xffff},
> + { DRM_FORMAT_XRGB8888, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_XBGR8888, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_ARGB8888, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_ABGR8888, BYTES_PP_4, 0x00ffffff},
> + { DRM_FORMAT_XRGB2101010, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_XBGR2101010, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_YUYV, BYTES_PP_4, 0x80eb80eb},
> + { DRM_FORMAT_YVYU, BYTES_PP_4, 0x80eb80eb},
> + { DRM_FORMAT_VYUY, BYTES_PP_4, 0xeb80eb80},
> + { DRM_FORMAT_UYVY, BYTES_PP_4, 0xeb80eb80},
>
> /*
> * (semi-)planar formats
> */
> - { DRM_FORMAT_NV12, 0, NV12, 0x80eb},
> + { DRM_FORMAT_NV12, NV12, 0x80eb},
> #ifdef DRM_FORMAT_P010
> - { DRM_FORMAT_P010, 0, P010, 0x8000eb00},
> + { DRM_FORMAT_P010, P010, 0x8000eb00},
> #endif
> #ifdef DRM_FORMAT_P012
> - { DRM_FORMAT_P012, 0, P010, 0x8000eb00},
> + { DRM_FORMAT_P012, P010, 0x8000eb00},
> #endif
> #ifdef DRM_FORMAT_P016
> - { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
> + { DRM_FORMAT_P016, P010, 0x8000eb00},
> #endif
> - { 0, 0, 0, 0 }
> + { 0, SKIP4, 0 }
> };
>
> /*
> @@ -221,24 +217,9 @@ static bool fill_in_fb(data_t *data,
> igt_output_t *output, igt_plane_t *plane,
> writesize = data->size+data->size/2;
> break;
> case SKIP4:
> - if (fillers[i].fourcc == DRM_FORMAT_ARGB8888 &&
> - plane->type == DRM_PLANE_TYPE_CURSOR) {
> - /*
> - * special for cursor plane where blending works
> correctly.
> - */
> - ptemp_32_buf = (unsigned int*)data->buf;
> - for (c = 0; c < data->size/4; c++)
> - ptemp_32_buf[c] = fillers[i].value;
> - writesize = data->size;
> - break;
> - }
> - igt_info("Format %s CRC comparison skipped by
> design.\n",
> - (char*)&fillers[i].fourcc);
> -
> - return false;
> default:
> - igt_info("Unsupported mode for test %s\n",
> - (char*)&fillers[i].fourcc);
> + igt_info("Unsupported mode for testing CRC %.4s\n",
> + (char *)&format);
> return false;
> }
>
> @@ -261,6 +242,8 @@ static bool setup_fb(data_t *data, igt_output_t
> *output, igt_plane_t *plane,
> int bpp = 0;
> int i;
>
> + data->allow_fail = false;
> +
> mode = igt_output_get_mode(output);
> if (plane->type != DRM_PLANE_TYPE_CURSOR) {
> w = mode->hdisplay;
> @@ -289,6 +272,8 @@ static bool setup_fb(data_t *data, igt_output_t
> *output, igt_plane_t *plane,
> break;
>
> case SKIP4:
> + data->allow_fail = true;
> + /* fall through */
> case BYTES_PP_4:
> bpp = 32;
> break;
> @@ -319,7 +304,7 @@ static bool setup_fb(data_t *data, igt_output_t
> *output, igt_plane_t *plane,
>
> if(ret < 0) {
> igt_info("Creating fb for format %s failed, return code
> %d\n",
> - (char*)&data->format.name, ret);
> + (char *)&data->format.name, ret);
>
> return false;
> }
> @@ -380,13 +365,14 @@ static bool prepare_crtc(data_t *data,
> igt_output_t *output,
>
>
> static int
> -test_one_mode(data_t* data, igt_output_t *output, igt_plane_t*
> plane,
> - int mode)
> +test_one_mode(data_t *data, igt_output_t *output, igt_plane_t
> *plane,
> + enum pipe pipe, int mode)
> {
> igt_crc_t current_crc;
> signed rVal = 0;
> bool do_crc;
> - char* crccompare[2];
> + char *crccompare[2];
> + igt_crc_t *p_crc;
>
> if (prepare_crtc(data, output, plane, mode)){
> /*
> @@ -404,32 +390,32 @@ test_one_mode(data_t* data, igt_output_t
> *output, igt_plane_t* plane,
> if (do_crc) {
> igt_pipe_crc_get_current(data->gfx_fd, data-
> >pipe_crc, ¤t_crc);
>
> - if (plane->type != DRM_PLANE_TYPE_CURSOR) {
> - if (!igt_check_crc_equal(¤t_crc,
> - &data->fullscreen_crc)) {
> - crccompare[0] =
> igt_crc_to_string(¤t_crc);
> - crccompare[1] =
> igt_crc_to_string(&data->fullscreen_crc);
> - igt_warn("crc mismatch. target
> %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
> - free(crccompare[0]);
> - free(crccompare[1]);
> - rVal++;
> - }
> - } else {
> - if (!igt_check_crc_equal(¤t_crc,
> - &data->cursor_crc)) {
> - crccompare[0] =
> igt_crc_to_string(¤t_crc);
> - crccompare[1] =
> igt_crc_to_string(&data->cursor_crc);
> - igt_warn("crc mismatch. target
> %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
> - free(crccompare[0]);
> - free(crccompare[1]);
> + if (plane->type != DRM_PLANE_TYPE_CURSOR)
> + p_crc = &data->fullscreen_crc;
> + else
> + p_crc = &data->cursor_crc;
> +
> + if (!igt_check_crc_equal(¤t_crc, p_crc))
> {
> + crccompare[0] =
> igt_crc_to_string(¤t_crc);
> + crccompare[1] =
> igt_crc_to_string(p_crc);
> + igt_warn("crc mismatch on %s PIPE %s
> plane %d format %.4s. target %.8s, result %.8s.\n",
> + igt_output_name(output),
> + kmstest_pipe_name(pipe),
> + plane->index,
> + (char *)&data->format.name,
> + crccompare[0],
> + crccompare[1]);
Can you please split this debug print into a separate patch? That way
we can see which format/plane/pipe combination is failing on ICL while
you are working on the gamma fixes?
> +
> + free(crccompare[0]);
> + free(crccompare[1]);
> + if (!data->allow_fail)
> rVal++;
> - }
> }
> }
> remove_fb(data, output, plane);
> return rVal;
> }
> - return 1;
> + return data->allow_fail ? 0 : 1;
> }
>
>
> @@ -440,14 +426,38 @@ test_available_modes(data_t* data)
> igt_plane_t *plane;
> int modeindex;
> enum pipe pipe;
> - int invalids = 0;
> + int failed_crcs = 0, i, lut_size;
> drmModePlane *modePlane;
> - char planetype[3][8] = {"OVERLAY\0", "PRIMARY\0", "CURSOR\0" };
> +
> + struct {
> + uint16_t red;
> + uint16_t green;
> + uint16_t blue;
> + uint16_t reserved;
> + } *lut;
>
> for_each_pipe_with_valid_output(&data->display, pipe, output) {
> + igt_display_reset(&data->display);
> igt_output_set_pipe(output, pipe);
> igt_display_commit2(&data->display, data->commit);
>
> + if (igt_pipe_obj_has_prop(&data->display.pipes[pipe],
> IGT_CRTC_GAMMA_LUT_SIZE)) {
> + lut_size = igt_pipe_get_prop(&data->display,
> pipe,
> + IGT_CRTC_GAMMA_LUT
> _SIZE);
> + lut = calloc(sizeof(*lut), lut_size);
> +
> + for (i = 0; i < lut_size; i++) {
> + lut[i].red = (i * 0xffff / (lut_size -
> 1)) & 0xfc00;
> + lut[i].green = (i * 0xffff / (lut_size
> - 1)) & 0xfc00;
> + lut[i].blue = (i * 0xffff / (lut_size -
> 1)) & 0xfc00;
> + }
> +
> + igt_pipe_replace_prop_blob(&data->display,
> pipe,
> + IGT_CRTC_GAMMA_LUT,
> + lut, sizeof(*lut) *
> lut_size);
> + free(lut);
> + }
> +
> data->pipe_crc = igt_pipe_crc_new(data->gfx_fd, pipe,
> INTEL_PIPE_CRC_SOURCE
> _AUTO);
>
> @@ -467,25 +477,18 @@ test_available_modes(data_t* data)
> modeindex++) {
> data->format.dword = modePlane-
> >formats[modeindex];
>
> - igt_info("Testing connector %s using
> pipe %s" \
> - " plane index %d type %s mode
> %s\n",
> - igt_output_name(output),
> - kmstest_pipe_name(pipe),
> - plane->index,
> - planetype[plane->type],
> - (char*)&data->format.name);
> -
> - invalids += test_one_mode(data, output,
> - plane,
> - modePlane-
> >formats[modeindex]);
> + failed_crcs += test_one_mode(data,
> output,
> + plane,
> pipe,
> + modePlane-
> >formats[modeindex]);
> }
> drmModeFreePlane(modePlane);
> }
> igt_pipe_crc_stop(data->pipe_crc);
> igt_pipe_crc_free(data->pipe_crc);
> - igt_display_commit2(&data->display, data->commit);
> +
> + igt_output_set_pipe(output, PIPE_ANY);
> }
> - igt_assert(invalids == 0);
> + igt_assert(failed_crcs == 0);
> }
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons
2018-12-19 13:41 ` Juha-Pekka Heikkila
2019-01-23 19:40 ` Dhinakaran Pandiyan
2019-01-23 19:41 ` Dhinakaran Pandiyan
@ 2019-01-23 19:42 ` Dhinakaran Pandiyan
2019-01-23 19:50 ` Pandiyan, Dhinakaran
3 siblings, 0 replies; 49+ messages in thread
From: Dhinakaran Pandiyan @ 2019-01-23 19:42 UTC (permalink / raw)
To: Juha-Pekka Heikkila, igt-dev
On Wed, 2018-12-19 at 15:41 +0200, Juha-Pekka Heikkila wrote:
> Fixed handling of single plane modes so used bpp never get to
> be 0 and ease off crc comparison a bit with gamma tables as
> idea of this test is to see chosen modes are able to initialize.
>
> Release output to PIPE_ANY at end of test per connector.
>
> Reduce verboseness if there's no errors.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106641
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> tests/kms_available_modes_crc.c | 169 ++++++++++++++++++++--------
> ------------
> 1 file changed, 86 insertions(+), 83 deletions(-)
>
> diff --git a/tests/kms_available_modes_crc.c
> b/tests/kms_available_modes_crc.c
> index 45a4775..04472d0 100644
> --- a/tests/kms_available_modes_crc.c
> +++ b/tests/kms_available_modes_crc.c
> @@ -54,6 +54,12 @@ typedef struct {
>
> igt_crc_t cursor_crc;
> igt_crc_t fullscreen_crc;
> +
> + /*
> + * If there's unknown format setting up mode can fail
> + * without failing entire test.
> + */
> + bool allow_fail;
> } data_t;
>
>
> @@ -120,7 +126,6 @@ static void generate_comparison_crc_list(data_t
> *data, igt_output_t *output)
>
> static const struct {
> uint32_t fourcc;
> - char zeropadding;
> enum { BYTES_PP_1=1,
> BYTES_PP_2=2,
> BYTES_PP_4=4,
> @@ -129,42 +134,33 @@ static const struct {
> SKIP4 } bpp;
> uint32_t value;
> } fillers[] = {
> - { DRM_FORMAT_C8, 0, BYTES_PP_1, 0xff},
> - { DRM_FORMAT_RGB565, 0, BYTES_PP_2, 0xffff},
> - { DRM_FORMAT_XRGB8888, 0, BYTES_PP_4, 0xffffffff},
> - { DRM_FORMAT_XBGR8888, 0, BYTES_PP_4, 0xffffffff},
> -
> - /*
> - * following two are skipped because blending seems to work
> - * incorrectly with exception of AR24 on cursor plane.
> - * Test still creates the planes, just filling plane
> - * and getting crc is skipped.
> - */
> - { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff},
> - { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff},
> -
> - { DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff},
> - { DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff},
> -
> - { DRM_FORMAT_YUYV, 0, BYTES_PP_4, 0x80eb80eb},
> - { DRM_FORMAT_YVYU, 0, BYTES_PP_4, 0x80eb80eb},
> - { DRM_FORMAT_VYUY, 0, BYTES_PP_4, 0xeb80eb80},
> - { DRM_FORMAT_UYVY, 0, BYTES_PP_4, 0xeb80eb80},
> + { DRM_FORMAT_C8, BYTES_PP_1, 0xff},
> + { DRM_FORMAT_RGB565, BYTES_PP_2, 0xffff},
> + { DRM_FORMAT_XRGB8888, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_XBGR8888, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_ARGB8888, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_ABGR8888, BYTES_PP_4, 0x00ffffff},
> + { DRM_FORMAT_XRGB2101010, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_XBGR2101010, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_YUYV, BYTES_PP_4, 0x80eb80eb},
> + { DRM_FORMAT_YVYU, BYTES_PP_4, 0x80eb80eb},
> + { DRM_FORMAT_VYUY, BYTES_PP_4, 0xeb80eb80},
> + { DRM_FORMAT_UYVY, BYTES_PP_4, 0xeb80eb80},
>
> /*
> * (semi-)planar formats
> */
> - { DRM_FORMAT_NV12, 0, NV12, 0x80eb},
> + { DRM_FORMAT_NV12, NV12, 0x80eb},
> #ifdef DRM_FORMAT_P010
> - { DRM_FORMAT_P010, 0, P010, 0x8000eb00},
> + { DRM_FORMAT_P010, P010, 0x8000eb00},
> #endif
> #ifdef DRM_FORMAT_P012
> - { DRM_FORMAT_P012, 0, P010, 0x8000eb00},
> + { DRM_FORMAT_P012, P010, 0x8000eb00},
> #endif
> #ifdef DRM_FORMAT_P016
> - { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
> + { DRM_FORMAT_P016, P010, 0x8000eb00},
> #endif
> - { 0, 0, 0, 0 }
> + { 0, SKIP4, 0 }
> };
>
> /*
> @@ -221,24 +217,9 @@ static bool fill_in_fb(data_t *data,
> igt_output_t *output, igt_plane_t *plane,
> writesize = data->size+data->size/2;
> break;
> case SKIP4:
> - if (fillers[i].fourcc == DRM_FORMAT_ARGB8888 &&
> - plane->type == DRM_PLANE_TYPE_CURSOR) {
> - /*
> - * special for cursor plane where blending works
> correctly.
> - */
> - ptemp_32_buf = (unsigned int*)data->buf;
> - for (c = 0; c < data->size/4; c++)
> - ptemp_32_buf[c] = fillers[i].value;
> - writesize = data->size;
> - break;
> - }
> - igt_info("Format %s CRC comparison skipped by
> design.\n",
> - (char*)&fillers[i].fourcc);
> -
> - return false;
> default:
> - igt_info("Unsupported mode for test %s\n",
> - (char*)&fillers[i].fourcc);
> + igt_info("Unsupported mode for testing CRC %.4s\n",
> + (char *)&format);
> return false;
> }
>
> @@ -261,6 +242,8 @@ static bool setup_fb(data_t *data, igt_output_t
> *output, igt_plane_t *plane,
> int bpp = 0;
> int i;
>
> + data->allow_fail = false;
> +
> mode = igt_output_get_mode(output);
> if (plane->type != DRM_PLANE_TYPE_CURSOR) {
> w = mode->hdisplay;
> @@ -289,6 +272,8 @@ static bool setup_fb(data_t *data, igt_output_t
> *output, igt_plane_t *plane,
> break;
>
> case SKIP4:
> + data->allow_fail = true;
> + /* fall through */
> case BYTES_PP_4:
> bpp = 32;
> break;
> @@ -319,7 +304,7 @@ static bool setup_fb(data_t *data, igt_output_t
> *output, igt_plane_t *plane,
>
> if(ret < 0) {
> igt_info("Creating fb for format %s failed, return code
> %d\n",
> - (char*)&data->format.name, ret);
> + (char *)&data->format.name, ret);
>
> return false;
> }
> @@ -380,13 +365,14 @@ static bool prepare_crtc(data_t *data,
> igt_output_t *output,
>
>
> static int
> -test_one_mode(data_t* data, igt_output_t *output, igt_plane_t*
> plane,
> - int mode)
> +test_one_mode(data_t *data, igt_output_t *output, igt_plane_t
> *plane,
> + enum pipe pipe, int mode)
> {
> igt_crc_t current_crc;
> signed rVal = 0;
> bool do_crc;
> - char* crccompare[2];
> + char *crccompare[2];
> + igt_crc_t *p_crc;
>
> if (prepare_crtc(data, output, plane, mode)){
> /*
> @@ -404,32 +390,32 @@ test_one_mode(data_t* data, igt_output_t
> *output, igt_plane_t* plane,
> if (do_crc) {
> igt_pipe_crc_get_current(data->gfx_fd, data-
> >pipe_crc, ¤t_crc);
>
> - if (plane->type != DRM_PLANE_TYPE_CURSOR) {
> - if (!igt_check_crc_equal(¤t_crc,
> - &data->fullscreen_crc)) {
> - crccompare[0] =
> igt_crc_to_string(¤t_crc);
> - crccompare[1] =
> igt_crc_to_string(&data->fullscreen_crc);
> - igt_warn("crc mismatch. target
> %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
> - free(crccompare[0]);
> - free(crccompare[1]);
> - rVal++;
> - }
> - } else {
> - if (!igt_check_crc_equal(¤t_crc,
> - &data->cursor_crc)) {
> - crccompare[0] =
> igt_crc_to_string(¤t_crc);
> - crccompare[1] =
> igt_crc_to_string(&data->cursor_crc);
> - igt_warn("crc mismatch. target
> %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
> - free(crccompare[0]);
> - free(crccompare[1]);
> + if (plane->type != DRM_PLANE_TYPE_CURSOR)
> + p_crc = &data->fullscreen_crc;
> + else
> + p_crc = &data->cursor_crc;
> +
> + if (!igt_check_crc_equal(¤t_crc, p_crc))
> {
> + crccompare[0] =
> igt_crc_to_string(¤t_crc);
> + crccompare[1] =
> igt_crc_to_string(p_crc);
> + igt_warn("crc mismatch on %s PIPE %s
> plane %d format %.4s. target %.8s, result %.8s.\n",
> + igt_output_name(output),
> + kmstest_pipe_name(pipe),
> + plane->index,
> + (char *)&data->format.name,
> + crccompare[0],
> + crccompare[1]);
Can you please split this debug print into a separate patch? That way
we can see which format/plane/pipe combination is failing on ICL while
you are working on the gamma fixes?
> +
> + free(crccompare[0]);
> + free(crccompare[1]);
> + if (!data->allow_fail)
> rVal++;
> - }
> }
> }
> remove_fb(data, output, plane);
> return rVal;
> }
> - return 1;
> + return data->allow_fail ? 0 : 1;
> }
>
>
> @@ -440,14 +426,38 @@ test_available_modes(data_t* data)
> igt_plane_t *plane;
> int modeindex;
> enum pipe pipe;
> - int invalids = 0;
> + int failed_crcs = 0, i, lut_size;
> drmModePlane *modePlane;
> - char planetype[3][8] = {"OVERLAY\0", "PRIMARY\0", "CURSOR\0" };
> +
> + struct {
> + uint16_t red;
> + uint16_t green;
> + uint16_t blue;
> + uint16_t reserved;
> + } *lut;
>
> for_each_pipe_with_valid_output(&data->display, pipe, output) {
> + igt_display_reset(&data->display);
> igt_output_set_pipe(output, pipe);
> igt_display_commit2(&data->display, data->commit);
>
> + if (igt_pipe_obj_has_prop(&data->display.pipes[pipe],
> IGT_CRTC_GAMMA_LUT_SIZE)) {
> + lut_size = igt_pipe_get_prop(&data->display,
> pipe,
> + IGT_CRTC_GAMMA_LUT
> _SIZE);
> + lut = calloc(sizeof(*lut), lut_size);
> +
> + for (i = 0; i < lut_size; i++) {
> + lut[i].red = (i * 0xffff / (lut_size -
> 1)) & 0xfc00;
> + lut[i].green = (i * 0xffff / (lut_size
> - 1)) & 0xfc00;
> + lut[i].blue = (i * 0xffff / (lut_size -
> 1)) & 0xfc00;
> + }
> +
> + igt_pipe_replace_prop_blob(&data->display,
> pipe,
> + IGT_CRTC_GAMMA_LUT,
> + lut, sizeof(*lut) *
> lut_size);
> + free(lut);
> + }
> +
> data->pipe_crc = igt_pipe_crc_new(data->gfx_fd, pipe,
> INTEL_PIPE_CRC_SOURCE
> _AUTO);
>
> @@ -467,25 +477,18 @@ test_available_modes(data_t* data)
> modeindex++) {
> data->format.dword = modePlane-
> >formats[modeindex];
>
> - igt_info("Testing connector %s using
> pipe %s" \
> - " plane index %d type %s mode
> %s\n",
> - igt_output_name(output),
> - kmstest_pipe_name(pipe),
> - plane->index,
> - planetype[plane->type],
> - (char*)&data->format.name);
> -
> - invalids += test_one_mode(data, output,
> - plane,
> - modePlane-
> >formats[modeindex]);
> + failed_crcs += test_one_mode(data,
> output,
> + plane,
> pipe,
> + modePlane-
> >formats[modeindex]);
> }
> drmModeFreePlane(modePlane);
> }
> igt_pipe_crc_stop(data->pipe_crc);
> igt_pipe_crc_free(data->pipe_crc);
> - igt_display_commit2(&data->display, data->commit);
> +
> + igt_output_set_pipe(output, PIPE_ANY);
> }
> - igt_assert(invalids == 0);
> + igt_assert(failed_crcs == 0);
> }
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons
2018-12-19 13:41 ` Juha-Pekka Heikkila
` (2 preceding siblings ...)
2019-01-23 19:42 ` Dhinakaran Pandiyan
@ 2019-01-23 19:50 ` Pandiyan, Dhinakaran
2019-01-29 14:01 ` Juha-Pekka Heikkila
3 siblings, 1 reply; 49+ messages in thread
From: Pandiyan, Dhinakaran @ 2019-01-23 19:50 UTC (permalink / raw)
To: juhapekka.heikkila@gmail.com, igt-dev@lists.freedesktop.org
On Wed, 2018-12-19 at 15:41 +0200, Juha-Pekka Heikkila wrote:
> Fixed handling of single plane modes so used bpp never get to
> be 0 and ease off crc comparison a bit with gamma tables as
> idea of this test is to see chosen modes are able to initialize.
>
> Release output to PIPE_ANY at end of test per connector.
>
> Reduce verboseness if there's no errors.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106641
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> tests/kms_available_modes_crc.c | 169 ++++++++++++++++++++--------
> ------------
> 1 file changed, 86 insertions(+), 83 deletions(-)
>
> diff --git a/tests/kms_available_modes_crc.c
> b/tests/kms_available_modes_crc.c
> index 45a4775..04472d0 100644
> --- a/tests/kms_available_modes_crc.c
> +++ b/tests/kms_available_modes_crc.c
> @@ -54,6 +54,12 @@ typedef struct {
>
> igt_crc_t cursor_crc;
> igt_crc_t fullscreen_crc;
> +
> + /*
> + * If there's unknown format setting up mode can fail
> + * without failing entire test.
> + */
> + bool allow_fail;
> } data_t;
>
>
> @@ -120,7 +126,6 @@ static void generate_comparison_crc_list(data_t
> *data, igt_output_t *output)
>
> static const struct {
> uint32_t fourcc;
> - char zeropadding;
> enum { BYTES_PP_1=1,
> BYTES_PP_2=2,
> BYTES_PP_4=4,
> @@ -129,42 +134,33 @@ static const struct {
> SKIP4 } bpp;
> uint32_t value;
> } fillers[] = {
> - { DRM_FORMAT_C8, 0, BYTES_PP_1, 0xff},
> - { DRM_FORMAT_RGB565, 0, BYTES_PP_2, 0xffff},
> - { DRM_FORMAT_XRGB8888, 0, BYTES_PP_4, 0xffffffff},
> - { DRM_FORMAT_XBGR8888, 0, BYTES_PP_4, 0xffffffff},
> -
> - /*
> - * following two are skipped because blending seems to work
> - * incorrectly with exception of AR24 on cursor plane.
> - * Test still creates the planes, just filling plane
> - * and getting crc is skipped.
> - */
> - { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff},
> - { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff},
> -
> - { DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff},
> - { DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff},
> -
> - { DRM_FORMAT_YUYV, 0, BYTES_PP_4, 0x80eb80eb},
> - { DRM_FORMAT_YVYU, 0, BYTES_PP_4, 0x80eb80eb},
> - { DRM_FORMAT_VYUY, 0, BYTES_PP_4, 0xeb80eb80},
> - { DRM_FORMAT_UYVY, 0, BYTES_PP_4, 0xeb80eb80},
> + { DRM_FORMAT_C8, BYTES_PP_1, 0xff},
> + { DRM_FORMAT_RGB565, BYTES_PP_2, 0xffff},
> + { DRM_FORMAT_XRGB8888, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_XBGR8888, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_ARGB8888, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_ABGR8888, BYTES_PP_4, 0x00ffffff},
> + { DRM_FORMAT_XRGB2101010, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_XBGR2101010, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_YUYV, BYTES_PP_4, 0x80eb80eb},
> + { DRM_FORMAT_YVYU, BYTES_PP_4, 0x80eb80eb},
> + { DRM_FORMAT_VYUY, BYTES_PP_4, 0xeb80eb80},
> + { DRM_FORMAT_UYVY, BYTES_PP_4, 0xeb80eb80},
>
> /*
> * (semi-)planar formats
> */
> - { DRM_FORMAT_NV12, 0, NV12, 0x80eb},
> + { DRM_FORMAT_NV12, NV12, 0x80eb},
> #ifdef DRM_FORMAT_P010
> - { DRM_FORMAT_P010, 0, P010, 0x8000eb00},
> + { DRM_FORMAT_P010, P010, 0x8000eb00},
> #endif
> #ifdef DRM_FORMAT_P012
> - { DRM_FORMAT_P012, 0, P010, 0x8000eb00},
> + { DRM_FORMAT_P012, P010, 0x8000eb00},
> #endif
> #ifdef DRM_FORMAT_P016
> - { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
> + { DRM_FORMAT_P016, P010, 0x8000eb00},
> #endif
> - { 0, 0, 0, 0 }
> + { 0, SKIP4, 0 }
> };
>
> /*
> @@ -221,24 +217,9 @@ static bool fill_in_fb(data_t *data,
> igt_output_t *output, igt_plane_t *plane,
> writesize = data->size+data->size/2;
> break;
> case SKIP4:
> - if (fillers[i].fourcc == DRM_FORMAT_ARGB8888 &&
> - plane->type == DRM_PLANE_TYPE_CURSOR) {
> - /*
> - * special for cursor plane where blending works
> correctly.
> - */
> - ptemp_32_buf = (unsigned int*)data->buf;
> - for (c = 0; c < data->size/4; c++)
> - ptemp_32_buf[c] = fillers[i].value;
> - writesize = data->size;
> - break;
> - }
> - igt_info("Format %s CRC comparison skipped by
> design.\n",
> - (char*)&fillers[i].fourcc);
> -
> - return false;
> default:
> - igt_info("Unsupported mode for test %s\n",
> - (char*)&fillers[i].fourcc);
> + igt_info("Unsupported mode for testing CRC %.4s\n",
> + (char *)&format);
> return false;
> }
>
> @@ -261,6 +242,8 @@ static bool setup_fb(data_t *data, igt_output_t
> *output, igt_plane_t *plane,
> int bpp = 0;
> int i;
>
> + data->allow_fail = false;
> +
> mode = igt_output_get_mode(output);
> if (plane->type != DRM_PLANE_TYPE_CURSOR) {
> w = mode->hdisplay;
> @@ -289,6 +272,8 @@ static bool setup_fb(data_t *data, igt_output_t
> *output, igt_plane_t *plane,
> break;
>
> case SKIP4:
> + data->allow_fail = true;
> + /* fall through */
> case BYTES_PP_4:
> bpp = 32;
> break;
> @@ -319,7 +304,7 @@ static bool setup_fb(data_t *data, igt_output_t
> *output, igt_plane_t *plane,
>
> if(ret < 0) {
> igt_info("Creating fb for format %s failed, return code
> %d\n",
> - (char*)&data->format.name, ret);
> + (char *)&data->format.name, ret);
>
> return false;
> }
> @@ -380,13 +365,14 @@ static bool prepare_crtc(data_t *data,
> igt_output_t *output,
>
>
> static int
> -test_one_mode(data_t* data, igt_output_t *output, igt_plane_t*
> plane,
> - int mode)
> +test_one_mode(data_t *data, igt_output_t *output, igt_plane_t
> *plane,
> + enum pipe pipe, int mode)
> {
> igt_crc_t current_crc;
> signed rVal = 0;
> bool do_crc;
> - char* crccompare[2];
> + char *crccompare[2];
> + igt_crc_t *p_crc;
>
> if (prepare_crtc(data, output, plane, mode)){
> /*
> @@ -404,32 +390,32 @@ test_one_mode(data_t* data, igt_output_t
> *output, igt_plane_t* plane,
> if (do_crc) {
> igt_pipe_crc_get_current(data->gfx_fd, data-
> >pipe_crc, ¤t_crc);
>
> - if (plane->type != DRM_PLANE_TYPE_CURSOR) {
> - if (!igt_check_crc_equal(¤t_crc,
> - &data->fullscreen_crc)) {
> - crccompare[0] =
> igt_crc_to_string(¤t_crc);
> - crccompare[1] =
> igt_crc_to_string(&data->fullscreen_crc);
> - igt_warn("crc mismatch. target
> %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
> - free(crccompare[0]);
> - free(crccompare[1]);
> - rVal++;
> - }
> - } else {
> - if (!igt_check_crc_equal(¤t_crc,
> - &data->cursor_crc)) {
> - crccompare[0] =
> igt_crc_to_string(¤t_crc);
> - crccompare[1] =
> igt_crc_to_string(&data->cursor_crc);
> - igt_warn("crc mismatch. target
> %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
> - free(crccompare[0]);
> - free(crccompare[1]);
> + if (plane->type != DRM_PLANE_TYPE_CURSOR)
> + p_crc = &data->fullscreen_crc;
> + else
> + p_crc = &data->cursor_crc;
> +
> + if (!igt_check_crc_equal(¤t_crc, p_crc))
> {
> + crccompare[0] =
> igt_crc_to_string(¤t_crc);
> + crccompare[1] =
> igt_crc_to_string(p_crc);
> + igt_warn("crc mismatch on %s PIPE %s
> plane %d format %.4s. target %.8s, result %.8s.\n",
> + igt_output_name(output),
> + kmstest_pipe_name(pipe),
> + plane->index,
> + (char *)&data->format.name,
> + crccompare[0],
> + crccompare[1]);
Can you please split this debug print into a separate patch? That way
we can see which format/plane/pipe combination is failing on ICL while
you are working on the gamma fixes?
> +
> + free(crccompare[0]);
> + free(crccompare[1]);
> + if (!data->allow_fail)
> rVal++;
> - }
> }
> }
> remove_fb(data, output, plane);
> return rVal;
> }
> - return 1;
> + return data->allow_fail ? 0 : 1;
> }
>
>
> @@ -440,14 +426,38 @@ test_available_modes(data_t* data)
> igt_plane_t *plane;
> int modeindex;
> enum pipe pipe;
> - int invalids = 0;
> + int failed_crcs = 0, i, lut_size;
> drmModePlane *modePlane;
> - char planetype[3][8] = {"OVERLAY\0", "PRIMARY\0", "CURSOR\0" };
> +
> + struct {
> + uint16_t red;
> + uint16_t green;
> + uint16_t blue;
> + uint16_t reserved;
> + } *lut;
>
> for_each_pipe_with_valid_output(&data->display, pipe, output) {
> + igt_display_reset(&data->display);
> igt_output_set_pipe(output, pipe);
> igt_display_commit2(&data->display, data->commit);
>
> + if (igt_pipe_obj_has_prop(&data->display.pipes[pipe],
> IGT_CRTC_GAMMA_LUT_SIZE)) {
> + lut_size = igt_pipe_get_prop(&data->display,
> pipe,
> + IGT_CRTC_GAMMA_LUT
> _SIZE);
> + lut = calloc(sizeof(*lut), lut_size);
> +
> + for (i = 0; i < lut_size; i++) {
> + lut[i].red = (i * 0xffff / (lut_size -
> 1)) & 0xfc00;
> + lut[i].green = (i * 0xffff / (lut_size
> - 1)) & 0xfc00;
> + lut[i].blue = (i * 0xffff / (lut_size -
> 1)) & 0xfc00;
> + }
> +
> + igt_pipe_replace_prop_blob(&data->display,
> pipe,
> + IGT_CRTC_GAMMA_LUT,
> + lut, sizeof(*lut) *
> lut_size);
> + free(lut);
> + }
> +
> data->pipe_crc = igt_pipe_crc_new(data->gfx_fd, pipe,
> INTEL_PIPE_CRC_SOURCE
> _AUTO);
>
> @@ -467,25 +477,18 @@ test_available_modes(data_t* data)
> modeindex++) {
> data->format.dword = modePlane-
> >formats[modeindex];
>
> - igt_info("Testing connector %s using
> pipe %s" \
> - " plane index %d type %s mode
> %s\n",
> - igt_output_name(output),
> - kmstest_pipe_name(pipe),
> - plane->index,
> - planetype[plane->type],
> - (char*)&data->format.name);
> -
> - invalids += test_one_mode(data, output,
> - plane,
> - modePlane-
> >formats[modeindex]);
> + failed_crcs += test_one_mode(data,
> output,
> + plane,
> pipe,
> + modePlane-
> >formats[modeindex]);
> }
> drmModeFreePlane(modePlane);
> }
> igt_pipe_crc_stop(data->pipe_crc);
> igt_pipe_crc_free(data->pipe_crc);
> - igt_display_commit2(&data->display, data->commit);
> +
> + igt_output_set_pipe(output, PIPE_ANY);
> }
> - igt_assert(invalids == 0);
> + igt_assert(failed_crcs == 0);
> }
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons
@ 2019-01-25 12:30 Juha-Pekka Heikkila
2019-01-28 11:43 ` Juha-Pekka Heikkila
2019-01-30 6:40 ` Dhinakaran Pandiyan
0 siblings, 2 replies; 49+ messages in thread
From: Juha-Pekka Heikkila @ 2019-01-25 12:30 UTC (permalink / raw)
To: igt-dev; +Cc: Pandiyan, Dhinakaran
Fixed handling of single plane modes so used bpp never get to
be 0.
Reduce verboseness if there's no errors.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
tests/kms_available_modes_crc.c | 123 ++++++++++++++++++++--------------------
1 file changed, 61 insertions(+), 62 deletions(-)
diff --git a/tests/kms_available_modes_crc.c b/tests/kms_available_modes_crc.c
index 7ff385f..432c084 100644
--- a/tests/kms_available_modes_crc.c
+++ b/tests/kms_available_modes_crc.c
@@ -54,6 +54,12 @@ typedef struct {
igt_crc_t cursor_crc;
igt_crc_t fullscreen_crc;
+
+ /*
+ * If there's unknown format setting up mode can fail
+ * without failing entire test.
+ */
+ bool allow_fail;
} data_t;
@@ -120,7 +126,6 @@ static void generate_comparison_crc_list(data_t *data, igt_output_t *output)
static const struct {
uint32_t fourcc;
- char zeropadding;
enum { BYTES_PP_1=1,
BYTES_PP_2=2,
BYTES_PP_4=4,
@@ -129,10 +134,10 @@ static const struct {
SKIP4 } bpp;
uint32_t value;
} fillers[] = {
- { DRM_FORMAT_C8, 0, BYTES_PP_1, 0xff},
- { DRM_FORMAT_RGB565, 0, BYTES_PP_2, 0xffff},
- { DRM_FORMAT_XRGB8888, 0, BYTES_PP_4, 0xffffffff},
- { DRM_FORMAT_XBGR8888, 0, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_C8, BYTES_PP_1, 0xff},
+ { DRM_FORMAT_RGB565, BYTES_PP_2, 0xffff},
+ { DRM_FORMAT_XRGB8888, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_XBGR8888, BYTES_PP_4, 0xffffffff},
/*
* following two are skipped because blending seems to work
@@ -140,31 +145,31 @@ static const struct {
* Test still creates the planes, just filling plane
* and getting crc is skipped.
*/
- { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff},
- { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff},
+ { DRM_FORMAT_ARGB8888, SKIP4, 0xffffffff},
+ { DRM_FORMAT_ABGR8888, SKIP4, 0x00ffffff},
- { DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff},
- { DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_XRGB2101010, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_XBGR2101010, BYTES_PP_4, 0xffffffff},
- { DRM_FORMAT_YUYV, 0, BYTES_PP_4, 0x80eb80eb},
- { DRM_FORMAT_YVYU, 0, BYTES_PP_4, 0x80eb80eb},
- { DRM_FORMAT_VYUY, 0, BYTES_PP_4, 0xeb80eb80},
- { DRM_FORMAT_UYVY, 0, BYTES_PP_4, 0xeb80eb80},
+ { DRM_FORMAT_YUYV, BYTES_PP_4, 0x80eb80eb},
+ { DRM_FORMAT_YVYU, BYTES_PP_4, 0x80eb80eb},
+ { DRM_FORMAT_VYUY, BYTES_PP_4, 0xeb80eb80},
+ { DRM_FORMAT_UYVY, BYTES_PP_4, 0xeb80eb80},
/*
* (semi-)planar formats
*/
- { DRM_FORMAT_NV12, 0, NV12, 0x80eb},
+ { DRM_FORMAT_NV12, NV12, 0x80eb},
#ifdef DRM_FORMAT_P010
- { DRM_FORMAT_P010, 0, P010, 0x8000eb00},
+ { DRM_FORMAT_P010, P010, 0x8000eb00},
#endif
#ifdef DRM_FORMAT_P012
- { DRM_FORMAT_P012, 0, P010, 0x8000eb00},
+ { DRM_FORMAT_P012, P010, 0x8000eb00},
#endif
#ifdef DRM_FORMAT_P016
- { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
+ { DRM_FORMAT_P016, P010, 0x8000eb00},
#endif
- { 0, 0, 0, 0 }
+ { 0, SKIP4, 0 }
};
/*
@@ -233,13 +238,10 @@ static bool fill_in_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
writesize = data->size;
break;
}
- igt_info("Format %s CRC comparison skipped by design.\n",
- (char*)&fillers[i].fourcc);
-
- return false;
+ /* Fall through */
default:
- igt_info("Unsupported mode for test %s\n",
- (char*)&fillers[i].fourcc);
+ igt_info("Unsupported mode for testing CRC %.4s\n",
+ (char *)&format);
return false;
}
@@ -260,6 +262,8 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
int bpp = 0;
int i;
+ data->allow_fail = false;
+
mode = igt_output_get_mode(output);
if (plane->type != DRM_PLANE_TYPE_CURSOR) {
w = mode->hdisplay;
@@ -288,6 +292,8 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
break;
case SKIP4:
+ data->allow_fail = true;
+ /* fall through */
case BYTES_PP_4:
bpp = 32;
break;
@@ -324,7 +330,7 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
if(ret < 0) {
igt_info("Creating fb for format %s failed, return code %d\n",
- (char*)&data->format.name, ret);
+ (char *)&data->format.name, ret);
return false;
}
@@ -385,13 +391,14 @@ static bool prepare_crtc(data_t *data, igt_output_t *output,
static int
-test_one_mode(data_t* data, igt_output_t *output, igt_plane_t* plane,
- int mode)
+test_one_mode(data_t *data, igt_output_t *output, igt_plane_t *plane,
+ enum pipe pipe, int mode)
{
igt_crc_t current_crc;
signed rVal = 0;
bool do_crc;
- char* crccompare[2];
+ char *crccompare[2];
+ igt_crc_t *p_crc;
if (prepare_crtc(data, output, plane, mode)){
/*
@@ -409,32 +416,32 @@ test_one_mode(data_t* data, igt_output_t *output, igt_plane_t* plane,
if (do_crc) {
igt_pipe_crc_get_current(data->gfx_fd, data->pipe_crc, ¤t_crc);
- if (plane->type != DRM_PLANE_TYPE_CURSOR) {
- if (!igt_check_crc_equal(¤t_crc,
- &data->fullscreen_crc)) {
- crccompare[0] = igt_crc_to_string(¤t_crc);
- crccompare[1] = igt_crc_to_string(&data->fullscreen_crc);
- igt_warn("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
- free(crccompare[0]);
- free(crccompare[1]);
- rVal++;
- }
- } else {
- if (!igt_check_crc_equal(¤t_crc,
- &data->cursor_crc)) {
- crccompare[0] = igt_crc_to_string(¤t_crc);
- crccompare[1] = igt_crc_to_string(&data->cursor_crc);
- igt_warn("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
- free(crccompare[0]);
- free(crccompare[1]);
+ if (plane->type != DRM_PLANE_TYPE_CURSOR)
+ p_crc = &data->fullscreen_crc;
+ else
+ p_crc = &data->cursor_crc;
+
+ if (!igt_check_crc_equal(¤t_crc, p_crc)) {
+ crccompare[0] = igt_crc_to_string(¤t_crc);
+ crccompare[1] = igt_crc_to_string(p_crc);
+ igt_warn("crc mismatch on %s PIPE %s plane %d format %.4s. target %.8s, result %.8s.\n",
+ igt_output_name(output),
+ kmstest_pipe_name(pipe),
+ plane->index,
+ (char *)&data->format.name,
+ crccompare[0],
+ crccompare[1]);
+
+ free(crccompare[0]);
+ free(crccompare[1]);
+ if (!data->allow_fail)
rVal++;
- }
}
}
remove_fb(data, output, plane);
return rVal;
}
- return 1;
+ return data->allow_fail ? 0 : 1;
}
@@ -445,11 +452,11 @@ test_available_modes(data_t* data)
igt_plane_t *plane;
int modeindex;
enum pipe pipe;
- int invalids = 0;
+ int failed_crcs = 0;
drmModePlane *modePlane;
- char planetype[3][8] = {"OVERLAY\0", "PRIMARY\0", "CURSOR\0" };
for_each_pipe_with_valid_output(&data->display, pipe, output) {
+ igt_display_reset(&data->display);
igt_output_set_pipe(output, pipe);
igt_display_commit2(&data->display, data->commit);
@@ -472,17 +479,9 @@ test_available_modes(data_t* data)
modeindex++) {
data->format.dword = modePlane->formats[modeindex];
- igt_info("Testing connector %s using pipe %s" \
- " plane index %d type %s mode %s\n",
- igt_output_name(output),
- kmstest_pipe_name(pipe),
- plane->index,
- planetype[plane->type],
- (char*)&data->format.name);
-
- invalids += test_one_mode(data, output,
- plane,
- modePlane->formats[modeindex]);
+ failed_crcs += test_one_mode(data, output,
+ plane, pipe,
+ modePlane->formats[modeindex]);
}
drmModeFreePlane(modePlane);
}
@@ -491,7 +490,7 @@ test_available_modes(data_t* data)
igt_display_commit2(&data->display, data->commit);
igt_output_set_pipe(output, PIPE_NONE);
}
- igt_assert(invalids == 0);
+ igt_assert_f((failed_crcs == 0), "There was %d modes with invalid crc\n", failed_crcs);
}
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 49+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons
2019-01-25 12:30 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons Juha-Pekka Heikkila
@ 2019-01-28 11:43 ` Juha-Pekka Heikkila
2019-01-30 6:40 ` Dhinakaran Pandiyan
1 sibling, 0 replies; 49+ messages in thread
From: Juha-Pekka Heikkila @ 2019-01-28 11:43 UTC (permalink / raw)
To: igt-dev
Fixed handling of single plane modes so used bpp never get to
be 0 and ease off crc comparison a bit with gamma tables as
idea of this test is to see chosen modes are able to initialize.
Reduce verboseness if there's no errors.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
tests/kms_available_modes_crc.c | 122 ++++++++++++++++++++--------------------
1 file changed, 60 insertions(+), 62 deletions(-)
diff --git a/tests/kms_available_modes_crc.c b/tests/kms_available_modes_crc.c
index 7ff385f..2c8f347 100644
--- a/tests/kms_available_modes_crc.c
+++ b/tests/kms_available_modes_crc.c
@@ -54,6 +54,12 @@ typedef struct {
igt_crc_t cursor_crc;
igt_crc_t fullscreen_crc;
+
+ /*
+ * If there's unknown format setting up mode can fail
+ * without failing entire test.
+ */
+ bool allow_fail;
} data_t;
@@ -120,7 +126,6 @@ static void generate_comparison_crc_list(data_t *data, igt_output_t *output)
static const struct {
uint32_t fourcc;
- char zeropadding;
enum { BYTES_PP_1=1,
BYTES_PP_2=2,
BYTES_PP_4=4,
@@ -129,10 +134,10 @@ static const struct {
SKIP4 } bpp;
uint32_t value;
} fillers[] = {
- { DRM_FORMAT_C8, 0, BYTES_PP_1, 0xff},
- { DRM_FORMAT_RGB565, 0, BYTES_PP_2, 0xffff},
- { DRM_FORMAT_XRGB8888, 0, BYTES_PP_4, 0xffffffff},
- { DRM_FORMAT_XBGR8888, 0, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_C8, BYTES_PP_1, 0xff},
+ { DRM_FORMAT_RGB565, BYTES_PP_2, 0xffff},
+ { DRM_FORMAT_XRGB8888, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_XBGR8888, BYTES_PP_4, 0xffffffff},
/*
* following two are skipped because blending seems to work
@@ -140,31 +145,31 @@ static const struct {
* Test still creates the planes, just filling plane
* and getting crc is skipped.
*/
- { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff},
- { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff},
+ { DRM_FORMAT_ARGB8888, SKIP4, 0xffffffff},
+ { DRM_FORMAT_ABGR8888, SKIP4, 0x00ffffff},
- { DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff},
- { DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_XRGB2101010, BYTES_PP_4, 0xffffffff},
+ { DRM_FORMAT_XBGR2101010, BYTES_PP_4, 0xffffffff},
- { DRM_FORMAT_YUYV, 0, BYTES_PP_4, 0x80eb80eb},
- { DRM_FORMAT_YVYU, 0, BYTES_PP_4, 0x80eb80eb},
- { DRM_FORMAT_VYUY, 0, BYTES_PP_4, 0xeb80eb80},
- { DRM_FORMAT_UYVY, 0, BYTES_PP_4, 0xeb80eb80},
+ { DRM_FORMAT_YUYV, BYTES_PP_4, 0x80eb80eb},
+ { DRM_FORMAT_YVYU, BYTES_PP_4, 0x80eb80eb},
+ { DRM_FORMAT_VYUY, BYTES_PP_4, 0xeb80eb80},
+ { DRM_FORMAT_UYVY, BYTES_PP_4, 0xeb80eb80},
/*
* (semi-)planar formats
*/
- { DRM_FORMAT_NV12, 0, NV12, 0x80eb},
+ { DRM_FORMAT_NV12, NV12, 0x80eb},
#ifdef DRM_FORMAT_P010
- { DRM_FORMAT_P010, 0, P010, 0x8000eb00},
+ { DRM_FORMAT_P010, P010, 0x8000eb00},
#endif
#ifdef DRM_FORMAT_P012
- { DRM_FORMAT_P012, 0, P010, 0x8000eb00},
+ { DRM_FORMAT_P012, P010, 0x8000eb00},
#endif
#ifdef DRM_FORMAT_P016
- { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
+ { DRM_FORMAT_P016, P010, 0x8000eb00},
#endif
- { 0, 0, 0, 0 }
+ { 0, SKIP4, 0 }
};
/*
@@ -233,13 +238,10 @@ static bool fill_in_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
writesize = data->size;
break;
}
- igt_info("Format %s CRC comparison skipped by design.\n",
- (char*)&fillers[i].fourcc);
-
- return false;
+ /* Fall through */
default:
- igt_info("Unsupported mode for test %s\n",
- (char*)&fillers[i].fourcc);
+ igt_info("Unsupported mode for testing CRC %.4s\n",
+ (char *)&format);
return false;
}
@@ -260,6 +262,8 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
int bpp = 0;
int i;
+ data->allow_fail = false;
+
mode = igt_output_get_mode(output);
if (plane->type != DRM_PLANE_TYPE_CURSOR) {
w = mode->hdisplay;
@@ -288,6 +292,8 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
break;
case SKIP4:
+ data->allow_fail = true;
+ /* fall through */
case BYTES_PP_4:
bpp = 32;
break;
@@ -324,7 +330,7 @@ static bool setup_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
if(ret < 0) {
igt_info("Creating fb for format %s failed, return code %d\n",
- (char*)&data->format.name, ret);
+ (char *)&data->format.name, ret);
return false;
}
@@ -385,13 +391,14 @@ static bool prepare_crtc(data_t *data, igt_output_t *output,
static int
-test_one_mode(data_t* data, igt_output_t *output, igt_plane_t* plane,
- int mode)
+test_one_mode(data_t *data, igt_output_t *output, igt_plane_t *plane,
+ enum pipe pipe, int mode)
{
igt_crc_t current_crc;
signed rVal = 0;
bool do_crc;
- char* crccompare[2];
+ char *crccompare[2];
+ igt_crc_t *p_crc;
if (prepare_crtc(data, output, plane, mode)){
/*
@@ -409,32 +416,32 @@ test_one_mode(data_t* data, igt_output_t *output, igt_plane_t* plane,
if (do_crc) {
igt_pipe_crc_get_current(data->gfx_fd, data->pipe_crc, ¤t_crc);
- if (plane->type != DRM_PLANE_TYPE_CURSOR) {
- if (!igt_check_crc_equal(¤t_crc,
- &data->fullscreen_crc)) {
- crccompare[0] = igt_crc_to_string(¤t_crc);
- crccompare[1] = igt_crc_to_string(&data->fullscreen_crc);
- igt_warn("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
- free(crccompare[0]);
- free(crccompare[1]);
- rVal++;
- }
- } else {
- if (!igt_check_crc_equal(¤t_crc,
- &data->cursor_crc)) {
- crccompare[0] = igt_crc_to_string(¤t_crc);
- crccompare[1] = igt_crc_to_string(&data->cursor_crc);
- igt_warn("crc mismatch. target %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
- free(crccompare[0]);
- free(crccompare[1]);
+ if (plane->type != DRM_PLANE_TYPE_CURSOR)
+ p_crc = &data->fullscreen_crc;
+ else
+ p_crc = &data->cursor_crc;
+
+ if (!igt_check_crc_equal(¤t_crc, p_crc)) {
+ crccompare[0] = igt_crc_to_string(¤t_crc);
+ crccompare[1] = igt_crc_to_string(p_crc);
+ igt_warn("crc mismatch on %s PIPE %s plane %d format %.4s. target %.8s, result %.8s.\n",
+ igt_output_name(output),
+ kmstest_pipe_name(pipe),
+ plane->index,
+ (char *)&data->format.name,
+ crccompare[0],
+ crccompare[1]);
+
+ free(crccompare[0]);
+ free(crccompare[1]);
+ if (!data->allow_fail)
rVal++;
- }
}
}
remove_fb(data, output, plane);
return rVal;
}
- return 1;
+ return data->allow_fail ? 0 : 1;
}
@@ -445,9 +452,8 @@ test_available_modes(data_t* data)
igt_plane_t *plane;
int modeindex;
enum pipe pipe;
- int invalids = 0;
+ int failed_crcs = 0;
drmModePlane *modePlane;
- char planetype[3][8] = {"OVERLAY\0", "PRIMARY\0", "CURSOR\0" };
for_each_pipe_with_valid_output(&data->display, pipe, output) {
igt_output_set_pipe(output, pipe);
@@ -472,17 +478,9 @@ test_available_modes(data_t* data)
modeindex++) {
data->format.dword = modePlane->formats[modeindex];
- igt_info("Testing connector %s using pipe %s" \
- " plane index %d type %s mode %s\n",
- igt_output_name(output),
- kmstest_pipe_name(pipe),
- plane->index,
- planetype[plane->type],
- (char*)&data->format.name);
-
- invalids += test_one_mode(data, output,
- plane,
- modePlane->formats[modeindex]);
+ failed_crcs += test_one_mode(data, output,
+ plane, pipe,
+ modePlane->formats[modeindex]);
}
drmModeFreePlane(modePlane);
}
@@ -491,7 +489,7 @@ test_available_modes(data_t* data)
igt_display_commit2(&data->display, data->commit);
igt_output_set_pipe(output, PIPE_NONE);
}
- igt_assert(invalids == 0);
+ igt_assert_f((failed_crcs == 0), "There was %d modes with invalid crc\n", failed_crcs);
}
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 49+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons
2019-01-23 19:50 ` Pandiyan, Dhinakaran
@ 2019-01-29 14:01 ` Juha-Pekka Heikkila
0 siblings, 0 replies; 49+ messages in thread
From: Juha-Pekka Heikkila @ 2019-01-29 14:01 UTC (permalink / raw)
To: Pandiyan, Dhinakaran, igt-dev@lists.freedesktop.org
On 23.1.2019 21.50, Pandiyan, Dhinakaran wrote:
> On Wed, 2018-12-19 at 15:41 +0200, Juha-Pekka Heikkila wrote:
>> Fixed handling of single plane modes so used bpp never get to
>> be 0 and ease off crc comparison a bit with gamma tables as
>> idea of this test is to see chosen modes are able to initialize.
>>
>> Release output to PIPE_ANY at end of test per connector.
>>
>> Reduce verboseness if there's no errors.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106641
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>> ---
>> tests/kms_available_modes_crc.c | 169 ++++++++++++++++++++--------
>> ------------
>> 1 file changed, 86 insertions(+), 83 deletions(-)
>>
>> diff --git a/tests/kms_available_modes_crc.c
>> b/tests/kms_available_modes_crc.c
>> index 45a4775..04472d0 100644
>> --- a/tests/kms_available_modes_crc.c
>> +++ b/tests/kms_available_modes_crc.c
>> @@ -54,6 +54,12 @@ typedef struct {
>>
>> igt_crc_t cursor_crc;
>> igt_crc_t fullscreen_crc;
>> +
>> + /*
>> + * If there's unknown format setting up mode can fail
>> + * without failing entire test.
>> + */
>> + bool allow_fail;
>> } data_t;
>>
>>
>> @@ -120,7 +126,6 @@ static void generate_comparison_crc_list(data_t
>> *data, igt_output_t *output)
>>
>> static const struct {
>> uint32_t fourcc;
>> - char zeropadding;
>> enum { BYTES_PP_1=1,
>> BYTES_PP_2=2,
>> BYTES_PP_4=4,
>> @@ -129,42 +134,33 @@ static const struct {
>> SKIP4 } bpp;
>> uint32_t value;
>> } fillers[] = {
>> - { DRM_FORMAT_C8, 0, BYTES_PP_1, 0xff},
>> - { DRM_FORMAT_RGB565, 0, BYTES_PP_2, 0xffff},
>> - { DRM_FORMAT_XRGB8888, 0, BYTES_PP_4, 0xffffffff},
>> - { DRM_FORMAT_XBGR8888, 0, BYTES_PP_4, 0xffffffff},
>> -
>> - /*
>> - * following two are skipped because blending seems to work
>> - * incorrectly with exception of AR24 on cursor plane.
>> - * Test still creates the planes, just filling plane
>> - * and getting crc is skipped.
>> - */
>> - { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff},
>> - { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff},
>> -
>> - { DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff},
>> - { DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff},
>> -
>> - { DRM_FORMAT_YUYV, 0, BYTES_PP_4, 0x80eb80eb},
>> - { DRM_FORMAT_YVYU, 0, BYTES_PP_4, 0x80eb80eb},
>> - { DRM_FORMAT_VYUY, 0, BYTES_PP_4, 0xeb80eb80},
>> - { DRM_FORMAT_UYVY, 0, BYTES_PP_4, 0xeb80eb80},
>> + { DRM_FORMAT_C8, BYTES_PP_1, 0xff},
>> + { DRM_FORMAT_RGB565, BYTES_PP_2, 0xffff},
>> + { DRM_FORMAT_XRGB8888, BYTES_PP_4, 0xffffffff},
>> + { DRM_FORMAT_XBGR8888, BYTES_PP_4, 0xffffffff},
>> + { DRM_FORMAT_ARGB8888, BYTES_PP_4, 0xffffffff},
>> + { DRM_FORMAT_ABGR8888, BYTES_PP_4, 0x00ffffff},
>> + { DRM_FORMAT_XRGB2101010, BYTES_PP_4, 0xffffffff},
>> + { DRM_FORMAT_XBGR2101010, BYTES_PP_4, 0xffffffff},
>> + { DRM_FORMAT_YUYV, BYTES_PP_4, 0x80eb80eb},
>> + { DRM_FORMAT_YVYU, BYTES_PP_4, 0x80eb80eb},
>> + { DRM_FORMAT_VYUY, BYTES_PP_4, 0xeb80eb80},
>> + { DRM_FORMAT_UYVY, BYTES_PP_4, 0xeb80eb80},
>>
>> /*
>> * (semi-)planar formats
>> */
>> - { DRM_FORMAT_NV12, 0, NV12, 0x80eb},
>> + { DRM_FORMAT_NV12, NV12, 0x80eb},
>> #ifdef DRM_FORMAT_P010
>> - { DRM_FORMAT_P010, 0, P010, 0x8000eb00},
>> + { DRM_FORMAT_P010, P010, 0x8000eb00},
>> #endif
>> #ifdef DRM_FORMAT_P012
>> - { DRM_FORMAT_P012, 0, P010, 0x8000eb00},
>> + { DRM_FORMAT_P012, P010, 0x8000eb00},
>> #endif
>> #ifdef DRM_FORMAT_P016
>> - { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
>> + { DRM_FORMAT_P016, P010, 0x8000eb00},
>> #endif
>> - { 0, 0, 0, 0 }
>> + { 0, SKIP4, 0 }
>> };
>>
>> /*
>> @@ -221,24 +217,9 @@ static bool fill_in_fb(data_t *data,
>> igt_output_t *output, igt_plane_t *plane,
>> writesize = data->size+data->size/2;
>> break;
>> case SKIP4:
>> - if (fillers[i].fourcc == DRM_FORMAT_ARGB8888 &&
>> - plane->type == DRM_PLANE_TYPE_CURSOR) {
>> - /*
>> - * special for cursor plane where blending works
>> correctly.
>> - */
>> - ptemp_32_buf = (unsigned int*)data->buf;
>> - for (c = 0; c < data->size/4; c++)
>> - ptemp_32_buf[c] = fillers[i].value;
>> - writesize = data->size;
>> - break;
>> - }
>> - igt_info("Format %s CRC comparison skipped by
>> design.\n",
>> - (char*)&fillers[i].fourcc);
>> -
>> - return false;
>> default:
>> - igt_info("Unsupported mode for test %s\n",
>> - (char*)&fillers[i].fourcc);
>> + igt_info("Unsupported mode for testing CRC %.4s\n",
>> + (char *)&format);
>> return false;
>> }
>>
>> @@ -261,6 +242,8 @@ static bool setup_fb(data_t *data, igt_output_t
>> *output, igt_plane_t *plane,
>> int bpp = 0;
>> int i;
>>
>> + data->allow_fail = false;
>> +
>> mode = igt_output_get_mode(output);
>> if (plane->type != DRM_PLANE_TYPE_CURSOR) {
>> w = mode->hdisplay;
>> @@ -289,6 +272,8 @@ static bool setup_fb(data_t *data, igt_output_t
>> *output, igt_plane_t *plane,
>> break;
>>
>> case SKIP4:
>> + data->allow_fail = true;
>> + /* fall through */
>> case BYTES_PP_4:
>> bpp = 32;
>> break;
>> @@ -319,7 +304,7 @@ static bool setup_fb(data_t *data, igt_output_t
>> *output, igt_plane_t *plane,
>>
>> if(ret < 0) {
>> igt_info("Creating fb for format %s failed, return code
>> %d\n",
>> - (char*)&data->format.name, ret);
>> + (char *)&data->format.name, ret);
>>
>> return false;
>> }
>> @@ -380,13 +365,14 @@ static bool prepare_crtc(data_t *data,
>> igt_output_t *output,
>>
>>
>> static int
>> -test_one_mode(data_t* data, igt_output_t *output, igt_plane_t*
>> plane,
>> - int mode)
>> +test_one_mode(data_t *data, igt_output_t *output, igt_plane_t
>> *plane,
>> + enum pipe pipe, int mode)
>> {
>> igt_crc_t current_crc;
>> signed rVal = 0;
>> bool do_crc;
>> - char* crccompare[2];
>> + char *crccompare[2];
>> + igt_crc_t *p_crc;
>>
>> if (prepare_crtc(data, output, plane, mode)){
>> /*
>> @@ -404,32 +390,32 @@ test_one_mode(data_t* data, igt_output_t
>> *output, igt_plane_t* plane,
>> if (do_crc) {
>> igt_pipe_crc_get_current(data->gfx_fd, data-
>>> pipe_crc, ¤t_crc);
>>
>> - if (plane->type != DRM_PLANE_TYPE_CURSOR) {
>> - if (!igt_check_crc_equal(¤t_crc,
>> - &data->fullscreen_crc)) {
>> - crccompare[0] =
>> igt_crc_to_string(¤t_crc);
>> - crccompare[1] =
>> igt_crc_to_string(&data->fullscreen_crc);
>> - igt_warn("crc mismatch. target
>> %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
>> - free(crccompare[0]);
>> - free(crccompare[1]);
>> - rVal++;
>> - }
>> - } else {
>> - if (!igt_check_crc_equal(¤t_crc,
>> - &data->cursor_crc)) {
>> - crccompare[0] =
>> igt_crc_to_string(¤t_crc);
>> - crccompare[1] =
>> igt_crc_to_string(&data->cursor_crc);
>> - igt_warn("crc mismatch. target
>> %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
>> - free(crccompare[0]);
>> - free(crccompare[1]);
>> + if (plane->type != DRM_PLANE_TYPE_CURSOR)
>> + p_crc = &data->fullscreen_crc;
>> + else
>> + p_crc = &data->cursor_crc;
>> +
>> + if (!igt_check_crc_equal(¤t_crc, p_crc))
>> {
>> + crccompare[0] =
>> igt_crc_to_string(¤t_crc);
>> + crccompare[1] =
>> igt_crc_to_string(p_crc);
>> + igt_warn("crc mismatch on %s PIPE %s
>> plane %d format %.4s. target %.8s, result %.8s.\n",
>> + igt_output_name(output),
>> + kmstest_pipe_name(pipe),
>> + plane->index,
>> + (char *)&data->format.name,
>> + crccompare[0],
>> + crccompare[1]);
>
> Can you please split this debug print into a separate patch? That way
> we can see which format/plane/pipe combination is failing on ICL while
> you are working on the gamma fixes?
This is what you were hoping for?
https://patchwork.freedesktop.org/series/55727/
/Juha-Pekka
>
>
>
>> +
>> + free(crccompare[0]);
>> + free(crccompare[1]);
>> + if (!data->allow_fail)
>> rVal++;
>> - }
>> }
>> }
>> remove_fb(data, output, plane);
>> return rVal;
>> }
>> - return 1;
>> + return data->allow_fail ? 0 : 1;
>> }
>>
>>
>> @@ -440,14 +426,38 @@ test_available_modes(data_t* data)
>> igt_plane_t *plane;
>> int modeindex;
>> enum pipe pipe;
>> - int invalids = 0;
>> + int failed_crcs = 0, i, lut_size;
>> drmModePlane *modePlane;
>> - char planetype[3][8] = {"OVERLAY\0", "PRIMARY\0", "CURSOR\0" };
>> +
>> + struct {
>> + uint16_t red;
>> + uint16_t green;
>> + uint16_t blue;
>> + uint16_t reserved;
>> + } *lut;
>>
>> for_each_pipe_with_valid_output(&data->display, pipe, output) {
>> + igt_display_reset(&data->display);
>> igt_output_set_pipe(output, pipe);
>> igt_display_commit2(&data->display, data->commit);
>>
>> + if (igt_pipe_obj_has_prop(&data->display.pipes[pipe],
>> IGT_CRTC_GAMMA_LUT_SIZE)) {
>> + lut_size = igt_pipe_get_prop(&data->display,
>> pipe,
>> + IGT_CRTC_GAMMA_LUT
>> _SIZE);
>> + lut = calloc(sizeof(*lut), lut_size);
>> +
>> + for (i = 0; i < lut_size; i++) {
>> + lut[i].red = (i * 0xffff / (lut_size -
>> 1)) & 0xfc00;
>> + lut[i].green = (i * 0xffff / (lut_size
>> - 1)) & 0xfc00;
>> + lut[i].blue = (i * 0xffff / (lut_size -
>> 1)) & 0xfc00;
>> + }
>> +
>> + igt_pipe_replace_prop_blob(&data->display,
>> pipe,
>> + IGT_CRTC_GAMMA_LUT,
>> + lut, sizeof(*lut) *
>> lut_size);
>> + free(lut);
>> + }
>> +
>> data->pipe_crc = igt_pipe_crc_new(data->gfx_fd, pipe,
>> INTEL_PIPE_CRC_SOURCE
>> _AUTO);
>>
>> @@ -467,25 +477,18 @@ test_available_modes(data_t* data)
>> modeindex++) {
>> data->format.dword = modePlane-
>>> formats[modeindex];
>>
>> - igt_info("Testing connector %s using
>> pipe %s" \
>> - " plane index %d type %s mode
>> %s\n",
>> - igt_output_name(output),
>> - kmstest_pipe_name(pipe),
>> - plane->index,
>> - planetype[plane->type],
>> - (char*)&data->format.name);
>> -
>> - invalids += test_one_mode(data, output,
>> - plane,
>> - modePlane-
>>> formats[modeindex]);
>> + failed_crcs += test_one_mode(data,
>> output,
>> + plane,
>> pipe,
>> + modePlane-
>>> formats[modeindex]);
>> }
>> drmModeFreePlane(modePlane);
>> }
>> igt_pipe_crc_stop(data->pipe_crc);
>> igt_pipe_crc_free(data->pipe_crc);
>> - igt_display_commit2(&data->display, data->commit);
>> +
>> + igt_output_set_pipe(output, PIPE_ANY);
>> }
>> - igt_assert(invalids == 0);
>> + igt_assert(failed_crcs == 0);
>> }
>>
>>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons
2019-01-25 12:30 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons Juha-Pekka Heikkila
2019-01-28 11:43 ` Juha-Pekka Heikkila
@ 2019-01-30 6:40 ` Dhinakaran Pandiyan
2019-01-30 11:25 ` Juha-Pekka Heikkila
1 sibling, 1 reply; 49+ messages in thread
From: Dhinakaran Pandiyan @ 2019-01-30 6:40 UTC (permalink / raw)
To: Juha-Pekka Heikkila, igt-dev
On Fri, 2019-01-25 at 14:30 +0200, Juha-Pekka Heikkila wrote:
> Fixed handling of single plane modes so used bpp never get to
> be 0.
>
> Reduce verboseness if there's no errors.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> tests/kms_available_modes_crc.c | 123 ++++++++++++++++++++--------
> ------------
> 1 file changed, 61 insertions(+), 62 deletions(-)
>
> diff --git a/tests/kms_available_modes_crc.c
> b/tests/kms_available_modes_crc.c
> index 7ff385f..432c084 100644
> --- a/tests/kms_available_modes_crc.c
> +++ b/tests/kms_available_modes_crc.c
> @@ -54,6 +54,12 @@ typedef struct {
>
> igt_crc_t cursor_crc;
> igt_crc_t fullscreen_crc;
> +
> + /*
> + * If there's unknown format setting up mode can fail
> + * without failing entire test.
> + */
> + bool allow_fail;
> } data_t;
>
>
> @@ -120,7 +126,6 @@ static void generate_comparison_crc_list(data_t
> *data, igt_output_t *output)
>
> static const struct {
> uint32_t fourcc;
> - char zeropadding;
> enum { BYTES_PP_1=1,
> BYTES_PP_2=2,
> BYTES_PP_4=4,
> @@ -129,10 +134,10 @@ static const struct {
> SKIP4 } bpp;
> uint32_t value;
> } fillers[] = {
> - { DRM_FORMAT_C8, 0, BYTES_PP_1, 0xff},
> - { DRM_FORMAT_RGB565, 0, BYTES_PP_2, 0xffff},
> - { DRM_FORMAT_XRGB8888, 0, BYTES_PP_4, 0xffffffff},
> - { DRM_FORMAT_XBGR8888, 0, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_C8, BYTES_PP_1, 0xff},
> + { DRM_FORMAT_RGB565, BYTES_PP_2, 0xffff},
> + { DRM_FORMAT_XRGB8888, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_XBGR8888, BYTES_PP_4, 0xffffffff},
>
> /*
> * following two are skipped because blending seems to work
> @@ -140,31 +145,31 @@ static const struct {
> * Test still creates the planes, just filling plane
> * and getting crc is skipped.
> */
> - { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff},
> - { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff},
> + { DRM_FORMAT_ARGB8888, SKIP4, 0xffffffff},
> + { DRM_FORMAT_ABGR8888, SKIP4, 0x00ffffff},
>
> - { DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff},
> - { DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_XRGB2101010, BYTES_PP_4, 0xffffffff},
> + { DRM_FORMAT_XBGR2101010, BYTES_PP_4, 0xffffffff},
>
> - { DRM_FORMAT_YUYV, 0, BYTES_PP_4, 0x80eb80eb},
> - { DRM_FORMAT_YVYU, 0, BYTES_PP_4, 0x80eb80eb},
> - { DRM_FORMAT_VYUY, 0, BYTES_PP_4, 0xeb80eb80},
> - { DRM_FORMAT_UYVY, 0, BYTES_PP_4, 0xeb80eb80},
> + { DRM_FORMAT_YUYV, BYTES_PP_4, 0x80eb80eb},
> + { DRM_FORMAT_YVYU, BYTES_PP_4, 0x80eb80eb},
> + { DRM_FORMAT_VYUY, BYTES_PP_4, 0xeb80eb80},
> + { DRM_FORMAT_UYVY, BYTES_PP_4, 0xeb80eb80},
>
> /*
> * (semi-)planar formats
> */
> - { DRM_FORMAT_NV12, 0, NV12, 0x80eb},
> + { DRM_FORMAT_NV12, NV12, 0x80eb},
> #ifdef DRM_FORMAT_P010
> - { DRM_FORMAT_P010, 0, P010, 0x8000eb00},
> + { DRM_FORMAT_P010, P010, 0x8000eb00},
> #endif
> #ifdef DRM_FORMAT_P012
> - { DRM_FORMAT_P012, 0, P010, 0x8000eb00},
> + { DRM_FORMAT_P012, P010, 0x8000eb00},
> #endif
> #ifdef DRM_FORMAT_P016
> - { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
> + { DRM_FORMAT_P016, P010, 0x8000eb00},
Doesn't the library implement this stuff already? I see similar code in
create_bo_for_fb(). Even if new formats are needed, I think it's best
to put that in the lib/igt_fb.
> #endif
> - { 0, 0, 0, 0 }
> + { 0, SKIP4, 0 }
> };
>
> /*
> @@ -233,13 +238,10 @@ static bool fill_in_fb(data_t *data,
> igt_output_t *output, igt_plane_t *plane,
> writesize = data->size;
> break;
> }
> - igt_info("Format %s CRC comparison skipped by
> design.\n",
> - (char*)&fillers[i].fourcc);
> -
> - return false;
> + /* Fall through */
> default:
> - igt_info("Unsupported mode for test %s\n",
> - (char*)&fillers[i].fourcc);
> + igt_info("Unsupported mode for testing CRC %.4s\n",
> + (char *)&format);
> return false;
> }
>
> @@ -260,6 +262,8 @@ static bool setup_fb(data_t *data, igt_output_t
> *output, igt_plane_t *plane,
> int bpp = 0;
> int i;
>
> + data->allow_fail = false;
> +
> mode = igt_output_get_mode(output);
> if (plane->type != DRM_PLANE_TYPE_CURSOR) {
> w = mode->hdisplay;
> @@ -288,6 +292,8 @@ static bool setup_fb(data_t *data, igt_output_t
> *output, igt_plane_t *plane,
> break;
>
> case SKIP4:
> + data->allow_fail = true;
> + /* fall through */
Wouldn't this prevent CRC testing for
(fillers[i].fourcc == DRM_FORMAT_ARGB8888 && plane->type ==
DRM_PLANE_TYPE_CURSOR) ?
> case BYTES_PP_4:
> bpp = 32;
> break;
> @@ -324,7 +330,7 @@ static bool setup_fb(data_t *data, igt_output_t
> *output, igt_plane_t *plane,
>
> if(ret < 0) {
> igt_info("Creating fb for format %s failed, return code
> %d\n",
> - (char*)&data->format.name, ret);
> + (char *)&data->format.name, ret);
>
> return false;
> }
> @@ -385,13 +391,14 @@ static bool prepare_crtc(data_t *data,
> igt_output_t *output,
>
>
> static int
> -test_one_mode(data_t* data, igt_output_t *output, igt_plane_t*
Side note not related to the changes you are making, "mode" is quite
misleading. Shouldn't the test be called kms_pixel_formats_crc or
something? I thought this was about testing different connector modes.
> plane,
> - int mode)
> +test_one_mode(data_t *data, igt_output_t *output, igt_plane_t
> *plane,
> + enum pipe pipe, int mode)
> {
> igt_crc_t current_crc;
> signed rVal = 0;
> bool do_crc;
> - char* crccompare[2];
> + char *crccompare[2];
> + igt_crc_t *p_crc;
>
> if (prepare_crtc(data, output, plane, mode)){
> /*
> @@ -409,32 +416,32 @@ test_one_mode(data_t* data, igt_output_t
> *output, igt_plane_t* plane,
> if (do_crc) {
> igt_pipe_crc_get_current(data->gfx_fd, data-
> >pipe_crc, ¤t_crc);
>
> - if (plane->type != DRM_PLANE_TYPE_CURSOR) {
> - if (!igt_check_crc_equal(¤t_crc,
> - &data->fullscreen_crc)) {
> - crccompare[0] =
> igt_crc_to_string(¤t_crc);
> - crccompare[1] =
> igt_crc_to_string(&data->fullscreen_crc);
> - igt_warn("crc mismatch. target
> %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
> - free(crccompare[0]);
> - free(crccompare[1]);
> - rVal++;
> - }
> - } else {
> - if (!igt_check_crc_equal(¤t_crc,
> - &data->cursor_crc)) {
> - crccompare[0] =
> igt_crc_to_string(¤t_crc);
> - crccompare[1] =
> igt_crc_to_string(&data->cursor_crc);
> - igt_warn("crc mismatch. target
> %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
> - free(crccompare[0]);
> - free(crccompare[1]);
> + if (plane->type != DRM_PLANE_TYPE_CURSOR)
> + p_crc = &data->fullscreen_crc;
> + else
> + p_crc = &data->cursor_crc;
> +
> + if (!igt_check_crc_equal(¤t_crc, p_crc))
> {
> + crccompare[0] =
> igt_crc_to_string(¤t_crc);
> + crccompare[1] =
> igt_crc_to_string(p_crc);
> + igt_warn("crc mismatch on %s PIPE %s
> plane %d format %.4s. target %.8s, result %.8s.\n",
> + igt_output_name(output),
> + kmstest_pipe_name(pipe),
> + plane->index,
> + (char *)&data->format.name,
> + crccompare[0],
> + crccompare[1]);
This is the only hunk I was hoping you would be able to split into a
separate patch.
> +
> + free(crccompare[0]);
> + free(crccompare[1]);
> + if (!data->allow_fail)
Is there a point of reading CRCs if failures are allowed?
> rVal++;
> - }
> }
> }
> remove_fb(data, output, plane);
> return rVal;
> }
> - return 1;
> + return data->allow_fail ? 0 : 1;
> }
>
>
> @@ -445,11 +452,11 @@ test_available_modes(data_t* data)
> igt_plane_t *plane;
> int modeindex;
> enum pipe pipe;
> - int invalids = 0;
> + int failed_crcs = 0;
> drmModePlane *modePlane;
> - char planetype[3][8] = {"OVERLAY\0", "PRIMARY\0", "CURSOR\0" };
>
> for_each_pipe_with_valid_output(&data->display, pipe, output) {
> + igt_display_reset(&data->display);
> igt_output_set_pipe(output, pipe);
> igt_display_commit2(&data->display, data->commit);
>
> @@ -472,17 +479,9 @@ test_available_modes(data_t* data)
> modeindex++) {
> data->format.dword = modePlane-
> >formats[modeindex];
>
> - igt_info("Testing connector %s using
> pipe %s" \
> - " plane index %d type %s mode
> %s\n",
> - igt_output_name(output),
> - kmstest_pipe_name(pipe),
> - plane->index,
> - planetype[plane->type],
> - (char*)&data->format.name);
> -
> - invalids += test_one_mode(data, output,
> - plane,
> - modePlane-
> >formats[modeindex]);
> + failed_crcs += test_one_mode(data,
> output,
> + plane,
> pipe,
> + modePlane-
> >formats[modeindex]);
> }
> drmModeFreePlane(modePlane);
> }
> @@ -491,7 +490,7 @@ test_available_modes(data_t* data)
> igt_display_commit2(&data->display, data->commit);
> igt_output_set_pipe(output, PIPE_NONE);
> }
> - igt_assert(invalids == 0);
> + igt_assert_f((failed_crcs == 0), "There was %d modes with
> invalid crc\n", failed_crcs);
> }
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons
2019-01-30 6:40 ` Dhinakaran Pandiyan
@ 2019-01-30 11:25 ` Juha-Pekka Heikkila
2019-01-30 18:23 ` Dhinakaran Pandiyan
0 siblings, 1 reply; 49+ messages in thread
From: Juha-Pekka Heikkila @ 2019-01-30 11:25 UTC (permalink / raw)
To: dhinakaran.pandiyan, igt-dev
On 30.1.2019 8.40, Dhinakaran Pandiyan wrote:
> On Fri, 2019-01-25 at 14:30 +0200, Juha-Pekka Heikkila wrote:
>> Fixed handling of single plane modes so used bpp never get to
>> be 0.
>>
>> Reduce verboseness if there's no errors.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>> ---
>> tests/kms_available_modes_crc.c | 123 ++++++++++++++++++++--------
>> ------------
>> 1 file changed, 61 insertions(+), 62 deletions(-)
>>
>> diff --git a/tests/kms_available_modes_crc.c
>> b/tests/kms_available_modes_crc.c
>> index 7ff385f..432c084 100644
>> --- a/tests/kms_available_modes_crc.c
>> +++ b/tests/kms_available_modes_crc.c
>> @@ -54,6 +54,12 @@ typedef struct {
>>
>> igt_crc_t cursor_crc;
>> igt_crc_t fullscreen_crc;
>> +
>> + /*
>> + * If there's unknown format setting up mode can fail
>> + * without failing entire test.
>> + */
>> + bool allow_fail;
>> } data_t;
>>
>>
>> @@ -120,7 +126,6 @@ static void generate_comparison_crc_list(data_t
>> *data, igt_output_t *output)
>>
>> static const struct {
>> uint32_t fourcc;
>> - char zeropadding;
>> enum { BYTES_PP_1=1,
>> BYTES_PP_2=2,
>> BYTES_PP_4=4,
>> @@ -129,10 +134,10 @@ static const struct {
>> SKIP4 } bpp;
>> uint32_t value;
>> } fillers[] = {
>> - { DRM_FORMAT_C8, 0, BYTES_PP_1, 0xff},
>> - { DRM_FORMAT_RGB565, 0, BYTES_PP_2, 0xffff},
>> - { DRM_FORMAT_XRGB8888, 0, BYTES_PP_4, 0xffffffff},
>> - { DRM_FORMAT_XBGR8888, 0, BYTES_PP_4, 0xffffffff},
>> + { DRM_FORMAT_C8, BYTES_PP_1, 0xff},
>> + { DRM_FORMAT_RGB565, BYTES_PP_2, 0xffff},
>> + { DRM_FORMAT_XRGB8888, BYTES_PP_4, 0xffffffff},
>> + { DRM_FORMAT_XBGR8888, BYTES_PP_4, 0xffffffff},
>>
>> /*
>> * following two are skipped because blending seems to work
>> @@ -140,31 +145,31 @@ static const struct {
>> * Test still creates the planes, just filling plane
>> * and getting crc is skipped.
>> */
>> - { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff},
>> - { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff},
>> + { DRM_FORMAT_ARGB8888, SKIP4, 0xffffffff},
>> + { DRM_FORMAT_ABGR8888, SKIP4, 0x00ffffff},
>>
>> - { DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff},
>> - { DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff},
>> + { DRM_FORMAT_XRGB2101010, BYTES_PP_4, 0xffffffff},
>> + { DRM_FORMAT_XBGR2101010, BYTES_PP_4, 0xffffffff},
>>
>> - { DRM_FORMAT_YUYV, 0, BYTES_PP_4, 0x80eb80eb},
>> - { DRM_FORMAT_YVYU, 0, BYTES_PP_4, 0x80eb80eb},
>> - { DRM_FORMAT_VYUY, 0, BYTES_PP_4, 0xeb80eb80},
>> - { DRM_FORMAT_UYVY, 0, BYTES_PP_4, 0xeb80eb80},
>> + { DRM_FORMAT_YUYV, BYTES_PP_4, 0x80eb80eb},
>> + { DRM_FORMAT_YVYU, BYTES_PP_4, 0x80eb80eb},
>> + { DRM_FORMAT_VYUY, BYTES_PP_4, 0xeb80eb80},
>> + { DRM_FORMAT_UYVY, BYTES_PP_4, 0xeb80eb80},
>>
>> /*
>> * (semi-)planar formats
>> */
>> - { DRM_FORMAT_NV12, 0, NV12, 0x80eb},
>> + { DRM_FORMAT_NV12, NV12, 0x80eb},
>> #ifdef DRM_FORMAT_P010
>> - { DRM_FORMAT_P010, 0, P010, 0x8000eb00},
>> + { DRM_FORMAT_P010, P010, 0x8000eb00},
>> #endif
>> #ifdef DRM_FORMAT_P012
>> - { DRM_FORMAT_P012, 0, P010, 0x8000eb00},
>> + { DRM_FORMAT_P012, P010, 0x8000eb00},
>> #endif
>> #ifdef DRM_FORMAT_P016
>> - { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
>> + { DRM_FORMAT_P016, P010, 0x8000eb00},
>
> Doesn't the library implement this stuff already? I see similar code in
> create_bo_for_fb(). Even if new formats are needed, I think it's best
> to put that in the lib/igt_fb.
These days igt_fb does implement most of these modes I agree. This test
was written back in the day when igt support was limited to RGB888 and
RGB565. Idea of this test was just to try all fb formats kernel
advertised could actually initialize.
If you feel this test is obsolete you could ask for votes to get it
removed, I tried that before xmas but nobody was interested in removing
this so I started to fix problems seen in this test.
In any case these days one cannot include new fb formats into i915
without IGT support so kms_plane test does what this test does.
>
>
>> #endif
>> - { 0, 0, 0, 0 }
>> + { 0, SKIP4, 0 }
>> };
>>
>> /*
>> @@ -233,13 +238,10 @@ static bool fill_in_fb(data_t *data,
>> igt_output_t *output, igt_plane_t *plane,
>> writesize = data->size;
>> break;
>> }
>> - igt_info("Format %s CRC comparison skipped by
>> design.\n",
>> - (char*)&fillers[i].fourcc);
>> -
>> - return false;
>> + /* Fall through */
>> default:
>> - igt_info("Unsupported mode for test %s\n",
>> - (char*)&fillers[i].fourcc);
>> + igt_info("Unsupported mode for testing CRC %.4s\n",
>> + (char *)&format);
>> return false;
>> }
>>
>> @@ -260,6 +262,8 @@ static bool setup_fb(data_t *data, igt_output_t
>> *output, igt_plane_t *plane,
>> int bpp = 0;
>> int i;
>>
>> + data->allow_fail = false;
>> +
>> mode = igt_output_get_mode(output);
>> if (plane->type != DRM_PLANE_TYPE_CURSOR) {
>> w = mode->hdisplay;
>> @@ -288,6 +292,8 @@ static bool setup_fb(data_t *data, igt_output_t
>> *output, igt_plane_t *plane,
>> break;
>>
>> case SKIP4:
>> + data->allow_fail = true;
>> + /* fall through */
> Wouldn't this prevent CRC testing for
> (fillers[i].fourcc == DRM_FORMAT_ARGB8888 && plane->type ==
> DRM_PLANE_TYPE_CURSOR) ?
There was later patch which fixed this. This version didn't pass CI test
because I had forgotten "igt_display_reset(&data->display)" call bit
below, it killed test on KBL.
>
>
>> case BYTES_PP_4:
>> bpp = 32;
>> break;
>> @@ -324,7 +330,7 @@ static bool setup_fb(data_t *data, igt_output_t
>> *output, igt_plane_t *plane,
>>
>> if(ret < 0) {
>> igt_info("Creating fb for format %s failed, return code
>> %d\n",
>> - (char*)&data->format.name, ret);
>> + (char *)&data->format.name, ret);
>>
>> return false;
>> }
>> @@ -385,13 +391,14 @@ static bool prepare_crtc(data_t *data,
>> igt_output_t *output,
>>
>>
>> static int
>> -test_one_mode(data_t* data, igt_output_t *output, igt_plane_t*
> Side note not related to the changes you are making, "mode" is quite
> misleading. Shouldn't the test be called kms_pixel_formats_crc or
> something? I thought this was about testing different connector modes.
>
>
>> plane,
>> - int mode)
>> +test_one_mode(data_t *data, igt_output_t *output, igt_plane_t
>> *plane,
>> + enum pipe pipe, int mode)
>> {
>> igt_crc_t current_crc;
>> signed rVal = 0;
>> bool do_crc;
>> - char* crccompare[2];
>> + char *crccompare[2];
>> + igt_crc_t *p_crc;
>>
>> if (prepare_crtc(data, output, plane, mode)){
>> /*
>> @@ -409,32 +416,32 @@ test_one_mode(data_t* data, igt_output_t
>> *output, igt_plane_t* plane,
>> if (do_crc) {
>> igt_pipe_crc_get_current(data->gfx_fd, data-
>>> pipe_crc, ¤t_crc);
>>
>> - if (plane->type != DRM_PLANE_TYPE_CURSOR) {
>> - if (!igt_check_crc_equal(¤t_crc,
>> - &data->fullscreen_crc)) {
>> - crccompare[0] =
>> igt_crc_to_string(¤t_crc);
>> - crccompare[1] =
>> igt_crc_to_string(&data->fullscreen_crc);
>> - igt_warn("crc mismatch. target
>> %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
>> - free(crccompare[0]);
>> - free(crccompare[1]);
>> - rVal++;
>> - }
>> - } else {
>> - if (!igt_check_crc_equal(¤t_crc,
>> - &data->cursor_crc)) {
>> - crccompare[0] =
>> igt_crc_to_string(¤t_crc);
>> - crccompare[1] =
>> igt_crc_to_string(&data->cursor_crc);
>> - igt_warn("crc mismatch. target
>> %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
>> - free(crccompare[0]);
>> - free(crccompare[1]);
>> + if (plane->type != DRM_PLANE_TYPE_CURSOR)
>> + p_crc = &data->fullscreen_crc;
>> + else
>> + p_crc = &data->cursor_crc;
>> +
>> + if (!igt_check_crc_equal(¤t_crc, p_crc))
>> {
>> + crccompare[0] =
>> igt_crc_to_string(¤t_crc);
>> + crccompare[1] =
>> igt_crc_to_string(p_crc);
>> + igt_warn("crc mismatch on %s PIPE %s
>> plane %d format %.4s. target %.8s, result %.8s.\n",
>> + igt_output_name(output),
>> + kmstest_pipe_name(pipe),
>> + plane->index,
>> + (char *)&data->format.name,
>> + crccompare[0],
>> + crccompare[1]);
> This is the only hunk I was hoping you would be able to split into a
> separate patch.
>
>> +
>> + free(crccompare[0]);
>> + free(crccompare[1]);
>> + if (!data->allow_fail)
> Is there a point of reading CRCs if failures are allowed?
It is marked as mode which is not listed in this test but initialization
worked so default paths are followed. It will produce warning which I
think is useful for indicating this test need updating but will not
produce failure to mark newly added features caused problems.
>
>> rVal++;
>> - }
>> }
>> }
>> remove_fb(data, output, plane);
>> return rVal;
>> }
>> - return 1;
>> + return data->allow_fail ? 0 : 1;
>> }
>>
>>
>> @@ -445,11 +452,11 @@ test_available_modes(data_t* data)
>> igt_plane_t *plane;
>> int modeindex;
>> enum pipe pipe;
>> - int invalids = 0;
>> + int failed_crcs = 0;
>> drmModePlane *modePlane;
>> - char planetype[3][8] = {"OVERLAY\0", "PRIMARY\0", "CURSOR\0" };
>>
>> for_each_pipe_with_valid_output(&data->display, pipe, output) {
>> + igt_display_reset(&data->display);
>> igt_output_set_pipe(output, pipe);
>> igt_display_commit2(&data->display, data->commit);
>>
>> @@ -472,17 +479,9 @@ test_available_modes(data_t* data)
>> modeindex++) {
>> data->format.dword = modePlane-
>>> formats[modeindex];
>>
>> - igt_info("Testing connector %s using
>> pipe %s" \
>> - " plane index %d type %s mode
>> %s\n",
>> - igt_output_name(output),
>> - kmstest_pipe_name(pipe),
>> - plane->index,
>> - planetype[plane->type],
>> - (char*)&data->format.name);
>> -
>> - invalids += test_one_mode(data, output,
>> - plane,
>> - modePlane-
>>> formats[modeindex]);
>> + failed_crcs += test_one_mode(data,
>> output,
>> + plane,
>> pipe,
>> + modePlane-
>>> formats[modeindex]);
>> }
>> drmModeFreePlane(modePlane);
>> }
>> @@ -491,7 +490,7 @@ test_available_modes(data_t* data)
>> igt_display_commit2(&data->display, data->commit);
>> igt_output_set_pipe(output, PIPE_NONE);
>> }
>> - igt_assert(invalids == 0);
>> + igt_assert_f((failed_crcs == 0), "There was %d modes with
>> invalid crc\n", failed_crcs);
>> }
>>
>>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons
2019-01-30 11:25 ` Juha-Pekka Heikkila
@ 2019-01-30 18:23 ` Dhinakaran Pandiyan
2019-02-05 15:18 ` Juha-Pekka Heikkila
0 siblings, 1 reply; 49+ messages in thread
From: Dhinakaran Pandiyan @ 2019-01-30 18:23 UTC (permalink / raw)
To: juhapekka.heikkila, igt-dev
On Wed, 2019-01-30 at 13:25 +0200, Juha-Pekka Heikkila wrote:
> On 30.1.2019 8.40, Dhinakaran Pandiyan wrote:
> > On Fri, 2019-01-25 at 14:30 +0200, Juha-Pekka Heikkila wrote:
> > > Fixed handling of single plane modes so used bpp never get to
> > > be 0.
> > >
> > > Reduce verboseness if there's no errors.
> > >
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
> > > Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> > > ---
> > > tests/kms_available_modes_crc.c | 123 ++++++++++++++++++++-----
> > > ---
> > > ------------
> > > 1 file changed, 61 insertions(+), 62 deletions(-)
> > >
> > > diff --git a/tests/kms_available_modes_crc.c
> > > b/tests/kms_available_modes_crc.c
> > > index 7ff385f..432c084 100644
> > > --- a/tests/kms_available_modes_crc.c
> > > +++ b/tests/kms_available_modes_crc.c
> > > @@ -54,6 +54,12 @@ typedef struct {
> > >
> > > igt_crc_t cursor_crc;
> > > igt_crc_t fullscreen_crc;
> > > +
> > > + /*
> > > + * If there's unknown format setting up mode can fail
> > > + * without failing entire test.
> > > + */
> > > + bool allow_fail;
> > > } data_t;
> > >
> > >
> > > @@ -120,7 +126,6 @@ static void
> > > generate_comparison_crc_list(data_t
> > > *data, igt_output_t *output)
> > >
> > > static const struct {
> > > uint32_t fourcc;
> > > - char zeropadding;
> > > enum { BYTES_PP_1=1,
> > > BYTES_PP_2=2,
> > > BYTES_PP_4=4,
> > > @@ -129,10 +134,10 @@ static const struct {
> > > SKIP4 } bpp;
> > > uint32_t value;
> > > } fillers[] = {
> > > - { DRM_FORMAT_C8, 0, BYTES_PP_1, 0xff},
> > > - { DRM_FORMAT_RGB565, 0, BYTES_PP_2, 0xffff},
> > > - { DRM_FORMAT_XRGB8888, 0, BYTES_PP_4, 0xffffffff},
> > > - { DRM_FORMAT_XBGR8888, 0, BYTES_PP_4, 0xffffffff},
> > > + { DRM_FORMAT_C8, BYTES_PP_1, 0xff},
> > > + { DRM_FORMAT_RGB565, BYTES_PP_2, 0xffff},
> > > + { DRM_FORMAT_XRGB8888, BYTES_PP_4, 0xffffffff},
> > > + { DRM_FORMAT_XBGR8888, BYTES_PP_4, 0xffffffff},
> > >
> > > /*
> > > * following two are skipped because blending seems to
> > > work
> > > @@ -140,31 +145,31 @@ static const struct {
> > > * Test still creates the planes, just filling plane
> > > * and getting crc is skipped.
> > > */
> > > - { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff},
> > > - { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff},
> > > + { DRM_FORMAT_ARGB8888, SKIP4, 0xffffffff},
> > > + { DRM_FORMAT_ABGR8888, SKIP4, 0x00ffffff},
> > >
> > > - { DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff},
> > > - { DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff},
> > > + { DRM_FORMAT_XRGB2101010, BYTES_PP_4, 0xffffffff},
> > > + { DRM_FORMAT_XBGR2101010, BYTES_PP_4, 0xffffffff},
> > >
> > > - { DRM_FORMAT_YUYV, 0, BYTES_PP_4, 0x80eb80eb},
> > > - { DRM_FORMAT_YVYU, 0, BYTES_PP_4, 0x80eb80eb},
> > > - { DRM_FORMAT_VYUY, 0, BYTES_PP_4, 0xeb80eb80},
> > > - { DRM_FORMAT_UYVY, 0, BYTES_PP_4, 0xeb80eb80},
> > > + { DRM_FORMAT_YUYV, BYTES_PP_4, 0x80eb80eb},
> > > + { DRM_FORMAT_YVYU, BYTES_PP_4, 0x80eb80eb},
> > > + { DRM_FORMAT_VYUY, BYTES_PP_4, 0xeb80eb80},
> > > + { DRM_FORMAT_UYVY, BYTES_PP_4, 0xeb80eb80},
> > >
> > > /*
> > > * (semi-)planar formats
> > > */
> > > - { DRM_FORMAT_NV12, 0, NV12, 0x80eb},
> > > + { DRM_FORMAT_NV12, NV12, 0x80eb},
> > > #ifdef DRM_FORMAT_P010
> > > - { DRM_FORMAT_P010, 0, P010, 0x8000eb00},
> > > + { DRM_FORMAT_P010, P010, 0x8000eb00},
> > > #endif
> > > #ifdef DRM_FORMAT_P012
> > > - { DRM_FORMAT_P012, 0, P010, 0x8000eb00},
> > > + { DRM_FORMAT_P012, P010, 0x8000eb00},
> > > #endif
> > > #ifdef DRM_FORMAT_P016
> > > - { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
> > > + { DRM_FORMAT_P016, P010, 0x8000eb00},
> >
> > Doesn't the library implement this stuff already? I see similar
> > code in
> > create_bo_for_fb(). Even if new formats are needed, I think it's
> > best
> > to put that in the lib/igt_fb.
>
> These days igt_fb does implement most of these modes I agree. This
> test
> was written back in the day when igt support was limited to RGB888
> and
> RGB565. Idea of this test was just to try all fb formats kernel
> advertised could actually initialize.
>
> If you feel this test is obsolete you could ask for votes to get it
> removed, I tried that before xmas but nobody was interested in
> removing
> this so I started to fix problems seen in this test.
I had a quick glance at kms_plane, like you said it pretty much does
the same things but better. My suggestion is to
1) add support in the library for the missing formats i.e.,
DRM_FORMAT_C8, DRM_FORMAT_XBGR2101010
2) get rid of this test.
-DK
>
> In any case these days one cannot include new fb formats into i915
> without IGT support so kms_plane test does what this test does.
>
> >
> >
> > > #endif
> > > - { 0, 0, 0, 0 }
> > > + { 0, SKIP4, 0 }
> > > };
> > >
> > > /*
> > > @@ -233,13 +238,10 @@ static bool fill_in_fb(data_t *data,
> > > igt_output_t *output, igt_plane_t *plane,
> > > writesize = data->size;
> > > break;
> > > }
> > > - igt_info("Format %s CRC comparison skipped by
> > > design.\n",
> > > - (char*)&fillers[i].fourcc);
> > > -
> > > - return false;
> > > + /* Fall through */
> > > default:
> > > - igt_info("Unsupported mode for test %s\n",
> > > - (char*)&fillers[i].fourcc);
> > > + igt_info("Unsupported mode for testing CRC %.4s\n",
> > > + (char *)&format);
> > > return false;
> > > }
> > >
> > > @@ -260,6 +262,8 @@ static bool setup_fb(data_t *data,
> > > igt_output_t
> > > *output, igt_plane_t *plane,
> > > int bpp = 0;
> > > int i;
> > >
> > > + data->allow_fail = false;
> > > +
> > > mode = igt_output_get_mode(output);
> > > if (plane->type != DRM_PLANE_TYPE_CURSOR) {
> > > w = mode->hdisplay;
> > > @@ -288,6 +292,8 @@ static bool setup_fb(data_t *data,
> > > igt_output_t
> > > *output, igt_plane_t *plane,
> > > break;
> > >
> > > case SKIP4:
> > > + data->allow_fail = true;
> > > + /* fall through */
> >
> > Wouldn't this prevent CRC testing for
> > (fillers[i].fourcc == DRM_FORMAT_ARGB8888 && plane->type ==
> > DRM_PLANE_TYPE_CURSOR) ?
>
> There was later patch which fixed this. This version didn't pass CI
> test
> because I had forgotten "igt_display_reset(&data->display)" call bit
> below, it killed test on KBL.
>
> >
> >
> > > case BYTES_PP_4:
> > > bpp = 32;
> > > break;
> > > @@ -324,7 +330,7 @@ static bool setup_fb(data_t *data,
> > > igt_output_t
> > > *output, igt_plane_t *plane,
> > >
> > > if(ret < 0) {
> > > igt_info("Creating fb for format %s failed,
> > > return code
> > > %d\n",
> > > - (char*)&data->format.name, ret);
> > > + (char *)&data->format.name, ret);
> > >
> > > return false;
> > > }
> > > @@ -385,13 +391,14 @@ static bool prepare_crtc(data_t *data,
> > > igt_output_t *output,
> > >
> > >
> > > static int
> > > -test_one_mode(data_t* data, igt_output_t *output, igt_plane_t*
> >
> > Side note not related to the changes you are making, "mode" is
> > quite
> > misleading. Shouldn't the test be called kms_pixel_formats_crc or
> > something? I thought this was about testing different connector
> > modes.
> >
> >
> > > plane,
> > > - int mode)
> > > +test_one_mode(data_t *data, igt_output_t *output, igt_plane_t
> > > *plane,
> > > + enum pipe pipe, int mode)
> > > {
> > > igt_crc_t current_crc;
> > > signed rVal = 0;
> > > bool do_crc;
> > > - char* crccompare[2];
> > > + char *crccompare[2];
> > > + igt_crc_t *p_crc;
> > >
> > > if (prepare_crtc(data, output, plane, mode)){
> > > /*
> > > @@ -409,32 +416,32 @@ test_one_mode(data_t* data, igt_output_t
> > > *output, igt_plane_t* plane,
> > > if (do_crc) {
> > > igt_pipe_crc_get_current(data->gfx_fd,
> > > data-
> > > > pipe_crc, ¤t_crc);
> > >
> > >
> > > - if (plane->type != DRM_PLANE_TYPE_CURSOR) {
> > > - if (!igt_check_crc_equal(¤t_crc,
> > > - &data->fullscreen_crc)) {
> > > - crccompare[0] =
> > > igt_crc_to_string(¤t_crc);
> > > - crccompare[1] =
> > > igt_crc_to_string(&data->fullscreen_crc);
> > > - igt_warn("crc mismatch. target
> > > %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
> > > - free(crccompare[0]);
> > > - free(crccompare[1]);
> > > - rVal++;
> > > - }
> > > - } else {
> > > - if (!igt_check_crc_equal(¤t_crc,
> > > - &data->cursor_crc)) {
> > > - crccompare[0] =
> > > igt_crc_to_string(¤t_crc);
> > > - crccompare[1] =
> > > igt_crc_to_string(&data->cursor_crc);
> > > - igt_warn("crc mismatch. target
> > > %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
> > > - free(crccompare[0]);
> > > - free(crccompare[1]);
> > > + if (plane->type != DRM_PLANE_TYPE_CURSOR)
> > > + p_crc = &data->fullscreen_crc;
> > > + else
> > > + p_crc = &data->cursor_crc;
> > > +
> > > + if (!igt_check_crc_equal(¤t_crc, p_crc))
> > > {
> > > + crccompare[0] =
> > > igt_crc_to_string(¤t_crc);
> > > + crccompare[1] =
> > > igt_crc_to_string(p_crc);
> > > + igt_warn("crc mismatch on %s PIPE %s
> > > plane %d format %.4s. target %.8s, result %.8s.\n",
> > > + igt_output_name(output),
> > > + kmstest_pipe_name(pipe),
> > > + plane->index,
> > > + (char *)&data->format.name,
> > > + crccompare[0],
> > > + crccompare[1]);
> >
> > This is the only hunk I was hoping you would be able to split into
> > a
> > separate patch.
> >
> > > +
> > > + free(crccompare[0]);
> > > + free(crccompare[1]);
> > > + if (!data->allow_fail)
> >
> > Is there a point of reading CRCs if failures are allowed?
>
> It is marked as mode which is not listed in this test but
> initialization
> worked so default paths are followed. It will produce warning which
> I
> think is useful for indicating this test need updating but will not
> produce failure to mark newly added features caused problems.
>
> >
> > > rVal++;
> > > - }
> > > }
> > > }
> > > remove_fb(data, output, plane);
> > > return rVal;
> > > }
> > > - return 1;
> > > + return data->allow_fail ? 0 : 1;
> > > }
> > >
> > >
> > > @@ -445,11 +452,11 @@ test_available_modes(data_t* data)
> > > igt_plane_t *plane;
> > > int modeindex;
> > > enum pipe pipe;
> > > - int invalids = 0;
> > > + int failed_crcs = 0;
> > > drmModePlane *modePlane;
> > > - char planetype[3][8] = {"OVERLAY\0", "PRIMARY\0", "CURSOR\0" };
> > >
> > > for_each_pipe_with_valid_output(&data->display, pipe,
> > > output) {
> > > + igt_display_reset(&data->display);
> > > igt_output_set_pipe(output, pipe);
> > > igt_display_commit2(&data->display, data-
> > > >commit);
> > >
> > > @@ -472,17 +479,9 @@ test_available_modes(data_t* data)
> > > modeindex++) {
> > > data->format.dword = modePlane-
> > > > formats[modeindex];
> > >
> > >
> > > - igt_info("Testing connector %s using
> > > pipe %s" \
> > > - " plane index %d type %s mode
> > > %s\n",
> > > - igt_output_name(output),
> > > - kmstest_pipe_name(pipe),
> > > - plane->index,
> > > - planetype[plane->type],
> > > - (char*)&data->format.name);
> > > -
> > > - invalids += test_one_mode(data, output,
> > > - plane,
> > > - modePlane-
> > > > formats[modeindex]);
> > >
> > > + failed_crcs += test_one_mode(data,
> > > output,
> > > + plane,
> > > pipe,
> > > + modePlane-
> > > > formats[modeindex]);
> > >
> > > }
> > > drmModeFreePlane(modePlane);
> > > }
> > > @@ -491,7 +490,7 @@ test_available_modes(data_t* data)
> > > igt_display_commit2(&data->display, data-
> > > >commit);
> > > igt_output_set_pipe(output, PIPE_NONE);
> > > }
> > > - igt_assert(invalids == 0);
> > > + igt_assert_f((failed_crcs == 0), "There was %d modes with
> > > invalid crc\n", failed_crcs);
> > > }
> > >
> > >
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons
2019-01-30 18:23 ` Dhinakaran Pandiyan
@ 2019-02-05 15:18 ` Juha-Pekka Heikkila
2019-02-05 22:01 ` Dhinakaran Pandiyan
0 siblings, 1 reply; 49+ messages in thread
From: Juha-Pekka Heikkila @ 2019-02-05 15:18 UTC (permalink / raw)
To: dhinakaran.pandiyan, igt-dev
On 30.1.2019 20.23, Dhinakaran Pandiyan wrote:
> On Wed, 2019-01-30 at 13:25 +0200, Juha-Pekka Heikkila wrote:
>> On 30.1.2019 8.40, Dhinakaran Pandiyan wrote:
>>> On Fri, 2019-01-25 at 14:30 +0200, Juha-Pekka Heikkila wrote:
>>>> Fixed handling of single plane modes so used bpp never get to
>>>> be 0.
>>>>
>>>> Reduce verboseness if there's no errors.
>>>>
>>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
>>>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>>>> ---
>>>> tests/kms_available_modes_crc.c | 123 ++++++++++++++++++++-----
>>>> ---
>>>> ------------
>>>> 1 file changed, 61 insertions(+), 62 deletions(-)
>>>>
>>>> diff --git a/tests/kms_available_modes_crc.c
>>>> b/tests/kms_available_modes_crc.c
>>>> index 7ff385f..432c084 100644
>>>> --- a/tests/kms_available_modes_crc.c
>>>> +++ b/tests/kms_available_modes_crc.c
>>>> @@ -54,6 +54,12 @@ typedef struct {
>>>>
>>>> igt_crc_t cursor_crc;
>>>> igt_crc_t fullscreen_crc;
>>>> +
>>>> + /*
>>>> + * If there's unknown format setting up mode can fail
>>>> + * without failing entire test.
>>>> + */
>>>> + bool allow_fail;
>>>> } data_t;
>>>>
>>>>
>>>> @@ -120,7 +126,6 @@ static void
>>>> generate_comparison_crc_list(data_t
>>>> *data, igt_output_t *output)
>>>>
>>>> static const struct {
>>>> uint32_t fourcc;
>>>> - char zeropadding;
>>>> enum { BYTES_PP_1=1,
>>>> BYTES_PP_2=2,
>>>> BYTES_PP_4=4,
>>>> @@ -129,10 +134,10 @@ static const struct {
>>>> SKIP4 } bpp;
>>>> uint32_t value;
>>>> } fillers[] = {
>>>> - { DRM_FORMAT_C8, 0, BYTES_PP_1, 0xff},
>>>> - { DRM_FORMAT_RGB565, 0, BYTES_PP_2, 0xffff},
>>>> - { DRM_FORMAT_XRGB8888, 0, BYTES_PP_4, 0xffffffff},
>>>> - { DRM_FORMAT_XBGR8888, 0, BYTES_PP_4, 0xffffffff},
>>>> + { DRM_FORMAT_C8, BYTES_PP_1, 0xff},
>>>> + { DRM_FORMAT_RGB565, BYTES_PP_2, 0xffff},
>>>> + { DRM_FORMAT_XRGB8888, BYTES_PP_4, 0xffffffff},
>>>> + { DRM_FORMAT_XBGR8888, BYTES_PP_4, 0xffffffff},
>>>>
>>>> /*
>>>> * following two are skipped because blending seems to
>>>> work
>>>> @@ -140,31 +145,31 @@ static const struct {
>>>> * Test still creates the planes, just filling plane
>>>> * and getting crc is skipped.
>>>> */
>>>> - { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff},
>>>> - { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff},
>>>> + { DRM_FORMAT_ARGB8888, SKIP4, 0xffffffff},
>>>> + { DRM_FORMAT_ABGR8888, SKIP4, 0x00ffffff},
>>>>
>>>> - { DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff},
>>>> - { DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff},
>>>> + { DRM_FORMAT_XRGB2101010, BYTES_PP_4, 0xffffffff},
>>>> + { DRM_FORMAT_XBGR2101010, BYTES_PP_4, 0xffffffff},
>>>>
>>>> - { DRM_FORMAT_YUYV, 0, BYTES_PP_4, 0x80eb80eb},
>>>> - { DRM_FORMAT_YVYU, 0, BYTES_PP_4, 0x80eb80eb},
>>>> - { DRM_FORMAT_VYUY, 0, BYTES_PP_4, 0xeb80eb80},
>>>> - { DRM_FORMAT_UYVY, 0, BYTES_PP_4, 0xeb80eb80},
>>>> + { DRM_FORMAT_YUYV, BYTES_PP_4, 0x80eb80eb},
>>>> + { DRM_FORMAT_YVYU, BYTES_PP_4, 0x80eb80eb},
>>>> + { DRM_FORMAT_VYUY, BYTES_PP_4, 0xeb80eb80},
>>>> + { DRM_FORMAT_UYVY, BYTES_PP_4, 0xeb80eb80},
>>>>
>>>> /*
>>>> * (semi-)planar formats
>>>> */
>>>> - { DRM_FORMAT_NV12, 0, NV12, 0x80eb},
>>>> + { DRM_FORMAT_NV12, NV12, 0x80eb},
>>>> #ifdef DRM_FORMAT_P010
>>>> - { DRM_FORMAT_P010, 0, P010, 0x8000eb00},
>>>> + { DRM_FORMAT_P010, P010, 0x8000eb00},
>>>> #endif
>>>> #ifdef DRM_FORMAT_P012
>>>> - { DRM_FORMAT_P012, 0, P010, 0x8000eb00},
>>>> + { DRM_FORMAT_P012, P010, 0x8000eb00},
>>>> #endif
>>>> #ifdef DRM_FORMAT_P016
>>>> - { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
>>>> + { DRM_FORMAT_P016, P010, 0x8000eb00},
>>>
>>> Doesn't the library implement this stuff already? I see similar
>>> code in
>>> create_bo_for_fb(). Even if new formats are needed, I think it's
>>> best
>>> to put that in the lib/igt_fb.
>>
>> These days igt_fb does implement most of these modes I agree. This
>> test
>> was written back in the day when igt support was limited to RGB888
>> and
>> RGB565. Idea of this test was just to try all fb formats kernel
>> advertised could actually initialize.
>>
>> If you feel this test is obsolete you could ask for votes to get it
>> removed, I tried that before xmas but nobody was interested in
>> removing
>> this so I started to fix problems seen in this test.
>
> I had a quick glance at kms_plane, like you said it pretty much does
> the same things but better. My suggestion is to
> 1) add support in the library for the missing formats i.e.,
> DRM_FORMAT_C8, DRM_FORMAT_XBGR2101010
> 2) get rid of this test.
>
Hi DK,
I was looking at those formats missing from list of IGT supported
formats. DRM_FORMAT_XBGR2101010 shouldn't be much of a problem to add
but it's yet to be seen how it will show in different tests.
DRM_FORMAT_C8 on the other hand is different story, I think it probably
should not be added as supported format for IGT. Reason for not adding
C8 would be the 8bit nature, I think it will never have enough colors to
be passing most of CRC tests. I had idea for C8 there would be separate
test which will only test C8 features.
I'd begin by removing available modes test as it seems to cause only
useless noise now and is doubled by kms_plane in places where it really
matter.
You have opinions or ideas on this? I'd add above on my 'to-do' list.
/Juha-Pekka
>
>>
>> In any case these days one cannot include new fb formats into i915
>> without IGT support so kms_plane test does what this test does.
>>
>>>
>>>
>>>> #endif
>>>> - { 0, 0, 0, 0 }
>>>> + { 0, SKIP4, 0 }
>>>> };
>>>>
>>>> /*
>>>> @@ -233,13 +238,10 @@ static bool fill_in_fb(data_t *data,
>>>> igt_output_t *output, igt_plane_t *plane,
>>>> writesize = data->size;
>>>> break;
>>>> }
>>>> - igt_info("Format %s CRC comparison skipped by
>>>> design.\n",
>>>> - (char*)&fillers[i].fourcc);
>>>> -
>>>> - return false;
>>>> + /* Fall through */
>>>> default:
>>>> - igt_info("Unsupported mode for test %s\n",
>>>> - (char*)&fillers[i].fourcc);
>>>> + igt_info("Unsupported mode for testing CRC %.4s\n",
>>>> + (char *)&format);
>>>> return false;
>>>> }
>>>>
>>>> @@ -260,6 +262,8 @@ static bool setup_fb(data_t *data,
>>>> igt_output_t
>>>> *output, igt_plane_t *plane,
>>>> int bpp = 0;
>>>> int i;
>>>>
>>>> + data->allow_fail = false;
>>>> +
>>>> mode = igt_output_get_mode(output);
>>>> if (plane->type != DRM_PLANE_TYPE_CURSOR) {
>>>> w = mode->hdisplay;
>>>> @@ -288,6 +292,8 @@ static bool setup_fb(data_t *data,
>>>> igt_output_t
>>>> *output, igt_plane_t *plane,
>>>> break;
>>>>
>>>> case SKIP4:
>>>> + data->allow_fail = true;
>>>> + /* fall through */
>>>
>>> Wouldn't this prevent CRC testing for
>>> (fillers[i].fourcc == DRM_FORMAT_ARGB8888 && plane->type ==
>>> DRM_PLANE_TYPE_CURSOR) ?
>>
>> There was later patch which fixed this. This version didn't pass CI
>> test
>> because I had forgotten "igt_display_reset(&data->display)" call bit
>> below, it killed test on KBL.
>>
>>>
>>>
>>>> case BYTES_PP_4:
>>>> bpp = 32;
>>>> break;
>>>> @@ -324,7 +330,7 @@ static bool setup_fb(data_t *data,
>>>> igt_output_t
>>>> *output, igt_plane_t *plane,
>>>>
>>>> if(ret < 0) {
>>>> igt_info("Creating fb for format %s failed,
>>>> return code
>>>> %d\n",
>>>> - (char*)&data->format.name, ret);
>>>> + (char *)&data->format.name, ret);
>>>>
>>>> return false;
>>>> }
>>>> @@ -385,13 +391,14 @@ static bool prepare_crtc(data_t *data,
>>>> igt_output_t *output,
>>>>
>>>>
>>>> static int
>>>> -test_one_mode(data_t* data, igt_output_t *output, igt_plane_t*
>>>
>>> Side note not related to the changes you are making, "mode" is
>>> quite
>>> misleading. Shouldn't the test be called kms_pixel_formats_crc or
>>> something? I thought this was about testing different connector
>>> modes.
>>>
>>>
>>>> plane,
>>>> - int mode)
>>>> +test_one_mode(data_t *data, igt_output_t *output, igt_plane_t
>>>> *plane,
>>>> + enum pipe pipe, int mode)
>>>> {
>>>> igt_crc_t current_crc;
>>>> signed rVal = 0;
>>>> bool do_crc;
>>>> - char* crccompare[2];
>>>> + char *crccompare[2];
>>>> + igt_crc_t *p_crc;
>>>>
>>>> if (prepare_crtc(data, output, plane, mode)){
>>>> /*
>>>> @@ -409,32 +416,32 @@ test_one_mode(data_t* data, igt_output_t
>>>> *output, igt_plane_t* plane,
>>>> if (do_crc) {
>>>> igt_pipe_crc_get_current(data->gfx_fd,
>>>> data-
>>>>> pipe_crc, ¤t_crc);
>>>>
>>>>
>>>> - if (plane->type != DRM_PLANE_TYPE_CURSOR) {
>>>> - if (!igt_check_crc_equal(¤t_crc,
>>>> - &data->fullscreen_crc)) {
>>>> - crccompare[0] =
>>>> igt_crc_to_string(¤t_crc);
>>>> - crccompare[1] =
>>>> igt_crc_to_string(&data->fullscreen_crc);
>>>> - igt_warn("crc mismatch. target
>>>> %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
>>>> - free(crccompare[0]);
>>>> - free(crccompare[1]);
>>>> - rVal++;
>>>> - }
>>>> - } else {
>>>> - if (!igt_check_crc_equal(¤t_crc,
>>>> - &data->cursor_crc)) {
>>>> - crccompare[0] =
>>>> igt_crc_to_string(¤t_crc);
>>>> - crccompare[1] =
>>>> igt_crc_to_string(&data->cursor_crc);
>>>> - igt_warn("crc mismatch. target
>>>> %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
>>>> - free(crccompare[0]);
>>>> - free(crccompare[1]);
>>>> + if (plane->type != DRM_PLANE_TYPE_CURSOR)
>>>> + p_crc = &data->fullscreen_crc;
>>>> + else
>>>> + p_crc = &data->cursor_crc;
>>>> +
>>>> + if (!igt_check_crc_equal(¤t_crc, p_crc))
>>>> {
>>>> + crccompare[0] =
>>>> igt_crc_to_string(¤t_crc);
>>>> + crccompare[1] =
>>>> igt_crc_to_string(p_crc);
>>>> + igt_warn("crc mismatch on %s PIPE %s
>>>> plane %d format %.4s. target %.8s, result %.8s.\n",
>>>> + igt_output_name(output),
>>>> + kmstest_pipe_name(pipe),
>>>> + plane->index,
>>>> + (char *)&data->format.name,
>>>> + crccompare[0],
>>>> + crccompare[1]);
>>>
>>> This is the only hunk I was hoping you would be able to split into
>>> a
>>> separate patch.
>>>
>>>> +
>>>> + free(crccompare[0]);
>>>> + free(crccompare[1]);
>>>> + if (!data->allow_fail)
>>>
>>> Is there a point of reading CRCs if failures are allowed?
>>
>> It is marked as mode which is not listed in this test but
>> initialization
>> worked so default paths are followed. It will produce warning which
>> I
>> think is useful for indicating this test need updating but will not
>> produce failure to mark newly added features caused problems.
>>
>>>
>>>> rVal++;
>>>> - }
>>>> }
>>>> }
>>>> remove_fb(data, output, plane);
>>>> return rVal;
>>>> }
>>>> - return 1;
>>>> + return data->allow_fail ? 0 : 1;
>>>> }
>>>>
>>>>
>>>> @@ -445,11 +452,11 @@ test_available_modes(data_t* data)
>>>> igt_plane_t *plane;
>>>> int modeindex;
>>>> enum pipe pipe;
>>>> - int invalids = 0;
>>>> + int failed_crcs = 0;
>>>> drmModePlane *modePlane;
>>>> - char planetype[3][8] = {"OVERLAY\0", "PRIMARY\0", "CURSOR\0" };
>>>>
>>>> for_each_pipe_with_valid_output(&data->display, pipe,
>>>> output) {
>>>> + igt_display_reset(&data->display);
>>>> igt_output_set_pipe(output, pipe);
>>>> igt_display_commit2(&data->display, data-
>>>>> commit);
>>>>
>>>> @@ -472,17 +479,9 @@ test_available_modes(data_t* data)
>>>> modeindex++) {
>>>> data->format.dword = modePlane-
>>>>> formats[modeindex];
>>>>
>>>>
>>>> - igt_info("Testing connector %s using
>>>> pipe %s" \
>>>> - " plane index %d type %s mode
>>>> %s\n",
>>>> - igt_output_name(output),
>>>> - kmstest_pipe_name(pipe),
>>>> - plane->index,
>>>> - planetype[plane->type],
>>>> - (char*)&data->format.name);
>>>> -
>>>> - invalids += test_one_mode(data, output,
>>>> - plane,
>>>> - modePlane-
>>>>> formats[modeindex]);
>>>>
>>>> + failed_crcs += test_one_mode(data,
>>>> output,
>>>> + plane,
>>>> pipe,
>>>> + modePlane-
>>>>> formats[modeindex]);
>>>>
>>>> }
>>>> drmModeFreePlane(modePlane);
>>>> }
>>>> @@ -491,7 +490,7 @@ test_available_modes(data_t* data)
>>>> igt_display_commit2(&data->display, data-
>>>>> commit);
>>>> igt_output_set_pipe(output, PIPE_NONE);
>>>> }
>>>> - igt_assert(invalids == 0);
>>>> + igt_assert_f((failed_crcs == 0), "There was %d modes with
>>>> invalid crc\n", failed_crcs);
>>>> }
>>>>
>>>>
>>
>>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons
2019-02-05 15:18 ` Juha-Pekka Heikkila
@ 2019-02-05 22:01 ` Dhinakaran Pandiyan
0 siblings, 0 replies; 49+ messages in thread
From: Dhinakaran Pandiyan @ 2019-02-05 22:01 UTC (permalink / raw)
To: juhapekka.heikkila, igt-dev
On Tue, 2019-02-05 at 17:18 +0200, Juha-Pekka Heikkila wrote:
> On 30.1.2019 20.23, Dhinakaran Pandiyan wrote:
> > On Wed, 2019-01-30 at 13:25 +0200, Juha-Pekka Heikkila wrote:
> > > On 30.1.2019 8.40, Dhinakaran Pandiyan wrote:
> > > > On Fri, 2019-01-25 at 14:30 +0200, Juha-Pekka Heikkila wrote:
> > > > > Fixed handling of single plane modes so used bpp never get to
> > > > > be 0.
> > > > >
> > > > > Reduce verboseness if there's no errors.
> > > > >
> > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106701
> > > > > Signed-off-by: Juha-Pekka Heikkila <
> > > > > juhapekka.heikkila@gmail.com>
> > > > > ---
> > > > > tests/kms_available_modes_crc.c | 123
> > > > > ++++++++++++++++++++-----
> > > > > ---
> > > > > ------------
> > > > > 1 file changed, 61 insertions(+), 62 deletions(-)
> > > > >
> > > > > diff --git a/tests/kms_available_modes_crc.c
> > > > > b/tests/kms_available_modes_crc.c
> > > > > index 7ff385f..432c084 100644
> > > > > --- a/tests/kms_available_modes_crc.c
> > > > > +++ b/tests/kms_available_modes_crc.c
> > > > > @@ -54,6 +54,12 @@ typedef struct {
> > > > >
> > > > > igt_crc_t cursor_crc;
> > > > > igt_crc_t fullscreen_crc;
> > > > > +
> > > > > + /*
> > > > > + * If there's unknown format setting up mode can fail
> > > > > + * without failing entire test.
> > > > > + */
> > > > > + bool allow_fail;
> > > > > } data_t;
> > > > >
> > > > >
> > > > > @@ -120,7 +126,6 @@ static void
> > > > > generate_comparison_crc_list(data_t
> > > > > *data, igt_output_t *output)
> > > > >
> > > > > static const struct {
> > > > > uint32_t fourcc;
> > > > > - char zeropadding;
> > > > > enum { BYTES_PP_1=1,
> > > > > BYTES_PP_2=2,
> > > > > BYTES_PP_4=4,
> > > > > @@ -129,10 +134,10 @@ static const struct {
> > > > > SKIP4 } bpp;
> > > > > uint32_t value;
> > > > > } fillers[] = {
> > > > > - { DRM_FORMAT_C8, 0, BYTES_PP_1, 0xff},
> > > > > - { DRM_FORMAT_RGB565, 0, BYTES_PP_2, 0xffff},
> > > > > - { DRM_FORMAT_XRGB8888, 0, BYTES_PP_4, 0xffffffff},
> > > > > - { DRM_FORMAT_XBGR8888, 0, BYTES_PP_4, 0xffffffff},
> > > > > + { DRM_FORMAT_C8, BYTES_PP_1, 0xff},
> > > > > + { DRM_FORMAT_RGB565, BYTES_PP_2, 0xffff},
> > > > > + { DRM_FORMAT_XRGB8888, BYTES_PP_4, 0xffffffff},
> > > > > + { DRM_FORMAT_XBGR8888, BYTES_PP_4, 0xffffffff},
> > > > >
> > > > > /*
> > > > > * following two are skipped because blending seems to
> > > > > work
> > > > > @@ -140,31 +145,31 @@ static const struct {
> > > > > * Test still creates the planes, just filling plane
> > > > > * and getting crc is skipped.
> > > > > */
> > > > > - { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff},
> > > > > - { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff},
> > > > > + { DRM_FORMAT_ARGB8888, SKIP4, 0xffffffff},
> > > > > + { DRM_FORMAT_ABGR8888, SKIP4, 0x00ffffff},
> > > > >
> > > > > - { DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff},
> > > > > - { DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff},
> > > > > + { DRM_FORMAT_XRGB2101010, BYTES_PP_4, 0xffffffff},
> > > > > + { DRM_FORMAT_XBGR2101010, BYTES_PP_4, 0xffffffff},
> > > > >
> > > > > - { DRM_FORMAT_YUYV, 0, BYTES_PP_4, 0x80eb80eb},
> > > > > - { DRM_FORMAT_YVYU, 0, BYTES_PP_4, 0x80eb80eb},
> > > > > - { DRM_FORMAT_VYUY, 0, BYTES_PP_4, 0xeb80eb80},
> > > > > - { DRM_FORMAT_UYVY, 0, BYTES_PP_4, 0xeb80eb80},
> > > > > + { DRM_FORMAT_YUYV, BYTES_PP_4, 0x80eb80eb},
> > > > > + { DRM_FORMAT_YVYU, BYTES_PP_4, 0x80eb80eb},
> > > > > + { DRM_FORMAT_VYUY, BYTES_PP_4, 0xeb80eb80},
> > > > > + { DRM_FORMAT_UYVY, BYTES_PP_4, 0xeb80eb80},
> > > > >
> > > > > /*
> > > > > * (semi-)planar formats
> > > > > */
> > > > > - { DRM_FORMAT_NV12, 0, NV12, 0x80eb},
> > > > > + { DRM_FORMAT_NV12, NV12, 0x80eb},
> > > > > #ifdef DRM_FORMAT_P010
> > > > > - { DRM_FORMAT_P010, 0, P010, 0x8000eb00},
> > > > > + { DRM_FORMAT_P010, P010, 0x8000eb00},
> > > > > #endif
> > > > > #ifdef DRM_FORMAT_P012
> > > > > - { DRM_FORMAT_P012, 0, P010, 0x8000eb00},
> > > > > + { DRM_FORMAT_P012, P010, 0x8000eb00},
> > > > > #endif
> > > > > #ifdef DRM_FORMAT_P016
> > > > > - { DRM_FORMAT_P016, 0, P010, 0x8000eb00},
> > > > > + { DRM_FORMAT_P016, P010, 0x8000eb00},
> > > >
> > > > Doesn't the library implement this stuff already? I see similar
> > > > code in
> > > > create_bo_for_fb(). Even if new formats are needed, I think
> > > > it's
> > > > best
> > > > to put that in the lib/igt_fb.
> > >
> > > These days igt_fb does implement most of these modes I agree.
> > > This
> > > test
> > > was written back in the day when igt support was limited to
> > > RGB888
> > > and
> > > RGB565. Idea of this test was just to try all fb formats kernel
> > > advertised could actually initialize.
> > >
> > > If you feel this test is obsolete you could ask for votes to get
> > > it
> > > removed, I tried that before xmas but nobody was interested in
> > > removing
> > > this so I started to fix problems seen in this test.
> >
> > I had a quick glance at kms_plane, like you said it pretty much
> > does
> > the same things but better. My suggestion is to
> > 1) add support in the library for the missing formats i.e.,
> > DRM_FORMAT_C8, DRM_FORMAT_XBGR2101010
> > 2) get rid of this test.
> >
>
> Hi DK,
>
> I was looking at those formats missing from list of IGT supported
> formats. DRM_FORMAT_XBGR2101010 shouldn't be much of a problem to
> add
> but it's yet to be seen how it will show in different tests.
> DRM_FORMAT_C8 on the other hand is different story, I think it
> probably
> should not be added as supported format for IGT. Reason for not
> adding
> C8 would be the 8bit nature, I think it will never have enough colors
> to
> be passing most of CRC tests.
I see. Would it not pass even if the color that we use is base color
like R, G or B? Can we conditionally limit the colors that are tested
for DRM_FORMAT_C8 in kms_plane?
> I had idea for C8 there would be separate
> test which will only test C8 features.
>
> I'd begin by removing available modes test as it seems to cause only
> useless noise now and is doubled by kms_plane in places where it
> really
> matter.
>
> You have opinions or ideas on this? I'd add above on my 'to-do' list.
How about first removing only the formats that are tested elsewhere -
reduces noise and test duplication? That should leave
DRM_FORMAT_XBGR2101010 and DRM_FORMAT_C8. When you've added support for
DRM_FORMAT_XBGR2101010 in kms_plane, then that can be removed too.
Finally, test a limited set of colors for DRM_FORMAT_C8 in kms_plane
and kill kms_available_modes_crc.
-DK
>
> /Juha-Pekka
>
> >
> > >
> > > In any case these days one cannot include new fb formats into
> > > i915
> > > without IGT support so kms_plane test does what this test does.
> > >
> > > >
> > > >
> > > > > #endif
> > > > > - { 0, 0, 0, 0 }
> > > > > + { 0, SKIP4, 0 }
> > > > > };
> > > > >
> > > > > /*
> > > > > @@ -233,13 +238,10 @@ static bool fill_in_fb(data_t *data,
> > > > > igt_output_t *output, igt_plane_t *plane,
> > > > > writesize = data->size;
> > > > > break;
> > > > > }
> > > > > - igt_info("Format %s CRC comparison skipped by
> > > > > design.\n",
> > > > > - (char*)&fillers[i].fourcc);
> > > > > -
> > > > > - return false;
> > > > > + /* Fall through */
> > > > > default:
> > > > > - igt_info("Unsupported mode for test %s\n",
> > > > > - (char*)&fillers[i].fourcc);
> > > > > + igt_info("Unsupported mode for testing CRC
> > > > > %.4s\n",
> > > > > + (char *)&format);
> > > > > return false;
> > > > > }
> > > > >
> > > > > @@ -260,6 +262,8 @@ static bool setup_fb(data_t *data,
> > > > > igt_output_t
> > > > > *output, igt_plane_t *plane,
> > > > > int bpp = 0;
> > > > > int i;
> > > > >
> > > > > + data->allow_fail = false;
> > > > > +
> > > > > mode = igt_output_get_mode(output);
> > > > > if (plane->type != DRM_PLANE_TYPE_CURSOR) {
> > > > > w = mode->hdisplay;
> > > > > @@ -288,6 +292,8 @@ static bool setup_fb(data_t *data,
> > > > > igt_output_t
> > > > > *output, igt_plane_t *plane,
> > > > > break;
> > > > >
> > > > > case SKIP4:
> > > > > + data->allow_fail = true;
> > > > > + /* fall through */
> > > >
> > > > Wouldn't this prevent CRC testing for
> > > > (fillers[i].fourcc == DRM_FORMAT_ARGB8888 && plane->type ==
> > > > DRM_PLANE_TYPE_CURSOR) ?
> > >
> > > There was later patch which fixed this. This version didn't pass
> > > CI
> > > test
> > > because I had forgotten "igt_display_reset(&data->display)" call
> > > bit
> > > below, it killed test on KBL.
> > >
> > > >
> > > >
> > > > > case BYTES_PP_4:
> > > > > bpp = 32;
> > > > > break;
> > > > > @@ -324,7 +330,7 @@ static bool setup_fb(data_t *data,
> > > > > igt_output_t
> > > > > *output, igt_plane_t *plane,
> > > > >
> > > > > if(ret < 0) {
> > > > > igt_info("Creating fb for format %s failed,
> > > > > return code
> > > > > %d\n",
> > > > > - (char*)&data->format.name, ret);
> > > > > + (char *)&data->format.name, ret);
> > > > >
> > > > > return false;
> > > > > }
> > > > > @@ -385,13 +391,14 @@ static bool prepare_crtc(data_t *data,
> > > > > igt_output_t *output,
> > > > >
> > > > >
> > > > > static int
> > > > > -test_one_mode(data_t* data, igt_output_t *output,
> > > > > igt_plane_t*
> > > >
> > > > Side note not related to the changes you are making, "mode" is
> > > > quite
> > > > misleading. Shouldn't the test be called kms_pixel_formats_crc
> > > > or
> > > > something? I thought this was about testing different connector
> > > > modes.
> > > >
> > > >
> > > > > plane,
> > > > > - int mode)
> > > > > +test_one_mode(data_t *data, igt_output_t *output,
> > > > > igt_plane_t
> > > > > *plane,
> > > > > + enum pipe pipe, int mode)
> > > > > {
> > > > > igt_crc_t current_crc;
> > > > > signed rVal = 0;
> > > > > bool do_crc;
> > > > > - char* crccompare[2];
> > > > > + char *crccompare[2];
> > > > > + igt_crc_t *p_crc;
> > > > >
> > > > > if (prepare_crtc(data, output, plane, mode)){
> > > > > /*
> > > > > @@ -409,32 +416,32 @@ test_one_mode(data_t* data,
> > > > > igt_output_t
> > > > > *output, igt_plane_t* plane,
> > > > > if (do_crc) {
> > > > > igt_pipe_crc_get_current(data->gfx_fd,
> > > > > data-
> > > > > > pipe_crc, ¤t_crc);
> > > > >
> > > > >
> > > > > - if (plane->type !=
> > > > > DRM_PLANE_TYPE_CURSOR) {
> > > > > - if
> > > > > (!igt_check_crc_equal(¤t_crc,
> > > > > - &data->fullscreen_crc))
> > > > > {
> > > > > - crccompare[0] =
> > > > > igt_crc_to_string(¤t_crc);
> > > > > - crccompare[1] =
> > > > > igt_crc_to_string(&data->fullscreen_crc);
> > > > > - igt_warn("crc mismatch.
> > > > > target
> > > > > %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
> > > > > - free(crccompare[0]);
> > > > > - free(crccompare[1]);
> > > > > - rVal++;
> > > > > - }
> > > > > - } else {
> > > > > - if
> > > > > (!igt_check_crc_equal(¤t_crc,
> > > > > - &data->cursor_crc)) {
> > > > > - crccompare[0] =
> > > > > igt_crc_to_string(¤t_crc);
> > > > > - crccompare[1] =
> > > > > igt_crc_to_string(&data->cursor_crc);
> > > > > - igt_warn("crc mismatch.
> > > > > target
> > > > > %.8s, result %.8s.\n", crccompare[0], crccompare[1]);
> > > > > - free(crccompare[0]);
> > > > > - free(crccompare[1]);
> > > > > + if (plane->type !=
> > > > > DRM_PLANE_TYPE_CURSOR)
> > > > > + p_crc = &data->fullscreen_crc;
> > > > > + else
> > > > > + p_crc = &data->cursor_crc;
> > > > > +
> > > > > + if (!igt_check_crc_equal(¤t_crc,
> > > > > p_crc))
> > > > > {
> > > > > + crccompare[0] =
> > > > > igt_crc_to_string(¤t_crc);
> > > > > + crccompare[1] =
> > > > > igt_crc_to_string(p_crc);
> > > > > + igt_warn("crc mismatch on %s
> > > > > PIPE %s
> > > > > plane %d format %.4s. target %.8s, result %.8s.\n",
> > > > > + igt_output_name(output
> > > > > ),
> > > > > + kmstest_pipe_name(pipe
> > > > > ),
> > > > > + plane->index,
> > > > > + (char *)&data-
> > > > > >format.name,
> > > > > + crccompare[0],
> > > > > + crccompare[1]);
> > > >
> > > > This is the only hunk I was hoping you would be able to split
> > > > into
> > > > a
> > > > separate patch.
> > > >
> > > > > +
> > > > > + free(crccompare[0]);
> > > > > + free(crccompare[1]);
> > > > > + if (!data->allow_fail)
> > > >
> > > > Is there a point of reading CRCs if failures are allowed?
> > >
> > > It is marked as mode which is not listed in this test but
> > > initialization
> > > worked so default paths are followed. It will produce warning
> > > which
> > > I
> > > think is useful for indicating this test need updating but will
> > > not
> > > produce failure to mark newly added features caused problems.
> > >
> > > >
> > > > > rVal++;
> > > > > - }
> > > > > }
> > > > > }
> > > > > remove_fb(data, output, plane);
> > > > > return rVal;
> > > > > }
> > > > > - return 1;
> > > > > + return data->allow_fail ? 0 : 1;
> > > > > }
> > > > >
> > > > >
> > > > > @@ -445,11 +452,11 @@ test_available_modes(data_t* data)
> > > > > igt_plane_t *plane;
> > > > > int modeindex;
> > > > > enum pipe pipe;
> > > > > - int invalids = 0;
> > > > > + int failed_crcs = 0;
> > > > > drmModePlane *modePlane;
> > > > > - char planetype[3][8] = {"OVERLAY\0", "PRIMARY\0",
> > > > > "CURSOR\0" };
> > > > >
> > > > > for_each_pipe_with_valid_output(&data->display, pipe,
> > > > > output) {
> > > > > + igt_display_reset(&data->display);
> > > > > igt_output_set_pipe(output, pipe);
> > > > > igt_display_commit2(&data->display, data-
> > > > > > commit);
> > > > >
> > > > >
> > > > > @@ -472,17 +479,9 @@ test_available_modes(data_t* data)
> > > > > modeindex++) {
> > > > > data->format.dword = modePlane-
> > > > > > formats[modeindex];
> > > > >
> > > > >
> > > > > - igt_info("Testing connector %s
> > > > > using
> > > > > pipe %s" \
> > > > > - " plane index %d type
> > > > > %s mode
> > > > > %s\n",
> > > > > - igt_output_name(output
> > > > > ),
> > > > > - kmstest_pipe_name(pipe
> > > > > ),
> > > > > - plane->index,
> > > > > - planetype[plane-
> > > > > >type],
> > > > > - (char*)&data-
> > > > > >format.name);
> > > > > -
> > > > > - invalids += test_one_mode(data,
> > > > > output,
> > > > > - plane
> > > > > ,
> > > > > - modeP
> > > > > lane-
> > > > > > formats[modeindex]);
> > > > >
> > > > > + failed_crcs +=
> > > > > test_one_mode(data,
> > > > > output,
> > > > > + pl
> > > > > ane,
> > > > > pipe,
> > > > > + mo
> > > > > dePlane-
> > > > > > formats[modeindex]);
> > > > >
> > > > > }
> > > > > drmModeFreePlane(modePlane);
> > > > > }
> > > > > @@ -491,7 +490,7 @@ test_available_modes(data_t* data)
> > > > > igt_display_commit2(&data->display, data-
> > > > > > commit);
> > > > >
> > > > > igt_output_set_pipe(output, PIPE_NONE);
> > > > > }
> > > > > - igt_assert(invalids == 0);
> > > > > + igt_assert_f((failed_crcs == 0), "There was %d modes
> > > > > with
> > > > > invalid crc\n", failed_crcs);
> > > > > }
> > > > >
> > > > >
> > >
> > >
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 49+ messages in thread
end of thread, other threads:[~2019-02-05 22:01 UTC | newest]
Thread overview: 49+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-03 11:28 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of unknown single plane modes Juha-Pekka Heikkila
2018-11-03 12:09 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-11-03 13:00 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-11-03 14:28 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2018-11-03 15:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-11-05 9:54 ` [igt-dev] [PATCH i-g-t] " Maarten Lankhorst
2018-11-05 11:24 ` Juha-Pekka Heikkila
2018-11-05 12:42 ` Maarten Lankhorst
2018-11-05 13:29 ` Juha-Pekka Heikkila
2018-11-05 11:32 ` [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons Juha-Pekka Heikkila
2018-11-05 12:19 ` Maarten Lankhorst
2018-12-13 11:16 ` Juha-Pekka Heikkila
2018-12-14 13:01 ` Juha-Pekka Heikkila
2018-12-18 14:40 ` Juha-Pekka Heikkila
2018-12-19 13:41 ` Juha-Pekka Heikkila
2019-01-23 19:40 ` Dhinakaran Pandiyan
2019-01-23 19:41 ` Dhinakaran Pandiyan
2019-01-23 19:42 ` Dhinakaran Pandiyan
2019-01-23 19:50 ` Pandiyan, Dhinakaran
2019-01-29 14:01 ` Juha-Pekka Heikkila
2018-11-05 12:10 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev2) Patchwork
2018-11-08 11:51 ` Patchwork
2018-11-08 12:48 ` Patchwork
2018-11-08 12:51 ` Patchwork
2018-11-08 12:57 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2018-11-08 20:15 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-11-09 6:44 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2018-11-09 12:53 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-12-13 11:56 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev3) Patchwork
2018-12-13 13:22 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-12-13 14:37 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev4) Patchwork
2018-12-13 18:32 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev5) Patchwork
2018-12-13 18:45 ` [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev4) Patchwork
2018-12-13 18:47 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev6) Patchwork
2018-12-13 22:27 ` [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev5) Patchwork
2018-12-13 23:16 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev6) Patchwork
2018-12-14 13:25 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev7) Patchwork
2018-12-14 15:12 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-12-18 14:58 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev8) Patchwork
2018-12-18 20:38 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-12-19 14:04 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Fix handling of unknown single plane modes (rev9) Patchwork
2018-12-19 15:05 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-01-25 12:30 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Fix handling of test comparisons Juha-Pekka Heikkila
2019-01-28 11:43 ` Juha-Pekka Heikkila
2019-01-30 6:40 ` Dhinakaran Pandiyan
2019-01-30 11:25 ` Juha-Pekka Heikkila
2019-01-30 18:23 ` Dhinakaran Pandiyan
2019-02-05 15:18 ` Juha-Pekka Heikkila
2019-02-05 22:01 ` Dhinakaran Pandiyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox