Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] lib/igt_fb: Mark Xe framebuffers as slow access
@ 2024-05-27 13:17 Juha-Pekka Heikkila
  2024-05-27 19:03 ` ✗ CI.xeBAT: failure for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 11+ messages in thread
From: Juha-Pekka Heikkila @ 2024-05-27 13:17 UTC (permalink / raw)
  To: igt-dev; +Cc: Juha-Pekka Heikkila

Reading from Xe device framebuffers is slow hence mark is as such.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 lib/igt_fb.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 5df5cb08f..26d6957f8 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -4401,7 +4401,8 @@ static void create_cairo_surface__convert(int fd, struct igt_fb *fb)
 		setup_linear_mapping(&blit->base);
 
 		/* speed things up by working from a copy in system memory */
-		cvt.src.slow_reads = is_i915_device(fd) && !gem_has_mappable_ggtt(fd);
+		cvt.src.slow_reads = (is_i915_device(fd) && !gem_has_mappable_ggtt(fd)) ||
+			is_xe_device(fd);
 	} else {
 		blit->base.linear.fb = *fb;
 		blit->base.linear.fb.gem_handle = 0;
@@ -4409,7 +4410,7 @@ static void create_cairo_surface__convert(int fd, struct igt_fb *fb)
 		igt_assert(blit->base.linear.map);
 
 		/* reading via gtt mmap is slow */
-		cvt.src.slow_reads = is_i915_device(fd);
+		cvt.src.slow_reads = is_intel_device(fd);
 	}
 
 	cvt.dst.ptr = blit->shadow_ptr;
-- 
2.43.2


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2024-05-31 10:53 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-27 13:17 [PATCH i-g-t] lib/igt_fb: Mark Xe framebuffers as slow access Juha-Pekka Heikkila
2024-05-27 19:03 ` ✗ CI.xeBAT: failure for " Patchwork
2024-05-27 19:10 ` ✓ Fi.CI.BAT: success " Patchwork
2024-05-28  3:51 ` [PATCH i-g-t] " Modem, Bhanuprakash
2024-05-28  7:47 ` Zbigniew Kempczyński
2024-05-28  8:27 ` ✗ Fi.CI.IGT: failure for " Patchwork
2024-05-29 19:18 ` ✓ Fi.CI.BAT: success for lib/igt_fb: Mark Xe framebuffers as slow access (rev2) Patchwork
2024-05-29 19:41 ` ✓ CI.xeBAT: " Patchwork
2024-05-29 22:38 ` ✗ CI.xeFULL: failure " Patchwork
2024-05-31 10:53   ` Juha-Pekka Heikkila
2024-05-30 20:40 ` ✗ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox