public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t v2] i915/gem_exec_params: Cross-check getparam against engine execution
@ 2023-02-02 17:27 Nirmoy Das
  2023-02-02 18:22 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_exec_params: Cross-check getparam against engine execution (rev3) Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Nirmoy Das @ 2023-02-02 17:27 UTC (permalink / raw)
  To: igt-dev; +Cc: Chris Wilson, Nirmoy Das

From: Chris Wilson <chris.p.wilson@intel.com>

Do not just skip the test if getparam for bsd, blt, vebox passes.
Be more robust and compare result of getparam with a engine execution
which should give more test coverage.

v2: improve commit message and keep RUN_FAIL()(Kamil)

Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Chris Wilson <chris.p.wilson@intel.com>
Co-developed-by: Nirmoy Das <nirmoy.das@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 tests/i915/gem_exec_params.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/tests/i915/gem_exec_params.c b/tests/i915/gem_exec_params.c
index 618635ec3..fd86afa16 100644
--- a/tests/i915/gem_exec_params.c
+++ b/tests/i915/gem_exec_params.c
@@ -411,24 +411,23 @@ igt_main
 	igt_subtest("mmapped")
 		mmapped(fd);
 
-#define RUN_FAIL(expected_errno) do { \
-		igt_assert_eq(__gem_execbuf(fd, &execbuf), -expected_errno); \
-	} while(0)
+#define CHK_RUN(has_check, expected_errno) \
+		igt_assert_eq(__gem_execbuf(fd, &execbuf), has_check(fd) ? 0 : -(expected_errno))
+#define RUN_FAIL(expected_errno) \
+		igt_assert_eq(__gem_execbuf(fd, &execbuf), -(expected_errno))
+
 
 	igt_subtest("no-bsd") {
-		igt_require(!gem_has_bsd(fd));
 		execbuf.flags = I915_EXEC_BSD;
-		RUN_FAIL(EINVAL);
+		CHK_RUN(gem_has_bsd, EINVAL);
 	}
 	igt_subtest("no-blt") {
-		igt_require(!gem_has_blt(fd));
 		execbuf.flags = I915_EXEC_BLT;
-		RUN_FAIL(EINVAL);
+		CHK_RUN(gem_has_blt, EINVAL);
 	}
 	igt_subtest("no-vebox") {
-		igt_require(!gem_has_vebox(fd));
 		execbuf.flags = I915_EXEC_VEBOX;
-		RUN_FAIL(EINVAL);
+		CHK_RUN(gem_has_vebox, EINVAL);
 	}
 	igt_subtest("invalid-ring") {
 		execbuf.flags = I915_EXEC_RING_MASK;
-- 
2.39.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-02-03 10:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-02 17:27 [igt-dev] [PATCH i-g-t v2] i915/gem_exec_params: Cross-check getparam against engine execution Nirmoy Das
2023-02-02 18:22 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_exec_params: Cross-check getparam against engine execution (rev3) Patchwork
2023-02-02 22:58 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-02-03  9:24 ` [igt-dev] [PATCH i-g-t v2] i915/gem_exec_params: Cross-check getparam against engine execution Kamil Konieczny
2023-02-03 10:11   ` Das, Nirmoy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox