Re: [PATCH i-g-t v2] tests/kms_lease: Cache xe_device info for lease fd

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 12/26/2023 1:39 PM, Mohammed Thasleem wrote:
> In case of xe device for lessor fd, the xe_device struct gets
> created and cached during drm_open. But for the lessee fd,
> the xe_device info struct is not created and cached.
>
> This causes problem in prepare_crtc() for lessee with xe, which
> needs the xe_device info struct. So, create and cache the xe_device
> struct info for lease fd, when we make lease and remove it from
> cache while terminating the lease.
>
> v2: -Update description and move logic to make_lease call. (Ankit)
>      -Add xe_device_put, while terminating the lease. (Ankit)
>
> Signed-off-by: Mohammed Thasleem <mohammed.thasleem@intel.com>

LGTM.

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>


Regards,

Ankit

> ---
>   tests/kms_lease.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/tests/kms_lease.c b/tests/kms_lease.c
> index 8ac58af38..f7531c803 100644
> --- a/tests/kms_lease.c
> +++ b/tests/kms_lease.c
> @@ -48,6 +48,8 @@
>   
>   #include <drm.h>
>   #include "igt_device.h"
> +#include "xe_drm.h"
> +#include "xe/xe_query.h"
>   
>   /**
>    * SUBTEST: atomic-implicit-crtc
> @@ -267,12 +269,20 @@ static int make_lease(data_t *data)
>   	if (ret)
>   		return ret;
>   
> +	/* Cache xe_device struct */
> +	if (is_xe_device(data->lease.fd))
> +		xe_device_get(data->lease.fd);
> +
>   	data->lease.lessee_id = mcl.lessee_id;
>   	return 0;
>   }
>   
>   static void terminate_lease(int lease_fd)
>   {
> +	/* Remove xe_device from cache. */
> +	if (is_xe_device(lease_fd))
> +		xe_device_put(lease_fd);
> +
>   	close(lease_fd);
>   }
>