Re: [igt-dev] [PATCH i-g-t v3 3/4] lib/gpgpu_fill: Create generic __gen9_gpgpu_fillfunc

[Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>]

On 09/05/18 07:21, Katarzyna Dec wrote:
> Starting from gen9 main gpgpu_fillfunc differs only with
> kernel parameter. Let's prepare generic __gen9 function to
> avoid duplicating all _fillfunc for future gens.
> 
> v2: fixed indentations
> 
> Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com>
> Cc: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Antonio Argenziano <antonio.argenziano@intel.com>
> Reviewed-by: Ewelina Musial <ewelina.musial@intel.com>
> ---
>   lib/gpgpu_fill.c | 23 +++++++++++++++++------
>   lib/gpgpu_fill.h |  8 ++++++++
>   2 files changed, 25 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/gpgpu_fill.c b/lib/gpgpu_fill.c
> index 010dde06..c44acb1f 100644
> --- a/lib/gpgpu_fill.c
> +++ b/lib/gpgpu_fill.c
> @@ -193,11 +193,12 @@ gen8_gpgpu_fillfunc(struct intel_batchbuffer *batch,
>   }
>   
>   void

As with the media_fill one, this function should be static and not 
exposed in the header.

Daniele

> -gen9_gpgpu_fillfunc(struct intel_batchbuffer *batch,
> -		    struct igt_buf *dst,
> -		    unsigned int x, unsigned int y,
> -		    unsigned int width, unsigned int height,
> -		    uint8_t color)
> +__gen9_gpgpu_fillfunc(struct intel_batchbuffer *batch,
> +		      struct igt_buf *dst,
> +		      unsigned int x, unsigned int y,
> +		      unsigned int width, unsigned int height,
> +		      uint8_t color, const uint32_t kernel[][4],
> +		      size_t kernel_size)
>   {
>   	uint32_t curbe_buffer, interface_descriptor;
>   	uint32_t batch_end;
> @@ -216,7 +217,7 @@ gen9_gpgpu_fillfunc(struct intel_batchbuffer *batch,
>   	curbe_buffer = gen7_fill_curbe_buffer_data(batch, color);
>   
>   	interface_descriptor = gen8_fill_interface_descriptor(batch, dst,
> -				gen9_gpgpu_kernel, sizeof(gen9_gpgpu_kernel));
> +				kernel, kernel_size);
>   
>   	igt_assert(batch->ptr < &batch->buffer[4095]);
>   
> @@ -240,3 +241,13 @@ gen9_gpgpu_fillfunc(struct intel_batchbuffer *batch,
>   	gen7_render_flush(batch, batch_end);
>   	intel_batchbuffer_reset(batch);
>   }
> +
> +void gen9_gpgpu_fillfunc(struct intel_batchbuffer *batch,
> +			 struct igt_buf *dst,
> +			 unsigned int x, unsigned int y,
> +			 unsigned int width, unsigned int height,
> +			 uint8_t color)
> +{
> +	__gen9_gpgpu_fillfunc(batch, dst, x, y, width, height, color,
> +			      gen9_gpgpu_kernel, sizeof(gen9_gpgpu_kernel));
> +}
> diff --git a/lib/gpgpu_fill.h b/lib/gpgpu_fill.h
> index 0190bfc1..7260c4fa 100644
> --- a/lib/gpgpu_fill.h
> +++ b/lib/gpgpu_fill.h
> @@ -43,6 +43,14 @@ gen8_gpgpu_fillfunc(struct intel_batchbuffer *batch,
>   		    unsigned int width, unsigned int height,
>   		    uint8_t color);
>   
> +void
> +__gen9_gpgpu_fillfunc(struct intel_batchbuffer *batch,
> +		      struct igt_buf *dst,
> +		      unsigned int x, unsigned int y,
> +		      unsigned int width, unsigned int height,
> +		      uint8_t color, const uint32_t kernel[][4],
> +		      size_t kernel_size);
> +
>   void
>   gen9_gpgpu_fillfunc(struct intel_batchbuffer *batch,
>   		    struct igt_buf *dst,
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev