Re: [igt-dev] [PATCH i-g-t v3 2/4] lib/media_fill: Add media_fillfunc for Gen10

[Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>]

On 09/05/18 07:21, Katarzyna Dec wrote:
> Gen10 media_fillfunc so far was the same as for gen9.
> Let's add proper gen10 function to make this code more
> clear. There are no changes in gen10 code.
> 

I personally disagree with this. It looks to me like we're making things 
less clear here by hiding the fact that gen10 is actually re-using the 
gen9 code with no changes. I would personally drop this patch (and 
likewise patch 4/4), but will leave the judgment to the maintainers.

Daniele

> v2: fixed indentations in few functions
> v3: fixed few more indentations
> 
> Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com>
> Cc: Ewelina Musial <ewelina.musial@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Antonio Argenziano <antonio.argenziano@intel.com>
> ---
>   lib/intel_batchbuffer.c |  4 +++-
>   lib/media_fill.c        | 12 ++++++++++++
>   lib/media_fill.h        |  7 +++++++
>   3 files changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
> index f87e6bed..42ec4f35 100644
> --- a/lib/intel_batchbuffer.c
> +++ b/lib/intel_batchbuffer.c
> @@ -858,7 +858,9 @@ igt_fillfunc_t igt_get_media_fillfunc(int devid)
>   {
>   	igt_fillfunc_t fill = NULL;
>   
> -	if (IS_GEN9(devid) || IS_GEN10(devid))
> +	if (IS_GEN10(devid))
> +		fill = gen10_media_fillfunc;
> +	else if (IS_GEN9(devid))
>   		fill = gen9_media_fillfunc;
>   	else if (IS_GEN8(devid))
>   		fill = gen8_media_fillfunc;
> diff --git a/lib/media_fill.c b/lib/media_fill.c
> index 872faf5a..fbcb9b28 100644
> --- a/lib/media_fill.c
> +++ b/lib/media_fill.c
> @@ -225,3 +225,15 @@ gen9_media_fillfunc(struct intel_batchbuffer *batch,
>   	__gen9_media_fillfunc(batch, dst, x, y, width, height, color,
>   			      gen9_media_kernel, sizeof(gen9_media_kernel));
>   }
> +
> +void
> +gen10_media_fillfunc(struct intel_batchbuffer *batch,
> +		     struct igt_buf *dst,
> +		     unsigned int x, unsigned int y,
> +		     unsigned int width, unsigned int height,
> +		     uint8_t color)
> +{
> +
> +	__gen9_media_fillfunc(batch, dst, x, y, width, height, color,
> +			      gen9_media_kernel, sizeof(gen9_media_kernel));
> +}
> diff --git a/lib/media_fill.h b/lib/media_fill.h
> index 42f8cb6a..ba352443 100644
> --- a/lib/media_fill.h
> +++ b/lib/media_fill.h
> @@ -33,4 +33,11 @@ gen9_media_fillfunc(struct intel_batchbuffer *batch,
>   		    unsigned int width, unsigned int height,
>   		    uint8_t color);
>   
> +void
> +gen10_media_fillfunc(struct intel_batchbuffer *batch,
> +		     struct igt_buf *dst,
> +		     unsigned int x, unsigned int y,
> +		     unsigned int width, unsigned int height,
> +		     uint8_t color);
> +
>   #endif /* RENDE_MEDIA_FILL_H */
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev