Re: [igt-dev] [i-g-t V4 4/6] tests/i915/kms_psr: Use linear modifier to create FB

["Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>]

On Thu-20-04-2023 10:42 am, Karthik B S wrote:
> 
> On 4/20/2023 10:34 AM, Nautiyal, Ankit K wrote:
>>
>> On 4/19/2023 4:52 PM, Bhanuprakash Modem wrote:
>>> To create a color framebuffer, nstead of using X-tiled use
>>> liniear modifier.
>>
>> typos : instead, linear.
>>
>> Perhaps it can be reworded to specify that the change is to make the 
>> test compatible for drivers, only supporting
>>
>> linear modifiers.
> 
> I agree with this. Please mention this reasoning as to why this change 
> is made.

Sure, will update the commit message while merging the patch. Hope don't 
need to float a new rev.

- Bhanu

> 
> With this update the patch LGTM.
> 
> Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> 
>>
>> Otherwise the changes LGTM.
>>
>> Acked-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>>
>>
>>>
>>> Cc: Karthik B S <karthik.b.s@intel.com>
>>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>>> ---
>>>   tests/i915/kms_psr.c | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/tests/i915/kms_psr.c b/tests/i915/kms_psr.c
>>> index 3efe1faec..dfc2fbb65 100644
>>> --- a/tests/i915/kms_psr.c
>>> +++ b/tests/i915/kms_psr.c
>>> @@ -388,7 +388,7 @@ static void setup_test_plane(data_t *data, int 
>>> test_plane)
>>>       igt_create_color_fb(data->drm_fd,
>>>                   data->mode->hdisplay, data->mode->vdisplay,
>>>                   DRM_FORMAT_XRGB8888,
>>> -                I915_FORMAT_MOD_X_TILED,
>>> +                DRM_FORMAT_MOD_LINEAR,
>>>                   0.0, 1.0, 0.0,
>>>                   &data->fb_green);
>>>   @@ -416,7 +416,7 @@ static void setup_test_plane(data_t *data, int 
>>> test_plane)
>>>           igt_create_color_fb(data->drm_fd,
>>>                       white_h, white_v,
>>>                       DRM_FORMAT_XRGB8888,
>>> -                    I915_FORMAT_MOD_X_TILED,
>>> +                    DRM_FORMAT_MOD_LINEAR,
>>>                       1.0, 1.0, 1.0,
>>>                       &data->fb_white);
>>>           break;