Re: [PATCH i-g-t] tests/kms_display_modes: Move intel_pipe_output_combo_valid before igt_output_set_pipe

["Sharma, Swati2" <swati2.sharma@intel.com>]

Hi Jeevan,

On 28-03-2025 11:59 am, Jeevan B wrote:
> Having this check after igt_output_set_pipe causes a commit failure,
> so we need to check intel_pipe_output_combo_valid before setting pipe.
We need to set_pipe() first and then check intel_pipe_output_combo_valid().
W/o setting pipe, we won't know if pipe/output combo is valid or not.
>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
>   tests/kms_display_modes.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
> index 588820170..3e388bb33 100644
> --- a/tests/kms_display_modes.c
> +++ b/tests/kms_display_modes.c
> @@ -199,12 +199,12 @@ static void run_extendedmode_test(data_t *data) {
>   
>   					igt_display_reset(display);
>   
> -					igt_output_set_pipe(output1, pipe1);
> -					igt_output_set_pipe(output2, pipe2);
> -
>   					if (!intel_pipe_output_combo_valid(display))
>   						continue;
>   
> +					igt_output_set_pipe(output1, pipe1);
> +					igt_output_set_pipe(output2, pipe2);
> +
>   					igt_dynamic_f("pipe-%s-%s-pipe-%s-%s",
>   						      kmstest_pipe_name(pipe1),
>   						      igt_output_name(output1),