From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Jeevan B <jeevan.b@intel.com>
Subject: [PATCH i-g-t] tests/kms_display_modes: Move intel_pipe_output_combo_valid before igt_output_set_pipe
Date: Fri, 28 Mar 2025 11:59:58 +0530 [thread overview]
Message-ID: <20250328062958.1500649-1-jeevan.b@intel.com> (raw)
Having this check after igt_output_set_pipe causes a commit failure,
so we need to check intel_pipe_output_combo_valid before setting pipe.
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/kms_display_modes.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
index 588820170..3e388bb33 100644
--- a/tests/kms_display_modes.c
+++ b/tests/kms_display_modes.c
@@ -199,12 +199,12 @@ static void run_extendedmode_test(data_t *data) {
igt_display_reset(display);
- igt_output_set_pipe(output1, pipe1);
- igt_output_set_pipe(output2, pipe2);
-
if (!intel_pipe_output_combo_valid(display))
continue;
+ igt_output_set_pipe(output1, pipe1);
+ igt_output_set_pipe(output2, pipe2);
+
igt_dynamic_f("pipe-%s-%s-pipe-%s-%s",
kmstest_pipe_name(pipe1),
igt_output_name(output1),
--
2.25.1
next reply other threads:[~2025-03-28 6:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 6:29 Jeevan B [this message]
2025-03-28 8:10 ` [PATCH i-g-t] tests/kms_display_modes: Move intel_pipe_output_combo_valid before igt_output_set_pipe Sharma, Swati2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250328062958.1500649-1-jeevan.b@intel.com \
--to=jeevan.b@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox